Before this change, mCanceledThumbnail is used but never assigned.
Test: Turn on live tile, swipe up to overview from app and observe that the screenshot from recents animation gets properly cleaned up.
Fixes: 143307786
Change-Id: I8fba46324c43df661adf12cd1e5d9e06a0a3ee6f
addPluginListener() needs to be moved into onUserUnlocked() since it
reads from the shared preferences. This fixes a crash in
Launcher3QuickStepGo on wembley.
Bug: 143249037
Change-Id: Ib60f688cb3f91e377141fab1ad9f2a0071c96694
- We did not pass in the user when creating the workspace item infos.
- Added check for if app is installed before adding item to workspace
to prevent any stale promise icons. This seems to happen when uninstalling
and then immediately reinstalling an application.
Bug: 141556707
Change-Id: I2db2d8da449c37eb248a59fbc9e7b517f50855c1
am: f13109df05 -s ours
am skip reason: change_id I54c71088cfe99ff28cdc719a1eb7a7d06ac95d2d with SHA1 5aeb3b84b8 is in history
Change-Id: I890cdcb712333c1519b411be1220e2710e290f8d
Existing clients now use the SingleAxisSwipeDetector subclass. A
followup CL will add BothAxesSwipeDetector, whose first client will be
the quick switch from home controller.
Bug: 126596417
Change-Id: I54c71088cfe99ff28cdc719a1eb7a7d06ac95d2d
Merged-In: I54c71088cfe99ff28cdc719a1eb7a7d06ac95d2d
Existing clients now use the SingleAxisSwipeDetector subclass. A
followup CL will add BothAxesSwipeDetector, whose first client will be
the quick switch from home controller.
Bug: 126596417
Change-Id: I54c71088cfe99ff28cdc719a1eb7a7d06ac95d2d
Because a PagedView has page a11y actions (PAGE_LEFT/RIGHT),
a11y services now identify recents apps as a pager.
Tweak the a11y event info to accomodate this so the announcements
are correct.
Also fix the CollectionItemInfo to have the correct page index.
Bug: 141899192
Test: Tested with TalkBack on device
Change-Id: Ic578bee8de26a41f0ab0e5468f1fd060ed21a7e1
am: ec72bf63df -s ours
am skip reason: change_id Ie137261ce65bfd3dd39df78d57784854a026e967 with SHA1 bc42d64c85 is in history
Change-Id: I7e3f5f26ed22351f0b331edcc79a88190416d6b1
> Connect to a predefined content provider to get package specific action
> Add that action to shortcut menu and task menu
Change-Id: Ide5c09d04112e86c8e19c2f9e66c88c15b3fd04e
Instead of starting getAppPackageName() and relying on it being our Test
Pin Item activity, instead launch our own test activities with the
FLAG_ACTIVITY_MULTIPLE_TASK and FLAG_ACTIVITY_NEW_DOCUMENT flags.
Test:
- Locally run testQuickSwitchFromApp() from Android Studio
- flake -oop -t com.android.quickstep.TaplTestsQuickstep#testQuickSwitchFromApp
Bug: 140252765
Change-Id: Ie137261ce65bfd3dd39df78d57784854a026e967
Instead of starting getAppPackageName() and relying on it being our Test
Pin Item activity, instead launch our own test activities with the
FLAG_ACTIVITY_MULTIPLE_TASK and FLAG_ACTIVITY_NEW_DOCUMENT flags.
Test:
- Locally run testQuickSwitchFromApp() from Android Studio
- flake -oop -t com.android.quickstep.TaplTestsQuickstep#testQuickSwitchFromApp
Bug: 140252765
Change-Id: Ie137261ce65bfd3dd39df78d57784854a026e967
Merged-In: Ie137261ce65bfd3dd39df78d57784854a026e967
- All apps swipe up 1s -> 200ms (doesn't matter if it's a fling)
- Scroll to last visible row 2.5s -> 1.25s (seems sufficient to not be a fling)
- Drag icon to workspace 2s -> 500ms (seems sufficient to not be a fling)
- This changes the total frames produced for the jank tests, but should not
change the jank proportion or the individual frame drawing times
Bug: 141484300
Change-Id: I9f2e647ebc2c27c6269238daa4c3e6ad314c8161
Signed-off-by: Winson Chung <winsonc@google.com>
- Rely on the device state navigation mode instead of tracking it
independently in various places
Bug: 141886704
Change-Id: I421c1fa11ca7362aff8e2388a2b5d427b39af3e9
> This makes easier to extend the factory and callbacks separately
> Availability checks are only performed once when getting the shortcut
Change-Id: I413541eabfb2b9e987c852d5171c6696b1853958
Test: Implemented plugin interface in Compose studiow build in
google_experimental, verified plugin shows up appropriately in
Launcher's home settings screen, verified gesture works if Compose
plugin enabled, and doesn't work if Compose plugin disabled.
Bug: n/a
Change-Id: Ica24ee8fe814ee02a1497a1bfbe7c7a24489b71e
Allows us to override only the required methods, instead of providing
a proxy method for everything
Change-Id: I816dcdb2a8d5432496050118ded0f2bbe7122cf7
If attachTo happens before the view is attached to window,
ViewOnDrawExecutor hooks to the tree observer twice (second time from
onViewAttachedToWindow). It only unhooks once.
Since tree observer is global, this leads to leaking the activity, and
besides, all old activities getting the events from the tree observer.
Bug: 139137636
Change-Id: Ie2641b8f3614545052fe34ad6588b070c3b82a33
(cherry picked from commit ebb5c75344)
- Prior to ag/9526193, there were a mixture of getCreatedActivity() and
passed in Activity calls. In the cases where we used the passed in
activity, it would happily make the call even if the activity is already
destroyed, but since we migrated to using the unified getCreatedActivity()
call, it results in an NPE. Since it's unnecessary to update the destroyed
activity, we can simply skip this work.
Long term, we should consider baking the activity associated with the
call into the activity interface, and ensure that the interface itself
is updated whenever the activity is recreated.
Bug: 141886704
Change-Id: I4f043e455d8d0d1c1b86362cc72618018bfbd900
Signed-off-by: Winson Chung <winsonc@google.com>
If attachTo happens before the view is attached to window,
ViewOnDrawExecutor hooks to the tree observer twice (second time from
onViewAttachedToWindow). It only unhooks once.
Since tree observer is global, this leads to leaking the activity, and
besides, all old activities getting the events from the tree observer.
Bug: 139137636
Change-Id: Ie2641b8f3614545052fe34ad6588b070c3b82a33
1. Skip all tests that fail in inproc mode on CF (this CL)
2. Observe postsubmit and make sure no inproc tests are failing or too
flaky on CF
3. Enable presubmit
4. Switch to skipping tests from step 1 only for inproc presubmit;
they'll start failing in postsubmit
5. Gradually make all tests pass and not flaky and enable them back on
presubmit
Bug: 142828227
Change-Id: I0092d6b92b0358866f8cbf9e00dbe3fabe23703d
- Previously, we would only cancel the current animation if
sharedState.canBeContinued which was only set when mGestureEndTarget
was set, which is only calculated when the swipe gesture ends,
and is only true if the end target is not Launcher.
In ag//9518396 the check for the null end target was moved into
isRunningAnimationToLauncher(), but that call actually bakes in two
checks together, which means that even when tapping the home button
(where there is no gesture and no end target), it would return false.
Instead, we should ensure that the gesture target is set before trying
to cancel the animation.
- Also fix an existing issue where if the consumer is cleaned up after
the start callback is registered, but not before the callback has
returned, that we may incorrectly set the wrong launcher state since
the callback is made to the old gesture handler which tries to prepare
the recents UI (this manifests as a blank launcher screen).
Bug: 141886704
Change-Id: I642f20d631924730e98d10bb2123bd9448793fc6
mContentAlpha sometimes equals 0, changing to 1 ensures recents card always shows when supposed to
Change-Id: I27eda97b72b75263c0aac09e2355bca72daecc27
Tracy Zhou
TreeHugger Robot
Winson Chung
Jon Miranda
Tony Wickham
sallyyuen
Sunny Goyal
Xin Li
James O'Leary
android-build-team Robot
vadimt
Sreyas Rangaraju