Commit Graph

16725 Commits

Author SHA1 Message Date
Luca Zuccarini 46338b09e3 Merge "Remove workspace fade from ALL_APPS > NORMAL transition." into tm-dev 2022-06-01 09:35:20 +00:00
Jeremy Sim cc305437f6 Merge "Remove deprecated verticalBar layout in Overview" into tm-qpr-dev am: 0183476559 am: 2e598e4859
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18422835

Change-Id: I6f966f9d33b1d769f8d4f3d2170f9f001fc5e4cb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 03:38:13 +00:00
Jeremy Sim 0183476559 Merge "Remove deprecated verticalBar layout in Overview" into tm-qpr-dev 2022-06-01 02:55:47 +00:00
James O'Leary 9c52973bb0 Merge "Revert "Update app icon shadows"" into tm-dev am: 202ac414bf am: e0ca1d1f12
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18675016

Change-Id: Ie52c8bb1f0581c7f65ac48f1f6d908a75be1c067
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 02:23:02 +00:00
James O'Leary 0ac64cba0f Merge "Revert "Update app icon shadows"" into tm-dev am: 202ac414bf am: b2919ce557
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18675016

Change-Id: I9f92216f1db5331b450b750855213cc9fd642335
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 01:52:33 +00:00
James O'Leary 202ac414bf Merge "Revert "Update app icon shadows"" into tm-dev 2022-06-01 01:29:34 +00:00
Alex Chau 8c1fe8abac Avoid DisplayController.currentSize from being stuck at wrong value am: 80d36083c2 am: 578e4add2c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18619540

Change-Id: I84e04e2c66f1b075aa7652d529a66e07757c037e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-31 22:23:44 +00:00
Jeremy Sim 3c2c3f1aea Remove deprecated verticalBar layout in Overview
Removes code that was intended for a now-deprecated layout style in Overview. See ag/18386646 for an example of an issue caused by this.

Bug: 232298587
Test: Manual on 3 devices
Change-Id: Icfd40e1e5a99cf5821b1c46357db58a31daaa835
2022-05-31 22:02:57 +00:00
James O'Leary dac75aef3b Revert "Update app icon shadows"
Revert submission 17935777-lightDarkDetection

Reason for revert: Talked with Adam Cohen, white shadows are controverstial and we'd need to escalate to senior UX if we want to ship. James would rather do it in U timeframe, will flag to UXers we work with that the opportunity to escalate is available if needed.
Reverted Changes:
Ia91221427:Update light/dark detection.
Ie12d3d054:Update app icon shadows
Icc88c3496:Update smartspace shadow

Change-Id: I8bc90e79073b8e088f2912fef2af4c6c99a33553
2022-05-31 21:12:38 +00:00
Stefan Andonian 2a7fbee0d4 Give FloatingIconView a copy of, rather than, the original icon.
Previously, if a user tapped on the clock icon then rapidly swiped back,
the clock icon would stop updating. This fixes that issue by avoiding
changes to the original icon's inner callback state while preparing and
displaying the FloatingIconView.

Bug: 188377749
Test: Locally enabled the second hand on the clock icon in addition to
the minute and hour hands, then verified that it was incrementing
correctly every second even after tapping then rapidly swiping back on
the clock icon.

Change-Id: Ib8eddb53de293194e5f9dce2fcafe8a481a6116c
2022-05-31 17:32:08 +00:00
Stefan Andonian 1644346e76 Merge "Give FloatingIconView a copy of, rather than, the original icon." 2022-05-31 17:31:45 +00:00
Luca Zuccarini a36af25ab7 Remove workspace fade from ALL_APPS > NORMAL transition.
This applies to phones only for the one-off transition (Home gesture or
swipe back. See before and after videos in the bug.

Bug: 234359814
Test: manual
Change-Id: I8f4fc9ec40687b641a721bd28b32fcf50514861f
2022-05-31 15:46:28 +00:00
Alex Chau 80d36083c2 Avoid DisplayController.currentSize from being stuck at wrong value
- Update Info when perDisplayBounds has changed
- Add more detailed logging to displayInfo, realBounds and perDisplayBounds
- Add perDisplayBounds to dumpsys and replace supportedBounds

Bug: 233562339
Test: manual
Change-Id: I9a040e8465a8b0a2dcde61bab06c6ca1df3006da
2022-05-30 18:09:45 +01:00
Luca Zuccarini 7ee40a4190 Update the workspace and background scale interpolators.
The spec had a typo (EMPHASIZED_DECELERATE instead of
EMPHASIZED_ACCELERATE). In addition, we're now using LINEAR for the
background since the feel is smoother this way. Cleared with motion
(simonroberts@).

Bug: 232418544
Test: manual
Change-Id: I492dbe8008856d331836793177f1dd58c3265ca2
2022-05-30 09:47:40 +00:00
James O'Leary 71854432a9 Merge "Update app icon shadows" into tm-dev am: 2b6700a94c am: 66ec297fea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17937870

Change-Id: I8448333160924d5a75627602b3fe0602e92cd65a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 23:09:51 +00:00
Stefan Andonian 15fd13470f Give FloatingIconView a copy of, rather than, the original icon.
Previously, if a user tapped on the clock icon then rapidly swiped back,
the clock icon would stop updating. This fixes that issue by avoiding
changes to the original icon's inner callback state while preparing and
displaying the FloatingIconView.

Bug: 188377749
Test: Locally enabled the second hand on the clock icon in addition to
the minute and hour hands, then verified that it was incrementing
correctly every second even after tapping then rapidly swiping back on
the clock icon.

Change-Id: Ib8eddb53de293194e5f9dce2fcafe8a481a6116c
2022-05-27 22:34:52 +00:00
James O'Leary ef64789d0a Merge "Update app icon shadows" into tm-dev am: 2b6700a94c am: 5131a1a203
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17937870

Change-Id: I16cb7b30a5219d196427bedbbe0c3adbb66c1360
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 20:29:31 +00:00
James O'Leary 2b6700a94c Merge "Update app icon shadows" into tm-dev 2022-05-27 19:44:39 +00:00
Winson Chung af5ac4984f Merge "Ensure page scrolls are initialized even for 0 children." into tm-dev am: 1e211e0c03 am: 0a3ef79f06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18625747

Change-Id: Ie10aeebc4e8f53f5c8882317e48a14b2b4fa8794
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 18:24:33 +00:00
Winson Chung d50bcca77e Merge "Ensure page scrolls are initialized even for 0 children." into tm-dev am: 1e211e0c03 am: bc8affdfb6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18625747

Change-Id: I2d33d848691c4791686ff719d67d53424edc670d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 18:14:14 +00:00
Winson Chung 1e211e0c03 Merge "Ensure page scrolls are initialized even for 0 children." into tm-dev 2022-05-27 17:42:22 +00:00
Brian Isganitis deaf8985f6 Merge "Have separate DeviceProfile instances for taskbar and all apps windows." into tm-dev 2022-05-27 17:25:16 +00:00
Vinit Nayak ca796876ca Merge "Limit starting bounds of swipe to animation start rect" into tm-dev am: e8a4e0e2dc am: fa886a3edf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18607508

Change-Id: I7f621d089c2f790cb6164efcef1e515bd6e063c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 03:50:35 +00:00
Vinit Nayak 1eb79473aa Merge "Limit starting bounds of swipe to animation start rect" into tm-dev am: e8a4e0e2dc am: e9e0800fd7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18607508

Change-Id: I7b4afd0d4eae8853e15c06c8f7f6472ef5035bf0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 03:29:15 +00:00
TreeHugger Robot 086368e4fd Merge "[conflict] Merge "Moves Search results into a separate RV (take 2)." into tm-dev am: 4ca247a6bb am: 15dc59f8b1" into tm-qpr-dev am: a7b4152e90 am: 731978a0a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18624669

Change-Id: Icf20a5e474e15c56962403cc4d9130d3289643aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-27 02:55:00 +00:00
Vinit Nayak e8a4e0e2dc Merge "Limit starting bounds of swipe to animation start rect" into tm-dev 2022-05-27 02:52:36 +00:00
Winson Chung 359cb5d1b6 Ensure page scrolls are initialized even for 0 children.
Bug: 233713180
Test: Walk through CtsVerifier Lock Task UI flow as described in the bug
Change-Id: I49cb942a37a202b3e1b7ee00479d68402fcaf8b0
2022-05-26 23:38:48 +00:00
Andy Wickham a1ec03bdfe [conflict] Merge "Moves Search results into a separate RV (take 2)." into tm-dev am: 4ca247a6bb am: 15dc59f8b1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18420827

Change-Id: Ic7e380e21342011afcbd1ada0eb453dc83eff4be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 23:31:31 +00:00
Vinit Nayak f7b4e7f497 Limit starting bounds of swipe to animation start rect
* If the starting point is greater than that of the current
device's width (in either positive or negative direction),
reset the starting rect to be fullscreen task bounds
* More details at b/228829958#comment12

Fixes: 228829958
Test: Reboot device and swipe up from home immediately,
app doesn't fling from the side.
Tested with portrait and landscape launcher.
Tested with fake landscape launcher.

Change-Id: I6ea24e30e9de5716b7830f487b2ed63f56598c50
2022-05-26 14:43:26 -07:00
Andy Wickham 4ca247a6bb Merge "Moves Search results into a separate RV (take 2)." into tm-dev 2022-05-26 21:41:55 +00:00
Brian Isganitis afd72f0726 Have separate DeviceProfile instances for taskbar and all apps windows.
We want to scale down the DeviceProfile for taskbar, but the all apps
window should rely on the original DeviceProfile.

Test: Manual
Fix: 232907361
Change-Id: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
Merged-In: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
(cherry picked from commit a9a78117c7)
2022-05-26 17:21:50 +00:00
Brandon Dayauon 039036693a Merge "fixed scalable grid allApps to match home screen icons in largest display size" into tm-dev am: 5ba5c76c76 am: cd9cffe63d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18512230

Change-Id: I9d35410f26d6e7ea42872e3029f51883aa65093e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 17:12:55 +00:00
Brandon Dayauon 9b42f62266 Merge "fixed scalable grid allApps to match home screen icons in largest display size" into tm-dev am: 5ba5c76c76 am: 99c0fdc273
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18512230

Change-Id: I3a1c665c4e2b0bf5fb36ea05a913b15b393abc1a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-26 16:49:31 +00:00
Brandon Dayauon 5ba5c76c76 Merge "fixed scalable grid allApps to match home screen icons in largest display size" into tm-dev 2022-05-26 16:06:02 +00:00
Alex Chau 56e367b744 Merge "Fix taskbar icon flicker and jump when transforming to hotseat" into tm-dev 2022-05-26 09:24:23 +00:00
Abhilasha Chahal ef1b1a9e92 Merge "Add type TYPE_ADD_TO_HOME_CONFIRMATION to AbstractFloatingView" into tm-dev am: d18c5085c5 am: 17318edce5 am: 91a9bf1ac3 am: d9bf86a02c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18457403

Change-Id: I31014c27c2a9704d9f56e9c77fce24b2f8fdc402
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 20:32:42 +00:00
Brian Isganitis 0bc68242ee Merge "Have separate DeviceProfile instances for taskbar and all apps windows." into tm-qpr-dev 2022-05-25 20:27:21 +00:00
Abhilasha Chahal 91a9bf1ac3 Merge "Add type TYPE_ADD_TO_HOME_CONFIRMATION to AbstractFloatingView" into tm-dev am: d18c5085c5 am: 17318edce5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18457403

Change-Id: I43dafd3be5d6e46d49fe900a660cd34596b7feb4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 19:39:44 +00:00
Brian Isganitis b09775cd0b Merge "Check if event is over All Apps correctly on large screens." into tm-qpr-dev am: 261dec20f7 am: bf6e735c24
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18591070

Change-Id: I7b46ef783d826647d9ddb63c14af8bd7bde7a079
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 18:50:05 +00:00
Abhilasha Chahal d18c5085c5 Merge "Add type TYPE_ADD_TO_HOME_CONFIRMATION to AbstractFloatingView" into tm-dev 2022-05-25 18:31:59 +00:00
Brian Isganitis 261dec20f7 Merge "Check if event is over All Apps correctly on large screens." into tm-qpr-dev 2022-05-25 18:13:33 +00:00
Brian Isganitis a9a78117c7 Have separate DeviceProfile instances for taskbar and all apps windows.
We want to scale down the DeviceProfile for taskbar, but the all apps
window should rely on the original DeviceProfile.

Test: Manual
Fix: 232907361
Change-Id: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
Merged-In: Ia09f674ada9e445c1d7278fa94c536ea9de13ef9
2022-05-25 18:11:51 +00:00
Brian Isganitis 54d474a028 Merge "Have separate DeviceProfile instances for taskbar and all apps windows." 2022-05-25 18:11:30 +00:00
Sebastian Franco 81cec527e9 Fix folder preview animation when adding or removing icons.
The functions PreviewItemManager.updatePreviewItems calls
PreviewItemManager.buildParamsForPage using mFirstPageParams and it
expects that mFirstPageParams contains the values before the reoredering
but they get updated in a previous call to updatePreviewItems(false),
so when doing the animation, the icons are animated to their current
position and nothing changes.

Fix: 233401274
Test: Add icons to a folder 1 to 5 without expanding the folder and
make sure they animate to their new position. Make sure they animate
when removing items as well.

Change-Id: Ia3e1393d8fb2b30eb107e8b2c6eefdf9e50e9f70
2022-05-25 10:26:10 -07:00
Alex Chau a62bd7cd0f Merge "Center drop target button alignment across devices" into tm-dev am: 179c289a6c am: 7ca1b38d7e am: 6329b20f43 am: ea9554cd21
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18580267

Change-Id: I98f4279c15cb61f1e047362c692f070563699fd7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 13:57:40 +00:00
Alex Chau 7a6ca4c461 Merge "Only setup SecondaryDropTarget in onDragStart" into tm-dev am: a2ecf75082 am: 9899c3f028 am: 4ffebaa68c am: 7b4d1f959f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18580266

Change-Id: Ibca48aa465a53fb9f28b168f058a399de5e83782
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 13:57:38 +00:00
Alex Chau 6329b20f43 Merge "Center drop target button alignment across devices" into tm-dev am: 179c289a6c am: 7ca1b38d7e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18580267

Change-Id: I57dd855387257a8704f8529f14ea176562e63549
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 13:24:02 +00:00
Alex Chau 4ffebaa68c Merge "Only setup SecondaryDropTarget in onDragStart" into tm-dev am: a2ecf75082 am: 9899c3f028
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18580266

Change-Id: Ib8da8d3fa08aad0335b9d5cfcf50e2a5c2f12dbd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-25 13:24:01 +00:00
Alex Chau 179c289a6c Merge "Center drop target button alignment across devices" into tm-dev 2022-05-25 12:38:11 +00:00
Alex Chau a2ecf75082 Merge "Only setup SecondaryDropTarget in onDragStart" into tm-dev 2022-05-25 12:38:11 +00:00