Commit Graph

16725 Commits

Author SHA1 Message Date
Jeremy Sim b0cce86385 Implement non-disappearing View for split staging instructions
The instructions for how to perform a splitscreen operation, previously conveyed through a disappearing Toast, are now conveyed through a custom View object.

Fixes: 219987907
Test: Manual
Change-Id: Iff2bb6e334e0325e8a091d76a5f9b8767071365f
2022-05-23 21:23:22 +00:00
Alex Chau ba3e8d4eef Merge "Update drop target button alignment across devices" into tm-dev am: 618047355d am: 15ca7e759b am: 1db078ee31 am: 3a5f40dc38
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18557384

Change-Id: I55c1893e7de2dd9badebd62d50e41d6c8bb5b2ef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-23 20:06:01 +00:00
TreeHugger Robot c32b18415c Merge "Fix taskbar icon flicker and jump when transforming to hotseat" into tm-qpr-dev am: fe4a4d1cb9 am: 945797146a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18491577

Change-Id: I8114bf76bda196d84981908276505e2375407e10
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-23 20:03:43 +00:00
Alex Chau 1db078ee31 Merge "Update drop target button alignment across devices" into tm-dev am: 618047355d am: 15ca7e759b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18557384

Change-Id: I1c7bb488bd2a164a6d3caf9a3f719b9e96e487cb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-23 19:35:23 +00:00
Stefan Andonian 140ed429ea Fix folder app icon truncation after rotating to landscape.
The folder bubble text views were being recycled after the launcher's
cache was cleared. This caused the new orientation's folders to re-use
the old views with their stale configuration. After this change, the
cache won't recycle views whose cache entry has been recreated,
implying that their environment might have changed and new setup is
required.

Bug: 230304658
Test: Verified erroneous UX on device was no longer reproducible after fix.
Change-Id: Ib01cf5792d83df752e05534e5aa08ab8e8763bdc
2022-05-23 19:33:58 +00:00
TreeHugger Robot fe4a4d1cb9 Merge "Fix taskbar icon flicker and jump when transforming to hotseat" into tm-qpr-dev 2022-05-23 19:21:14 +00:00
Sukesh Ram aed1b074f3 Added debug menu option for testing secondary display.
Test: manual
Fix: 233639924
Change-Id: Iaca90a1391078d56bd57fa5de097f34ec0425866
2022-05-23 18:59:03 +00:00
Sunny Goyal 52bbef9d94 Adding support for customiting the animation in PropertySetter
Bug: 233223446
Test: Manual
Change-Id: I53fc39fa4871c9ea5b6eaf324ec1054140ccc292
2022-05-23 09:55:56 -07:00
Alex Chau 906d882f91 Update drop target button alignment across devices
- Partial re-land of http://ag/18520765
- Layout the buttons from center of screen for two panels, or from center of workspace for all other cases

Bug: 229789612
Fix: 231706480
Fix: 232063941
Fix: 232283628
Test: manual
Change-Id: Icbc9e2a19140ce3127d5dfe9f798a8ada336cea8
2022-05-23 15:08:52 +00:00
Alex Chau 51da219869 Fix taskbar icon flicker and jump when transforming to hotseat
- Apply additional translation on TaskbarView to account for difference between taskbar icon to bottom spacing compared to hotseat icon to bottom spacing
- Call updateIconAlignment outside of synchronizeNextDraw's then block, which get run after the synchronization

Bug: 204850744
Test: manual
Change-Id: Id65842f506eb342105082649446eb694cd5c33a4
2022-05-23 14:33:34 +01:00
TreeHugger Robot 7bd85d59c6 Merge "Remove obsolete TODO for verifying all apps on 2nd display." into tm-dev am: 2940565595 am: c0c1097d18 am: 64ee73294d am: 3ef721e452
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18496510

Change-Id: I0e940793f2d53174d54652ceb641d5a1e45fbae8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-20 21:03:00 +00:00
Pat Manning 466ef04efb Revert "Update drop target button alignment across devices." am: b29dabce18 am: bb846ab675 am: 04cb3f04d3 am: e77155415a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18520765

Change-Id: I08c768b3c02f44de368bcb9077549662c7f3cd40
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-20 20:59:59 +00:00
TreeHugger Robot 3ef721e452 Merge "Remove obsolete TODO for verifying all apps on 2nd display." into tm-dev am: 2940565595 am: c0c1097d18 am: 64ee73294d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18496510

Change-Id: I9b69ae67d485c374919fe0071509d77878ad4669
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-20 20:13:40 +00:00
TreeHugger Robot 69b48b307f Merge "Remove obsolete TODO for verifying all apps on 2nd display." into tm-dev am: 2940565595 am: c0c1097d18
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18496510

Change-Id: I3de873ca379bb3d7e2db5271b39c5b48feb1fa3a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-20 19:44:00 +00:00
Pat Manning 04cb3f04d3 Revert "Update drop target button alignment across devices." am: b29dabce18 am: bb846ab675
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18520765

Change-Id: Ica2d184549e8ffaaf6574a459b2aacf523264762
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-20 19:43:48 +00:00
TreeHugger Robot 2940565595 Merge "Remove obsolete TODO for verifying all apps on 2nd display." into tm-dev 2022-05-20 18:49:33 +00:00
Pat Manning b29dabce18 Revert "Update drop target button alignment across devices."
This reverts commit 27bfcaa651.

Reason for revert: b/232636570

Bug: 229789612
Bug: 231711806
Bug: 231706480
Bug: 232063941
Bug: 232283628
Change-Id: Ic83515173f4a64228a80f63d75db938243cbf625
2022-05-20 18:20:26 +00:00
Brandon Dayauon 969f6a8c4d fixed scalable grid allApps to match home screen icons in largest display size
fixed allApps Icon's text size to scale

Test: Pictures in bug thread
Bug: 232908037
Change-Id: I4b171e76c61d1fe913c23034b823f16668839f1b
2022-05-20 09:49:56 -07:00
Pat Manning d030d0acdc Bound drop target layout values to left and right. am: 3c0f4c156d am: 781c68b236 am: a8b8de1fa0 am: 34a5562cba
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18491881

Change-Id: Ie4f73c145aaa80e6ef9121150017cf8b92e31568
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-20 12:49:48 +00:00
Shikha Malhotra e3bfeced57 Merge "Updating visibility of some members for easier extensibility" 2022-05-20 12:05:28 +00:00
Pat Manning a8b8de1fa0 Bound drop target layout values to left and right. am: 3c0f4c156d am: 781c68b236
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18491881

Change-Id: I14acd17e473d0f2a081a90e41bfb1598f21c49d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-20 00:48:56 +00:00
Anushree Ganjam 0d345e5e04 Add "incrementEventCountBy" function to OnboardingPrefs.
This will help to increment the count by a value rather than just by 1.

Bug: 231659198
Test: Manual
Change-Id: I180ab3bd622df3bee2a6cb2b0cd8793e07a4f114
2022-05-19 23:07:06 +00:00
Brian Isganitis b811a29b7d Remove obsolete TODO for verifying all apps on 2nd display.
It works \o/.

Test: No
Change-Id: I5b2c6c1b3bb656ad3d5bb21188ac9e9f8cdc0fec
2022-05-19 13:30:55 -07:00
Shikha Malhotra c487e1b4c5 Updating visibility of some members for easier extensibility
Bug: b/218186980
Test: Manual Testing that Launcher3 compiles and works
Change-Id: Id85486ef763ce9a04b83fef44542b2eb3e0e599d
2022-05-19 20:19:43 +00:00
Abhilasha Chahal ee14d4761a Add LAUNCHER_SYSTEM_SHORTCUT_APP_SHARE_TAP event
Bug: 233224567
Test: Manually verified the event in logs
Change-Id: Ie81ca8774adb241f1c8635444dad884f34f3929d
2022-05-19 19:21:45 +00:00
Pat Manning 3c0f4c156d Bound drop target layout values to left and right.
Test: manual
Fix: 232636570
Bug: 233225825
Change-Id: I388cb3407cb9f887ccc222f4804636f9f7651884
2022-05-19 18:48:14 +01:00
Sebastián Franco 3f1bed0ec0 Merge "Widget migration now supports widgets and repeated elements in the worskpace." into tm-qpr-dev am: ce213d3306 am: 17060be2aa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18442023

Change-Id: I077b499de6583011710221f959d8ad90c4fa07ec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-19 03:34:03 +00:00
Luca Zuccarini 4051995e5d Merge "Additional polish for the NORMAL<->ALL_APPS transitions." into tm-dev am: 175fc66aa8 am: 22bb04bb77 am: a3719625f2 am: 1f6d6429bb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18375247

Change-Id: I6fd45122c75a14b0029dbc93bb8b91854eed9c98
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-19 02:05:55 +00:00
Sebastián Franco ce213d3306 Merge "Widget migration now supports widgets and repeated elements in the worskpace." into tm-qpr-dev 2022-05-18 23:27:24 +00:00
Sunny Goyal 77138a74d6 Merge "Adding support for extending back behavior in Launcher" into tm-dev am: a292987030 am: b81b13d590 am: 56a7c1f671 am: 1c369dbcde
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18187213

Change-Id: I3fe6a0b885c56a861e8b2de0fa3e6052aaa8702e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-18 22:14:18 +00:00
Luca Zuccarini 62161cfce7 Merge "Update the NORMAL<->ALL_APPS swipe transitions on phones." into tm-dev am: 3eb149b055 am: cf1dc294cb am: c3abf0043f am: 3ef21aba38
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18185506

Change-Id: I556c46b2899f2411fcde6bab95f623b8e058bdb4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-18 22:14:00 +00:00
Vinit Nayak 776912ae96 Merge "Report ITYPE_BOTTOM_MANDATORY_GESTURES insets for Taskbar" into tm-dev am: cfdb076d12 am: 2593347a28 am: 94543b6b13 am: 1017dd3b96
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18286602

Change-Id: I26122ce98f9169787aba85a0ed70371e9e0aa2a8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-18 22:13:34 +00:00
TreeHugger Robot ab2c551ab0 Merge "Log the reason why a WorkspaceItemInfo was removed" into tm-dev am: 8eaf87e77b am: 13d50111c6 am: fa19bc6d12 am: 9bb74be812
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18298829

Change-Id: I6b2421f3e3056269c3e14389d494895e8cbb6456
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-18 22:13:16 +00:00
Brandon Dayauon ac57bdeb66 Merge "Fix issue when preference screen title won't change depending on the device.." into tm-dev am: 1460a6a0fb am: cb406595ac am: 1aa8ef2249 am: 9a7e7fc530
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18235011

Change-Id: I024b4c07ee3f6b9bc459ab0598a7f790e529389d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-18 22:13:06 +00:00
TreeHugger Robot b22c10d9e1 Merge "Revert "Set mState = mCurrentStableState in onAnimationCancel()"" into tm-dev am: 4608bd00dc am: 64be3ba846 am: 6b67555e27 am: 465de0ada6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18344362

Change-Id: Ib34e07f57190473237568cb3a52da1faa223466d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-18 22:12:57 +00:00
Sebastian Franco 08788a939b Widget migration now supports widgets and repeated elements in the worskpace.
The widget migration was using the variable DbEntry.mIntent as an
id for calculating the difference between two workspaces but widgets
don't have that variable, it's always null. So that had created some
bugs.

Also, the function GridSizeMigrationTaskV2.calcDiff didn't accounted for
repeated icons or repeated widgets. It's not a big deal not account
for repeated icons, but repeated widgets can be usefull for the user,
so now calcDiff keeps repeated icons and widgets.

Fix: 229701468
Test: Add multiple icons and widgets in the workspace and change the
grid size, this code only runs after the first time you change the
grid size, so try a couple of times. It should keep the widgets and
icons, even if they are repeated.

Change-Id: I5812445cec8364d8cc57cbcc3f1ae04ba9099932
2022-05-18 17:10:11 +00:00
Luca Zuccarini 175fc66aa8 Merge "Additional polish for the NORMAL<->ALL_APPS transitions." into tm-dev 2022-05-18 14:21:27 +00:00
Abhilasha Chahal e2aca3e664 Add type TYPE_ADD_TO_HOME_CONFIRMATION to AbstractFloatingView
Test: Manually verified that the Floating view appears
Bug: 217360015
Change-Id: Id9edd3f9c2ef06ece4f541830c2080aeed11f1b1

Change-Id: I7f89a191ff55bcc03ec70c49aea659188083f0dd
2022-05-18 11:32:51 +00:00
Sunny Goyal a292987030 Merge "Adding support for extending back behavior in Launcher" into tm-dev 2022-05-17 23:02:50 +00:00
Luca Zuccarini 3eb149b055 Merge "Update the NORMAL<->ALL_APPS swipe transitions on phones." into tm-dev 2022-05-17 16:06:27 +00:00
Vinit Nayak cfdb076d12 Merge "Report ITYPE_BOTTOM_MANDATORY_GESTURES insets for Taskbar" into tm-dev 2022-05-17 13:56:51 +00:00
TreeHugger Robot 8eaf87e77b Merge "Log the reason why a WorkspaceItemInfo was removed" into tm-dev 2022-05-17 05:01:15 +00:00
Vinit Nayak 2cb5cb5d00 Report ITYPE_BOTTOM_MANDATORY_GESTURES insets for Taskbar
Bug: 205493938
Change-Id: I196bc52c1bec75b5442f3546f466799ba9c3831b
2022-05-16 21:38:28 -07:00
Brandon Dayauon 1460a6a0fb Merge "Fix issue when preference screen title won't change depending on the device.." into tm-dev 2022-05-16 22:47:17 +00:00
Sunny Goyal 3f2637faee Adding support for extending back behavior in Launcher
Bug: 231224820
Test: Manual
Change-Id: I9accc30c01dce5f6920b611cfeed9fa0584d2846
2022-05-16 14:40:19 -07:00
Pinyao Ting 6a41d56b50 Log the reason why a WorkspaceItemInfo was removed
In the past we've seen a WorkspaceItem disappeared from the workspace
but wasn't able to determine why it was removed. This CL includes the
reason why it was removed in the error log, which hopefully would help
us debugging similar issues in the future.

Bug: 231239260
Test: make
Change-Id: Iba3d57568c9b3e011a6b65b26f0d4170d42fe1a5
2022-05-16 20:17:47 +00:00
TreeHugger Robot 4608bd00dc Merge "Revert "Set mState = mCurrentStableState in onAnimationCancel()"" into tm-dev 2022-05-16 18:15:14 +00:00
Brandon Dayauon 303b4e8aae Fix issue when preference screen title won't change depending on the device..
previously it defaults to just "Search your phone"
Now it correctly displays Phone/Tablet

Before: https://screenshot.googleplex.com/3PJrsP9mGvwMr98
After: https://screenshot.googleplex.com/B2nnUQHeHmEXXPd

Bug: 231611501
Change-Id: I49eab7e827ce4bb31a2722fbf21c244f98145907
2022-05-16 10:25:12 -07:00
Stefan Andonian 83bc5f5050 Change accessibility announcement for workspace from "Pixel Launcher" to "Home".
Bug: 228410736
Test: Verified correct talkback announcements.
Change-Id: Ic0a5295cde3cd23d2fc5a6fcd19b6cf8e0f3e386
2022-05-16 16:54:51 +00:00
Hyunyoung Song ef4da349f8 Merge "Add latency tracking for aiai" into tm-dev 2022-05-15 06:56:01 +00:00