Commit Graph

16725 Commits

Author SHA1 Message Date
TreeHugger Robot 87ccecb6fc Merge "Revert "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar.""" into tm-qpr-dev 2022-11-15 22:31:55 +00:00
Federico Baron c7e76005e0 Fix spring-loaded folder animation offset bug
The folder close animation is offset due incorrect scaling in SpringLoaded mode. We fix the folder offset by scaling offsetX() and offsetY() by the scale of the workspace in spring loaded mode (scaleRelativeToDragLayer), and the offset of the preview icons is fixed by dividing previewItemOffsetX by initialScale rather than initialScale / scaleRelativeToDragLayer

Fix: 255420905
Test: manual
Change-Id: I305c1047c14c4c9f1b4c3bd0143e9bb764c71524
2022-11-15 12:51:57 -08:00
Sunny Goyal ea76d35278 Cleaning Utilities.java
> Removing some unused methods
> Moving some specialized methods to corresponding classes
> Removing GridProvider check as it is released

Bug: 257555083
Test: Presubmit
Change-Id: Ib0f8c673d018071d3f4b7d9247e0a35718ab009c
2022-11-15 20:21:56 +00:00
Jon Miranda deaff5fbb4 Move feature flags that have been changed to the top of the list.
Bug: 259270717
Test: change flag, check that its at the top of the sorted list
Change-Id: Ib10882e8de625471ef430a2f3162b85f9c6e1c1d
2022-11-15 20:16:18 +00:00
Sihua Ma a992eab9c6 Merge "Making talkback focus on the widget after the resize" into tm-qpr-dev am: 3ccbba3e9f am: 4edd146a06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20447067

Change-Id: I1ceeb5604c125c1ad807eb273f961a9d3df32318
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 19:16:44 +00:00
Sebastián Franco d2c6cc75b5 Merge "Fix the wiggle reorder aniamtion stopping if dragging" into tm-qpr-dev am: 659197407b am: 26412fba5b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20429797

Change-Id: I1940686f2e7454ac1e73a03976df1322b10e6e73
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 19:15:43 +00:00
Anushree Ganjam dc5e58604c Merge "Add SearchResultCode to onSearchResult()" into tm-qpr-dev am: 30c1043b1c am: 20c037c730
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20445922

Change-Id: Ibc2542d2fc2390128944c671d2b8669c530b5bf6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 19:15:10 +00:00
Sihua Ma 4edd146a06 Merge "Making talkback focus on the widget after the resize" into tm-qpr-dev am: 3ccbba3e9f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20447067

Change-Id: I2887f80b17c1e8fa1e40d22dd2061472341c7688
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 18:43:46 +00:00
Sebastián Franco 26412fba5b Merge "Fix the wiggle reorder aniamtion stopping if dragging" into tm-qpr-dev am: 659197407b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20429797

Change-Id: Ie67f086459ad74c7d67b7c6fadbd5a1737227311
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 18:43:37 +00:00
Anushree Ganjam 20c037c730 Merge "Add SearchResultCode to onSearchResult()" into tm-qpr-dev am: 30c1043b1c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20445922

Change-Id: I67353fe895e700890851cd007e6966ce1d8b9f70
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 18:43:23 +00:00
Sihua Ma 3ccbba3e9f Merge "Making talkback focus on the widget after the resize" into tm-qpr-dev 2022-11-15 18:32:55 +00:00
Sebastián Franco 659197407b Merge "Fix the wiggle reorder aniamtion stopping if dragging" into tm-qpr-dev 2022-11-15 18:28:29 +00:00
Anushree Ganjam 30c1043b1c Merge "Add SearchResultCode to onSearchResult()" into tm-qpr-dev 2022-11-15 18:17:33 +00:00
Sam Dubey d993a0cbab Merge "Revert "Reorder widgets no longer overlaps when no space is avai..."" into tm-qpr-dev am: 3d24f6735a am: 56cb636ac5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20479526

Change-Id: Idec760d0313c9400c38a3c8b6d25ab36d8df8056
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 14:57:32 +00:00
Sam Dubey 56cb636ac5 Merge "Revert "Reorder widgets no longer overlaps when no space is avai..."" into tm-qpr-dev am: 3d24f6735a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20479526

Change-Id: Ic53020d90f3056f3d3c686b4d5e55743c46c766b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 14:37:56 +00:00
Sam Dubey 3d24f6735a Merge "Revert "Reorder widgets no longer overlaps when no space is avai..."" into tm-qpr-dev 2022-11-15 14:28:11 +00:00
Sam Dubey 3dad4fec9f Revert "Reorder widgets no longer overlaps when no space is avai..."
Revert "Reorder widgets no longer overlaps when no space is avai..."

Revert submission 20427045-258023561

Reason for revert: Likely causing NPE while running launcher shortcut tests (Part of DM+Platinum monitor rotation. The revert won't be submitted if proven otherwise)

Bug: 259234533
Reverted Changes:
Ie599f7cb7:Reorder widgets no longer overlaps when no space i...
I04b262ecc:Reorder widgets no longer overlaps when no space i...

Change-Id: I4cc552588c8099356bc3f05c4c63d17a524f2a24
2022-11-15 13:24:19 +00:00
Luca Zuccarini 665ac9967b Merge "[Toast] Update A-Z <-> Toast transition for drawable backgrounds." into tm-qpr-dev am: 56ccb4eda5 am: b940d3e458
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20007687

Change-Id: Ida7f988f897da142021571830e1adbfd48c8c25a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 11:29:53 +00:00
Luca Zuccarini b940d3e458 Merge "[Toast] Update A-Z <-> Toast transition for drawable backgrounds." into tm-qpr-dev am: 56ccb4eda5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20007687

Change-Id: I29a84d48d8f591bc911f8459b43079f6ddfba72e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 11:07:23 +00:00
Luca Zuccarini 56ccb4eda5 Merge "[Toast] Update A-Z <-> Toast transition for drawable backgrounds." into tm-qpr-dev 2022-11-15 10:54:03 +00:00
TreeHugger Robot 7936906716 Merge "Reorder widgets no longer overlaps when no space is available" into tm-qpr-dev am: e2334d76fe am: 1660639dc0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20413617

Change-Id: I14b439ed928a6418e29dd11299a16e91ebb822ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 10:37:14 +00:00
TreeHugger Robot 1660639dc0 Merge "Reorder widgets no longer overlaps when no space is available" into tm-qpr-dev am: e2334d76fe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20413617

Change-Id: Ib60f471012fb310366f82e55653cdc65c2e7dd5a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 10:15:55 +00:00
TreeHugger Robot e2334d76fe Merge "Reorder widgets no longer overlaps when no space is available" into tm-qpr-dev 2022-11-15 09:53:02 +00:00
Saumya Prakash a836e9ba00 Merge "Add a flag for the redesigned Gesture Nav Tutorial" into tm-qpr-dev am: 59a3c51a43 am: b67ffcb04b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20470536

Change-Id: Ic89466fcf8349427af5b618afacab5d490ab2dfc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 03:10:37 +00:00
Saumya Prakash b67ffcb04b Merge "Add a flag for the redesigned Gesture Nav Tutorial" into tm-qpr-dev am: 59a3c51a43
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20470536

Change-Id: Iaad0a7624aa157f982c8156c993d5b98faac8c4d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 03:06:02 +00:00
Saumya Prakash 7eac37254b Add a flag for the redesigned Gesture Nav Tutorial
We plan to improve the gesture navigation education tutorial as
discussed and shown in go/gesture-nav-education.

Test: N/A
Bug: 241813570
Change-Id: I2ad8d12cf14c1b3f0eec3208ad12a24ac54b9dbc
2022-11-14 22:38:21 +00:00
Alex Chau 2426514bf6 Put IDP.getDeviceProfile logging behind a feature flag
- To avoid memory regression in performance testse

Fix: 257359801
Test: manual
Change-Id: I5ed768d90dba149eeb8f7be7d1d229b0b599a485
2022-11-14 21:19:44 +00:00
Sihua Ma 7a382f139d Making talkback focus on the widget after the resize
Fix: 216386890
Test: Manual
Change-Id: I79b0280c0f24a81be44e1578755ed90cf3343f88
2022-11-14 13:12:44 -08:00
Federico Baron 61dbfde9ed Merge "Add flag for 'Improve widget picker UX on large display form factor'" into tm-qpr-dev am: e779a8c783 am: 9b30b84879
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20341701

Change-Id: I7f4c1c4f43d2132714a98cd3429e7413dbd358b7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-14 19:39:06 +00:00
Federico Baron 9b30b84879 Merge "Add flag for 'Improve widget picker UX on large display form factor'" into tm-qpr-dev am: e779a8c783
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20341701

Change-Id: I63d9f134fe7c428d1dfe1dc02dcd6e418f6b98f0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-14 19:06:46 +00:00
Tracy Zhou 0b96f63514 Merge "Use movement on the trackpad instead of on screen for trackpad gestures used for gesture nav" 2022-11-11 22:31:35 +00:00
Federico Baron c0dc93d384 Add flag for 'Improve widget picker UX on large display form factor'
here's how we plan on improving widget picker under this flag: https://docs.google.com/presentation/d/1mcdjJWutr-ZGbPOndhe1D8YCdCh6EbO8eNyK3YMMVEY/edit#slide=id.g1571d496dda_0_145
Test: N/A
Bug: 256684299

Change-Id: I365516b43e70a37c7b93e089b6822c58a0f81540
2022-11-11 22:24:18 +00:00
Anushree Ganjam c36593139c Introduce imeHeight in KeyboardStateManager.
Bug: 204781396
Test: Manual
Change-Id: If9dc9427a73ab22d6418edb9c954e79fd0958395
2022-11-11 19:20:16 +00:00
Anushree Ganjam 6024013953 Add SearchResultCode to onSearchResult()
Bug: 204781396
Test: Manual
Change-Id: Ia776be0fdd42e1d5fa405911e28d9b0a12c1fdde
2022-11-11 18:26:58 +00:00
Anushree Ganjam 96c72745ae Add ImpressionLogger to StatsLogManager
go/toast-search-impression-logging

Bug: 204781396
Test: Manual
Change-Id: If00027581000d315590ce2fac46428cbf173da49
2022-11-11 18:23:25 +00:00
Tracy Zhou aef9d75f78 Use movement on the trackpad instead of on screen for trackpad gestures used for gesture nav
Bug: 254783214
Test: https://recall.googleplex.com/projects/3388b17c-d22f-46f8-b140-a102690377b4/sessions/f3311fbc-d8cf-4f19-b83c-8626aa285452
Change-Id: Iad2da5831af85dd3647e1e31b42fea0a6302b49c
2022-11-11 00:05:03 -08:00
Sebastian Franco 592e2691f6 Fix the wiggle reorder aniamtion stopping if dragging
We were using the minimum span to calculate the cell position
of the widget and if you move slightly because the minimum is usually smaller than the current size it would calculate wrong cell positions
that are change more frequently because it's smaller.

Also, I went back and moved
performReorder(... CellLayout.MODE_SHOW_REORDER_HINT) with the
alarm if block as it was before one of my refactors, it still works
if they are separate but is harder to think about the logic if they
are divided so it's better to all be in one block.

Fix: 255421416
Test: manual testing, reordering and making sure the animation is playing well.
Test: atest ReorderWidgets (to make sure the reorder is not broken)
Change-Id: I3eff5bc9f21fda8f2f8908380397d8639ac15ff9
2022-11-10 21:53:33 +00:00
Anushree Ganjam 9aa386cde2 Merge "Add ENABLE_TOAST_IMPRESSION_LOGGING to FeatureFlags." into tm-qpr-dev am: b63cc3f113 am: 9d77abc3f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20432435

Change-Id: Ifd258e36efa3b175292b7698a4233934abd7fad8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 20:44:23 +00:00
Anushree Ganjam 5fc563b2b5 Merge "Add OnLayoutCompleted() Listener." into tm-qpr-dev am: fd7afb707a am: 04c268daef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20432434

Change-Id: If48dabaf57308b293b7e9b211b04a50ce01420ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 20:44:15 +00:00
Anushree Ganjam 9d77abc3f4 Merge "Add ENABLE_TOAST_IMPRESSION_LOGGING to FeatureFlags." into tm-qpr-dev am: b63cc3f113
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20432435

Change-Id: If02f87ef74c73321afa3427d845ad80539292b30
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 20:43:32 +00:00
Anushree Ganjam 04c268daef Merge "Add OnLayoutCompleted() Listener." into tm-qpr-dev am: fd7afb707a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20432434

Change-Id: I21481a4769668479d161f5557caddaa8b7b85edf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 20:43:22 +00:00
TreeHugger Robot 5a84fe1817 Merge "Create test for default grid" into tm-qpr-dev am: 267d7179cd am: ed50adb7b4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20347132

Change-Id: I00abba38b3cd56d73bdef126493c1b7c601ad380
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 20:42:43 +00:00
Anushree Ganjam b63cc3f113 Merge "Add ENABLE_TOAST_IMPRESSION_LOGGING to FeatureFlags." into tm-qpr-dev 2022-11-10 20:31:01 +00:00
Anushree Ganjam fd7afb707a Merge "Add OnLayoutCompleted() Listener." into tm-qpr-dev 2022-11-10 20:19:42 +00:00
Vinit Nayak 27d004d369 Merge "Improve Split portrait gesture animation" into tm-qpr-dev am: 2ca82f38e4 am: 4b6c05c2ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20330754

Change-Id: Ib1e9cf31c70edb187f6bc8467f7a2d5ddaa9bb1e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 20:18:10 +00:00
TreeHugger Robot ed50adb7b4 Merge "Create test for default grid" into tm-qpr-dev am: 267d7179cd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20347132

Change-Id: I6cb50a223aa63323812133b50499fb84b6c19698
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 20:09:29 +00:00
TreeHugger Robot 267d7179cd Merge "Create test for default grid" into tm-qpr-dev 2022-11-10 19:37:11 +00:00
Vinit Nayak 4b6c05c2ef Merge "Improve Split portrait gesture animation" into tm-qpr-dev am: 2ca82f38e4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20330754

Change-Id: I6cd4962097e2c72762cf28f8c4feb01efa66f22b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 19:28:59 +00:00
Vinit Nayak 2ca82f38e4 Merge "Improve Split portrait gesture animation" into tm-qpr-dev 2022-11-10 19:19:39 +00:00
Jon Miranda f0349354ec Revert "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar.""
This reverts commit e7011d2b87.

Reason for revert: attempt to fix test issues

- Instead of using SharedPrefs which can be flaky anyways,
  we pass along a boolean to test transient taskbar when
  we are in the test harness

Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: I7c15a97363adc377f29853c1fe60b1960c77bfc3
2022-11-10 11:11:14 -08:00