6d66ad20cf
Fix issue in RTL where swipes on Launcher Smartspace are intercepted.
...
The `+ getScrollX()` translation is a duplicate, because
`mapCoordInSelfToDescendant` also does it internally. Same for the `+
getScrollY()`.
This wasn't an issue in LTR because the top left corner of the root view
is the same as the top left corner of the first page. `getScrollX()`
returns 0 in that case.
In RTL, the second page is to the left of the first page. If the touch
is on the first page, `+ getScrollX()` translates it outside of the
first page. This incorrectly sets mIsEventOverFirstPagePinnedItem to
false, leading to the swipe being intercepted.
Bug: 240380590
Fix: 240380590
Test: manual
Change-Id: I51f534695401ce527da8d2158130a4d54b086f3d
2022-11-21 23:52:20 +00:00
3d72ac1a78
Add revised thresholds for transient taskbar behind flag ENABLE_TASKBAR_REVISED_THRESHOLDS.
...
Bug: 260002412
Test: enable flag
Change-Id: I4d82a853061b1540b6c6aea5e58b05a3ea6638e0
2022-11-21 23:46:34 +00:00
dec4305d0c
Refactor GridSizeMigrationTaskV2
...
The majority of the logic in grid size migration should be implemented
as static functions in the first place since (1) they only runs once
after instantiation and (2) they are executed immediately after they are
instantiated.
This CL removes most of the instance variables from grid size migration
in favor of static methods since the later is more efficient, more
testable and therefore considered better programming practice in
general.
Bug: 256859723
Test: atest GridSizeMigrationUtilTest
Change-Id: Ief4654d79ad5cfd636e6145fdcc9dfe5a39cdf62
2022-11-21 15:24:38 -08:00
d5529bd651
Merge "Removing ENABLE_LOCAL_COLOR_POPUPS feature flag" into tm-qpr-dev am: db81133e94 am: 1326dc1981
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20523600
Change-Id: Idfed55fab3f55b7b8dfacd42a854c2db5078f5ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 22:36:58 +00:00
04ce9fa3ef
Adding the flag for putting widget host in the background
...
Bug: 235358918
Test: N/A
Change-Id: I300bb5e293de6995a0e69402a6e337739055ca59
2022-11-21 14:17:50 -08:00
1326dc1981
Merge "Removing ENABLE_LOCAL_COLOR_POPUPS feature flag" into tm-qpr-dev am: db81133e94
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20523600
Change-Id: I021598ca2f8cc2cc159ff0cb849b56ef3cadc682
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 22:01:44 +00:00
db81133e94
Merge "Removing ENABLE_LOCAL_COLOR_POPUPS feature flag" into tm-qpr-dev
2022-11-21 21:45:47 +00:00
654c3d1b98
[Toast] Add a feature flag for rich answer
...
Bug: 241295640
Test: tested with opt-in suggest data.
Change-Id: I424525eed93c60e77566bcaf673f9f1ff61e1fa1
2022-11-21 19:44:44 +00:00
7b022b93f8
Merge "Increase icon size to be closer to spec" into tm-qpr-dev am: 81a994e9a7 am: 1414f12c14
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20500530
Change-Id: Ic92db57de677e39bb299f7d175b9ed191992d7d1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 19:26:39 +00:00
661c8b9f04
Merge "Revert "Enable Pinning Deep Shortcuts in Secondary Display""
2022-11-21 19:20:38 +00:00
1414f12c14
Merge "Increase icon size to be closer to spec" into tm-qpr-dev am: 81a994e9a7
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20500530
Change-Id: Ib9eeb7e73e6b84c7dab4c8f89187a454f333bb33
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-21 18:49:50 +00:00
81a994e9a7
Merge "Increase icon size to be closer to spec" into tm-qpr-dev
2022-11-21 18:35:31 +00:00
bbe956ef5f
Removing ENABLE_LOCAL_COLOR_POPUPS feature flag
...
The feature has been disabled for a while and is not working correctly.
Also there is no UX plan to revisit this currently
Bug: 206508141
Bug: 259733681
Test: Presubmit
Change-Id: If1279c22b9d074592ba181c7caa0cf38f9cb842e
2022-11-21 10:21:45 -08:00
b7f7c71b01
Merge "Adds flag to show 2 rows of predicted apps in All Apps 0 state." into tm-qpr-dev am: c9c45ed783 am: c0eb61e82c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20489432
Change-Id: I3c3e9ae2a90dc3df541f4d4142e46f9d4ba55ab5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-19 01:09:48 +00:00
c0eb61e82c
Merge "Adds flag to show 2 rows of predicted apps in All Apps 0 state." into tm-qpr-dev am: c9c45ed783
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20489432
Change-Id: I59fa040c912c209f241d70b4d693df5b4d2649f5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-19 01:04:01 +00:00
c9c45ed783
Merge "Adds flag to show 2 rows of predicted apps in All Apps 0 state." into tm-qpr-dev
2022-11-19 00:48:49 +00:00
c62080726a
Add feature flag to control whether to inject fallback app results when AiAi fails to return app corpus results.
...
Bug: 255355348
Test: manual
Change-Id: Ic314f2f7fb1939f470b687d1f869753489ae8da6
2022-11-18 14:51:28 -08:00
4ec982b456
Revert "Enable Pinning Deep Shortcuts in Secondary Display"
...
This reverts commit 353b0a914f
2022-11-18 11:52:16 -08:00
81c47ad656
Merge "Fix issue where the solution is not updated when the grid is empty" into tm-qpr-dev am: 6322cb2e61 am: df8f8a9e97
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20512199
Change-Id: I4c02f26acb43643daafa4103ff765d178fa7e9a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 19:17:18 +00:00
df8f8a9e97
Merge "Fix issue where the solution is not updated when the grid is empty" into tm-qpr-dev am: 6322cb2e61
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20512199
Change-Id: If5ac96d72dbc287445bb35d1eb7f418852f97365
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 18:42:49 +00:00
6322cb2e61
Merge "Fix issue where the solution is not updated when the grid is empty" into tm-qpr-dev
2022-11-18 18:20:15 +00:00
ae0d7ef782
Increase icon size to be closer to spec
...
Also change paddings because spaces changed
Bug: 258463609
Test: DeviceProfileDumpTest
Change-Id: Iaee433ea3fb5ef633ad428699ce230317021b170
2022-11-18 12:38:14 +00:00
4e189b34dd
Merge "Add overlay proxy type to ALL and REBIND_SAFE." into tm-qpr-dev am: 2766142f80 am: d652a85075
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20502300
Change-Id: I2933103260942c6677375f840310d290f08d5b81
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 06:50:52 +00:00
d652a85075
Merge "Add overlay proxy type to ALL and REBIND_SAFE." into tm-qpr-dev am: 2766142f80
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20502300
Change-Id: Iaa266409b8878dee8146bb8ad85c5197924f4729
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 06:20:43 +00:00
2766142f80
Merge "Add overlay proxy type to ALL and REBIND_SAFE." into tm-qpr-dev
2022-11-18 05:58:17 +00:00
41e176d2dd
Merge "Fix pause work apps button being higher than normal" into tm-qpr-dev am: e1b66bd1bf am: 5d4646ab66
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20512477
Change-Id: I4c2a3f3cae8a6b0990636ed31440232a7dfc5106
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 05:05:53 +00:00
5d4646ab66
Merge "Fix pause work apps button being higher than normal" into tm-qpr-dev am: e1b66bd1bf
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20512477
Change-Id: I6d6edc1468bedac51e0cbd9ff283fc011fa851e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 04:33:08 +00:00
e1b66bd1bf
Merge "Fix pause work apps button being higher than normal" into tm-qpr-dev
2022-11-18 04:05:26 +00:00
7810361fdb
Merge "Fix ConcurrentModificationExceptions during binding." into tm-qpr-dev am: 3a801de233 am: ed37fabc9c
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20468156
Change-Id: Idb957261db7fd8ce440a04e909ae5e330767cac7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 02:02:55 +00:00
a306c7a226
Merge "Add feature flag to control whether to inject fallback app results when AiAi fails to return app corpus results." into tm-qpr-dev am: c5b5044aff am: 4f366af03e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20240749
Change-Id: I6ca3d72be87eadb858ec185b0bf413316bcfb9bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 02:02:32 +00:00
ed37fabc9c
Merge "Fix ConcurrentModificationExceptions during binding." into tm-qpr-dev am: 3a801de233
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20468156
Change-Id: I2a176b09a92ce02acd2a406f6647701098164328
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 01:57:55 +00:00
3a801de233
Merge "Fix ConcurrentModificationExceptions during binding." into tm-qpr-dev
2022-11-18 01:44:01 +00:00
4f366af03e
Merge "Add feature flag to control whether to inject fallback app results when AiAi fails to return app corpus results." into tm-qpr-dev am: c5b5044aff
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20240749
Change-Id: I1998767143366e5e7ed2f2d0bad7a596cf9e8729
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 01:32:56 +00:00
c5b5044aff
Merge "Add feature flag to control whether to inject fallback app results when AiAi fails to return app corpus results." into tm-qpr-dev
2022-11-18 01:09:23 +00:00
953a517765
Merge "Move SharedPreferences code to its own class." into tm-qpr-dev am: 3233010c5a am: b626411c99
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20446860
Change-Id: Ibafb226c2bc6bd1ea425725920520540a8720351
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 00:47:28 +00:00
b626411c99
Merge "Move SharedPreferences code to its own class." into tm-qpr-dev am: 3233010c5a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20446860
Change-Id: I397957b5d9584aebf4182930763a2c5ab6401073
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-18 00:17:45 +00:00
bcd65e85f4
Fix pause work apps button being higher than normal
...
This issue can be repro'd by typing something in toast box, hightlighting text, share, then back gesturing back to allApps work tab.
To fix, we can simply reset the translation when updating the visibility of the button by calling onApplyWindowInsets() in updateVisibility()
bug: 259004115
test: Photos Before: https://screenshot.googleplex.com/6JbHbK3rfdXiXM4 after: https://screenshot.googleplex.com/B99SLsFcPYf6jrG
Change-Id: I2d44de37666d5342457c6ae14c691eb1804043cd
2022-11-17 14:44:44 -08:00
02b4711e74
Fix issue where the solution is not updated when the grid is empty
...
Test: Manually move widgets and shortcuts around and the position should match the animation
Fix: 259502044
Change-Id: I20a98f9366394c840bb3cd0577de26a181a229ac
2022-11-17 14:23:09 -08:00
a04de842d1
Fix ConcurrentModificationExceptions during binding.
...
The same lists of extra items stored in BgModelData are also stored in
UI components. This is causing ConcurrentModificationExceptions. The
solution is to clone these lists or mark them as immutable before storing
them in their respective components.
Bug: 206918543
Test: Verified that crash no longer occurs after fix.
Change-Id: I571a2c451af58137aa7513b372b6a8ecf9bd3ff6
2022-11-17 20:46:51 +00:00
589c8d3e29
Add overlay proxy type to ALL and REBIND_SAFE.
...
Test: Manual
Fix: 259575422
Change-Id: I121fa0471f96df90e5ff88bbd0aba04556293dc7
2022-11-17 20:08:05 +00:00
146701ca3e
Move SharedPreferences code to its own class.
...
Bug: 251502424
Test: Code compiled correctly.
Change-Id: Iea0d6ab2999504117546ee0f7adc0c7b8b45c065
2022-11-17 17:22:47 +00:00
0a3d67f34f
Add support for multiple focus listeners to ExtendedEditText.
...
Bug: 249952937
Test: manual, see other bug in the topic
Change-Id: I8cc6f525d1a895cc9ee6c6087b51af330d4f25a6
2022-11-17 13:07:16 +00:00
fe4389ceab
Merge "Revert "Introducing new variable to enable/disable shortcuts."" into tm-qpr-dev am: 698239e16a am: 1b3a9650ce
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20033817
Change-Id: I64a2297ccb27de5a2a2f7a9a35eddeff74f9b3ff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-17 12:00:58 +00:00
c306591cff
Merge "Update overview to fit transient taskbar" into tm-qpr-dev am: 3dc6d7fb47 am: 29db172f9f
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20469954
Change-Id: Ic066a31ae1d97dbab5900b8648695d3dc9903938
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-17 12:00:35 +00:00
1b3a9650ce
Merge "Revert "Introducing new variable to enable/disable shortcuts."" into tm-qpr-dev am: 698239e16a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20033817
Change-Id: I1a36a8b8cef9038d95bc226f902f0b13f1acf12b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-17 11:34:40 +00:00
29db172f9f
Merge "Update overview to fit transient taskbar" into tm-qpr-dev am: 3dc6d7fb47
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20469954
Change-Id: I3907c3804f3c1a7e8b4fc9f647bde01b5eb186ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-17 11:34:15 +00:00
698239e16a
Merge "Revert "Introducing new variable to enable/disable shortcuts."" into tm-qpr-dev
2022-11-17 11:28:05 +00:00
3dc6d7fb47
Merge "Update overview to fit transient taskbar" into tm-qpr-dev
2022-11-17 11:04:18 +00:00
66bfb8bfab
Merge "Implement split from workspace to workspace" into tm-qpr-dev am: a71d353ff8 am: 7f754c162e
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20341821
Change-Id: Ic2b061618579edc04b1fda25955d415803d9556b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-17 08:14:00 +00:00
7f754c162e
Merge "Implement split from workspace to workspace" into tm-qpr-dev am: a71d353ff8
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20341821
Change-Id: I868918e650e3ef220a371ff785f2cd8d5de18225
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-11-17 07:46:17 +00:00
Xiaowen Lei
Jon Miranda
Pinyao Ting
TreeHugger Robot
Sihua Ma
Becky Qiu
Brian Isganitis
Sunny Goyal
Holly Sun
Sebastián Franco
Thales Lima
Brandon Dayauon
Stefan Andonian
Luca Zuccarini
Alex Chau
Tracy Zhou