Commit Graph

83004 Commits

Author SHA1 Message Date
Brian Isganitis 066f5adcf6 Run Taskbar controller tests on VirtualDisplay.
Flag: TEST_ONLY
Test: go/testedequals
Bug: 369641781
Change-Id: Id53f420e7edc1779da9eb7647644ffffb74e67b3
2024-10-10 19:13:40 +00:00
Federico Baron f20255fd09 Revert "Demote TaplThemeIconsTest#testShortcutIconWithTheme"
This reverts commit 7672f320e8.

Reason for revert: issue no longer happening

Change-Id: I6dd0b00deb626e0248abc9007c0ae58743931f0c
2024-10-10 18:45:56 +00:00
Treehugger Robot 30b32fe00a Merge "Add state manager logs to protolog" into main 2024-10-10 17:01:20 +00:00
Liran Binyamin 81d1295b46 Merge "Create container view for bubble bar" into main 2024-10-10 13:25:57 +00:00
Himanshu Gupta 45fe132a48 Handle Quiet Mode for Work Profile gracefully when Pixel Launcher is not default.
Bug: 364759351
Change-Id: I997af16e2756ddfdd964916cce4ac98e39b86917
Test: Manual
Flag: NONE Bug fix tweak.
2024-10-10 12:54:42 +00:00
Uwais Ashraf 71fb897f39 Merge "Adds View screenshot tests for TaskThumbnailView." into main 2024-10-10 11:38:19 +00:00
Jagrut Desai f567652348 Merge "Update taskbar corner roundness progress" into main 2024-10-10 03:44:02 +00:00
Sunny Goyal 266f51b488 Converting LauncherModel to kotlin
> This will make it easier to migrate to dagger as it will
  increase the number of constructor parameters significantly

Test: presubmit
Bug: 361850561
Flag: EXEMPT dagger migration
Change-Id: Id06246ec74c678d7614f4c6a798c5644b40a0545
2024-10-10 00:34:12 +00:00
Android Build Coastguard Worker d82c3fe0ed Snap for 12478163 from 1160d080f4 to 25Q1-release
Change-Id: I2b9e7c5ef90218c07b4e0fdf8b596c049c413bc1
2024-10-09 23:23:59 +00:00
Brian Isganitis 7f6ecaaa06 Add FakeLauncherPrefs with basic tests.
Flag: TEST_ONLY
Bug: 369504330
Test: go/testedequals
Change-Id: I1cc408451b1f6e316c0ec6b087989323bcd9da4d
2024-10-09 18:55:51 -04:00
Brian Isganitis 9cbc478574 Split LauncherPrefs into abs class / impl.
Splitting allows easily making a fake that doesn't have to override the implementation details of LauncherPrefs. The fake should not deal with SharedPreferences.

LauncherPrefs could be an interface, but then the companion object has more limitations. The solution there is to have a dedicated object class, e.g. `LauncherPrefItems`. I went with an abs class to make the refactor simpler.

Flag: EXEMPT refactor
Bug: 369641781
Test: go/testedequals
Change-Id: I97a2d495d3b5fa892fa53a11fb3f7a7dfb98515b
2024-10-09 18:55:51 -04:00
randypfohl 2d85bf6432 Small refactor to remove unecessary inheritance
Test: Built and ran locally

Flag: com.android.launcher3.enable_fallback_overview_in_window

Bug:292269949

Change-Id: I05042834912accc9720d41d79a6222109d53a6e0
2024-10-09 15:47:05 -07:00
Shamali Patwa 1e97487ceb Merge "Fix issue that widget drag and drop failed when are off" into main 2024-10-09 22:27:19 +00:00
Jagrut Desai 04c2bf387a Update taskbar corner roundness progress
This cl simply updates taskbar corner roundness after it finishes initializing all the controllers.

Test: Presubmit
Bug: 370984727
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: Ieb98835c74cc992f47354dbfa86ededeadf5c786
2024-10-09 14:41:22 -07:00
Ats Jenk d137856e26 Merge "Update bubble bar swipe logic" into main 2024-10-09 21:32:43 +00:00
Randy Pfohl 6fe18165b4 Merge changes Ifd147d6f,I72629a27 into main
* changes:
  decoupling task animation lifecycle from recents lifecycle
  fixing a state cycle issue in recents window  where we set home instead of bg_launcher
2024-10-09 21:27:01 +00:00
Android Build Coastguard Worker 04fe471d8d Snap for 12477291 from f7ae1ec325 to 25Q1-release
Change-Id: I4e2194c6ab2e21479de8f7c5386e8248aeed8c73
2024-10-09 21:22:20 +00:00
Brian Isganitis 601d1f04e9 Merge "Migrate Taskbar tests to use SandboxApplication." into main 2024-10-09 21:12:14 +00:00
Shamali P dfcec9c71c Fix issue that widget drag and drop failed when are off
Remove extra screen & go to normal state only if widget
addition was complete. If a config activity was started, then
don't change to remove screen yet or go to normal state. Else,
QuickStepLauncher clears the existing activity open requests when
going to normal state. When animations are off, this led to config activity to never launch and hence, such widgets not being added.

Bug: 369422714
Test: Manual
Flag: EXEMPT BUGFIX
Change-Id: I4e7e29fd998a0cc5ca18a7a48b91a5b788a60a52
2024-10-09 20:28:39 +00:00
Treehugger Robot 1160d080f4 Merge "Fix cropped folder name text in arabic" into main 2024-10-09 19:35:13 +00:00
Liran Binyamin 024b0e63da Merge "Prepare for wiring bubble bar flyout" into main 2024-10-09 19:23:54 +00:00
mpodolian 51e2bb31ed Created a helper method that calculates the hotseat icons shift X.
Moved out logic that computes the translation X for the hotseat icons.

Fixes: 368379159
Test: Manual. Have the hotseat adjusted. Open any application from the
hotseat bar. Go back to home.
Flag: EXEMPT refactoring

Change-Id: If9dfa70be537f87b075bd865e7f9c5cd1ae78f00
2024-10-09 12:17:01 -07:00
randypfohl ff160c51a0 decoupling task animation lifecycle from recents lifecycle
this will fix a few bugs but create acouple others. Luckily this is all behind a flag for now but will prevent us building on broken code

Test: Built locally and tested

Flag: com.android.launcher3.enable_fallback_overview_in_window

Bug:292269949

Change-Id: Ifd147d6f3dd3234dfb1afe369f83c241a205c6af
2024-10-09 12:03:49 -07:00
Liran Binyamin c25aa0c20f Create container view for bubble bar
The container will be used to inflate the bubble bar flyout view

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: builds successfully -- code is not wired up yet

Change-Id: I3012caa801c73f9e13f26c8803595b59e250ae1e
2024-10-09 11:09:48 -04:00
Schneider Victor-Tulias 1decb57e61 Add state manager logs to protolog
Flag: com.android.launcher3.enable_state_manager_proto_log
Bug: 292269949
Test: checked winscope traces
Change-Id: I0941620efca3bf0d3cd859c211a7b06932d3838a
2024-10-09 14:14:22 +00:00
Sunny Goyal f7ae1ec325 Merge "Moving manifest initialization to RoboApplication instead of a separate rule" into main 2024-10-09 07:52:37 +00:00
Fengjiang Li 741806408d Merge "[Dagger] Make AsyncClockEventDelegate provided by DaggerSingletonObject" into main 2024-10-08 23:56:25 +00:00
Mykola Podolian 7153b179a9 Merge "Update stashing hotseat logic." into main 2024-10-08 23:38:38 +00:00
Android Build Coastguard Worker 97d2e46094 Snap for 12470893 from 9dcf307a62 to 25Q1-release
Change-Id: I6e2f6bd48089a6ecc50be27ea59d4e947f3f953b
2024-10-08 23:23:06 +00:00
Ats Jenk 6570ac750f Update bubble bar swipe logic
After changes following swipe interactions are available for the bubble
bar:
1. stashed handle
- swipe up to show bubble bar, after swipe reaches unstash threshold, we
  show the bubble bar
- swipe down to stash bubble bar in the same gesture (without lifting
  finger), do this when swipe moves back below unstash threshold
- expand bubble bar on finger lifted when currently above unstash
  threshold

2. collapsed bubble bar (used in home or overview)
- swipe up and release over unstash threshold to expand bubble bar
- bubble bar can't be swiped down to stash it

3. expanded bubble bar
- no swipe interactions available

Bug: 371229061
Flag: com.android.wm.shell.enable_bubble_bar
Test: BubbleBarSwipeControllerTest
Test: manually test:
  - stashed bubble bar:
      - swipe up and back down => bubble bar shown and stashed
      - swipe up slightly and release => bubble bar not shown
      - swipe up and release => bubble bar shown, expands on release
  - collapsed bubble bar:
      - swipe down => no action
      - swipe up slightly => no action
      - swipe up and release => bar expands on release
Change-Id: I42aa59dc288446603e06a3d02419be38cf17fa1f
2024-10-08 16:17:32 -07:00
randypfohl c8d1465a76 fixing a state cycle issue in recents window where we set home instead of bg_launcher
Flag: com.android.launcher3.enable_fallback_overview_in_window

Test: Local state cycling

Bug: 292269949

Change-Id: I72629a270f0afa1d05803636f9c9308d2a0e08fd
2024-10-08 16:15:23 -07:00
Android Build Coastguard Worker 98a8922e41 Merge cherrypicks of ['googleplex-android-review.googlesource.com/29694146'] into 24Q4-release.
Change-Id: I40ab3875937e5d443fc62b800f7ddaae1166cbbf
2024-10-08 22:58:29 +00:00
Tony Wickham 045814a2c6 Don't invalidate swipe handler until parallel anim finishes
- When invalidateHandler() is called, it calls endRunningWindowAnim()
  which includes mParallelRunningAnim. This causes a jump if
  mParallelRunningAnim was not already finished, so we now wait to
  invalidate the handler after mParallelRunningAnim ends.

Flag: EXEMPT bugfix
Test: AbsSwipeUpHandlerTestCase (added two tests for this)
Fixes: 370208192
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:ee98cd4bdf739c2f93f7cf0a20764acb2a837b0c)
Merged-In: I37ed281a993b1d2fa3634754378314511f3295f0
Change-Id: I37ed281a993b1d2fa3634754378314511f3295f0
2024-10-08 22:55:35 +00:00
Liran Binyamin 98ecad0352 Prepare for wiring bubble bar flyout
Implement BubbleBarFlyoutPositioner in BubbleBarViewController

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: builds successfully -- code is not wired up yet
Change-Id: Ib2d9b1f2f6e972f6ce949e10d50334a501c8c805
2024-10-08 16:40:31 -04:00
Alina Zaidi 90f9700b4d Merge "[dev_option] Move DestopModeFlags out of android.windows.flags" into main 2024-10-08 20:24:06 +00:00
Sukesh Ram 26b2757958 Merge "Create Launcher flag: enable_taskbar_connected_displays" into main 2024-10-08 18:59:41 +00:00
Sunny Goyal 6a207fc4f9 Moving manifest initialization to RoboApplication instead of a separate rule
This makes the behavior same as instrumentation test

Bug: 370080120
Test: Presubmit
Flag: EXEMPT test fix
Change-Id: Id4183c91f3951748b657b583fde8860abe55d3a8
2024-10-08 11:00:22 -07:00
Alina Zaidi 8c0dc4c655 [dev_option] Move DestopModeFlags out of android.windows.flags
This is to maintain separation of non-generated files from generated flag values.

Test: Current tests pass
Flag: EXEMPT refactoring
Bug: 370777204
Change-Id: If9ca76cbf084da7a37241216f41319610adc52b0
2024-10-08 17:51:23 +00:00
Sunny Goyal 9dcf307a62 Merge "Fixing test flakiness in Launcher initialization" into main 2024-10-08 17:29:27 +00:00
Fengjiang Li 2075e39c76 [Dagger] Make AsyncClockEventDelegate provided by DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: NONE - dagger
Change-Id: I53791218e0ff1e5d61cefee3f32a4c49882777cc
2024-10-08 10:19:01 -07:00
Fengjiang Li a49a2a32be Merge "[Dagger] Make SettingsCache provided by DaggerSingletonObject" into main 2024-10-08 17:13:20 +00:00
Brian Isganitis 46b20441e4 Migrate Taskbar tests to use SandboxApplication.
This class has even better sandboxing and is a TestRule, making it easy to tear down singletons.

Flag: TEST_ONLY
Fix: 369504330
Test: go/testedequals
Change-Id: I86fbfecc275da536ab745d61bef8b9bebb28379c
2024-10-08 16:34:44 +00:00
Brian Isganitis 67ed920053 Merge changes from topic "brianji-object-sandbox" into main
* changes:
  Add SandboxApplication for keeping created contexts in sandbox.
  Allow specifying base for SandboxModelContext.
  Rename to ObjectSandbox.
2024-10-08 16:33:47 +00:00
Jagrut Desai d37759429b Merge "Fix Taskbar to Hotseat Animation for Non-Predective back apps" into main 2024-10-08 16:08:09 +00:00
Orhan Uysal 3d7bba6a6e Merge "Use desktop API to remove desktop for dismiss" into main 2024-10-08 15:18:06 +00:00
Liran Binyamin 9c3c7cc3e2 Merge "Store the flyout in BubbleBarBubble" into main 2024-10-08 13:31:53 +00:00
Sukesh Ram 95a806d50b Create Launcher flag: enable_taskbar_connected_displays
Test: N/A
Bug: 362720616
Flag: EXEMPT creating the flag itself
Change-Id: I86fdb5c634b6d81361c60ecce2bb8e25641a83fa
2024-10-08 10:41:13 +00:00
Sukesh Ram fb1088ef87 Merge "Refactor Taskbar Button Coloring Code" into main 2024-10-08 08:06:51 +00:00
Sunny Goyal 8f921688b7 Merge "Removing dependency on PackageInfo in IconCache" into main 2024-10-08 07:33:39 +00:00
Fengjiang Li 4d819d9dea [Dagger] Make SettingsCache provided by DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: NONE - dagger
Change-Id: Id709a6e1d14446b8361cf292d5f5422f2ea3524c
2024-10-07 23:10:53 -07:00