Commit Graph

83004 Commits

Author SHA1 Message Date
Jordan Silva 06dbdcea4e Fix a bug where the last large task index was not being set correctly.
This was causing the focused task shift to be calculated incorrectly, which was resulting in the focused task being shifted too far to the left.


Bug: 330342294
Fix: 371490320
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: Manual. Open 1 DesktopTask, 1 FocusedTask, 2 other tasks in the grid. Dismiss the focused task. The rebalance should work keeping the new focused task next to desktop task.
Change-Id: If6f95814942c2cbadc30a0082649569f21dea60a
2024-10-04 07:28:42 +00:00
Treehugger Robot 5a90a5ab96 Merge "Fix for recents button quick switch with only focus and desktop task" into main 2024-10-04 05:05:37 +00:00
vinayjoglekar b6ac8b2ae9 Fix for recents button quick switch with only focus and desktop task
This CL also fixes : Home -> Recents -> Recents opens the last large tile (Which was broken when there is desktop window tile in recents.)

Test: Manual
BUG: 365756337
Fix: 365756337
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: I0b8fe3a0a7074355f14ced23ae282fe2943d8ce9
2024-10-03 18:58:48 -07:00
Jordan Silva e4b0747194 Update bug number for enable_large_desktop_windowing_tile
Bug: 357860832
Change-Id: If208bfb26bd4e082bf5197b44f7270ee3e68ae39
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: Gantry should update the bug reference
2024-10-04 01:08:13 +00:00
mpodolian 989aa8ac83 3 button nav is laid out correctly.
Updated logic of laying out the 3 nav buttons container. Also updated
placement of the hotseat, so it is not shifted on the phone.

Test: Manual. Fold and unfold felix with and without bubbles. Reboot
the devices and perform the same test.
Fixes: 370773620
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I7d5ba51f7ded275f7456a8690d04001b9651f6c5
2024-10-03 16:57:58 -07:00
Android Build Coastguard Worker 19a768463e Snap for 12451942 from 2f3d7b16c6 to 25Q1-release
Change-Id: I69a86bff3d3f7a1c8ec26295de261299ddefb3a0
2024-10-03 23:22:16 +00:00
Rajeev Kumar d0ce1d3c50 Get rid of unused PopupDataProvider field and also add method to Share class to be able to pass mock StatsLogManager from unit tests.
Bug: 371327013
Fixes: 371327013
Flag: EXEMPT bugfix
Test: atest com.android.launcher3.AppSharingTest
Change-Id: I2267b2ba5bbc997e36440881f0228e2b3099a09d
2024-10-03 23:04:44 +00:00
Ats Jenk d819f32e46 Animate bubble bar alpha when notif shade opens
Similar to taskbar, animate the alpha for bubble bar when notification
shade is expanded.

Bug: 345687278
Test: have bubbles on home screen, swipe down notification shade,
  bubbles are hidden with an animation
Test: have bubbles in app, stashed, swipe down notification shade,
  no change
Test: have bubbles in app, unstashed, swipe down notification shade,
  bubbles hidden with an animation
Test: receive bubble notification while shade is open, check that
  bubble bar is not shown

Test: compare bubble bar shadow and stroke before and after change
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I74af6a7230f81628540f9b935cbe7dc801bd7a01
2024-10-03 15:33:38 -07:00
Ats Jenk 2166749190 Set bubble bar invisible while stashed
Update bubble bar visibility when it is stashed.
Ensures that if alpha is updated, it won't show up.

Bug: 345687278
Test: TransientBubbleStashController
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I603a67a824a5cee0fb35de7c3f2dc98d9d2323ed
2024-10-03 15:33:38 -07:00
Ats Jenk 2f3d7b16c6 Merge "Apply bubble bar background alpha to stroke paint" into main 2024-10-03 20:20:08 +00:00
Ats Jenk 35b87d33b2 Inject bubble controllers directly
Replace injecting bubble controllers class with each controller
separately.c

Bug: 371017282
Test: TaskbarStashControllerTest
Flag: TEST_ONLY
Change-Id: Iccb870b0976b51fcd5a987cf208531da413921d1
2024-10-03 10:09:30 -07:00
Mady Mellor 2aedf52b8f Merge "If we're going to overview we might need to unstash" into main 2024-10-03 16:12:09 +00:00
Orhan Uysal 4acf699619 Merge "Fix overview animation after reboot." into main 2024-10-03 14:01:57 +00:00
Shamali Patwa b5c32d4c4f Merge "Add logs in ProxyActivityStarter when it fails to launch an activity" into main 2024-10-03 02:35:54 +00:00
Treehugger Robot 1bbcff3d48 Merge "Fix an issue where bubble bar would collapse when rotating" into main 2024-10-03 02:07:02 +00:00
Android Build Coastguard Worker eeff3497e0 Merge cherrypicks of ['googleplex-android-review.googlesource.com/29616053', 'googleplex-android-review.googlesource.com/29656286'] into 24Q4-release.
Change-Id: If5fb394c4a29ca3153eecdc894f54321dbaa3927
2024-10-02 23:23:28 +00:00
Android Build Coastguard Worker 94efb16851 Snap for 12445464 from 17b246a556 to 25Q1-release
Change-Id: Id9550bc05cc13a98d51afd7e7c7f88040909da77
2024-10-02 23:22:45 +00:00
Jeremy Sim 7b33cd902b Fix small bug with TaskView tile expansion
There was a small typo that resulted in the wrong measurement being returned for the remaining TaskView. This CL fixes it.

Fixes: 365476600
Test: Manual
Flag: NONE bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:21f504e0f14f0d3b983bf6694eeda8fc7bedda34)
Merged-In: I1abf993abcaa8d06e5475f31c0322017f6e96e6f
Change-Id: I1abf993abcaa8d06e5475f31c0322017f6e96e6f
2024-10-02 23:22:06 +00:00
Jagrut Desai 73532bf515 Two Taskbar Bug
This cl fixes two taskbar bug being present when invoking CtS.

Solution: simply measure displacement and compare that with slop to animate taksbar background or not.

Test: Presubmit
Bug: 360116669
Flag: EXEMPT Bug Fix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:7cada7c46b0462bc56d2dc363d61e8967a42001f)
Merged-In: I7d5a95e1a3729e30e5cf588dcf5b823f3d7de93f
Change-Id: I7d5a95e1a3729e30e5cf588dcf5b823f3d7de93f
2024-10-02 23:21:56 +00:00
Ats Jenk 936fec94bd Allow injecting bubble controllers in taskbar test
Update TaskbarUnitTestRule @InjectController annotation to support
injecting bubble controllers.
Bubble controllers are optional and only initialized if the feature flag
is enabled.
Add a test to check that bubble controllers are only initialized when
the flag is on.

Bug: 371017282
Test: TaskbarUnitTestRuleTest
Flag: TEST_ONLY
Change-Id: Ibea2dbe0db854d530ef93ac53204a361572fa5b2
2024-10-02 15:56:08 -07:00
Shamali P 66b501eae2 Add logs in ProxyActivityStarter when it fails to launch an activity
Apparently, it doesn't log when it fails due to some reason.

In 369422714, we see it being started but the appwidget's config
 activity not being launched. The absorbed exception makes it harder to
  know. There isn't a system log as well.

  At least looking at logs, we think for some reason appwidget's
   configuration activity wasn't launched by launcher.

Bug: 369422714
Test: N/A logging
Flag: EXEMPT BUGFIX

Change-Id: I56294ef37d7ddceb61c4e6d0e10d0f24fde42cb2
2024-10-02 22:33:39 +00:00
Fengjiang Li a909cc2dd7 [NPE] Fix NPE of TaskInfo in FloatingWidgetView#getDefaultBackgroundColor
Fix: 370315165
Flag: NONE - prod crash
Test: presubmit
Change-Id: I50e71f0611fc9c664cfe51fbe9c3fc21462e10ed
2024-10-02 14:30:08 -07:00
Mady Mellor 3e8cc610b3 Fix an issue where bubble bar would collapse when rotating
When the device is rotated, everything gets recreated, in this case,
bubble bar state is typically set to be stashed. However, if taskbar
and bubble bar were unstashed while rotating, bubble bar would be
incorrectly stashed. To fix this, only do the stash if taskbar is
also stashed in this case.

Flag: com.android.wm.shell.enable_bubble_bar
Test: manual - be in an app, unstash bubbles, rotate device
             => observe that bubble bar is unstashed like taskbar
                after rotation
Bug: 353884121
Change-Id: Ia37397c62a1a6819c1bd42261f8a9955db511da3
2024-10-02 13:55:55 -07:00
Jagrut Desai 831ca957c0 Merge "Remove unused TestProtocol" into main 2024-10-02 20:51:10 +00:00
Sunny Goyal e14af2316b Merge "Converting some caching logic booleans to lookup flags" into main 2024-10-02 20:34:16 +00:00
Shamali Patwa 1667cf561f Merge "Move padding from parent to WidgetPagedView and siblings in 2-pane pkr" into main 2024-10-02 20:31:16 +00:00
Brandon Dayauon 17b246a556 Merge "Don't call onAppsUpdated() when in testHarness" into main 2024-10-02 19:53:36 +00:00
Ats Jenk ad7a938268 Apply bubble bar background alpha to stroke paint
Alpha was applied to fill paint only. Add it to stroke paint as well.
Introduce a new method in Utilities to map range of ints and not only
floats.

Bug: 345687278
Test: compare bubble bar shadow and stroke before and after change
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I7c9e8d6337a857a661de0c945181cdd5ef2fd4ca
2024-10-02 10:20:06 -07:00
Shamali P adc171b313 Move padding from parent to WidgetPagedView and siblings in 2-pane pkr
WidgetPagedView seems to rely on padding to position it such that
 talkback doesn't focus on it before sticky header.

Bug: 348107507
Test: With talkback
Flag: EXEMPT bugfix

Change-Id: I2fcdc0cbf027a7a8c1bee104f85a61f700faf776
2024-10-02 16:55:59 +00:00
Liran Binyamin d8c3328d4d Pass bubble flyout from wm shell to launcher
Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarViewAnimatorTest
Change-Id: I8666765937a491903c6fc042d2d629374be4c70d
2024-10-02 12:27:52 -04:00
Liran Binyamin 1663bb3004 Merge "Bubble bar flyout polish" into main 2024-10-02 16:15:53 +00:00
Treehugger Robot d8daf184bc Merge "Update where we end CUJ_LAUNCHER_APP_SWIPE_TO_RECENTS" into main 2024-10-02 15:55:45 +00:00
Treehugger Robot 3faec179c0 Merge "Add debug memory logs to AbstractLauncherUiTest" into main 2024-10-02 15:39:05 +00:00
Schneider Victor-Tulias 9240b68dd6 Update where we end CUJ_LAUNCHER_APP_SWIPE_TO_RECENTS
Flag: EXEMPT bug fix
Fixes: 369359244
Test: performance testing
Change-Id: Id70c4b02738fd1abd62027fcddd0fac3c99fe95e
2024-10-02 14:15:56 +00:00
Bill Yi 4f4b2335b9 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-10-02 05:37:39 +00:00
Bill Yi bf752db081 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-10-02 05:37:39 +00:00
Treehugger Robot 5c3e15b0e0 Merge "Fix small bug with TaskView tile expansion" into main 2024-10-02 02:13:04 +00:00
Android Build Coastguard Worker afabbb624b Merge cherrypicks of ['googleplex-android-review.googlesource.com/29573568'] into 24Q4-release.
Change-Id: I32f46d6425e475f8cdc4b76c7ad4d6a00ca2b100
2024-10-02 01:58:44 +00:00
Anushree Ganjam 0dc88fece8 Merge "Make InstallSessionHelper injected by Dagger (7/n)" into main 2024-10-02 01:57:48 +00:00
Sunny Goyal 8c53be4b11 Fixing wallpaper preview rendered not being cleaned properly
> Using a single RunnableList for all the cleanup
> Performing cleanup when renderer surface is released

Bug: 362292374
Test: Verified manually using heapdump
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:be796be5e66b70bde118996dd5650d7fc9901ca5)
Merged-In: Idc1ee20dee2a2944d8e1c1d06b2662818d2b7001
Change-Id: Idc1ee20dee2a2944d8e1c1d06b2662818d2b7001
2024-10-02 01:57:42 +00:00
Toni Barzic 32ef2aed33 Handle enter key as editor action in search bar
Handles IME_NULL action in AllAppSearchBarController, which is generated
in response to the enter key (with no modifiers) keyboard event in
multiline text view. The action triggers search in the same way as
ACTION_SEARCH and ACTION_GO. Without this, enter key gets treated as
new line in the app list search box.

Test: Open all apps, and enter a search query using physical keyboard.
     Pressing ENTER triggers search. Pressing Shift + ENTER adds a new
     line to search query.
Bug: 370780257
Flag: com.android.launcher3.multiline_search_bar
Change-Id: I6aef5e120210f4efc216e03d24974b04ab5f1d16
2024-10-02 01:25:35 +00:00
Treehugger Robot b4b2d16bcc Merge "Fix translation when focused task or desktop task is dismissed. (3/4)" into main 2024-10-02 00:38:10 +00:00
Treehugger Robot 6d763a301c Merge "Fix Taskbar unlock transition" into main 2024-10-02 00:14:04 +00:00
Uwais Ashraf 67d0d59caf Adds View screenshot tests for TaskThumbnailView.
Bug: 344800402
Test: TaskThumbnailViewScreenshotTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: If6530ea9dfe026589f05731d5362dc10f719fc70
2024-10-01 23:42:39 +00:00
Android Build Coastguard Worker 89d50545e9 Snap for 12439515 from da8487eb33 to 25Q1-release
Change-Id: Ibef562c628941b0b147f53577c8ca55240b82fb4
2024-10-01 23:22:36 +00:00
Treehugger Robot da290bcacf Merge "Make large task tile snap to position after scrolling" into main 2024-10-01 23:01:37 +00:00
Treehugger Robot ff97ec0d22 Merge "Fix comment in TransientBubbleStashControllerTest" into main 2024-10-01 22:38:17 +00:00
Kevin Lim adac5834e3 Merge "Use context#getDrawable instead of AppCompatResources#getDrawable to fix test failure." into main 2024-10-01 21:21:20 +00:00
Ats Jenk da477af93d Fix comment in TransientBubbleStashControllerTest
Bug: 345488489
Change-Id: Ide38c1e36a0da53e9fcc7a5c6b0c3241eff24add
Test: na
Flag: DOCS_ONLY
2024-10-01 21:06:02 +00:00
mattsziklay 2f3a57eb5d Add split instructions view to desktop split.
Fixes issues with desktop split caused by the instructions view not
being present. Makes desktop split select more uniform with other split select transitions.

Fix: 369961040
Fix: 370038890
Test: Manual
Flag: EXEMPT bug fix
Change-Id: Icfc6228f3e2692fda59ce5ab7c847ebe5314b25e
2024-10-01 21:02:17 +00:00