Commit Graph

83004 Commits

Author SHA1 Message Date
Sunny Goyal 7966dd785c Move ContextualSearchHapticManager to MainThreadInitialiedObject
It depends on VibratorWrapper, ContextualSearchStateManager and LockedUserState
which needs to be migrated first

Bug: 373557167
Test: Manual (will merge automated tests once all culprits are resolved)
Flag: EXEMPT dagger
Change-Id: Ib078b89a541c179d105ddf8706edc94bcaf6066b
2024-10-17 15:38:11 -07:00
Sunny Goyal 4eaf3df1fe Merge "Moving PluginManager to dagger" into main 2024-10-17 21:47:28 +00:00
Charlie Anderson 91a2aad67f Prevent archived apps content description from being overridden unexpectedly
Bug: 372035896
Test: manually tested archiving/unarchiving with Talkback
Flag: EXEMPT bugfix
Change-Id: Ief7f7d176c6ed23a8d7798cf31506e0a9c8921ed
2024-10-17 17:39:59 -04:00
Jagrut Desai 0e7ca6c650 Merge "Fix Hotseat stashing on user going to dream" into main 2024-10-17 20:52:31 +00:00
Schneider Victor-tulias 892ad69191 Merge "Improve test isolation in AbstractLauncherUiTests" into main 2024-10-17 19:22:37 +00:00
Artsiom Mitrokhin ab7220c342 Open taskbar pinning popup view from anywhere
This CL handles both long-press and right-click events anywhere on
pinned taskbar and opens `TaskbarDividerPopupView` correctly
positioning it above the event coordinates.

Bug: 297325541
Flag: com.android.launcher3.show_taskbar_pinning_popup_from_anywhere
Test: manual for now, flip the flag, long-click or right-click
      on empty space on the pinned taskbar
Change-Id: I1849db14f65bf9478ed9f4fd39f95d08987baf8d
2024-10-17 15:00:40 -04:00
Sunny Goyal 9cd3154952 Moving PluginManager to dagger
Multiple singletons depend on Plugin which can cause deadlock
if PluginManager is initialized on main thread

Test: presubmit
Bug: 361850561
Bug: 373557167
Flag: EXEMPT dagger
Change-Id: I79f17ac6b78a2ce60df2d27a6e794b9e4eba1b51
2024-10-17 11:48:38 -07:00
Treehugger Robot fc4420dc3e Merge "Add animation runner for alt-tab desktop app launch" into main 2024-10-17 18:48:31 +00:00
Treehugger Robot 5572968c0b Merge "Moving SettingsChangeLogger back to MainThreadInitializedObject" into main 2024-10-17 18:33:04 +00:00
Brandon Dayauon 134bd12153 Merge "Set psDivider to gone in collapse due to updateAdapterItem suppression in test." into main 2024-10-17 17:09:12 +00:00
Jagrut Desai 36bbc4f18f Fix Hotseat stashing on user going to dream
This cl simply delays the taskbar icon alignment animation and stashing animation by duration of dream animation and plays it off screen with 0 duration.

Test: Manual, Presubmit
Bug: 333989177
Flag: EXEMPT bugfix
Change-Id: I35d26b0cf895f9990fcfd73ceebc15b0f9886476
2024-10-17 09:59:26 -07:00
Sunny Goyal 3c873420e8 Moving SettingsChangeLogger back to MainThreadInitializedObject
SettingsChangeLogger depends on DisplayController which needs to be migrated
first. Otherwise it introduces a deadlock when initializing DisplayController
in constructor

Bug: 373557167
Test: Manual (will merge automated tests once all culprits are resolved)
Flag: EXEMPT dagger
Change-Id: I2386812693e470bcee1a64d5cec49c03fd36f230
2024-10-17 09:51:59 -07:00
mpodolian 1d4e75c777 Refactored hotseat translation X logic
Made retrieval of the hotseat translation X easier to use.

Test: Manual. Set the navigation mode to 3-button. Moved the bubble bar
from one side to the other. Switched the navigation mode to gestures.
Moved the bubble bar from one side to the other again.
Bug: 373422448
Flag: EXEMPT refactoring

Change-Id: Ie69f1ecf178244008e5c752882c4b91a30928756
2024-10-17 09:46:47 -07:00
Jordan Silva ab23dc8648 Fix split selection translation when focused task is selected for splitscreen
After enabling large tile for desktop windowing, some animations and translations for dismiss were changed. The changes involved to translate the tasks when a large tile (i.e., focused task and desktop window) are dismissed and no other focusedTaskView is selected to replace the previous one. However, when we split a focused task, we don't replace it by another task in the grid. And also triggers the createTaskDismissAnimation, entering the same condition described before (focused task dismissed, nextFocusedTaskView = null), causing the weird and broken animation for split.

To fix this, we skip this animation when is dismissing a task for split selection.

Fix: 374104009
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: Manual. With flag enabled and multiple apps opened in Overview, split the focused task.
Change-Id: Ib79ad5abc0660a0b654f23b22b90f9889c6f7806
2024-10-17 17:41:36 +01:00
Treehugger Robot 559837d810 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-10-17 16:19:23 +00:00
Treehugger Robot b7c471f517 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-10-17 16:19:23 +00:00
Schneider Victor-Tulias ecaf00a464 Update RecentsWindowSwipeHandler to animate home alpha properly
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 366022874
Test: Attempted gesture from home and launched app
Change-Id: I553ad200b291f7765bbb026c314ea6652a3b5542
2024-10-17 15:41:01 +00:00
Sam Cackett 072970e1fa Merge "Draw live tile below Overview after launch animation" into main 2024-10-17 13:52:17 +00:00
samcackett ea788d92be Draw live tile below Overview after launch animation
A fix (see http://go/b320307512_problems) was put in to change layers
when swiping from Desktop Windowing to Overview, so that the blur effect
 didn't apply to the live tile. The result of this change was that the
 tasks now sat on top of Overview and if you didn't launch the task but
 went back to Overview, then you could interact with them and do things
 like resize the task and get into a very broken state.

This fix simply flips the layer ordering back after the animation
completes to ensure Overview sits on top.

Fix: 373400009
Flag: NONE bugfix
Test: Swipe from Desktop to Overview. Swipe down from Overview to launch
 the live tile, but then swipe back to Overview i.e. don't launch
 Desktop. Try to resize the DW window.

Change-Id: I80c8d72f76a8393eb8bd963df81723defd85ed97
2024-10-17 13:51:28 +00:00
Treehugger Robot c9b444c790 Merge "Fixed the opened folder on taskbar when NotifShade is shown" into main 2024-10-17 02:42:19 +00:00
Treehugger Robot 642e84e397 Merge "Cleanup for TAPL Debugging" into main 2024-10-17 02:18:08 +00:00
Randy Pfohl 2ff556131a Merge "Using synthetic recents transitions for Recents in Window" into main 2024-10-17 01:53:35 +00:00
Treehugger Robot 3cac51e141 Merge "Fix RecentsView crash when DesktopTask has only 1 task and it is in split mode" into main 2024-10-17 01:14:38 +00:00
Bill Yi fbe5044c4e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I5e1473aede364901d9b4da42154df8c7c5f90ad5
2024-10-16 18:09:30 -07:00
Bill Yi 7cbcaa7b67 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie3e674cb84d50b961c50a5beb5616fbd002957db
2024-10-16 18:08:40 -07:00
Sukesh Ram fc6cc4e409 Cleanup for TAPL Debugging
Cleaning up leftover log statements.

Flag: EXEMPT bugfix
Bug: 324419890
Test: Manual
Change-Id: I54145d07f0699f68c44aaa34e1692c8fe2f7b780
2024-10-16 16:55:45 -07:00
Android Build Coastguard Worker 28a8faf726 Snap for 12508860 from dca74bcb24 to 25Q1-release
Change-Id: I96598742b35d4bedbde24d07e7e9bd81eda84927
2024-10-16 23:22:34 +00:00
Winson Chung a2dea77229 Using synthetic recents transitions for Recents in Window
Bug: 366021931
Flag: com.android.launcher3.enable_fallback_overview_in_window
Test: manual with enableFallbackOverviewInWindow=true
Change-Id: I26fbc96373b55f0a4a87756fa99347f0e4f4361b
2024-10-16 13:23:17 -07:00
Wen-Chien Wang e37b479b17 Fixed the opened folder on taskbar when NotifShade is shown
This cl fixes the bug by closing all abstract floating views
including opened folders when the notification shade is shown.
Usually this was handled in the folder class where it intercepted
the touch event to close it by dispatching the back key, but this
didn't work when the virtual keyboard existed.

More context is added in the bug.

Flag: EXEMPT bug fix
Fixes: 267529599
Test: Ran on a 1P device

Change-Id: Ifdd357668ece2c11888ecfc69af64b1742c07d6e
2024-10-16 17:53:08 +00:00
Treehugger Robot dca74bcb24 Merge "Have external resource call init() explicitly." into main 2024-10-16 17:37:47 +00:00
Schneider Victor-Tulias 07669e9575 Improve test isolation in AbstractLauncherUiTests
- Removing suspicious duplicate uses of AbstractLauncherUiTest.initialize to prevent unnecesary launcher restarts
- Adding UiDevice#pressHome to AbstractLauncherUiTests.verifyLauncherState to ensure the next test starts with a known clean state

Flag: EXEMPT test fix
Fixes: 372956489
Test: AbstractLauncherUiTest
Change-Id: Id68ece4ab195a4f6c47aa401eb50a91b8ff70e10
2024-10-16 13:18:36 -04:00
Jordan Silva f4a21b7e5c Fix RecentsView crash when DesktopTask has only 1 task and it is in split mode
This CL fixes a crash happening when no other task is available in Desktop Windowing (DW), and the only task in DW is selected to be part of the pair (split mode). The crash is happening because of the following logic:

- applyLoadPlan skips the staged tasks (for split) from the groupTask when adding the TaskViews to RecentsView.
- If a groupTask has multiple tasks, and one of the tasks is staged, groupTask will be treated as a single task and applyLoadPlan uses the other task (not staged) to create a single TaskView in Overview.
- DesktopTasks returns true for hasMultipleTasks, even when only 1 task is in DW mode. This causes a crash when the only task available in DW is staged for split.

This fix will skip DesktopTaskView creation when split selection is active. In addition, it updates DesktopTask to report multiple tasks only when more than 1 task is its task list.

Fix: 372357270
Fix: 372375086
Fix: 372864249
Flag: EXEMPT bugfix
Test: Manual. Instructions on bug report.
Change-Id: I95e32252a5cac4f6b99296422703d69d129a5a47
2024-10-16 17:34:08 +01:00
Anushree Ganjam 46636f2230 Merge "Add User group logging for Omnient" into main 2024-10-16 16:31:04 +00:00
Kevin Lim 9c5d8a2059 Merge "[Tests] Clear MAIN_EXECUTOR in NavHandleLongPressInputConsumerTest#tearDown" into main 2024-10-16 00:50:55 +00:00
Mykola Podolian 79032facbf Merge "Created a helper method that calculates the hotseat icons shift X." into main 2024-10-16 00:12:44 +00:00
Anushree Ganjam 6beaa59710 Add User group logging for Omnient
Bug: 369604840
Test: Manual
Flag: EXEMPT Omnient feature is launched
Change-Id: I5184ebf001d5c741f36592360e5a7f7b2292c0d5
2024-10-15 17:12:38 -07:00
Brian Isganitis fa6ca0fe6f Have external resource call init() explicitly.
Change-Id: Ibdd444478d0d171353a58c060022f5a181f9d1c4
Flag: TEST_ONLY
Test: go/testedequals
Bug: 230027385
2024-10-15 23:43:31 +00:00
Android Build Coastguard Worker d75dbbcba7 Snap for 12502765 from 8915d3c3b8 to 25Q1-release
Change-Id: I4e714821abb3e9fd570e0e9d6d1fe7376d52f91b
2024-10-15 23:23:09 +00:00
Brandon Dayauon 7e1149471a Update letter list textview background color to spec.
Spec: https://www.figma.com/design/uMzPkNMZpb7EyfHDo8usIa/V-%E2%80%A2-Toast-Butter?node-id=2746-180205&node-type=frame&m=dev

bug: 358673724
Test: manually - photo: https://drive.google.com/file/d/1RWlaSRHbXCYhsY1F3nzruldQnABszUiz/view?usp=sharing
Flag: com.android.launcher3.letter_fast_scroller
Change-Id: I03cd4fbf1e76a7ad34983ace18a69a52116e7834
2024-10-15 15:01:25 -07:00
Brandon Dayauon 347b149f6f Remove color animations when scrolling.
bug: 358673724
Test: manually
Flag: com.android.launcher3.letter_fast_scroller

Change-Id: I9601a01fbde3b74ad94e78fad151143820288f3e
2024-10-15 13:40:08 -07:00
Mykola Podolian 2eea74b623 Merge "Made the taskbar touchable during animation to home." into main 2024-10-15 20:29:05 +00:00
Treehugger Robot 8915d3c3b8 Merge "[Dagger] Make CustomWidgetManager provided by DaggerSingletonObject" into main 2024-10-15 19:19:36 +00:00
mpodolian d89732ef85 Made the taskbar touchable during animation to home.
Enabled taskbar touch processing while animating to home. Also excluded
quick search bar from touch region, so it is not interactable during the
animation & removed corresponding TODO from TaskbarView.

Fixes: 368419997
Test: Manual. Enable gesture navigation. Open any application. Swipe up
to go to the launcher home screen. Click any taskbar icon - the
corresponding application will open. If clicking on Quick search,
launcher search will be opened. Video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/g6UWhF9dQZq3QsFyH0EwtK
Perform the same test for buttons navigation mode. Video:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/gvuoSRnQfXQlejewBG1Ex8
Flag: EXEMPT bug fix

Change-Id: I07280bce70dd25d5ab78210302f08c0614309130
2024-10-15 11:54:04 -07:00
Kevin Lim f36375d907 [Tests] Clear MAIN_EXECUTOR in
NavHandleLongPressInputConsumerTest#tearDown

Attempt at fixing flaky tests

Bug: b/359911511,b/355232772
Flag: EXEMPT Test change
Test: NavHandleLongPressInputConsumerTest
Change-Id: I8ea91f732e91b1a7df4b2e2816dc70e35f14d504
2024-10-15 18:32:35 +00:00
Treehugger Robot 242d5b9e26 Merge "Revert "Add screenrecord for testWorkspaceSwitchToAllApps"" into main 2024-10-15 17:58:28 +00:00
Gustav Sennton 6bb9d56ded Add animation runner for alt-tab desktop app launch
Create a remote transition supporting alt-tab app-launches (app launches
caused by a user using alt-tab to select a minimized app) and any
minimization caused by hitting the window limit during such an app
launch.

Test: manual, and WindowAnimatorTest
Bug: 349791584
Flag: com.android.window.flags.enable_desktop_app_launch_alttab_transitions
Change-Id: I6474fff351f3d7681ca25cd7331e4955e3d1c6e0
2024-10-15 17:34:53 +00:00
Tracy Zhou ada58203ad Merge "Disallow 2-finger swipe from the corners to trigger assistant from trackpad" into main 2024-10-15 17:30:53 +00:00
Brian Isganitis dc4f56040a Merge "Migrate to FakeLauncherPrefs for Taskbar unit tests." into main 2024-10-15 17:08:35 +00:00
Jordan Silva d2867286ff Merge "Update OverviewCommandHelper to use Executors.MAIN to reduce the percentage of missed frames" into main 2024-10-15 16:52:05 +00:00
Graciela Putri 19c00bb849 Merge "Add task menu item to move task to external display" into main 2024-10-15 16:51:20 +00:00