Commit Graph

83004 Commits

Author SHA1 Message Date
mpodolian ed7ef84782 Set proper interpolators and durations for the bubble bar animations
Set proper interpolator and duration for bubble bar expansion and
collapsing animation. Also set animation properties for the taskbar
fade in and out animations.

Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Expand / collapse bubble bar when taskbar is pinned and
expanded bubble bar would intersect the task bar.
Fixes: 360821863

Change-Id: Ia83d6aecdae921721a31b45f22400f878040f3d6
2024-10-24 13:14:54 -07:00
Sunny Goyal 6bbd805e77 Keeping the custom widget placeholder even when the plugin is not corrected
Custom widget plugin can take some time to load, which causes already added
custom widgets to get removed during reboot. Instead keeping the placeHolder
while the plugin loads

Bug: 375444632
Flag: EXEMPT bugfix
Test: Manually verified using a custom plugin
Change-Id: Ibdf14f6d24adc194a716b29bb75a22220384e730
2024-10-24 12:40:13 -07:00
Brandon Dayauon 838a5e9d23 Merge "Add trace logs in Launcher for perfetto to investigate two line issue" into main 2024-10-24 19:35:15 +00:00
Anushree Ganjam ef2c5c0e49 Make ApiWrapper to be injected by dagger (12/n)
Bug: 361850561
Test: Manual
Flag: EXEMPT Dagger Integration
Change-Id: I53ec78999085b3e0ad6df69e177806e0cb1b52d1
2024-10-24 12:14:40 -07:00
Treehugger Robot c7b078d7a2 Merge "Refactor grid migration" into main 2024-10-24 19:00:22 +00:00
mpodolian 9fc4fad24f Fixed icons overlapping issue.
Removed early return condition from the Hotseat view

Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Unfold foldable device and have bubble. Fold the device.
Hotseat icons are not overlapped.
Fixes: 375240372

Change-Id: I576c893896c98d2a0dcb25f64396f4e9fe62f61c
2024-10-24 11:24:07 -07:00
Saumya Prakash 747c6b4427 Merge "Prevent Search taskbar edu from showing on home screen." into main 2024-10-24 18:00:24 +00:00
Wen-chien Wang 94fb42cef9 Merge "Add margins to KQS view that is triggered from taskbar" into main 2024-10-24 17:47:37 +00:00
Schneider Victor-Tulias 8b88177fb7 Fix launcher crash on configuration changed
Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 375398042
Test: rotated device
Change-Id: Ib57a7c43a664b5ba73284b9265c04cba16e4d4d2
2024-10-24 11:13:33 -04:00
Brandon Dayauon aebe733849 Merge "Set twoline toggle to false when not in english language." into main 2024-10-24 15:09:08 +00:00
Vinit Nayak 14e43ef0de Disable OrientationEventListener in RotationTouchHelper#destroy()
* Also cleared the list of runnables to run on destroy after
they are all executed

Bug: 361850561
Flag: EXEMPT bugfix
Test: QS works as expected in different rotations
Change-Id: If0dfbb7d538b24fe7aad0b4ed427d779b5a86bfd
2024-10-24 10:25:14 -04:00
Liran Binyamin abc4b6a137 Merge "Handle taps on bubble bar flyout" into main 2024-10-24 13:26:50 +00:00
Fengjiang Li c8bd4bd3d3 Merge "[PostBoot] Do not destroy post boot loader because of theme change" into main 2024-10-24 07:59:24 +00:00
Brandon Dayauon 51db65ee49 Add trace logs in Launcher for perfetto to investigate two line issue
bug:375267130
Test manually screenshot:
onIdpChange: https://screenshot.googleplex.com/ASbyGFoAhTXgnWK
statefulActivityOnConfigChange: https://screenshot.googleplex.com/gLqxeJN7TzUURCy
Flag: NONE adding traces to perfetto

Change-Id: Ib2ac49fb8668fdfc91c8e38b91a4afd10127a4c5
2024-10-23 22:59:58 -07:00
Treehugger Robot 388701a031 Merge "Add debugging logs to transition animation" into main 2024-10-24 05:51:18 +00:00
Mykola Podolian 4dc6617988 Merge "Updated bubble bar position to be center aligned with the hotseat" into main 2024-10-24 02:10:43 +00:00
Fengjiang Li db897c4fe9 [PostBoot] Do not destroy post boot loader because of theme change
Bug: 298231234
Test: manual
Flag: NONE - xml flag not supported
Change-Id: I7ee9de3bddaac8578b639f091d6bbbf3ae458fd1
2024-10-24 09:09:44 +08:00
Sihua Ma aa921fa3eb Add debugging logs to transition animation
Test: N/A
Bug: 364465567
Flag: EXEMPT logs only
Change-Id: I8275c43ac44cd4b027fa8ad3d94fe0e84063b8d1
2024-10-24 00:58:58 +00:00
Treehugger Robot 1e4f42ff7f Merge "Account for all apps offset during taskbar layout" into main 2024-10-24 00:10:08 +00:00
Liran Binyamin aa3f772622 Handle taps on bubble bar flyout
Expand the bubble bar when the user taps on the flyout view.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarViewAnimatorTest
Test: atest BubbleBarFlyoutControllerTest
Change-Id: I156acfa663d6a00bc70dd7bbfc35642643902d83
2024-10-23 19:46:14 -04:00
Android Build Coastguard Worker 4fad0dee78 Snap for 12543847 from 25220cdbda to 25Q1-release
Change-Id: I2a3b6cd388216b189755b9923753416a30709026
2024-10-23 23:22:22 +00:00
Holly Sun cf5fbe7816 [clean-up] Clean up Quick Launch V2 and V1.
Bug: 282830271
Test: manual
Flag: EXEMPT old flag enable_quick_launch_v2
Change-Id: Ibcd8938a021b5f558a807e85c44fe6c161aa572a
2024-10-23 16:05:16 -07:00
Treehugger Robot 46a98e1827 Merge "Update taskbar overflow button" into main 2024-10-23 22:49:37 +00:00
fbaron a796d74e36 Refactor grid migration
In this CL:
-Make GridsizeMigrationLogic functions pure (no side effects)
-Make it so GridSizeMigrationLogic contains the migration logic and does NOT interact with the database
-Let GridSizeMigrationUtil receive the results from the logic layer and use those results to interact with the database appropriately

In future CLs:
-Refactor GridSizeMigrationLogic to Kotlin

Bug: 358399271
Flag: com.android.launcher3.grid_migration_refactor
Test: GridSizeMigrationTest
Change-Id: Ifcc5ca356558a7463352580f2e89eef8c86ed16b
2024-10-23 22:26:38 +00:00
mpodolian f230eee2ff Updated bubble bar position to be center aligned with the hotseat
Added a method to the device profile to calculate the vertical center of
the hotseat icons. Simplified the logic for positioning the bubble bar.

Test: TransientBubbleStashControllerTest
Test: PersistentBubbleStashControllerTest
Test: Visual. Go to home page, check that bubble bar is vertically
center aligned with the hotseat
Bug: 345491493
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I52f1b94de79f6c912f43a88fcc5c884e20e56310
2024-10-23 14:44:40 -07:00
Saumya Prakash 9b60028f99 Prevent Search taskbar edu from showing on home screen.
If a user pins the taskbar and immediately swipes to home, this would
show the taskbar edu tooltip on the home screen. This change checks that
taskbar isn't transitioning to home to prevent that scenario.

Fix: 369061563
Test: Reset Search Taskbar edu, pin taskbar, then swipe to home
immediately. Ensure that the edu doesn't show up on home
Flag: EXEMPT bugfix

Change-Id: I9948189df880b3ed318c4952a8f715cf9a7fa708
2024-10-23 21:38:58 +00:00
Treehugger Robot 8e7ab8d282 Merge "Differentiate failed restores from failed grid migrations." into main 2024-10-23 21:03:17 +00:00
Brian Isganitis c0a18d57e8 Actually merge the colors for recent indicators.
Forgot to do a git add :)

Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Bug: 356394053
Test: go/testedequals
Change-Id: I42f85f5850152f498db8a399835b19a5e493c68d
2024-10-23 14:45:49 -04:00
Stefan Andonian 8c0a78727c Differentiate failed restores from failed grid migrations.
Bug: 353505773
Test: Verified logs on my device. Behavior was correct.
Flag: EXEMPT logging
Change-Id: Id0b3dcaae8640c8dd0fac4f8fb42c41dc2eb1385
2024-10-23 11:32:53 -07:00
Treehugger Robot 25220cdbda Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-10-23 17:34:58 +00:00
Treehugger Robot debda9cdd9 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-10-23 17:34:58 +00:00
Toni Barzic a5b6c155b6 Update taskbar overflow button
Creates a new view for the taskbar overflow button that draws up to 4
recent item previews. The items are stacked on top of each other in
counter clockwise order, with overlapping bounds, recent items closer
to the top. The item icons have a 2 dip ring around them, of the taskbar
background color.

Adjusts logic to calculate which items become part of the overflow
button, so more recent items get shown in the taskbar.

Initial consideration was to usse FolderIcon to represent the overflow
button, but decided against it because:
*    FolderIcon is fairly entangled with the associated folder view
*    item information uses different data structure (ItemInfo) than
     recent items (GroupTasks)
*    item preview layout within the main icon is similar, but
     sufficiently different that using clipped folder layout rules felt
     like hacking around assumptions made for folder icon UI

Bug: 368119679
Test: Keep opening apps until the task bar enters overflow - verify that
overview button shows up, and contains least recent task
representations. Keep adding items, then closing windows, and verify
the icon gets updated accordingly. Done in landscape and portrait, and
ltr and rtl layout.
Flag: com.android.launcher3.taskbar_overflow

Change-Id: I2824cb0db1f7516ebd74361ce00fb8887857325d
2024-10-23 17:05:58 +00:00
Brandon Dayauon 8cc4cd1d86 Merge "Call invalidate() during updateView() for updating the header." into main 2024-10-23 15:27:49 +00:00
Wen-Chien Wang 69ed08ef86 Add margins to KQS view that is triggered from taskbar
Bug: 368119679
Test: open KQS via taskbar and observe the bounds change
Flag: com.android.launcher3.taskbar_overflow
Change-Id: I5060a339cf0cdf70a2a11b57a325767405772ef8
2024-10-23 04:03:50 +00:00
Shamali Patwa d6f39e3f45 Merge "Enforce system radius instead of separate value for widgets in launcher" into main 2024-10-23 00:04:50 +00:00
Brandon Dayauon d633368465 Call invalidate() during updateView() for updating the header.
This issue is triggered due to onAppsUpdated() randomly due to app installing/uninstalling/updating/archiving. Eventually
onBind() is called but logs shows evidence that the state is correct (even though it doesn't reflect that), hence invalidating will fix this issue.
We can't call notifyItemChange() in updateView() since updateView() can be part of onBind() in which case means this is part of a scrolling gesture. notifyItemChange()
via adapter index will also not work in reset() since doing so will mess up upon animation.

bug: 373345958
Test: manual/presubmit
Flag: NONE invalidating when updateView() is called
Change-Id: Ibc99cc70562575cadf035136e50e9e5eec1e70ea
2024-10-22 17:02:50 -07:00
Android Build Coastguard Worker 4404a5583d Snap for 12537680 from 8018dcad35 to 25Q1-release
Change-Id: I12bbd2b78444cd566b545e08af09456f331c2a9f
2024-10-22 23:25:14 +00:00
mpodolian f679ba942f Removed stashing hotseat calls.
Removed calls that were stashing and unstashing the hotseat bar.

Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Be on Launcher home, have some bubbles. Expand / collapse
bubble bar. Hotseat remains behind the scream view.
Fixes: 373429249

Change-Id: I1a9ba39c8ca11d49340f217f095d5e872b06105b
2024-10-22 15:25:26 -07:00
Treehugger Robot 08007068d4 Merge "Generalize ActivityTracker to support RecentsWindowManager" into main 2024-10-22 21:26:58 +00:00
Bill Yi 7664e67678 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic6dd940c3672272c721da8d96d7d29b788a2e2e3
2024-10-22 13:46:03 -07:00
Bill Yi 451a5e395f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie3164382c2b9dbf6623f91721a88a2347b9fdde1
2024-10-22 13:45:15 -07:00
Brian Isganitis 8018dcad35 Merge "Update recent indicators to match spec." into main 2024-10-22 19:31:48 +00:00
Schneider Victor-Tulias 8463dc47eb Generalize ActivityTracker to support RecentsWindowManager
Continued quick switch couldn't work using existing infrastructure until RecentsWindowManager could be properly tracked by ActivityTracker. Refactored ActivityTracker into ContextTracker to support this.

Also refactored ActivityInitListener into ContextInitListener to fit the updated pattern.

Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 366023051
Test: RecentsWindowSwipeHandlerTestCase; Attempted continued quick switch from home and launched app
Change-Id: Ic38ebf3611ef22fbfd1ddeb79d72d8a3621940a0
2024-10-22 15:29:59 -04:00
mpodolian eedc7ab8fd Animate the bubble bar Y for task bar pinned/unpinned switches.
Animate the horizontal position of the bubble bar on taskbar pinned /
unpinned switches.

Bug: 345698412
Test: TaskbarPinningControllerTest
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: If330dc9e5f7b16a588973ad6043a5dc6709e13ab
2024-10-22 11:19:17 -07:00
Shamali Patwa 2fc32dc2d8 Enforce system radius instead of separate value for widgets in launcher
The change is behind a flag. This is to get to the stage of having
consistent corner radius across rectangular widgets.

Bug: 373351337
Test: Unit test and manual
Flag: com.android.launcher3.enforce_system_radius_for_app_widgets
Change-Id: I23d8d3bb2561b4fc3f780fc4ddce62e8b9293192
2024-10-22 18:03:07 +00:00
Brandon Dayauon 9c65174760 Set twoline toggle to false when not in english language.
Set toggle preference in deviceProfile as this is the first step after the locale change before any binding/inflation happens.
Otherwise the toggle will be stale if we set this false during "apply"/bind which can cause complexities.

bug:373670311
Test manually vid: https://drive.google.com/file/d/1WXl_fMU8eynwlxdwYBamEnqP1tU_q0kb/view?usp=sharing
Flag: NONE bugfix

Change-Id: Iaf9e88ef76ebda6b62942b7bc3f4e39b4ced5116
2024-10-22 09:57:23 -07:00
Treehugger Robot 08f950245e Merge "Fix swipe up from Desktop Tasks is updated does not show focused task" into main 2024-10-22 16:40:34 +00:00
Anushree Ganjam 266554fe58 Merge "Make RefreshRateTracker to be injected by Dagger (11/n)" into main 2024-10-22 16:27:28 +00:00
Brandon Dayauon 9cd3aae49a Merge "Instead of checking for locale, check language specifically." into main 2024-10-22 15:28:31 +00:00
Jordan Silva a48efb33f2 Fix swipe up from Desktop Tasks is updated does not show focused task
Fixes the condition that defines which task should be the focused task when grid-only is enabled and desktop windowing is the running task.

In some cases, when the user adds or removes a task from Desktop Window, the DesktopTaskView does not get updated with the new list of tasks. This causes a mismatch of tasks that are inside the DesktopTaskView and the actual Desktop Windowing. So, RecentsView can't match the previous DesktopTaskView with the current running tasks, entering a specific condition to update the runningTaskViewId. The method called in this condition (showCurrentTask) also updates the focusedTaskViewId for some situations. This CL fixes the conditions which focusedTaskViewId is set to prevent it to replace the focused task id when it's not needed.

Fix: 370736395
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: Manual
Change-Id: I25f5bd67ee0486f6754673eec404832779fc0498
2024-10-22 15:38:49 +01:00