Commit Graph

83004 Commits

Author SHA1 Message Date
fbaron 22029f6517 Fix grid migration tests with grid migration refactor flag on
Bug: 358399271
Flag: com.android.launcher3.grid_migration_refactor
Test: GridSizeMigrationDBControllerTest, ValidGridMigrationUnitTest
Change-Id: I2dceb5f9756da7ee7e7ef2d5ec29b3550a51e965
2024-10-28 10:46:17 -07:00
Jagrut Desai d7cb00cfb2 Merge "Fix Taskbar Touchable Region when overview is in split select mode" into main 2024-10-28 17:33:36 +00:00
Randy Pfohl 6dab7bac46 Merge "Enabling Fallback launcher cases" into main 2024-10-28 17:28:58 +00:00
randypfohl 9d7141d1fe Enabling Fallback launcher cases
Test: Locally tested and verified flow for fallback.

Flag:  com.android.launcher3.enable_launcher_overview_in_window

Bug: 365777265

Change-Id: I991a82152b47f2cfb7c1335c699e297b8f53bcf3
2024-10-28 17:28:27 +00:00
Sukesh Ram 99c442b015 Revert "Fix Taskbar Y-Translation with Visible Bottom Sheet"
This reverts commit d82503fc42.

Reason for revert: Introduced crashes

Change-Id: I0956f746e25ccfe655169580fd802d33f99c0652
2024-10-28 17:26:47 +00:00
Treehugger Robot 4a3c23a902 Merge changes I83746510,Ie2aa28cd into main
* changes:
  Fix TAPL OverviewTask to use correct resource to measure height
  Add TAPL test for dismiss DesktopTaskView
2024-10-28 17:18:36 +00:00
Charlie Anderson 7df6af5831 Fix flagging for LoaderTask broadcast tests and add more coverage
Flag: EXEMPT just tests
Bug: 375674876
Bug: 375704692
Test: LoaderTaskTest and presubmit
Change-Id: Ied00f9282f48ee88949697e5d684c489013e8aeb
2024-10-28 13:15:27 -04:00
George Lin f052a2ccf7 Shape screen communication with the Launcher's app (2/2)
Support querying / preview / apply for the shapes from the Launcher's
app.

Test: Manually tested that it works
Bug: 348664593
Flag: com.android.systemui.shared.new_customization_picker_ui
Change-Id: I2b2fa570eb71c8975354f154640cc4891f16116b
2024-10-28 15:36:57 +00:00
Alex Chau edd7ff2fa1 Add a feature flag to toggle DW carousel detach
Fix: 376015547
Flag: com.android.launcher3.enable_desktop_windowing_carousel_detach
Test: manual
Change-Id: I98d4fbb17e8e432c94842c38d83735533d5ea197
2024-10-28 14:29:31 +00:00
Liran Binyamin 35e6157303 Allow updating the flyout message
Add functions to allow updating the contents of the flyout while it
is either expanding or fully expanded.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutControllerTest
Change-Id: Iea3fc7df792e02605df6b44c1da39e267f6d9d43
2024-10-28 09:58:37 -04:00
Jordan Silva a244c0b70e Fix TAPL OverviewTask to use correct resource to measure height
The background in DesktopTaskView wasn't added for accessibility, so it couldn't be retrieved from the view hierarchy during e2e tests. This view is necessary to calculate the correct size of the DesktopTaskView.

The changes in this cl:
- Add backgroundView to DesktopTaskView's children for accessibility
- Use the correct snapshot resource for desktop mode in OverviewTask

Bug: 353948500
Change-Id: I83746510849e4013d623d49cbaccebd81daba96d
Flag: EXEMPT bugfix
Test: TaplTestsOverviewDesktop
2024-10-28 12:25:25 +00:00
Jordan Silva 7054095b16 Add TAPL test for dismiss DesktopTaskView
This CL adds 2 new E2E Tapl tests for checking dismiss DesktopTaskView.
- dismissFocusedTask_thenDesktopIsCentered validates the following scenarios:
  - Scenario: When Focused Task is in the center of the screen, with 1 other task in the grid and 1 desktop task.
  - When focused task is dismissed, the next task in the grid takes its place to be the next focused task at the center of the screen.
  - When the last focused task is dismissed, the desktop task takes its place at the center of the screen.

- dismissDesktopTask_thenFocusedTaskIsCentred validates the following scenarios:
  - Scenario: When Desktop Task is in the center of the screen, with 1 focused task and 1 task in the grid.
  - When focused task is dismissed, the next task in the grid takes its place, adjacent to desktop task.
  - When desktop task is dismissed, the focused task takes its place at the center of the screen.

Fix: 353948500
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: TaplTestsOverviewDesktop
Change-Id: Ie2aa28cd2b30a2bf10e877721416399bcf47acf6
2024-10-28 12:25:25 +00:00
Yuichiro Hanada c90fcf26c4 Move the animator for the minimization to WMShell
to share the animator with the minimize button.

Flag: EXEMPT refactoring
Bug: 369349585
Test: manual
Change-Id: I42325913313a85e1086ab6bc4151f60cb3bc4605
2024-10-28 16:53:47 +09:00
Toshiki Kikuchi b00c260669 Handle display windowing mode change in onConfigChanged
This CL allows onConfigChanged to handle the changes of
showLockedTaskbarOnHome().
The return value of showLockedTaskbarOnHome() depends on the display
windowing mode. And onConfigChanged() is triggered when the display
windowing mode changes (e.g. by adb shell wm set-display-windowing
mode).

Bug: 375321881
Flag: com.android.window.flags.enter_desktop_by_default_on_freeform_displays
Test: DisplayControllerTest
Test: manual
Change-Id: I1932f460735b9517cc68170c01cd45ca9bacfeb0
2024-10-28 08:47:26 +09:00
Android Build Coastguard Worker 6c671d527d Snap for 12561555 from 972531f529 to 25Q1-release
Change-Id: Id3207d298169179ff762a4be4257d20165e5bfb5
2024-10-26 21:22:06 +00:00
Vinay Joglekar 972531f529 Merge "Fix flickering of tasks in desktop window when opened as static tile." into main 2024-10-26 12:18:13 +00:00
Treehugger Robot f6c4a7acb1 Merge "[PostBoot] Fix bug where post boot shader has a flicker" into main 2024-10-26 07:17:58 +00:00
Treehugger Robot 7ba66be10c Merge "[PostBoot] Don't destroy loader because of config change, not just because of theme change" into main 2024-10-26 04:52:39 +00:00
Treehugger Robot 423178c71e Merge "Match taskbar edge padding to nav button end insets" into main 2024-10-26 03:19:14 +00:00
Android Build Coastguard Worker 936be85542 Snap for 12559614 from ddf212523f to 25Q1-release
Change-Id: I47f4f3ea239b32aad348d1be97f66185caab2e97
2024-10-26 01:27:32 +00:00
Android Build Coastguard Worker 43ce93230a Merge cherrypicks of ['googleplex-android-review.googlesource.com/29753546'] into 24Q4-release.
Change-Id: I3940c51a0c576d43afd3e731ef5e907c3a8618ab
2024-10-25 23:03:31 +00:00
Charlie Anderson 219371c4ef Prevent archived apps content description from being overridden unexpectedly
Bug: 372035896
Test: manually tested archiving/unarchiving with Talkback
Flag: EXEMPT bugfix
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:91a2aad67f2f5a9b8773d49daaf8c634884867e3)
Merged-In: Ief7f7d176c6ed23a8d7798cf31506e0a9c8921ed
Change-Id: Ief7f7d176c6ed23a8d7798cf31506e0a9c8921ed
2024-10-25 23:02:18 +00:00
Shamali P 656a026488 Fix issue that expanding only search result led to weird scroll
This piece of code was making list scroll for last item, which doesn't
really resolve problem or help for expanding items at end of visible
 list. As such scrolling only to get last time into visible area doesn't
 benefit anything (but creates inconsistency).

Bug: 371508727
Test: With talkback & screenshot tests
Flag: EXEMPT BUGFIX
Change-Id: I7ca519edfbb3a18c10fa518e28183da365f740e4
2024-10-25 23:00:57 +00:00
Shamali P be18ff2b7d Fix issue that items were invisible in 2-pane picker with talkback.
Bug: 371508727
Test: With talkback & screenshot tests
Flag: EXEMPT BUGFIX
Change-Id: Id8419e51bf20a38f203ce2422bae6290babcd63e
2024-10-25 23:00:36 +00:00
Stefan Andonian bb85110a0d Delete Unused Flag related to Altering how the workspace is loaded.
This flagged feature was never released, and instead was thought to be too
complicated compared to the benefits in decreased latency.

Bug: 251502424
Test: Verified that this launcher still loads properly when this flag is removed.
Flag: EXEMPT flag removal
Change-Id: I672708e26cb37d1e2b22c4510f9c3500edd4f959
2024-10-25 22:28:55 +00:00
Stefan Andonian e87ca267b3 Cleaning up unused flag.
This feature was never released, but was meant to speed up the launcher's loading time.
It wasn't released because we ended up simply showing a Loading screen for long launch
times, and the extra complexity of this change was not deemed worth the decreased latency.

Bug: 251502424
Test: Verified that this launcher still loads properly when this flag is removed.
Flag: EXEMPT flag removal
Change-Id: Ice0d8cbdc75ad69e80570d31d45c73f307fbf8b8
2024-10-25 22:28:29 +00:00
Toni Barzic befd6bb1ea Prevent tap in swipe up zone from closing KQS
Tap down action in swipe up start zone may or may not be start of a
navigation gesture - for example, it may be start of a tab on an icon in
the task bar. If the user taps on the taskbar overflow button, closing
the KQS on tap down produces unintended behavior (KQS is closed on tap
down, and reopened on tap up). Additionally, this produces inconsistent
behavior in response to app icon taps depending on whether gesture
navigation is enabled or not.
Instead, close KQS as part of `hideOverlayWindow()`, which gets called
when a swipe gesture actually starts (note that KQS is added to the
overlay's drag layer).
Additionally, make sure that KeyboardQuickSwitchController state is
reset if KeyboardQuickSwitchView gets detached from UI due to the
taskbar overlay getting hidden (e.g. in response to home button).
Without this, in certain situations, KQS may get hidden with the
controller thinking the UI is still shown - in case the user releases
the Alt + Tab key combination in this state, the shortcut would end up
getting handled, and switch to the next task.

Bug: 368119679

Test: Press and hold Alt+Tab (while an app is open). After KQS is open,
Swipe up to transition to overflow, or home screen - KQS gets hidden.
Releasing Alt+Tab is no-op.
Test: Press and hold Alt+Tab (while an app is open) with three button
navigation enabled. Press home button. KQS gets hidden. Releasting
Alt+Tab is no-op.
Test: Press and hold Alt+Tab. After KQS is open, open an app from task
bar (either transient or persistent), or all apps list. KQS gets closed,
Releasing Alt+Tab is no-op.

Flag: EXEMPT bugfix

Change-Id: I8b561db3c6ec8a9c7de93e330faf8e3e4d3c8f4e
2024-10-25 21:43:56 +00:00
Toni Barzic ce6d32199b Mark TaskbarOverlayProxyView closed sooner
Marks TaskbarOverlayProxyView closed earlier in handleClose, before
removing it as a view from the drag layer. BaseDragLayer expects that a
floating view is closed by the time it gets removed, and asynchronously
issues another close call if this is not the case as a workaround.

Marking the proxy view closed sooner also reduces chances of reentrant
close call while handling current close.

Bug: 368119679
Test: Opening/closing all apps, folders, KQS
Flag: com.android.launcher3.taskbar_overflow

Change-Id: I33ccb82ebd7e967f2e47f38db3e41527dad9d573
2024-10-25 21:06:27 +00:00
Toni Barzic 20e420ca40 Match taskbar edge padding to nav button end insets
When calculating max number of items to show in a taskbar with overflow,
reserve space for taskbar end/start margins that matches inline nav
buttons end spacing.

Bug: 368119679
Test: None
Flag: com.android.launcher3.taskbar_overflow
Change-Id: I1205663ed4455ae1e7807f8d4edf5aaf2beba7d4
2024-10-25 20:49:04 +00:00
Mykola Podolian ddf212523f Merge changes Ibdecabd1,If330dc9e into main
* changes:
  Added scale animation for taskbar pinning transition.
  Animate the bubble bar Y for task bar pinned/unpinned switches.
2024-10-25 19:48:55 +00:00
Mykola Podolian f871e64f3c Merge "Set proper interpolators and durations for the bubble bar animations" into main 2024-10-25 19:48:08 +00:00
Mykola Podolian 3889bbc068 Merge "Fixed icons overlapping issue." into main 2024-10-25 19:37:38 +00:00
Anushree Ganjam ba8c0a8fbd Merge "Make ApiWrapper to be injected by dagger (12/n)" into main 2024-10-25 19:27:50 +00:00
Ana Salazar Maldonado b88f5ba0e6 Merge "Add flag for launcher pill" into main 2024-10-25 17:51:32 +00:00
Uwais Ashraf 821bcaade5 Merge changes I65e6ad57,I0335e4d0 into main
* changes:
  Remove listener in destroy() that caused a memory leak.
  Reuse TTV, recreating deps to get faster load times, lower mem usage
2024-10-25 17:11:37 +00:00
Sunny Goyal c5c619b657 Merge "Keeping the custom widget placeholder even when the plugin is not corrected" into main 2024-10-25 16:47:38 +00:00
Uwais Ashraf b80f90bc0d Remove listener in destroy() that caused a memory leak.
Fix: 370916189
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manually looking at heap dumps. Verify leaked obj no longer there
Change-Id: I65e6ad57d1ac6873946d836d8221b67deef548b1
2024-10-25 15:18:23 +00:00
Uwais Ashraf 6f61228a6b Reuse TTV, recreating deps to get faster load times, lower mem usage
Use a ViewPool for DesktopTaskView for same reason.

Fix: 369590189
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manually looking at slow-mo videos of home to overview
Change-Id: I0335e4d0eea4841145815244bbbec19541f31c73
2024-10-25 15:18:08 +00:00
Cosmin Băieș 879cbb1ff4 Cleanup ENABLE_HIDE_IME_CAPTION_BAR flag
This flag has already been enabled for a while, and is included in
releases, so we can clean it up now.

Flag: EXEMPT cleanup
Bug: 375571655
Test: atest InputMethodServiceTest#testRequestHideImeCaptionBar
  InputMethodServiceTest#testRequestHideThenShowImeCaptionBar
  InsetsSourceTest#testCalculateInsets_imeCaptionBar
  InsetsSourceTest#testCalculateInsets_imeCaptionBar
  InsetsSourceTest#testCalculateBoundingRects_imeCaptionBar
  InsetsSourceTesttestCalculateBoundingRects_imeCaptionBarFrameMisaligned_rectsFixedToBottom
Change-Id: I809c69156c06ff5c06ca43ef4dd248f90d54f6d8
2024-10-25 12:07:46 +02:00
vinayjoglekar d5d51e51d7 Fix flickering of tasks in desktop window when opened as static tile.
This for loop was added to fix animation glitch if there is scenario of showing splash screen(on config change). Live tiles don't have this issue because we don't create RemoteTargetHandles.

Fix is to set Z-Index as per correct order since current value is same for all tasks.

Test: Manual, Add multiple apps to desktop task, Make it static tile and launch.
Fix: 370731110
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: I9e3f1fd1333b6113423f51309917317febc1805b
2024-10-25 10:30:38 +01:00
Fengjiang Li dd7d854c3a [PostBoot] Fix bug where post boot shader has a flicker
Pass correct default value -1 when getting RUNTIME_STATE_PENDING_REQUEST_CODE when it is not set.

This will avoid accidentally starting ProxyActivityStarter from Launcher#onCreate(), which will cause a flicker for post boot animation

Fix: 375308654
Flag: NONE - xml flag not supported
Test: manual
Change-Id: Ic3888508657b5b7aab37f6022768d53007bf9c00
2024-10-25 03:59:47 +00:00
Toni Barzic 143edac127 Tapping overflow button toggles KQS
Updates the taskbar overflow button handler to toggle the KQS instead of
merely showing it. The toggle action will open KQS view if it's not
visible, or close it if it's visible and has been shown from the
taskbar. If the view is shown, but in response to Alt+Tab, the view will
be closed, and reshown above the task bar.

Requires CL:30016166 for tapping to work as expected, and CL:30074037
for tapping overflow button reopen KQS over shelf if KQS is already
active for Alt+Tab

Bug: 368119679
Test: Enter task bar overflow. Tap overflow button to show KQS, tap
overlow button to hide KQS. Press Alt+Tab, tap overflow button to
reshow KQS over taskbar, and with filtered set of tasks.
Flag: com.android.launcher3.taskbar_overflow

Change-Id: Id598f9cad649aa174aaf1c5802bf6b6837413d1e
2024-10-25 03:28:17 +00:00
Treehugger Robot 38c94afefc Merge "Actually merge the colors for recent indicators." into main 2024-10-24 23:26:18 +00:00
Android Build Coastguard Worker 6c35f0a79e Snap for 12551711 from c7b078d7a2 to 25Q1-release
Change-Id: Ifdce8ce29ec71791d856fa6cc09b20e1a757c986
2024-10-24 23:22:42 +00:00
Jagrut Desai 9aa005b657 Fix Taskbar Touchable Region when overview is in split select mode
The problem: when Overview is in split slect mode second split app pick from taskbar take you back home. Why, because upon touch the taskbar touch region get
 set to empty and then we later don't meet any conditions to set default touch region to something.

The solution: change the condition of checking overview in onTaskbarOrBubblebarWindowHeightOrInsetsChanged so that we check that taskbar is in any overview s
tate and we don't rely on the stash controller flag alone. we follow similar logic in updateInsetsTouchability, but we gate that only behind transient taskba
r hence this was not an issue for transient taskbar.

Test: Manual
Bug: 373559050
Flag: EXEMPT bugfix
Change-Id: Ia507354f42959ce9d320114a313bfc533186b524
2024-10-24 15:31:02 -07:00
Fengjiang Li edb2741c97 [PostBoot] Don't destroy loader because of config change, not just because of theme change
Follow up of ag/30026330

Bug: 298231234
Test: manual
Flag: NONE - xml flag not supported
Change-Id: I28caebbcb9f22c671dd64cfe56763a1f8b4c3f5a
2024-10-25 06:08:16 +08:00
Holly Sun 818608a2d2 Catch exception to prevent Launcher crash.
It happens on the line to get content description, which finally goes to `UserManager#getProfileType` (https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:frameworks/base/core/java/android/os/UserManager.java;l=3390;drc=6fa95973e4c654ccd2b9c17b5e23ecf094875c5a). Catch the SecurityException to prevent Launcher crash.

Bug: 355793052
Test: manual
Flag: EXEMPT bug fix
Change-Id: I5ff83a50506e851362f190b5ab4c72ad7681f060
2024-10-24 14:47:04 -07:00
Ana Salazar Maldonado f607018261 Add flag for launcher pill
Bug: 341217082
Flag: EXEMPT adding flag
Test: EXEMPT adding flag
Change-Id: I00f7c943817b8bc72a148f2fb2340cd47c4237b9
2024-10-24 21:39:02 +00:00
mpodolian 92d25cd21d Added scale animation for taskbar pinning transition.
Animate the bubble bar icons size and padding for taskbar change mode
animation.

Bug: 345698412
Test: TaskbarPinningControllerTest
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Ibdecabd1310203dc956f69673dc446a0e7e556a6
2024-10-24 13:45:11 -07:00
Mykola Podolian f85a484a9d Merge "Removed stashing hotseat calls." into main 2024-10-24 20:36:06 +00:00