Commit Graph

83004 Commits

Author SHA1 Message Date
Federico Baron 8d9d81e4b2 Sort grid options in onegrid
We need to make sure that the new grid options are sorted by column
count from greatest to least

Bug: 395086953
Flag: com.android.launcher3.one_grid_specs
Test: manually verified
Change-Id: I94fbf0fe74fa7dfc92afc64be92cdf511b79e763
2025-02-07 20:13:41 +00:00
Treehugger Robot 126566a096 Merge "desktop-exploded-view: Implement layout algorithm" into main 2025-02-07 12:00:23 -08:00
Treehugger Robot 795b36785e Merge "Initial Desks tracking on Launcher" into main 2025-02-07 11:53:55 -08:00
Brandon Dayauon b995cbe857 Fix shadow clipping in work FAB.
The reason is because the parent container having set clipped children
to true. It is already turned off for the fast letter scroll prototype
so we can probably just set to false all together.

Bug: 383299303
Test: manually-
before: https://drive.google.com/file/d/1GfJtmdX6RPi0QWlpjd1uBNGcDm_ePJko/view?usp=sharing
after: https://drive.google.com/file/d/1Lf6boBSeZ1ZcJ9M24S_JP6jzdUfov8kh/view?usp=sharing
Flag: com.android.launcher3.work_scheduler_in_work_profile
Change-Id: I5060081f51a11dd34fd55afb75a5302759e16670
2025-02-07 19:24:59 +00:00
Daniel Norman da4d1d9f00 Merge "aconfig must have the same container with the declaration" into main 2025-02-07 11:10:45 -08:00
Charlie Anderson 4f23162f77 Reorder shape options, making sure that the default Circle is first.
Bug: 394885877
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: manually verifying options
Change-Id: I85e9b56f6ede3b5a367e6833fa51ce5962f42883
2025-02-07 18:57:31 +00:00
minch b39d3015f8 Make AddDesktopButton can be navigated to through keys
Add the focus outline to the button as well.
Same color, ripple effect as the ClearAllButton is applied.

Flag: com.android.window.flags.enable_multiple_desktops_frontend
      com.android.window.flags.enable_multiple_desktops_backend
Bug:391875235
Test: TaskGridNavHelperTest
Change-Id: If93f86a1dce4df8ee6b1c50dfc44092dad2eafab
2025-02-07 18:33:23 +00:00
Xiaoqian Dai 3491fa49a7 desktop-exploded-view: Implement layout algorithm
It was ported over from ChromeOS Overview layout algorithm. In overview,
the layout is done in two stages:
1. Optimal height is determined. In this stage height is bisected to
   find maximum height which still allows all the windows to fit.
2. Row widths are balanced. In this stage the available width is reduced
   until some windows are no longer fitting or until the difference
   between the narrowest and the widest rows starts growing. Overall
   this achieves the goals of maximum size for previews (or maximum
   row height which is equivalent assuming fixed height), balanced rows
   and minimal wasted space.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: b:367353392, b:353948965

Change-Id: I1d0fd2b30ffa5bbc0853650884cf85b519be4227
2025-02-07 10:06:05 -08:00
Ahmed Fakhry c0597ac53b Initial Desks tracking on Launcher
This CL adds the initial implementation of the desks tracking
on the launcher side inside `DesktopVisibilityController`.

Bug: 392986431
Test: m
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: I7ece2407a03fec1cad4663efa230ec9a1980fb75
2025-02-07 17:49:36 +00:00
Treehugger Robot cdc1483f59 Merge "Append application name to content description for direct share targets" into main 2025-02-07 09:28:51 -08:00
Alex Chau 90fb4f883e Merge "Fix Home->Overview grid task not in top-right" into main 2025-02-07 09:28:31 -08:00
Vinit Nayak 7f6f7aad7b Re-use existing method to get split root
Test: Launching app pair from desktop, in-app,
overview from taskbar launches as expected
Bug: 372837890
Flag: EXEMPT bugfix

Change-Id: I50ab3cb1dc95a2cf20b77ae5d00cad3be7cd8e5c
2025-02-07 12:23:50 -05:00
Treehugger Robot bc37b2c46d Merge "desktop-exploded-view: Add some comments" into main 2025-02-07 09:00:07 -08:00
Mykola Podolian 7fa6b816e9 Merge "Added application shortcut extra to allow the Shell adding bubble." into main 2025-02-07 08:17:23 -08:00
Gustav Sennton dad84b4121 Merge "Only set task surface corner radius once in TransformParams" into main 2025-02-07 07:42:06 -08:00
Alex Chau ee082ce6e8 Fix Home->Overview grid task not in top-right
- Use expectedCurrentTaskView's position to calculate if we should add extra gap between clear all button, instead of using the right most task's position; this fixed the case where current task is not the right most task e.g. grid task and desktop task
- The accumulated row width to expectedCurrentTaskView is tracked in the udpateGridProperties loop, and used to calculate the position of the expected position of expectedCurrentTaskView from ClearAllButton
- With this new calculation we no longer needs to adjust longRowWidth when there are onlg large tile tasks

Fix: 391306182
Test: With and without grid-only Overview, test both home and app to Overview with 0-5 tasks with a desktop task; repeat for RTL
Flag: EXEMPT BUG_FIX
Change-Id: I324208c7e063c8b043815291cc0fef7beec884b6
2025-02-07 07:30:08 -08:00
samcackett d4d4d580da Append application name to content description for direct share targets
The direct share targets `label` will be the name of the receiving
device, so we also need to append the application name for a better
readout

Fix: 380008872
Test: MANUAL. Talkback on. Open an app with a url or image. Open Recents
. Select the url or image AiAi chip. Select the first direct share
target. Talkback should read the targets name and application name.
Share. App should dismiss.
Flag: EXEMPT bugfix

Change-Id: I3d7df44d239ae9b8a3a62b7343e65bcd6a2e9939
2025-02-07 15:25:59 +00:00
Charlie Anderson b97431394e Merge "Adjust predicted app icon to draw better inner stroke for shapes:" into main 2025-02-07 05:39:51 -08:00
Federico Baron 54b09dc41f Fix issue where turning off fixed landscape goes to default grid
Bug: 390091751
Test: manually verified on device
Flag: com.android.launcher3.one_grid_specs
Change-Id: Id9de8cadc6fc1ee0ac0124638b2c487b8f8357bb
2025-02-07 09:22:42 +00:00
Gustav Sennton cbb7ecddfe Only set task surface corner radius once in TransformParams
When setting the corner radius constantly in TransformParams sometimes
we set the radius after the end of the recents transition, causing
Desktop tasks to have non-rounded corners at the end of recents
transitions.

Bug: 378657004
Test: manual + TransformParamsTest
Flag: com.android.window.flags.enable_desktop_recents_transitions_corners_bugfix
Change-Id: I2ae919424602d655d0995b4dc1951d96c7dfd3d8
2025-02-07 07:16:33 +00:00
Justin Yun 8b6d59f97b aconfig must have the same container with the declaration
com_android_launcher3_flags is in the system_ext container. Flags in
this declaration must have the same system_ext container.

Bug: 385213580
Test: "adb shell aflags list" must not be changed.
Flag: EXEMPT refactor
Change-Id: I9a674fc91ab2114741480a118349102455aa6020
2025-02-06 20:23:49 -08:00
Treehugger Robot 026930cd14 Merge "Use pinned taskbar with desktop tasks on freeform displays" into main 2025-02-06 19:37:47 -08:00
Brandon Dayauon b30bb197d1 Fix focusability of web suggest via talkback
The reasson is due to shortcut flow not having sent an accessibility
event. Shortcuts adding to home can use the same flow of how apps are
added to home by using bindInflatedItems() with an animation
endCallback(). This change should be fine since addInScreen() is called
in bindInflatedItems() too.

Bug:383461209
Test:Manually video- https://drive.google.com/file/d/1y3CslaIvRQMsODlQCYnGtG0Im4t7p4rR/view?usp=sharing
Flag: EXEMPT bug fix

Change-Id: I3b88b5ee40b4bcd43a83d362b6cbb0925120b700
2025-02-07 02:34:16 +00:00
Saumya Prakash 44daae3c06 Merge "Remove back button and enable back gesture on SUW" into main 2025-02-06 18:06:47 -08:00
Charlie Anderson c150eeb2e1 Adjust predicted app icon to draw better inner stroke for shapes:
Bug: 377938036
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: manually verifying

Change-Id: Ib2c80f0db08bdd24fc6338bed3d666348d09037f
2025-02-06 16:26:50 -08:00
Charlie Anderson 2ffea06040 Merge "Resizes shaped icons based on selected shape" into main 2025-02-06 16:26:37 -08:00
Daniel Andersson 31191f8cee desktop-exploded-view: Add some comments
This adds some comments in DesktopTaskViewModel. There are no semantic changes.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: N/A
Bug: 367353392
Change-Id: I484bf4d0f094c5b87716022ffcd3db85d8b85ef7
2025-02-06 16:14:50 -08:00
Daniel Andersson 4899bc2c80 Merge "desktop-exploded-view: Initial implementation" into main 2025-02-06 14:51:31 -08:00
Saumya Prakash f6496357e2 Remove back button and enable back gesture on SUW
According to new spec, for devices that have a different theme, Setup Wizard
should no longer have the back button, and instead should use the back
gesture in between screens.

Fix: 349495243
Flag: EXEMPT bugfix
Test: Set the System property for setup wizard device theme to be expressive. Rerun setup wizard and ensure the back button doesn't show up and the back gesture works. For the existing theme, the behavior should remain unchanged.

Change-Id: I6b8e95f4eeecdf7422c9f1c099b30a4fc2d2fd12
2025-02-06 22:17:46 +00:00
Hongwei Wang 4d883c5b78 Update the comment on detach
With ag/31545168, it's no longer caller's responsibility to recycle the
bitmap being for overlay. Comment is updated accordling.

Flag: EXEMPT comment
Bug: 393584443
Test: N/A comment only
Change-Id: Idc9b01dc71cf4b15773a03272baa97f9821710f7
2025-02-06 14:01:58 -08:00
Charlie Anderson c902340594 Resizes shaped icons based on selected shape
Bug: 372905360

Test: Manual verify specs
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: Ia73fde0f493235004ed577738696c8be98a290f7
2025-02-06 12:32:47 -08:00
Fengjiang Li c324094762 Merge "[Memory Leak] Fix leak of TouchInteractionService from DisplayInfoChangeListener" into main 2025-02-06 09:49:27 -08:00
Winson Chung acca04d897 Merge "Move multi-instance suppport checking to ApiWrapper" into main 2025-02-06 08:17:55 -08:00
Treehugger Robot d026b7be7e Merge "Fixing ProxyPrefs not removing values correctly" into main 2025-02-05 20:49:02 -08:00
Sunny Goyal c9d9e335a4 Fixing ProxyPrefs not removing values correctly
Bug: 394600803
Flag: EXEMPT bugfix
Test: atest ProxyPrefsTest
Change-Id: Icb116df1826e9538c929a08f4e8afc32d1b1f183
2025-02-05 18:49:54 -08:00
Fengjiang Li c5e7b955af [Memory Leak] Fix leak of TouchInteractionService from DisplayInfoChangeListener
Fix: 394672098
Flag: NONE - released code
Test: manual
Change-Id: I99bfd783e8be34066e29072f5c1a6719802bde05
2025-02-05 18:26:50 -08:00
Treehugger Robot de35987f27 Merge "Stub impl new multi-desks IDesktopTaskListener APIs" into main 2025-02-05 17:18:46 -08:00
Daniel Andersson 66288ed6fa desktop-exploded-view: Initial implementation
This is an initial implementation of the desktop exploded view. The
layout algorithm (implemented in OrganizeDesktopTasksUseCase) is
currently a basic placeholder.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 367353392

Change-Id: I6826a2583a3e0027c809d4fd3b9bab716f2f3b72
2025-02-05 15:56:27 -08:00
Adnan Begovic 2eb151771c launcher3: Gate strict mode enablement behind flag.
Bug: 394651876
Flag: com.android.launcher3.enable_strict_mode
Test: Manual
Change-Id: I973dacbfac1fbcd889c503623df948c8fde379dd
2025-02-05 15:32:40 -08:00
Treehugger Robot 734411999e Merge "Merge "Update All Apps / Smartspace / Circle to Search team owners" into main am: d61628084b am: 35d68b1726" into main 2025-02-05 15:27:42 -08:00
Treehugger Robot 8e5b44ad9c Merge "Introduce non-null itemInfo inside TaskView" into main 2025-02-05 15:09:39 -08:00
mpodolian 93c22f9e34 Added application shortcut extra to allow the Shell adding bubble.
Included an application shortcut extra in the arguments for system
drag and drop initiated from the taskbar. With this intent, the
Shell process can add an application shortcut bubble.

Bug: 388894910
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual. Have a shortcut and app icons in the taskbar.
Drag and drop both items over the bubble drop zone.
Observe that items are added to the bubble bar.
video: http://recall/-/gx8ASgewUeUS3QYohfrd1J/fnHDKrNWzJEzRw6rgIm0fG

Change-Id: I232da417facb22919a2bebd23e712c1d877c218e
2025-02-05 14:41:14 -08:00
Saumya Prakash 4e084c19f1 Merge "Add aconfig feature flag for expressive theme in Gesture nav and Taskbar" into main 2025-02-05 14:22:05 -08:00
Andy Wickham 47eb0d2081 Merge "Update All Apps / Smartspace / Circle to Search team owners" into main am: d61628084b am: 35d68b1726
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3473344

Flag: EXEMPT owners file change
Change-Id: I1b4ced62280aaad84376d048f81407fc8008dbfe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-05 13:48:58 -08:00
Sebastian Franco 2164771130 Fix null ptr exception on createUpdateRunnable lambda
Fix: 394043832
Test: NA
Flag: EXEMPT bugfix
Change-Id: I60b85c520e7553318ea741da8768951c974dcc7e
2025-02-05 13:38:31 -08:00
Treehugger Robot 19d46bede8 Merge "[CD Taskbar] New NavigationBarPanelContext per instance of taskbar" into main 2025-02-05 12:47:18 -08:00
Charlie Anderson 8107a6ea07 Merge "Remove spammy log in LoaderTask" into main 2025-02-05 12:44:21 -08:00
Andy Wickham 35d68b1726 Merge "Update All Apps / Smartspace / Circle to Search team owners" into main am: d61628084b
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3473344

Change-Id: I04205e4d7d2c925c0af33ed710361747171cbbd6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-05 11:56:37 -08:00
Charlie Anderson 53dcfdf963 Merge "Fix folder morphing animation" into main 2025-02-05 11:42:59 -08:00
Saumya Prakash d50f5cb431 Add aconfig feature flag for expressive theme in Gesture nav and Taskbar
Test: Presubmit
Fix: 394613212
Flag: com.android.launcher3.expressive_theme_in_taskbar_and_navigation
Change-Id: I73ad79719d255953e75445209fa92c587356a47b
2025-02-05 11:29:27 -08:00