Commit Graph

83004 Commits

Author SHA1 Message Date
Cole Faust ad78da873d Replace .toList() with .collect()
.toList() was only introduced to android in api level 34, which is newer than
this module's min_sdk_version. Replace it with .collect().

This was found while updating android lint.

Flag: EXEMPT refactor
Bug: 394096385
Test: Presubmits
Change-Id: I71fd1435b7645ea4f1f653c05fef1ddc47adbc14
Merged-In: Id8d1de1531b67a7daf448e45592b7ef78f685fc2
2025-02-03 14:19:57 -08:00
Cole Faust 1b9fd985d4 Replace .toList() with .collect()
.toList() was only introduced to android in api level 34, which is newer than
this module's min_sdk_version. Replace it with .collect().

This was found while updating android lint.

Flag: EXEMPT refactor
Bug: 394096385
Test: Presubmits
Change-Id: Id8d1de1531b67a7daf448e45592b7ef78f685fc2
2025-02-03 14:19:12 -08:00
Matthew Mourgos 6c19792dcd Merge "Stop mouse click+drag from opening all apps" into main 2025-02-03 13:29:58 -08:00
Pat Manning c824545d07 Refactor TaskViewTouchController to separately handle dismiss and launch.
Remove use of PendingAnimation for task dismiss.

Fix: 389080698
Test: Manual.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: Ifdfd7d8ef78bba5d10ff6f157635430637805584
2025-02-03 19:46:52 +00:00
Shamali Patwa a398bf4dc4 Merge "Support exclusion widget category filter in the widget picker" into main 2025-02-03 11:28:41 -08:00
Jeremy Sim 933c73ea0b Merge "Fix bug with app pair 10:90 launch" into main 2025-02-03 11:06:36 -08:00
Shamali Patwa 2b6f14b621 Merge "Fix issue that talkback announces click label on pin sheet" into main 2025-02-03 10:29:09 -08:00
Treehugger Robot 0931a36562 Merge "Log TaskThumbnailView state changes with task ID and view hashcode" into main 2025-02-03 09:32:23 -08:00
Treehugger Robot 4e376db890 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-02-03 09:26:40 -08:00
Treehugger Robot 661312bba9 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-02-03 09:26:40 -08:00
Shamali P 29715c0a00 Fix issue that talkback announces click label on pin sheet
Pin sheet doesn't support tap-to-add, so doesn't need tap announcement.

Bug: 390562493
Fix: 390562493
Test: With talkback
Flag: EXEMPT bugfix
Change-Id: Iad71248f288e73f4dfbc9077ce8a2454bb5e3e56
2025-02-03 07:00:36 -08:00
Shamali P 2e1b51c54b Support exclusion widget category filter in the widget picker
The newly added NOT_KEYGUARD category enables hosts that shows all
widgets to let widgets opt out from being displayed in keyguard like
surfaces.

Bug: 394047125
Test: Unit tests and support app
Flag: EXEMPT bugfix

Change-Id: Ibaab0c8a052700b77289cd571bca33e3d96fa09f
2025-02-03 14:33:20 +00:00
Jordan Silva d4ae2b1b8f Log TaskThumbnailView state changes with task ID and view hashcode
Fix: 392417881
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual.
Change-Id: I17c63afb106e66d87882618580eebd5105d1cb4d
2025-02-03 13:38:37 +00:00
Ajinkya Chalke 772b851fb6 Add Aconfig flag for Alt + Tab KQS view on CD
Change-Id: Icdeebf551828975630adce05bcb1ee3f5956bf98
Flag: EXEMPT adding flag
Test: EXEMPT adding flag
Bug: 394007677
2025-02-03 03:15:38 -08:00
Alex Chau 11c035cb2f Merge "Consider tasks with INVALID_DISPLAY as it's on DEFAULT_DISPLAY" into main 2025-02-03 02:06:51 -08:00
Alex Chau 5ab6c2e68a Consider tasks with INVALID_DISPLAY as it's on DEFAULT_DISPLAY
- In the test environment, some main display tasks can have INVALID_DISPLAY (-1) as their displayId, we should consider them as main display tasks or else they'll be sorted to an unexpected section in RecentsView

Bug: 391311008
Test: TaplTestsQuickstep#testQuickSwitchFromHome
Flag: com.android.launcher3.enable_separate_external_display_tasks
Change-Id: I5a89d91e342557e114eae6796e153a160d729301
2025-02-01 10:01:44 +00:00
Treehugger Robot 85b6ba2821 Merge "Don't close Folder from system nav region while editing name" into main 2025-01-31 22:46:53 -08:00
Treehugger Robot 0012e24fbc Merge "Use launcher db icon column to load pre-archived app icons on restore, similar to Promise Icons." into main 2025-01-31 19:10:15 -08:00
Treehugger Robot 5c11f67ca3 Merge "[CD Taskbar] Refactor TaskbarManager - Make Window Contexts also follow map pattern" into main 2025-01-31 18:02:23 -08:00
Charlie Anderson 0905744966 Use launcher db icon column to load pre-archived app icons on restore, similar to Promise Icons.
- includes loading icons for AllApps as archived apps show there as well

Bug: 391913214
Flag: com.android.launcher3.restore_archived_app_icons_from_db
Test: LoaderTaskTest, LoaderCursorTest and manually doing backup + restore
Change-Id: Icc9dc292551d4a3c6ac23de89aea4cb14856744c
2025-02-01 01:11:04 +00:00
Jeremy Sim bc6df4af71 Fix bug with app pair 10:90 launch
Small fix for supporting the 10:90 split ratio. Previously, we detected the leftTop app by checking for left == 0 or top == 0; this led to a crash on app pair launch for 10:90 because, for example, the left pair's left bound was negative. Now we check for left <= 0 or top <= 0 instead.

Bug: 391866990
Flag: com.android.wm.shell.enable_flexible_two_app_split
Test: Visually correct when a 90:10 pair goes to recents and back
Change-Id: Ie22c12ea547b6d2dfeea4570ec32a79040cc45c2
2025-01-31 16:37:36 -08:00
Tony Wickham e6cb984fdf Don't close Folder from system nav region while editing name
Fixes: 359127164
Test: Manual, add language, change it from IME switcher while
editing folder name
Flag: EXEMPT bug fix

Change-Id: I275bf8ee43d591d1adce98cef99e59c9ffa2baf1
2025-02-01 00:30:45 +00:00
Treehugger Robot d038e1945c Merge "Add grid icon for wallpaper picker" into main 2025-01-31 14:33:03 -08:00
Sukesh Ram 2f74082b3b [CD Taskbar] Refactor TaskbarManager - Make Window Contexts also follow map pattern
Make Window Contexts also follow map pattern.

Flag: EXEMPT not adding new behavior
Bug: 391706879
Test: Manual
Change-Id: Ib0672e653b9dbfcb3597210ca244f110515cd4dc
2025-01-31 21:53:46 +00:00
Matthew Mourgos cdc67c5768 Merge "Stop mouse long press from opening workspace menu" into main 2025-01-31 12:55:09 -08:00
Treehugger Robot 634c3a0f8f Merge changes I8af39b58,I9a3e8ee2 into main
* changes:
  Finally remove `task1` and `task2` from `GroupTask`
  Remove `GroupTask.mSplitBounds`
2025-01-31 11:51:02 -08:00
Treehugger Robot 340720e8a7 Merge "Remove all external usages of GroupTask.task1/2 from Launcher3" into main 2025-01-31 11:42:55 -08:00
fbaron 9ed02b841b Add grid icon for wallpaper picker
Bug: 384938435
Test: n/a
Flag: com.android.launcher3.one_grid_specs
Change-Id: I3480244d63cd8b4796ff656245a862094a1b5854
2025-01-31 19:26:02 +00:00
Treehugger Robot b8fc998679 Merge "If onegrid is on we don't check if destination db is new or not" into main 2025-01-31 09:53:40 -08:00
Ahmed Fakhry 129a3a0097 Finally remove task1 and task2 from GroupTask
See go/refactor-group-task for details. This is the final CL
in this refactor, where `task1` and `task2` are finally removed,
and `DesktopTask` is allowed to have empty tasks.

Bug: 388593902
Test: m
Flag: EXEMPT pure refactor with no behavior change.
Change-Id: I8af39b58138f11030981311efc2e95a77cef125b
2025-01-31 17:14:46 +00:00
Ahmed Fakhry c590a62c80 Remove GroupTask.mSplitBounds
See go/refactor-group-task for details. This CL removes `mSplitBounds`
from `GroupTask` and adds `splitBounds` to `SplitTask`. This makes its
usages more intentional.

Bug: 388593902
Test: m
Flag: EXEMPT pure refactor with no behavior change.
Change-Id: I9a3e8ee2e96d46f9eb79a58ffcf5efc257615aac
2025-01-31 17:14:46 +00:00
Ahmed Fakhry b6ecf5889e Remove all external usages of GroupTask.task1/2 from Launcher3
See go/refactor-group-task for details. This CL removes all the usages
of `task1` and `task2` from `GroupTask` in Launcher3. Follow-up CLs will
remove it from NexusLauncher and remove the fields altogether.

Bug: 388593902
Test: m
Flag: EXEMPT pure refactor with no behavior change.
Change-Id: I902c8135b3a0aae95acf25267b3bcbf286bd4e7d
2025-01-31 17:14:44 +00:00
samcackett 5df5144b45 Add task menu shortcut for closing apps
Fix: 383977717
Test: OverviewMenuImageTest
Flag: EXEMPT bugfix

Change-Id: I24338a821e1ec9be21d22a5d1c4295dd6e28d13d
2025-01-31 08:37:18 -08:00
Harry Cutts 496b908033 Fix button state consistency issues in TAPL event streams
Change I59b886bfb632f0f26ee58c40f82f447f5ea59b41 caused a number of
launcher and WM tests to fail because the TAPL code was producing motion
events with invalid button states, or just not sending BUTTON_PRESS and
BUTTON_RELEASE events at all. While this change does not address all
possible uses of LauncherInstrumentation#sendPointer (for example,
sending a MOVE during which a button should be held down), it fixes
consistency issues in all cases currently used by tests. A more
comprehensive fix is not worthwhile since this kind of input event
injection is deprecated and should be replaced with usage of uinput or
virtual devices anyway.

Test: $ atest \
      NexusLauncherOutOfProcTests:com.android.launcher3.appiconmenu.TaplAppIconMenuTest \
      NexusLauncherOutOfProcTests:com.android.launcher3.dragging.TaplDragTest \
      NexusLauncherOutOfProcTests:com.android.launcher3.dragging.TaplUninstallRemoveTest \
      NexusLauncherTests:com.android.quickstep.TaplTestsTransientTaskbar \
      'NexusLauncherTests:com.android.quickstep.TaplTestsTaskbar#testOpenMenuViaRightClick' \
      'WMShellFlickerServicePlatinumTests:com.android.wm.shell.EnterSplitScreenByDragFromShortcutGesturalNavLandscape#enterSplitScreenByDragFromShortcut'
Bug: 372571823
Bug: 392150793
Flag: TEST_ONLY
Change-Id: I5c259c13d433d3010d2cf9c6fe01e08ba5990ef7
2025-01-31 14:14:54 +00:00
Treehugger Robot 815b265cf7 Merge "Move enable_taskbar_connected_displays to lse_desktop_experiences" into main 2025-01-30 22:17:28 -08:00
Treehugger Robot dfa11eb35e Merge "Not calling updateCallback in constructor as it can cause initialization error" into main 2025-01-30 20:36:38 -08:00
Charlie Anderson 6009fa94b6 Merge "Add folder shapes for corresponding icon shapes" into main 2025-01-30 19:29:51 -08:00
Treehugger Robot 94eadd7529 Merge changes from topic "tc-refactor" into main
* changes:
  Introduce leftTop and rightBottom TaskContainer to GroupedTaskView
  Refactor TaskView to allow no TaskContainers
2025-01-30 19:22:41 -08:00
Matthew Mourgos 351ae6cd62 Stop mouse click+drag from opening all apps
This change is intended for the desktop use case.

Bug: 388898277
Test: Manual
Flag: com.android.launcher3.enable_mouse_interaction_changes
Change-Id: Ibbca58f1e98a6648be68fc7e3b6337f5c78160da
2025-01-30 19:16:43 -08:00
Sukesh Ram 65042fde52 Move enable_taskbar_connected_displays to lse_desktop_experiences
Removing launcher flag for taskbar in secondary display and adding it to lse_desktop_experiences.

Test: m
Bug: 393398093
Bug: 383634014
Flag: com.android.window.flags.enable_taskbar_connected_displays
Change-Id: Ia73f31346eb1b3bd273ecb7801eb1264d92e6863
2025-01-31 00:11:02 +00:00
Federico Baron 7938a50b28 If onegrid is on we don't check if destination db is new or not
We just migrate them using the special case where everything shifts up
if we meet the criteria

Bug: 392978014
Test: GridSizeMigrationTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: I4efda781d6fbe6f3e1854b22685abd1b923c3dc4
2025-01-30 15:51:54 -08:00
Treehugger Robot 821572007d Merge "Revert^2 "Unifying various model update callbacks into one"" into main 2025-01-30 15:45:47 -08:00
Bill Yi 90bf368a19 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I395ce6f61ecb9e74bd8da7a6104fccb85de951d6
2025-01-30 15:24:30 -08:00
Bill Yi a11ddc12d1 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I0e74c003b45f48b1aada8bd1357820ab0e284ef5
2025-01-30 15:23:40 -08:00
Matthew Mourgos 5adb3b4b09 Stop mouse long press from opening workspace menu
This feature is intended for the desktop use case.

Bug: 388898277
Test: Manual
Flag: com.android.launcher3.enable_mouse_interaction_changes
Change-Id: Ifc2da01b248c7dbdbe272f4fa124b6d1182c599d
2025-01-30 14:55:10 -08:00
Sunny Goyal 430fd3104f Not calling updateCallback in constructor as it can cause initialization error
Bug: 390930809
Flag: EXEMPT bugfix
Test: atest ActiveTrackpadListTest
Change-Id: Ifb14e2949f1f399fbb8b63f493f96d0dd54cc081
2025-01-30 13:25:04 -08:00
Sunny Goyal dfbbebc9e3 Revert^2 "Unifying various model update callbacks into one"
72f9943f64

Change-Id: I38901714947a2b7926723ea25df4a2b8216303e4
2025-01-30 13:19:32 -08:00
Priyanka Advani (xWF) da2e19a821 Merge "Revert "Unifying various model update callbacks into one"" into main 2025-01-30 13:12:33 -08:00
Adnan Begovic 6a69b19389 Merge "Launcher3: Introduce lint checks for Launcher3." into main 2025-01-30 11:25:25 -08:00
Android Build Coastguard Worker d9229faff2 Merge cherrypicks of ['googleplex-android-review.googlesource.com/31516215'] into 25Q1-release.
Change-Id: Ie301dc0e65ce80dff237a9b9dc8805de115c43e2
2025-01-30 10:45:02 -08:00