Commit Graph

83004 Commits

Author SHA1 Message Date
Alex Chau e15fa0470c Merge "Crop Desktop TaskThumbnailView according to its intersection with parent" into main 2025-02-13 09:10:34 -08:00
Treehugger Robot 38a203e8f4 Merge "Convert TaskGridNavHelper to Kotlin." into main 2025-02-13 08:54:17 -08:00
Uwais Ashraf 58b4407154 Retrieve thumbnail for freeform windowing
Fix: 348643341
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual - open freeform task and see thumbnail shown during launch. Videos in b/348643341.
Change-Id: I7c9d070e6b39391301a9701f33adef57819e631d
2025-02-13 15:25:41 +00:00
Pat Manning 1bc108f1c2 Convert TaskGridNavHelper to Kotlin.
Fix: 396114184
Test: TaskGridNavHelperTest
Flag: EXEMPT Kotlin conversion
Change-Id: I1c3da7eac7f41a0763293a0b408f608799f02cf2
2025-02-13 14:47:21 +00:00
Elliott Hughes 1c442011de Merge "Fix typo." into main 2025-02-13 06:15:09 -08:00
Alex Chau 08bd1bfcdb Crop Desktop TaskThumbnailView according to its intersection with parent
- Override TaskThumbnailView's outline bounds to be the Rect that the view intersect with parent, so it draw corner radius around the intersection, to match the corner radius behavior in live tile
- This is not fixed in TaskThumbnailViewDeprecated as it doesn't have an outline implemenation, and it's too complicated to rewrite that as a bugfix

Fix: 379881502
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Flag: com.android.window.flags.enable_desktop_recents_transitions_corners_bugfix
Test: OverviewDesktopTaskImageTest
Change-Id: I67d7e6a05b15f0f651c8ec71f33ca1e02d662b06
2025-02-13 12:38:03 +00:00
Pat Manning 849d204c71 Merge "Add Haptic feedback to task dismiss animations." into main 2025-02-13 02:51:01 -08:00
Treehugger Robot 6191d06684 Merge "launcher3: Improve SimpleBroadcastReceiver." into main 2025-02-12 18:19:35 -08:00
Sunny Goyal 46b9e9a2dd Moving LauncherIcons to dagger
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger

Change-Id: Ia6de74a5fd632872460dc7745f6c29ead1ab0a2e
2025-02-12 16:47:12 -08:00
Ana Salazar Maldonado 3bb0634a32 Merge "Fix contrast tile measurement calculation for folders" into main 2025-02-12 16:45:54 -08:00
Treehugger Robot c2ef2629cd Merge "Notify with onIsInDesktopModeChanged()" into main 2025-02-12 16:27:38 -08:00
Jeremy Sim d658a709f9 Handle dim layers in recents animation
Launcher-side changes for ag/31424956.

Bug: 349828130
Flag: com.android.wm.shell.enable_flexible_two_app_split
Test: Visually correct when a 90:10 pair goes to recents and back
Change-Id: I65bc56565291eae5959cd567057754d47a84bcaa
2025-02-12 15:39:52 -08:00
Treehugger Robot 6a039c4465 Merge "Implement isInDesktopMode*()" into main 2025-02-12 15:31:53 -08:00
Ana Salazar Maldonado 4ff68edea9 Fix contrast tile measurement calculation for folders
When creating a folder, the element name begins empty. Because of this,
while layout is happening, the paddings for the text and the bubble are
not considered. Fix the condition within onMeasure to add the respective
paddings when the bubble could be drawn.

Bug: 341217082
Flag: com.android.launcher3.enable_contrast_tiles
Test: Manual, visual change
Change-Id: Ie707102fa3d4827568a9db247ea5ebf5f8e1ae0d
2025-02-12 14:31:01 -08:00
Brian Isganitis 7dce7a09c7 Have per-environment bindings for Taskbar multivalent tests.
Flag: TEST_ONLY
Bug: 230027385
Test: go/testedequals
Change-Id: I7dba1e052855da19c9b58c87a0a8b5258ee0dc7c
2025-02-12 16:51:08 -05:00
Adnan Begovic 1b26bb4a74 launcher3: Improve SimpleBroadcastReceiver.
Unless explicitly annotated, parameters in java are by
  default nullable. There are a few cases where a null context
  may be passed to the unregisterReceiverSafely function
  of SimpleBroadcastReceiver.

  To mitigate misuses or incorrect contexts being passed for
  register vs unregister, keep the context as a strong reference
  in the constructor.

  Also added NonNull annotations for any public callsites to
  enforce behavior.

Bug: 395019017, 395966395
Flag: NONE - bug fixed
Test: manual - presubmit
Change-Id: Ie371fa45cadceaf51cf184b446df9123ef27c337
2025-02-12 13:43:34 -08:00
Ahmed Fakhry 2289c28f7f Notify with onIsInDesktopModeChanged()
This CL renamed `onDesktopVisibilityChanged()` to
`onIsInDesktopModeChanged()` and adds a parameter for the display ID
on which the change is taking place.

When the multiple desktops flags are disabled, the behavior should
remain exactly as it is today; `onIsInDesktopModeChanged()` is
triggered only for the `DEFAULT_DISPLAY`, and when the same old
conditions occur.

Bug: 394685645
Test: m
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: I31658b1b7932c787ebd430cee7e5c99bdd01e8c9
2025-02-12 21:18:54 +00:00
Ahmed Fakhry ad6fee6111 Implement isInDesktopMode*()
This CL does the following:
- Adds new methods `isInDesktopMode()` and
  `isInDesktopModeAndNotInOverview()` to `DesktopVisibilityController`.
- These two methods rely on the new multi-desks impl when the flags are
  enabled.
- Makes the existing `areDesktopTasksVisible()` and
  `areDesktopTasksVisibleAndNotInOverview()` private, and migrates all
  the usages to the new methods.
- The new methods uses the old methods if the flags are disabled.

A companion NexusLauncher CL is at ag/31601363.

Bug: 394182435
Test: m
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: I29ff38f984bfe2f68a120f84e1a75fa36b739258
2025-02-12 21:18:51 +00:00
Treehugger Robot 4425ab3062 Merge "Moving InvariantDeviceProfile to Dagger" into main 2025-02-12 12:44:44 -08:00
Treehugger Robot 6c33393fe3 Merge "Revert "Refactor all uses of DisplayController singleton INSTANCE"" into main 2025-02-12 12:34:41 -08:00
Pat Manning f49e206f7e Merge "Add additional dampening to neighboring springs the further they are from dragged task." into main 2025-02-12 11:34:03 -08:00
Sunny Goyal c864281f3c Revert "Refactor all uses of DisplayController singleton INSTANCE"
Revert submission 31490053-DisplayControllRefactorForCD

Reason for revert: Leak is displayProvider

Reverted changes: /q/submissionid:31490053-DisplayControllRefactorForCD

Change-Id: Ib65150cdde765be009b5c4ce960f9fe025de9e60
2025-02-12 10:27:18 -08:00
Treehugger Robot 92513ecc7e Merge "Revert "Adding logs to debug test failures"" into main 2025-02-12 10:10:46 -08:00
Pat Manning 58fa42ad13 Add additional dampening to neighboring springs the further they are from dragged task.
Fix: 394513952
Test: TaskGridNavHelperTest
Test: TaplTestsQuickstep#testDismissCancel
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: Ib26a48256e9f14974aa01266c6950d15412683c3
2025-02-12 16:23:15 +00:00
Pat Manning fe7eb99dc4 Add Haptic feedback to task dismiss animations.
Fix: 389640582
Test: Manual.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: Icfbc875b4021136f612d8227f5cbbc1491e54801
2025-02-12 14:21:34 +00:00
Jordan Silva 55e3fcfb4e Revert "Adding logs to debug test failures"
This reverts commit 4151c1eb9a.

Reason for revert: These logs are no longer necessary.

Change-Id: Ic0c8e8ba148f0103ca8001dfec2b3dc031973dab
2025-02-12 05:56:24 -08:00
Treehugger Robot fb683dff89 Merge "Refactor all uses of DisplayController singleton INSTANCE" into main 2025-02-12 05:47:46 -08:00
Treehugger Robot a6a4b0921a Merge "Pass TransitionInfo from onTasksAppeared() to TransformParams" into main 2025-02-12 04:28:45 -08:00
Treehugger Robot efebae2ef4 Merge "Destroy RecentsDependencies in tests that initialise it." into main 2025-02-12 02:48:35 -08:00
Will Osborn 5f8b6206ce Refactor all uses of DisplayController singleton INSTANCE
And make DisplayController display id aware

Test: locally tested on Tangor
Flag: EXEMPT refactor
Bug: 392858637

Change-Id: I805cd7323c48a2988c95b9fda7f6cfe4c153860c
2025-02-12 10:46:34 +00:00
Gustav Sennton 57ce690d4e Pass TransitionInfo from onTasksAppeared() to TransformParams
Pass the TransitionInfo of the merging recents-transition through to
TransformParams to allow setting the corner radius of desktop tasks to
zero during the second part of a recents transition.

Bug: 378657004
Flag: com.android.window.flags.enable_desktop_recents_transitions_corners_bugfix
Test: swipe up from fullscreen app to overview, then tap desktop tile

Change-Id: I08f87aa1b9a2feca9e9f8bed2c55279e0ddc1edb
2025-02-12 10:19:14 +00:00
Uwais Ashraf d7007ef6e8 Destroy RecentsDependencies in tests that initialise it.
This prevents unaccounted for destructions which can lead to a leak in tests after these.

Bug: 395214062
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TaplStartLauncherViaGestureTests.testStressPressHome
Change-Id: I5cf9214ea9344f7e9d79b61e87269fd6e2c05753
2025-02-12 00:49:00 -08:00
Treehugger Robot 1844db355f Merge "Disable All Apps keyboard shortcut during user setup." into main 2025-02-11 19:58:28 -08:00
Treehugger Robot 97d837e8b8 Merge "Converting LauncherIcons to kotlin" into main 2025-02-11 16:32:22 -08:00
Owner Cleanup Bot 40e6a538ab [owners] Remove zakcohen@google.com from tests/src/com/android/launcher3/widget/picker/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.
If this change is unnecessary or in error, vote the lowest CR value
(i.e. reject the CL) and the bot will abandon it. Vote the highest CR to
approve this change. You may also abandon this change.

See the owner's recent activity for context:
https://android-review.googlesource.com/q/zakcohen@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: I012d61af6b55dd1ae2f00be846af393bc7bc2f38
2025-02-11 16:03:09 -08:00
Owner Cleanup Bot 41ed20667e [owners] Remove zakcohen@google.com from tests/multivalentTests/src/com/android/launcher3/widget/picker/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.
If this change is unnecessary or in error, vote the lowest CR value
(i.e. reject the CL) and the bot will abandon it. Vote the highest CR to
approve this change. You may also abandon this change.

See the owner's recent activity for context:
https://android-review.googlesource.com/q/zakcohen@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: I72cb2c5e66ee297e9ff09257969d3d8934aad373
2025-02-11 16:02:59 -08:00
Owner Cleanup Bot b0a7ca0dbb [owners] Remove zakcohen@google.com from src/com/android/launcher3/widget/picker/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.
If this change is unnecessary or in error, vote the lowest CR value
(i.e. reject the CL) and the bot will abandon it. Vote the highest CR to
approve this change. You may also abandon this change.

See the owner's recent activity for context:
https://android-review.googlesource.com/q/zakcohen@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: Ibb729a15daafdf804c57c080a72ab8004f6861a0
2025-02-11 16:02:48 -08:00
Sunny Goyal 5bca45a739 Moving InvariantDeviceProfile to Dagger
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: Ia99ee031e96c5e6069a56fe90a262a533dd8665a
2025-02-11 15:22:18 -08:00
Treehugger Robot 0d9c54fc51 Merge "Make sure only old grids show up when the flag is off" into main 2025-02-11 13:52:38 -08:00
Sunny Goyal a48e22319e Converting LauncherIcons to kotlin
This will simplify migration to dagger

Bug: 361850561
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: I1d806c51a49cea4a5c44788d2fc3b825c2da8bbd
2025-02-11 13:22:06 -08:00
Treehugger Robot 4be58b0d75 Merge "Adding logs to debug test failures" into main 2025-02-11 12:46:31 -08:00
Bill Yi 1a8e5c9097 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-02-11 12:18:30 -08:00
Bill Yi 7e988a4d73 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-02-11 12:18:30 -08:00
Treehugger Robot 48e89f1273 Merge "Let DesktopTaskView.bind() use DesktopTask" into main 2025-02-11 10:52:58 -08:00
Jordan Silva 4151c1eb9a Adding logs to debug test failures
Bug: 395214062
Test: TaplStartLauncherViaGestureTests
Flag: com.android.launcher3.enable_overview_icon_menu
Change-Id: I4bc612bb5b928a251ee2cf80e14bb9408d1d415c
2025-02-11 10:45:39 -08:00
Sebastian Franco e34f561224 Rotate Wallpaper Picker if in FixedLandscape
Bug: 382906719
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: Id4f29567899e4fec5585247077456eec5f343b98
2025-02-11 12:32:52 -06:00
Priyanka Advani (xWF) 77a5341e53 Merge "Revert "Moving TisBinder to its own class"" into main 2025-02-11 10:17:13 -08:00
Treehugger Robot 0703ed2931 Merge "[CD Taskbar] Force 3 Button Mode on External Display by Default" into main 2025-02-11 10:04:22 -08:00
ELIYAZ MOMIN (xWF) 31d6be8891 Revert "Moving TisBinder to its own class"
This reverts commit ce9ad064d6.

Reason for revert: <Potential culprit for  b/395855288  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted>

Change-Id: I12d1eb66ae03e2638a503c103d0b1fa8a863b6b5
2025-02-11 08:18:42 -08:00
Schneider Victor-Tulias f9c1e29766 Add debug logs to AbsSwipeUpHandler.calculateEndTarget
Flag: EXEMPT debug logs
Bug: 394364217
Test: logcat
Change-Id: I2b95cbbae4fdfb84dc29ebc90e7339aae199237d
2025-02-11 11:14:51 -05:00