Commit Graph

20057 Commits

Author SHA1 Message Date
Jordan Silva 17fd5f13f4 Remove unused overviewActionsButtonSpacing from DeviceProfile
Bug: 404479758
Flag: EXEMPT. Clean-up code.
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Test: DeviceDefaultGridTest
Change-Id: Ieb9ec81f82e80d293f04de71d5c2575a4ce50301
2025-04-03 10:18:23 -07:00
Stefan Andonian 8860d1eca9 PageIndicatorDot Placement && Arrow Touchboxes.
In the previous image tests, the page indicator placement within folders
was inconsistent depending on the number of pages in a folder. This change fixes that by removing the margin_End for the page indicator in folders, as well as fixing the onMeasure call in PageIndicatorDots to be the same as the legacy calculation, just with additional space for the arrows.

Previously, the touchboxes were very small, and difficult to use. To enlarge the touchbox, enlarged padding is used. This means when the indicator & arrows are visible, we need to remove the margin from the layout container and move it to padding for the indicator.

Bug: 394355070
Test: Tested folders with 2, 3, and 18 pages in both left to right
and right to left mode.
Flag: com.android.launcher3.enable_launcher_visual_refresh

Change-Id: I3a5d9d6d77dec963865adede1c4bfe38890d608f
2025-04-02 22:35:35 +00:00
Matthew Mourgos df91b22fab Put EnableMouseInteractionChanges behind desktop form factor value
Ensure that the EnableMouseInteractionChanges feature only affects
desktop devices, by adding a check for the desktop_form_factor value.

Flag: com.android.launcher3.enable_mouse_interaction_changes
Bug: 388897603
Test: Manual
Change-Id: I483def8ca249a83e5d028e71db74ec85a700bfb4
2025-04-02 13:16:35 -07:00
Treehugger Robot 8310d2d219 Merge "Dispatch KeyEvents received by the RecentsWindowManager to the LauncherRootView" into main 2025-04-02 12:40:28 -07:00
Andy Wickham 5994d29e20 Merge "Re-adds Workspace behind All Apps and ties to DepthController." into main 2025-04-01 09:59:56 -07:00
Schneider Victor-Tulias 9f75f51a2c Dispatch KeyEvents received by the RecentsWindowManager to the LauncherRootView
- TaplTestsQuickstep.testDismissModalTaskAndOverviewWithEscKey was failing because RecentsWindowManager didn't dispatch key events at all.
- Also moving all LauncherRootView setup to a one-time execution

Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 368610710
Bug: 377678992
Test: TaplTestsQuickstep.testDismissModalTaskAndOverviewWithEscKey
Change-Id: I9d8e0c91a549ed08398b2c89b1e4d23561f95c62
2025-04-01 07:31:49 -07:00
Sunny Goyal 55c51ff06d Merge "Lazily loading theme icons" into main 2025-03-31 23:31:30 -07:00
Sebastián Franco 713624e79d Merge "Deactivate fixed landscape preview and show portrait preview instead." into main 2025-03-31 13:44:17 -07:00
Sunny Goyal 50884dadfe Lazily loading theme icons
Theme icons are generated and stored in cache, but only loaded if requested in lookup flags
This allows to keep the memory usage low, but not loading theme icons for all the apps

Bug: 381897614
Flag: com.android.launcher3.extendible_theme_manager
Test: Updated tests
Change-Id: I494eab9c4f70670e6f5aeb864ed5287f6b9f1b9e
2025-03-31 13:07:03 -07:00
Treehugger Robot 73818a634d Merge "Turn on debug log for BaseActivity" into main 2025-03-31 12:54:54 -07:00
Charlie Anderson 6db3955ef4 Merge "remove shape-based icon scaling" into main 2025-03-31 11:17:42 -07:00
Alex Chau 0896c64198 Turn on debug log for BaseActivity
Bug: 406230491
Test: presubmit
Flag: EXEMPT logging
Change-Id: Ie39dc12f0d6d245dc547f911120e13753e90a7af
2025-03-31 18:25:31 +01:00
Andy Wickham 3c7f59ac4b Re-adds Workspace behind All Apps and ties to DepthController.
I had previously hidden workspace with All Apps blur because the
approaches I had tried looked poor. However, I found that this
approach is both simple and relatively performant! Essentially,
wallpaper is still pushed back and blurred by the DepthController.
When the DepthController applies blur, we also apply it to the
Workspace and Hotseat. In addition, we scale these at the same
rate as the depth when swiping to all apps. Perhaps we can have
the DepthController control this scale too, but for now we just
use the same Interpolator. The result looks pretty cohesive.

Demo: https://drive.google.com/file/d/1KyKc0c5BsAEOrT3K4buOW3U9-Gk0e7vE/view?usp=sharing&resourcekey=0-MI1gdQMul0cro9IEkQDEng
App exit demo (slightly outdated): https://drive.google.com/file/d/1r-VhzGhlI0300_6IUXthty3Tm1cgw9aI/view?usp=sharing&resourcekey=0-nxZ2BHW2UN34lr567I0RdA

Bug: 400827727
Bug: 371343636
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: I5dc66619a001ccd32f37272cf77966cbe1bf8ef6
2025-03-29 08:12:29 +00:00
Treehugger Robot e18ec2b41a Merge "Remove demo mode layout code" into main 2025-03-28 19:14:34 -07:00
Brandon Dayauon df761a1c53 Merge "Override PS app icon title to Add" into main 2025-03-28 17:35:20 -07:00
Sebastian Franco af31a6fa80 Deactivate fixed landscape preview and show portrait preview instead.
There is extra work needed from the Wallpaper picker side to support
showing the FixedLandscape view on the Launcher. They are already
working on it but in the meantime we will disable the preview and show
the portrait view instead.

Fix: 402353157
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: I12942a8f4edb7eff537d8431880cfe108e161ed2
2025-03-28 17:05:51 -07:00
Federico Baron dc1e7d004c Remove demo mode layout code
It's no longer used/needed

Bug: 407120123
Flag: EXEMPT internal cleanup
Test: EXEMPT internal cleanup
Change-Id: Ie0ae18b67ed4d7119b7901e652c27c024450da4b
2025-03-28 23:58:50 +00:00
Sunny Goyal 45f1a5190c Merge "Using item inflater for predicted items and previews" into main 2025-03-28 15:18:11 -07:00
Charlie Anderson 3cbdf78b4f remove shape-based icon scaling
Bug: 400774067
Test: trying different shapes
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: I9535cdaa275abcda1d0fc73128f24fe89d473e4d
2025-03-28 17:23:58 -04:00
Will Osborn 5c00b41505 Merge "Refactor RecentsAnimationDeviceState and TaskAnimationManager using new PerDisplay library" into main 2025-03-28 14:05:39 -07:00
Sunny Goyal bdd3f29342 Using item inflater for predicted items and previews
Bug: 406668365
Test: Verified manually in picker
Flag: EXEMPT refactor
Change-Id: If8ca919a19b7d1b6cbdc33823a9f294df1afa968
2025-03-28 13:05:25 -07:00
Brandon Dayauon 7bd0749070 Override PS app icon title to Add
The psApp icon will have an original title "Private Space" but should
only be "Add" in the container.

bug: 360313403
Test: manually:
Before: https://hsv.googleplex.com/6348079987949568
After: https://hsv.googleplex.com/6126091247812608
Flag: android.multiuser.enable_moving_content_into_private_space
Change-Id: Ifcb599cdb5f4a97e2da68cafa81f23b387a2beb6
2025-03-28 17:31:43 +00:00
Treehugger Robot e5ae6347f3 Merge "Enable previewing themed icon in wallpaper picker" into main 2025-03-28 09:49:54 -07:00
Will Osborn ec8d20d0ed Refactor RecentsAnimationDeviceState and TaskAnimationManager using new PerDisplay library
Test: locally tested on Tangor
Bug: 399371607
Flag: EXEMPT refactor

Change-Id: Ie52f53a2d5dee757a8dc3b19248736bc15e5e0c6
2025-03-28 12:08:36 +00:00
Shamali Patwa f216f3d2ce Merge "Delete the filter code as it will be provided differently in refactor" into main 2025-03-27 16:19:36 -07:00
Sihua Ma 5c1534b58d Enable previewing themed icon in wallpaper picker
Test: Presubmit
Flag: com.android.systemui.shared.new_customization_picker_ui
Bug: 406813938
Change-Id: I9377db41ac422cd80e7af434f28a5b16cdbd02d2
2025-03-27 22:38:03 +00:00
Treehugger Robot d81b43802a Merge "Add showPinningView to TaskbarPinningControllerTest." into main 2025-03-27 14:45:20 -07:00
Shamali P 472709d9ca Delete the filter code as it will be provided differently in refactor
With the dagger update the initialization happens in constructor which
we would avoid once we work on refactor and move it into a repository
class. The list will also be fetched from a different data source, so,
makes sense to delete it at the moment.

Bug: 406324964
Flag: EXEMPT BUGFIX
Test: Not applicable as code is removed
Change-Id: Iab8bb1e94677abf9b5b882f4d3485b002faf3e0f
2025-03-27 14:15:05 -07:00
Sunny Goyal 2201485e22 Merge "Using ItemInflator for inflating Folder instead of duplicating code" into main 2025-03-27 12:45:01 -07:00
Treehugger Robot b3a5b7c8e4 Merge "Revert^2 "Simplifying model testing rules"" into main 2025-03-27 10:11:38 -07:00
Sunny Goyal 0479ff832c Using ItemInflator for inflating Folder instead of duplicating code
Bug: 406668365
Flag: EXEMPT refactor
Test: atest FolderTest
Change-Id: I63186ba620b5380edfc5e8cded253a85379a5d82
2025-03-27 09:48:46 -07:00
Sebastián Franco edb8aab1fe Merge "Using the same string "App List" for Long press menu and Talkback" into main 2025-03-27 09:40:55 -07:00
Charlie Anderson 25c0547a53 Merge "Add transalatable Strings for shape titles" into main 2025-03-27 06:36:45 -07:00
Charlie Anderson 91f881ed7b Merge "Add metrics logging for selected icon shape" into main 2025-03-27 06:35:40 -07:00
Andy Wickham b3459574f4 Remove header protection for blurred app panel.
As requested here: https://docs.google.com/presentation/d/1BKFfB2LAIDoaA5aLs8did6IcUw_pktrSWI5xmypkl3s/edit?resourcekey=0-HpXwztiEYGe0BYQzUeBBbQ&pli=1&disco=AAABe0KKmWU

Demo: https://drive.google.com/file/d/19kf1BzfOL3-umWwmxLDFnCXrw08IeHIB/view?usp=sharing&resourcekey=0-dMDKrgz4-qEnhvneHI_EQw

Bug: 400827727
Bug: 371343636
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: Id8560e0d8b95f454bbd96bf484f4578bf505c88e
2025-03-26 23:18:40 -07:00
Sunny Goyal 3b307455a0 Revert^2 "Simplifying model testing rules"
35b6d322ab

Change-Id: I3ed574a517dbe350b6dfe5b1d3ed198203d22f44
2025-03-26 23:08:55 -07:00
Treehugger Robot b932dea54e Merge "Implement spring animations for running state changes." into main 2025-03-26 21:06:14 -07:00
Treehugger Robot d46249c412 Merge "Update Launcher UI when model changes are made outside of Launcher UI" into main 2025-03-26 20:35:30 -07:00
Charlie Anderson d2560ecf31 Add transalatable Strings for shape titles
Bug: 406486710
Test: presubmit
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: I227227e7591979de474c27adcd71c6d83393bae9
2025-03-26 20:09:07 -07:00
Charlie Anderson a8b5c62382 Add metrics logging for selected icon shape
Bug: 400696362
Test: N/A
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: Ibe85fad20ec35bc49dc8e76e3dbf402d31810d21
2025-03-26 20:08:48 -07:00
Jon Miranda e6d41c9b2f Add showPinningView to TaskbarPinningControllerTest.
Simple test that checks long pressing on the divider icon shows the
pinning view.

Bug: 402671805
Bug: 346394250
Test: TaskbarPinningControllerTest
Flag: TEST_ONLY
Change-Id: I435be4d7a12b0a92432cba49e57b6cef46e9679d
2025-03-26 19:05:03 -07:00
Sunny Goyal 6e12b811a0 Merge "Revert "Simplifying model testing rules"" into main 2025-03-26 16:37:45 -07:00
Priyanka Advani (xWF) 35b6d322ab Revert "Simplifying model testing rules"
Revert submission 32704934-model-test-cleanup

Reason for revert: Droidmonitor created revert due to b/406588406. Will be verifying through ABTD before submission.

Reverted changes: /q/submissionid:32704934-model-test-cleanup

Change-Id: Ieeb7f5b5699afeae27f946f060147bb68afc36e5
2025-03-26 16:12:16 -07:00
Treehugger Robot 0219df0770 Merge "Simplifying model testing rules" into main 2025-03-26 15:10:44 -07:00
Sebastian Franco 0fbd630149 Using the same string "App List" for Long press menu and Talkback
Bug: 386737601
Test: OptionsPopupTest
Flag: EXEMPT BUGFIX
Change-Id: I20e5a89ee46389e6ce059f27041b5bd1a7224410
2025-03-26 14:08:54 -07:00
Sunny Goyal ca1f87d8f5 Update Launcher UI when model changes are made outside of Launcher UI
Bug: 305877212
Flag: EXEMPT bugfix
Test: Verified manually by modifing folder in taskbar
Change-Id: I513dcfbc9e4ffcd970766ce8352815571e576461
2025-03-26 13:52:53 -07:00
Sunny Goyal 49ec691f92 Removing unnecessary preAdd method from ModelCallbacks
Bug: 390572144
Test: Presubmit
Flag: EXEMPT refactor
Change-Id: I23671339394e48ea1e8804a60be1d4dbf520e7d5
2025-03-26 11:57:17 -07:00
Sunny Goyal cb84230913 Simplifying model testing rules
> Using Sandbox application everywhere to avoid test leaks
> Removing LauncherModelHelper and moving some utility methods to rules and extensions

Bug: 406521480
Flag: EXEMPT test only
Test: Presubmit

Change-Id: I17bd5ec2bdb0fc0cbe02be9c8ee76595effe3f11
2025-03-26 11:34:15 -07:00
Treehugger Robot eddb50613d Merge "Update icon override map when theme changes" into main 2025-03-25 17:12:42 -07:00
Sihua Ma 44e9645719 Update icon override map when theme changes
Fix: 391970288
Bug: 406240868
Test: Manual
Flag: EXEMPT bug fix
Change-Id: I458e5892b819a4599476017eac71eddf0a92a16f
2025-03-25 21:43:46 +00:00