Commit Graph

20057 Commits

Author SHA1 Message Date
Sunny Goyal 1ac78b6ec6 Removing listeners from FolderInfo
Folder and FolderIcon are UI objects and can talk to each other directly.
FolderInfo changes are already propogated via model callbacks, and doesn't need a separate listener pattern.

Bug: 398791288
Flag: EXEMPT bugfix
Test: atest FolderTest

Change-Id: Iefd47b8ea12a8ecaf34211a3d908220a0e999187
2025-03-13 10:28:07 -07:00
helencheuk de869b3624 Check null when getting drop view in DragController
When the flag is on, there are some cases dropTarget is null:
TaplTestsTaskbar.testOpenMenu_fromTaskbarAllApps
TaplTestsTaskbar.testLaunchShortcutInSplitscreen
TaplTestsTaskbar.testLaunchShortcut

Add logic to check null before getting drop view and calling drop complete.

Bug: 343650193
Test: TaplTestsTaskbar.testOpenMenu_fromTaskbarAllApps
Test: TaplTestsTaskbar.testLaunchShortcutInSplitscreen
Test: TaplTestsTaskbar.testLaunchShortcut
Flag: com.android.launcher3.remove_apps_refresh_on_right_click
Change-Id: If8ce93bd6f7d0506e2272ca17dd7c19666549cfa
2025-03-13 15:21:11 +00:00
Stefan Andonian 43e7eba492 Fix Entry Animations for VisualRefresh Page Indicator Dots
Previously, the folder entry was offset, and also clipped in RTL modes.
This is because the new PageIndicatorDots are wider than the previous ones.

Bug: 383974843
Test: Verified that everything works in RTL and in LTR modes.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: I3bacf454befac2b8148236253a82bd5b7317036a
2025-03-12 21:32:40 -07:00
Stefan Andonian db74d32103 Fix Page Indicator Dots Arrow Clicks in RTL Mode
I assumed that these would map to start and end, but they actually
are literally right and left arrows, even in RTL mode.

Bug: 383974843
Test: Verified that everything works in RTL and in LTR modes.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: I8027f33cde9b2c7cc241b9b13414bb1ffed94d31
2025-03-12 21:18:57 -07:00
Sebastián Franco 837e576c56 Merge "Add padding in Fixed Landscape on the side oposite of the camera hole" into main 2025-03-12 18:34:30 -07:00
Brandon Dayauon 0e3de56211 Change private space app content description
bug: 360313403
Test: manually
Flag: android.multiuser.enable_moving_content_into_private_space
Change-Id: I3fb779e5217285c6d6b059f021c6d5f965aed531
2025-03-13 01:01:44 +00:00
Brandon Dayauon 726fbcf003 Don't show system shortcuts for the psApp
bug: 360313403
Test: manually - https://hsv.googleplex.com/5320142379548672
Flag: android.multiuser.enable_moving_content_into_private_space
Change-Id: Ibb3322ab7793d3d9e925d5392a80bb6bd16568fd
2025-03-13 01:01:40 +00:00
George Lin 4aec306026 Merge "Handle app icon preview and update cases" into main 2025-03-12 17:48:53 -07:00
Treehugger Robot 9e50f5eea4 Merge "Fixing folder contents getting clipped during open/close animation" into main 2025-03-12 13:41:42 -07:00
Andy Wickham 250d85698c Merge "Adds all_apps_blur flag." into main 2025-03-12 11:25:50 -07:00
Sunny Goyal 778b89c334 Fixing folder contents getting clipped during open/close animation
Bug: 394932723
Test: Manual
Flag: EXEMPT bug-fix
Change-Id: I4995f8c178f7a422cb03a2b548b77fd88b93fab6
2025-03-12 11:23:23 -07:00
Helen Cheuk df47454b28 Merge "Reland - Not refresh predicted app in right click" into main 2025-03-12 11:14:26 -07:00
Thu-Huong Vu 09846676b5 Merge "Register SimpleBroadcastReceiver permission." into main 2025-03-12 10:36:22 -07:00
Stefan Andonian 85b5f813eb Merge "Fix RTL mode for new PageIndicatorDots" into main 2025-03-12 10:01:00 -07:00
helencheuk 69193807f7 Reland - Not refresh predicted app in right click
When users right click the mouse/touchpad, predicted apps in hotseat refresh and it is weird.
It refreshes because the right click is treated as a drag and a drag would trigger predicted apps refresh.
This fix adds a PreDragCondition when right click to avoid it from starting drag.

Bug: 343650193
Test: Manual, connect to touchpad and right click on widget and folderIcon
Flag: com.android.launcher3.remove_apps_refresh_on_right_click
Change-Id: Id0be87beb8a0e9baf78a4ba8ec4c93462ec7bb3e
2025-03-12 15:56:53 +00:00
Treehugger Robot b615b9bdaf Merge "Add Arrows to Folder PageIndicatorDots for Accessibility Purposes." into main 2025-03-11 23:50:53 -07:00
Treehugger Robot 0b5f6698c9 Merge "Attempt #2. Fix OutlineProvider for PageIndicatorDots for new visual updates." into main 2025-03-11 23:50:50 -07:00
Treehugger Robot 8561c5690f Merge "Drag and drop from the search view on the overview screen." into main 2025-03-11 18:26:48 -07:00
Andy Wickham ccb3a5c25c Adds all_apps_blur flag.
This enables blur both for Taskbar and Launcher, but in slightly
different ways.

For Taskbar All Apps, we apply blur to the overlay window, and
for Launcher All Apps, we utilize the existing DepthController to
blur the wallpaper window. For similicity, we currently fade out
workspace/hotseat to avoid awkward view + window blurs which
don't look that good. This is not the POR, but I think it achieves
most of the effect and will help us get some blur exposure.

Separately I will continue to investigate options such as blurring
workspace in a clever way so it feels blended with the wallpaper,
reusing the Taskbar window and connecting it to LauncherState, or
using a SurfaceView (though I spent quite some time trying this and
it seemed the same as the original issue).

In both cases, we use a 20-30% opacity scrim with a set color, and a
panel that blends 40% opacity of a dark/light color with 10% white.

Also updated some incorrect isTablet checks which really should have
been checking shouldShowAllAppsOnSheet(), which includes the
all_apps_sheet_for_handheld flag.

Demo: https://drive.google.com/file/d/1Ov9Dg3R9YHNfisfxNf97ZIhlDeEA1IWj/view?usp=sharing&resourcekey=0-l_SDpqpS4HtOb10a3b_jNg

Other upcoming improvements: interpolator tweaks, colors of things
inside the app panel (tabs, private space, search results, etc).

Bug: 400827727
Bug: 371343636
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: Ic7063cd822f39a5977715b5477f825bf11e57bdf
2025-03-11 23:34:03 +00:00
mpodolian 61de3b43cb Drag and drop from the search view on the overview screen.
Bubble bar drop targets have been added to the TaskbarDragController
used in the TaskbarOverlayContext. This enables dragging taskbar icons
to the bubble bar drop zone from the search view on the overview screen.

Bug: 399678274
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual. Go to the overview screen. Click the search icon. Drag any
application icon from the grid to the bubble bar drop zone. Drop the
application icon.

Change-Id: I33eb13785d8837fefc717a95a6566d3091ec855b
2025-03-11 16:07:21 -07:00
George Lin e24533cb40 Handle app icon preview and update cases
Add 2 more cases:
1. Update icon shape only
2. Preview icon themed

Test: TBD
Bug: 402161932
Flag: com.android.systemui.shared.new_customization_picker_ui
Change-Id: I2dc21e14d346a1d444ed8baa759e7a6d38f6cd41
2025-03-11 23:02:59 +00:00
Stefan Andonian 105fe8cdda Fix RTL mode for new PageIndicatorDots
Bug: 383974843
Test: Verified that everything works in RTL and in LTR modes.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: Idcbff06321fedfd6720780387803a0139a920520
2025-03-11 15:32:33 -07:00
Stefan Andonian cea8019728 Attempt #2. Fix OutlineProvider for PageIndicatorDots for new visual updates.
This attempt puts 100% of the change behind a flag and doesn't round any values.

Bug: 394355070
Test: Verified locally that the active indicator is outlined properly.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: I6e610cb8a5ad9914d3152ef0019fcb5f50c331c3
2025-03-11 15:10:38 -07:00
Ana Salazar Maldonado 71d485d264 Merge "Add Widget Resize Frame actions" into main 2025-03-11 15:01:43 -07:00
Sebastián Franco 9e77e5de46 Merge "Adding access to All Apps in the long press menu in Launcher" into main 2025-03-11 15:00:47 -07:00
Treehugger Robot ace69f7644 Merge "Making various model objects injectable" into main 2025-03-11 14:48:30 -07:00
Sebastian Franco ad047c74b3 Add padding in Fixed Landscape on the side oposite of the camera hole
Fix: 380031237
Test: HomeScreenImageTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: Ie7557767f629f0c7a5b7b62a3039c8a5c3cc7f43
2025-03-11 14:27:52 -07:00
Stefan Andonian aa29761825 Add Arrows to Folder PageIndicatorDots for Accessibility Purposes.
Bug: 383974843
Test: Verified via go/web-hv that the hitbox sizes were correct. Measured the width and height within the folder for 1 through 7 pages, and everything looked great.Change title worked, and pressing on arrows to change page worked great.
Flag: com.android.launcher3.enable_launcher_visual_refresh

Change-Id: Ic095b2abe330544882467fb4803724e8d50a1798
2025-03-11 14:27:35 -07:00
Ana Salazar Maldonado 71c38ab75c Add Widget Resize Frame actions
Demos:
http://screencast/cast/NTE1NDE3NzM0MzgxNTY4MHwxYzQ2MDVlOC1mOQ
http://screencast/cast/NTcwNTM3ODE5MTkwMDY3Mnw5MDBiNzAzMS03MA

Bug: 374248904
Test: manual - activate talkback, add new widget
Flag: EXEMPT bug fix
Change-Id: I80ab0da75ec054709a28f41d9ceabce9e94866d9
2025-03-11 12:39:12 -07:00
Sunny Goyal 029315d9f5 Making GridCustomizatonProxy extendible
Bug: 381897614
Flag: com.android.launcher3.extendible_theme_manager
Test: Manual
Change-Id: I9a29e371a4159ba436d4caaffce4bcdaa7fd16e2
2025-03-11 11:57:47 -07:00
Brandon Dayauon 91689e89e7 Merge "Update creationFlag state only on non PSApp" into main 2025-03-11 11:46:42 -07:00
Treehugger Robot 19cb25f98e Merge "Add TODO for PageIndicatorDots refactor." into main 2025-03-11 10:45:06 -07:00
Sebastian Franco d8ec43b94e Adding access to All Apps in the long press menu in Launcher
Bug: 386737601
Test: TaplTestsLauncher3Test
Flag: EXEMPT BUGFIX
Change-Id: I1e49cf521c40e8217c1fdefa7ce8461da16429bd
2025-03-11 09:48:32 -07:00
Brandon Dayauon ea388ef77b Update creationFlag state only on non PSApp
Essentially reverting original change with the current test passing now.

bug: 401529887
Test: atest BubbleTextView
Flag: EXEMPT bug fix
Change-Id: Id12672cbdf66960915c4dcf75329f0c5df21ce4c
2025-03-11 16:03:52 +00:00
Stefan Andonian b7df497d94 Add TODO for PageIndicatorDots refactor.
Bug: 402258632
Test: Verified complilation works fine.
Flag: EXEMPT bug fix
Change-Id: I6ffffc07e06438f5c09d7e28e85fd479166bcc89
2025-03-10 19:12:19 -07:00
Shamali Patwa 7077e8d1c4 Merge "Fix flicker issue in widget picker with app activity in background" into main 2025-03-10 16:57:39 -07:00
Thu-Huong Vu 48dd9eee1c Register SimpleBroadcastReceiver permission.
Update SimpleBroadcastReceiver API to pass in broadcast permission and
register Growth Broadcast Receiver with permission to prevent other apps
from triggering Growth Nudge on their behalf.

Flag: EXEMPT add separately
Test: Manual
Bug: 397739323
Change-Id: I3a9d5e131ced752af0a1b35d400eed6d170fc81e
2025-03-10 23:29:33 +00:00
Sunny Goyal 42975c39db Making various model objects injectable
Bug: 361850561
Test: Updated tests
Flag: EXEMPT dagger
Change-Id: Ibb45b72c186e6aeeed7a37b0ae3f8083472019d7
2025-03-10 14:37:43 -07:00
Ahmed Fakhry 30d39caacb Merge "Propagate desks changes" into main 2025-03-10 14:06:52 -07:00
Charlie Anderson 24645d732c Merge "Make sure profile badging matches shape" into main 2025-03-10 12:54:31 -07:00
Treehugger Robot a4fc3ad45d Merge "Introducing a wrapper over binder to simplify lifecycle management for IPC" into main 2025-03-10 12:46:34 -07:00
Shamali Patwa 1027bb0419 Fix flicker issue in widget picker with app activity in background
When apps are being installed in background, the widgets maybe rebound;
similarly, when app activity e.g. messaging happens, sometimes
recommendations are regenerated and bound again.

For the widget section that is expanded, when recycling the displayed
table, we reuse the rows that didn't change.

For recommendations, we already make sure we don't change them when
unless mRecommendedWidgetsMap is reset - so this change just ensures to
additionally re-render only when conditions such as available space or
uiMode are changed.

Bug: 393080128
Fix: 393080128
Flag: EXEMPT BUGFIX
Test: Manual - reproduced the scenario mentioned above.
Change-Id: I46a564c3f7b75145dd168f7fb0b59c130540df78
2025-03-10 12:40:10 -07:00
Ahmed Fakhry 6a19fc0765 Propagate desks changes
This CL propagates desk changes events to `RecentTasksList` and
`RecentsView`.

Bug: 395908683
Test: m
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: I77457d5e2e66166dd8c7d6505317d9add5b886a2
2025-03-10 18:06:03 +00:00
Shamali Patwa af883adedc Merge changes from topic "flags-cleanup" into main
* changes:
  [Part 3] Clean up references for flags from past release.
  [Part 2] Clean up references for flags from past release.
  [Part 1] Clean up references to flags from past release.
2025-03-10 10:54:42 -07:00
Sunny Goyal 018356d3c3 Introducing a wrapper over binder to simplify lifecycle management for IPC
Fix: 400733213
Flag: NONE - release code
Test: manual
Change-Id: I5e143fce6a4cbc1dbb246bc6e0141ebbbc8bd274
2025-03-10 10:27:58 -07:00
Brian Isganitis 0dc5fac084 Merge "Animate changes in Taskbar recents indicators." into main 2025-03-07 14:47:08 -08:00
Charlie Anderson 567097eee8 Make sure profile badging matches shape
Bug: 398875512
Test: testing different shapes on work profile
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: I5cb9e629f711f2fc607ca646d82a8523c0b43d1b
2025-03-07 21:31:11 +00:00
Brian Isganitis 26f9468db1 Animate changes in Taskbar recents indicators.
Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Fix: 356394053
Test: go/testedequals
Change-Id: Ic018695254bbfea11469c3579e242089b00b90f5
2025-03-07 15:47:48 -05:00
Treehugger Robot b6001773da Merge "desktop-exploded-view: Launch desktop task view should reverse its exploded animation" into main 2025-03-07 11:45:18 -08:00
Treehugger Robot ae4a474e89 Merge "Modify logging to log the specifc grid size when taking a snapshot" into main 2025-03-07 11:29:18 -08:00