Commit Graph

20057 Commits

Author SHA1 Message Date
Treehugger Robot 59e208c28e Merge "Moving various launcher binding logic, outside LauncherModel" into main 2025-04-23 12:32:54 -07:00
Treehugger Robot ab4794a638 Merge "Fixing crashes due to code 1032 SQLITE_READONLY_DBMOVED" into main 2025-04-23 12:31:46 -07:00
Sunny Goyal 3678af5a81 Fixing crashes due to code 1032 SQLITE_READONLY_DBMOVED
1) Moving any DB file deletion before opening the DB to avoid deleting already opened file
2) Using a sandbox directory for BackupAndRestoreDBSelectionTest which can delete actively opened files causing other tests to fail

Bug: 403551539
Flag: EXEMPT bugfix
Test: Presubmit
Change-Id: Ib1088a0e486edf755e5f7dcd738eb835af78b4c4
2025-04-22 16:09:52 -07:00
Sunny Goyal c078d6554c Moving various launcher binding logic, outside LauncherModel
This brings the BgCallbacks closer to a repository pattern making is easier to switch eventually

Bug: 390572144
Flag: EXEMPT refactor
Test: Updated AsyncBindingTest to use real ModelCalbacks
Change-Id: I9c932b00ea8ac7330473b9c0f5d778453fe7a390
2025-04-22 14:12:17 -07:00
Anushree Ganjam 41998110bd Move FolderNameProvider to dagger.
Helps us to delete ResourceBasedOverride class.
Delete "folder_name_provider_class" resource from config.

Introduce FolderNameSuggestionLoader for easy dagger injection for
folderNameProvider.

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I58a68cb4ce11331458a1cccef2e692f74c14ea53
2025-04-22 19:31:51 +00:00
Anushree Ganjam 77f22bf9cf Merge "Move StatsLogManager to Dagger" into main 2025-04-21 18:48:56 -07:00
Treehugger Robot 5643f452d5 Merge "Merging update and modify model callbacks" into main 2025-04-21 15:15:13 -07:00
Sunny Goyal 007cfecf5e Merging update and modify model callbacks
Instead of the dispatcher specifying the type, the UI checks th diff. This
ensures that the UI is updated correctly in all paths

Bug: 390572144
Flag: EXEMPT refactor
Test: Manually verified folder edit path where these callbacks were getting dispatched

Change-Id: Ib73eed5da87a847753a78453a48ab4fc495c1199
2025-04-21 12:31:23 -07:00
Anushree Ganjam 291438aaec Move StatsLogManager to Dagger
Helps us to delete ResourceBasedOverride class.
Delete "stats_log_manager_class" resource from config.

Delete unused "app_launch_tracker_class" resource from config.

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger

Change-Id: I71ed7ffca62e7c74d4ee0d0b4c045ffed9599cfe
2025-04-21 19:13:22 +00:00
George Lin 196b901d68 Merge "Fix shape update unexpected (2/2)" into main 2025-04-21 05:20:26 -07:00
Treehugger Robot 4c4db8ceb5 Merge "Update home tappable insets when taskbar is shown on home" into main 2025-04-19 19:21:15 -07:00
Andy Wickham 1d04216b4f Merge "Fix navbar to home for All Apps." into main 2025-04-18 22:45:01 -07:00
Treehugger Robot bf044d730c Merge "Move InstantAppResolver to Dagger." into main 2025-04-18 18:06:15 -07:00
Treehugger Robot fede3aee46 Merge "Don't blur workspace targets when dragging out of All Apps." into main 2025-04-18 16:28:27 -07:00
Charlie Anderson 8ec6581db0 Merge "Update system shortcut icons to filled GM3 versions" into main 2025-04-18 13:20:51 -07:00
Anushree Ganjam 59d5401f59 Move InstantAppResolver to Dagger.
Helps us to delete ResourceBasedOverride class.

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I9320e0309e2ae4370dcbf2f6f62d704712876bd5
2025-04-18 20:14:14 +00:00
Charlie Anderson e2aa4dc71b Handle exception thrown for missing Component during restore
Bug: 400681403
Flag: EXEMPT bugfix
Test: presubmit
Change-Id: Ieb5357a7afa76b45aaa60a4c391e79d4a7196d98
2025-04-18 10:45:53 -07:00
Treehugger Robot 579672c0d8 Merge "Update All Apps colors to use shared sysui resources." into main 2025-04-17 20:00:20 -07:00
Fengjiang Li 924d6a8a6f [Taskbar] Remove uncessary threading check on LauncherModel.
The LauncherModel#addCallbacks() and #removeCallbacks() apis are thread safe due to synchronized(mCallbacksList). So there is no need to enforce main thread.

This CL will unblock taskbar per-window ui thread work.

Bug: 404636836
Test: presubmit
Flag: NONE - released code
Change-Id: Iccc3f6da12625305f8db7111226df6e923c1891e
2025-04-17 16:27:58 -07:00
Andy Wickham c626620f74 Don't blur workspace targets when dragging out of All Apps.
Sorry for the whack-a-mole here. The intention is to only blur
going to All Apps or returning from All Apps to Normal. Added some
tests to help prevent regressions.

Test: DepthControllerTest#test_blurWorkspaceDepthTargets
Flag: com.android.launcher3.all_apps_blur
Bug: NA (noticed locally from a recent cl)
Change-Id: Ib0285dae42c41ba9eb2e747b272d40c228e0b035
2025-04-17 21:00:21 +00:00
Andy Wickham 51a0a3829a Update All Apps colors to use shared sysui resources.
This includes the new scrim color and panel treatment documented
here: https://docs.google.com/presentation/d/1BKFfB2LAIDoaA5aLs8did6IcUw_pktrSWI5xmypkl3s/edit?slide=id.g3484dcfffc6_1_203&resourcekey=0-HpXwztiEYGe0BYQzUeBBbQ#slide=id.g3484dcfffc6_1_203

Bug: 371343636
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: I810aaa84eda218ab33112c9a5c1561cdb088b310
2025-04-17 19:14:18 +00:00
Sunny Goyal 54e5ed0d36 Creating a dumpmanager class to allow dumping state from singleton objects
Bug: 410927105
Flag: EXEMPT refactor
Test: atest DumpManagerTest
Change-Id: Idcd1c74b1edf7a79ec8e4fa91676e617afa04907
2025-04-17 11:05:20 -07:00
Alex Chau bb5958ec48 Merge "Clean-up enableDesktopWindowingCarouselDetach and refactor detachDesktopCarousel" into main 2025-04-17 07:04:21 -07:00
Alex Chau e4413f929d Clean-up enableDesktopWindowingCarouselDetach and refactor detachDesktopCarousel
- Removed enableDesktopWindowingCarouselDetach flag
- detachDesktopCarousel is now always false, except in home quick switch (QuickSwitchState)
- Updated home quick switch controller NoButtonQuickSwitchTouchController to apply DESKTOP_CAROUSEL_DETACH_PROGRESS

Fix: 411127271
Test: manual
Flag: EXEMPT flag cleanup and refactor
Change-Id: I1cbf0987b111d0111cb8b9b6c7994f4494780e1a
2025-04-17 05:08:41 -07:00
Anushree Ganjam cf00d63c2e Merge "Introduce "qsb_container_hotseat" layout to override the existing search_container_hotseat." into main 2025-04-16 22:44:12 -07:00
Treehugger Robot 73779be7cd Merge "Change the handling of shouldBlurWorkspace in LauncherState." into main 2025-04-16 22:09:21 -07:00
Andy Wickham e3371d32f5 Change the handling of shouldBlurWorkspace in LauncherState.
Previously: blur if previous and next state want it blurred.
New: blur if previous OR next state want it blurred.

As part of this, change the default from true to false. Only All
Apps currently sets it to true, meaning we blur workspace only
going to or from All Apps.

Fix: 405836159
Test: Launch app, quickly go home and to All Apps
Flag: com.android.launcher3.all_apps_blur
Change-Id: Ic52c5aa2dce7e1e107418952031574bc2e47e585
2025-04-17 02:31:50 +00:00
Andy Wickham f0d3ce8bfd Fix navbar to home for All Apps.
It reuses the predictive back animation now. In addition, if All
Apps entered directly into the Search state (i.e. via QSB), the
back gesture now scales the whole panel to indicate it will close
and return to the home screen (as opposed to closing Search within
All Apps).

Demo: https://drive.google.com/file/d/1wpaZg3JaSxDMMc62uU-1miP9RaIO10EB/view?usp=drive_link&resourcekey=0-h8qKzuDguwIE2vUDr0H6lQ

Fix: 406523972
Flag: EXEMPT bugfix
Test: Manual
Change-Id: I470d67e03b2d8bbbaa39aea76c7dde639cff62f5
2025-04-16 18:58:47 -07:00
Treehugger Robot 2711f8d0d9 Merge "Removing flag enable_smartspace_removal_toggle" into main 2025-04-16 18:57:40 -07:00
Jeff DeCew 9593f2b612 Merge "Set shouldForceThemeIcon = true in ThemeManager" into main 2025-04-16 18:16:17 -07:00
Treehugger Robot 8a45dc2cd1 Merge "Make static DisplayController methods respect display id" into main 2025-04-16 17:10:04 -07:00
Anushree Ganjam 87603a10e8 Introduce "qsb_container_hotseat" layout to override the existing search_container_hotseat.
This layout is no-op in AOSP.

Bug: 405166827
Test: Manual
Flag: com.android.launcher3.enable_qsb_on_hotseat
Change-Id: Ief142c3c141a672c5a4c53814b7901ff322ed053
2025-04-16 22:21:50 +00:00
Anushree Ganjam f6d039c9ab Remove flag "enable_shortcut_dont_suggest_app" since it's eligible to be removed.
Bug: 409611054
Test: Presubmit, Verified "Don't suggest app" shortcut works fine for predicted apps.
Flag: EXEMPT Flag removal
Change-Id: Icb92f3519760ad0dc27e10d9690505c737b9dd25
2025-04-16 18:16:39 +00:00
George Lin fa2c9ab00b Fix shape update unexpected (2/2)
1. Fix shape update unexpected after updating grid
2. Fix grid apply not updated after clicking

Test: Manually tested. See bug.
Bug: 409895694
Flag: com.android.systemui.shared.new_customization_picker_ui
Change-Id: Iad1b29b222adf1a0ed5a73b53b72b4dcf979e335
2025-04-16 18:11:24 +00:00
Sunny Goyal 613db2b609 Removing flag enable_smartspace_removal_toggle
Test: Presubmit
Flag: EXEMPT cleanup
Bug: 303471576
Change-Id: Iae8cc3afbf15c66612589fd1e19377e4339af7fc
2025-04-16 10:54:45 -07:00
Treehugger Robot a9bb3b53a5 Merge "Adds Blur and BlurFallback styles for All Apps." into main 2025-04-16 10:21:48 -07:00
Will Osborn 7efffe621a Make static DisplayController methods respect display id
Bug: 404854138
Test: local + presubmits
Flag: com.android.launcher3.enable_overview_on_connected_displays
Change-Id: Ica46a400101b1b0126355ef842ca5d8b9be20306
2025-04-16 13:45:29 +00:00
Treehugger Robot 71981575d0 Merge "Remove flag private_space_app_installer_button." into main 2025-04-16 02:12:23 -07:00
Ioana Alexandru a58f02bcec Set shouldForceThemeIcon = true in ThemeManager
This is now preferred over a boolean config value.

Bug: 406507218
Test: manual
Flag: EXEMPT minor change
Change-Id: I3c6f359d7eb78784ea4c9a9f462bc6a6f1914bb6
2025-04-16 09:03:13 +02:00
Holly Sun bd5c455302 Remove flag private_space_app_installer_button.
Bug: 409610010
Test: verified PS app install button stills works
Flag: EXEMPT flag removal
Change-Id: I7fd606ab0fd939bcb1202861d89c3996b241c105
2025-04-15 20:45:59 -07:00
Treehugger Robot 8fc4228087 Merge "When only folder page indicator is visible, set gravity to End." into main 2025-04-15 19:44:46 -07:00
Andy Wickham 16a024df71 Adds Blur and BlurFallback styles for All Apps.
Technically these styles can be used throughout Launcher, e.g.
Widget Picker and Folders, but this CL only applies it to All Apps.

At a high level, views wishing to apply transparency to show blur
should use these new attr values rather than colors directly.

When blur changes, e.g. starting or stopping battery saver, the
style is re-applied and revelant views are invalidated. For
Launcher, this is handled by DepthController, and for Taskbar it's
handled by a CrossWindowBlurListener.

Also updated the Private Space animation slightly to account for
the translucent decorators (specifically, we can't use the mask
view to cover them when blur is enabled).

Screenshots: https://drive.google.com/drive/folders/1tU472KHotgEBpT-Ec9VOBWPBf_YdVqv2?resourcekey=0-ebf7W8O6iDJ4UVMtRzTABg&usp=sharing
Private Space animations: https://drive.google.com/file/d/1h5pn8Xb17TPcbujr7uSAJNTq8kwNZoIp/view?usp=drive_link&resourcekey=0-TzpaJ16Gg8_QJctBx4oiIg
Private Space QS Tile animations: https://drive.google.com/file/d/1dCuqnqd5z2kSBEakGobMlEkMwFDBWRbJ/view?usp=drive_link&resourcekey=0-qRVFPb-a6OzaZQOf4x86Jw

Bug: 371343636
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: Ia9f581f50d1adc0830569656bdeb751deb710a9c
2025-04-15 16:42:56 -07:00
Adnan Begovic 315625af9f Merge changes Id4127db3,I6359adc1 into main
* changes:
  launcher3: Expose coroutine contexts from concurrency module.
  launcher3: Use @UiExecutor within ThemeManager.
2025-04-15 12:48:23 -07:00
Shamali Patwa 79563b3d77 Merge "Add accessibility actions for "REMOVE", "UNINSTALL" & "Widget Settings"" into main 2025-04-15 12:07:37 -07:00
Stefan Andonian 060b364718 When only folder page indicator is visible, set gravity to End.
Bug: 394355070
Test: Verified locally that indicator dots are not cut off with 6 pages.
Flag: com.android.launcher3.enable_launcher_visual_refresh
Change-Id: I1804cc7b8de032415cb8fe557a0e98a8f4acb5cd
2025-04-15 11:31:50 -07:00
Li Lin 64d6a14386 Merge "Add Growth Framework nudge view." into main 2025-04-15 09:31:58 -07:00
Adnan Begovic ee79e0f5d2 launcher3: Use @UiExecutor within ThemeManager.
Use the provided @UiExecutor within the ThemeManager
instead of referencing the MAIN_EXECUTOR directly.

Bug: 407593767
Test: ThemeManagerTest
Flag: NONE - new module
Change-Id: I6359adc1308bdb209dcf6c6e1c2d3fc7f4438585
2025-04-15 09:04:44 -07:00
Shamali P a8afda25da Add accessibility actions for "REMOVE", "UNINSTALL" & "Widget Settings"
Bug: 279800472
Flag: EXEMPT BUGFIX
Test: Talkback & VoiceAccess
Change-Id: I78387020cf23910fad5f7b98f9501bc1eb410a72
2025-04-15 15:05:52 +00:00
Charlie Anderson c77791ba2e Update system shortcut icons to filled GM3 versions
Flag: com.android.launcher3.enable_launcher_visual_refresh
Bug: 364950287
Test: manually and popup screenshot tests

Change-Id: I5e4c964b60a4254f9f67c8128e23f5b04b621541
2025-04-15 06:48:22 -07:00
Treehugger Robot bb2b582e7f Merge "Injrect WindowContext into RecentsWindowManager" into main 2025-04-15 02:22:07 -07:00