Commit Graph

20057 Commits

Author SHA1 Message Date
Charlie Anderson ee78d44eb2 Merge "Fixing polish issues with the U app shortcut popup design" into main 2023-11-08 18:08:30 +00:00
Jordan Silva 376036a36e Resize icon and text size for AllApps when it doesn't fit the cell
Bug: 287975993
Fix: 309489796
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: DeviceProfileDumpTest
Test: DeviceProfileResponsiveDumpTest
Test: ResponsiveHomeScreenImageTest
Test: ResponsiveFolderImageTest
Test: ResponsiveAllAppsImageTest
Change-Id: I1dda073b558a7f4540d5fe5c438fa796a70b6ddd
2023-11-08 18:05:59 +00:00
Thales Lima 55fcfacd1a Merge "Center AllApps on the screen" into main 2023-11-08 18:02:16 +00:00
Thales Lima d94993ed9e Merge "Use new icon stepping logic for Folders" into main 2023-11-08 15:50:41 +00:00
Thales Lima a25cd90b5e Center AllApps on the screen
AllApps used workspace paddings which are unbalanced in verticalBar. This changes it to always be centered. In dynamic grid AllApps now uses the whole width for the layout. In responsive grid it keeps the cell width and center the layout.

Note that this is centered on the screen but nothing could be done regarding the camera inset at this time, as it would need a refactor of how AllApps QSB is layout as well.

Bug: 269632571
Test: NexusLauncherTest
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Change-Id: I326d041bcef211d398d1a5c3210958b689414d49
2023-11-08 14:39:52 +00:00
Jordan Silva 72bc6f53f7 Merge changes from topic "comet-landscape" into main
* changes:
  Update Responsive Grid tests with aspect ratio group
  Refactoring Responsive Grid XML specs for more flexibility
2023-11-08 11:16:21 +00:00
Sebastián Franco 5054899552 Merge "Moving some constants in Launcher.java to a separate file for ease of readability" into main 2023-11-07 21:22:11 +00:00
Federico Baron 8bd0aac27f Merge "Remove white background from shortcuts in widget picker" into main 2023-11-07 16:53:53 +00:00
Sebastian Franco 974cc94839 Moving some constants in Launcher.java to a separate file for ease of readability
Part of  go/launcher_SoR

Flag: N/A
Bug: 306465626
Test: compiling, no-op change
Change-Id: I5ea40acb2ba1ea5840021e297516a511b032a043
2023-11-07 10:12:26 -06:00
Jordan Silva f2402e25f1 Refactoring Responsive Grid XML specs for more flexibility
It merges portrait and landscape XML specs for responsive grid. This update allows the responsive grid to rely on other properties like aspect ratio and not solely the orientation from resource qualifiers.

Bug: 299889733
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: CalculatedAllAppsSpecTest
Test: CalculatedFolderSpecTest
Test: CalculatedHotseatSpecTest
Test: CalculatedWorkspaceSpecTest
Test: AllAppsSpecsTest
Test: FolderSpecTest
Test: HotseatSpecsTest
Test: WorkspaceSpecsTest
Change-Id: I39ee54d49c9d2a54fcbe91c8a1327a21a8126032
2023-11-07 11:51:28 +00:00
Himanshu Gupta 7d56e6ea23 Merge "Adding Prework for Private Space integration in Launcher" into main 2023-11-07 08:45:41 +00:00
Catherine Liang 7059799ac6 Merge "Update launcher preview icons on themed icon update" into main 2023-11-06 19:08:10 +00:00
Andreas Agvard d103d230a9 Merge "Enabled haptics during long press nav handle" into main 2023-11-06 08:40:58 +00:00
Himanshu Gupta 9aab4d4603 Adding Prework for Private Space integration in Launcher
This Cl adds the following:
1. Fixes for Quite Mode check maintained by Launcher
2. Addition of new Quite Mode broadcasts
3. Fixes for determining work profile user correctly.

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I5f6158b213723339e70ff99e66c5f439f5879e12
2023-11-05 12:31:10 +00:00
Andy Wickham 402ca3e3e5 Merge "Add animateNavBarLongPress to SystemUiProxy and ANIMATE_LPNH flag" into main 2023-11-04 19:57:39 +00:00
Thales Lima e9b5e14a2b Use new icon stepping logic for Folders
Bug: 307694237
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: ResponsiveFolderImageTest
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Change-Id: Ifbfb714e48c2e0851ef55ac60cadafbb6358d074
2023-11-04 17:10:13 +00:00
Andreas Agvard cb016243c7 Enabled haptics during long press nav handle
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT ENABLED
Test: Manual
Bug: 303023676
Change-Id: Ia792fc6d00bf06320f51d56c43ed59c6dd23d456
2023-11-03 23:44:13 +01:00
Andreas Agvard 15ddc16b53 Merge "Tweak lpnh haptics based on UX input" into main 2023-11-03 22:41:02 +00:00
Priyanka Advani ebc9a3b5e1 Merge "Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."" into main 2023-11-03 22:10:27 +00:00
Priyanka Advani 9aed56096c Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."
Revert submission 24877128-cherrypick-tapl-transient-swipe-owubvwrsw6i

Reason for revert: Likely culprit for b/309158105

Reverted changes: /q/submissionid:24877128-cherrypick-tapl-transient-swipe-owubvwrsw6i

Change-Id: I8ee560f7e599bcfde09eff53f049309ba25ce77f
2023-11-03 21:31:45 +00:00
Pat Manning 89bd90927d Merge "Fix focus navigation of All Apps when using external keyboard." into main 2023-11-03 18:42:37 +00:00
Tony Wickham 075a67da15 Merge "Change TAPL to swipe to stash taskbar (instead of deprecated long press)" into main 2023-11-03 18:35:54 +00:00
Kevin Lim ab242020a2 Merge "[Settings] Remove logic to restore highlight to 0th item in SettingsActivity." into main 2023-11-03 18:12:09 +00:00
Charlie Anderson a2d85dec47 Fixing polish issues with the U app shortcut popup design
Test: locally verified against design
Flag: NONE
Bug: 304807548

Change-Id: Iff22b3515b638700fb66e856944ec4aa1287e401
2023-11-03 11:46:44 -04:00
Andreas Agvard 3221a9235f Tweak lpnh haptics based on UX input
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT DISABLED
Test: Manual
Bug: 303023676
Change-Id: I7c96ac82358059418665dfe569705e745da7b1d8
2023-11-03 14:11:41 +01:00
Michael Stokes f5a83e56e0 Merge "Revert "Fix the badge in badge (triple badging), by simply remov..."" into main 2023-11-03 12:36:10 +00:00
Uwais Ashraf b965427554 Revert "Fix the badge in badge (triple badging), by simply remov..."
Revert submission 24721954-cherrypick-removeBadgeInBadge-dia2ji7r7td

Reason for revert: Breaking tests

Reverted changes: /q/submissionid:24721954-cherrypick-removeBadgeInBadge-dia2ji7r7td

Change-Id: Ia78cbae76d52b52fdfdc258311712f44bd645f2e
2023-11-03 12:20:33 +00:00
Catherine Liang d64230f449 Update launcher preview icons on themed icon update
Flag: NA
Bug: 300257098
Test: manually verified
Change-Id: Ic34cdce3021d8fcc97c153671bd1f05013933b6d
2023-11-03 11:40:02 +08:00
Jagrut Desai 2d9f2c1cec Merge "Animate aways Notification Dots for Taskbar Pinning Annimation" into main 2023-11-03 02:02:49 +00:00
Jagrut Desai 61526a7413 Merge "Improvements to TaskbarDividerPopupView" into main 2023-11-03 02:02:28 +00:00
Jagrut Desai 47bf322e21 Animate aways Notification Dots for Taskbar Pinning Annimation
Test: Manual
Bug: 308460959
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: Ic16881c05c70ed717dc63131d94ece805c39f6fc
2023-11-02 17:39:37 -07:00
Jagrut Desai 9af2084a56 Improvements to TaskbarDividerPopupView
- Close Animation improvement for popup.
- Popup location changed to  16dp above the taskbar view.
- Support for disabled state when user is in 3-button mode. (design changes to come in separate cl)

Test: Manual
Bug: 265170176
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: I9c91e6eb2b29c85433ba1c3d34505f0519448a6f
2023-11-02 17:24:50 -07:00
Tracy Zhou de8e25cf11 [Trackpad] Do not reverse two-finger gestures on the homescreen when reverse scrolling is on
- Swipe up to pull up all apps
- Swipe down to pull down notifications
- Same gesture to close in reverse scrolling mode

Bug: 301966246
Bug: 301966690
Test: manual
Change-Id: Ia3770ce8b279d24b2de4844f441f14e0feaf57c7
2023-11-02 12:30:50 -07:00
Federico Baron 0282c107fa Merge "Fix page indicator bugs for foldable" into main 2023-11-02 17:34:18 +00:00
Brandon Dayauon 2424d48867 Merge "Fix the badge in badge (triple badging), by simply removing the user badge (FLAG_SKIP_USER_BADGE)." into main 2023-11-02 15:27:11 +00:00
Tony Wickham eccf070bae Change TAPL to swipe to stash taskbar (instead of deprecated long press)
This also means Taskbar is transient by default in automated tests,
instead of persistent. Updated some checks accordingly.

Flag: LEGACY ENABLE_TRANSIENT_TASKBAR ENABLED
Test: TaskbarExpandCollapse#hideShowTaskbar; TaplTestsTaskbar;
TaplTestsTransientTaskbar; TaplTestsPersistentTaskbar
Bug: 270395798

Change-Id: Ib6e592a31a55a912a7ea991a421a9c60bca51c80
2023-11-01 23:16:10 +00:00
Kevin Lim a8ada5314c [Settings] Remove logic to restore highlight to 0th item in
SettingsActivity.

Bug: b/303787732
Flag: NONE
Test: Manual: http://recall/clips/9504ce89-ec62-4b32-b43e-0740300f872f
Change-Id: I47e55811637ff2d7fff996b19ad7af867a1307ba
2023-11-01 22:28:46 +00:00
Jagrut Desai 1e63858559 Merge "Turn on TASKBAR_PINNING for TEAMFOOD" into main 2023-11-01 22:06:31 +00:00
fbaron 95ed863d96 Fix page indicator bugs for foldable
There are bugs when unfolding the felix device where the page indicator will appear in the wrong place, and have to animate all the way back to where it should go. This was originally fixed with ag/24399441 but it seems that the issue is still happening when flag FOLDABLE_SINGLE_PAGE is off. Here we fix that issue..

Fix: 294231977
Fix: 291822492
Flag: NONE
Test: n/a
Change-Id: I6ae97ebbb034f5b520a4f5ace729b44b89ea73a0
2023-11-01 14:19:07 -07:00
Thales Lima 9623aaa470 Merge "Change AllApps padding to use a Rect" into main 2023-11-01 12:21:53 +00:00
Andy Wickham 24a50df135 Add animateNavBarLongPress to SystemUiProxy and ANIMATE_LPNH flag
Bug: 306400785
Bug: 308693847
Test: Manual
Flag: LEGACY ANIMATE_LPNH TEAMFOOD
Change-Id: I996c923e5a1949e6219f900da12e2b5091597750
2023-10-31 23:45:12 -07:00
Stefan Andonian 7117c55578 Merge "Robustly fixed issue where migration from different versions of DB data tables was causing crashes upon grid size switching." into main 2023-10-31 22:44:06 +00:00
Stefan Andonian e8b86db34d Robustly fixed issue where migration from different versions of DB data
tables was causing crashes upon grid size switching.

Bug: 304687723
Test: Verified behavior through unit test. Also manually tested that
factory resetting device -> adding shortcuts to the workspace ->
changing the grid size didn't cause any issues and resulted in normal
behavior.

Change-Id: I1945004d2c9a2d6f2b74d9597b39763ed4962e7b
2023-10-31 20:27:26 +00:00
Himanshu Gupta 510fa88571 Merge "Adding support for private/clone profile badge in Launcher3." into main 2023-10-31 16:28:40 +00:00
Thales Lima b433c9c312 Change AllApps padding to use a Rect
AllApps uses different values for left and right padding in some places (e.g. ActivityAllAppsContainerView uses workspacePadding.left/right), and this change is the first step into moving those values into DeviceProfile.

Bug: 269632571
Test: NexusLauncherTest
Flag: NONE
Change-Id: I14c4edf55ca74f256b1aaa336fff246a0c78e25d
2023-10-31 16:19:40 +00:00
Pat Manning b53d8d6360 Fix focus navigation of All Apps when using external keyboard.
- All apps icons do not show the focus rectangle when focused as mIconFocusListener is null in BaseAllAppsAdapter when onCreateViewHolder is called.
- All apps recyclerview does not scroll down when focus goes from top to bottom of list, as AllAppsToastUiDelegate calls hideKeyboard which clears focus.
- Focus goes behind AllApps into hotseat, so update hotseat setDescendantFocusability.

Flag: NONE
Fix: 296844600
Test: TaplKeyboardFocusTest
Change-Id: I65f6fbb6f4df0be4b4ff922dda267d27da16effe
2023-10-31 13:47:12 +00:00
Himanshu Gupta 6e030348dd Adding support for private/clone profile badge in Launcher3.
Bug: 289224457
Flag: None
Test: Flash on device and Presubmit
Change-Id: Icebb5b5129a2f0d909481f00d51e047431a23a15
2023-10-31 07:46:34 +00:00
Ats Jenk 866e77101c Merge "Use aconfig flag for desktop mode" into main 2023-10-31 05:07:02 +00:00
Sunny Goyal 24e738e872 Merge "Removing some dependencies on Activity" into main 2023-10-30 22:50:19 +00:00
Jagrut Desai 0dbc0d0285 Turn on TASKBAR_PINNING for TEAMFOOD
Test: Presubmit
Bug: 265437087
Flag: LEGACY ENABLE_TASKBAR_PINNING TEAMFOOD
Change-Id: I13e7e5b96323a3b10d930a053fbeca7023cbba5f
2023-10-30 12:24:50 -07:00