Commit Graph

20057 Commits

Author SHA1 Message Date
Pat Manning d3f3308d12 Merge "Update Icon App Chip Menu to new specs." into main 2023-11-17 15:06:42 +00:00
Andreas Agvard ef8df12ff8 Merge "Makes deep press for LPNH toggelable" into main 2023-11-17 07:51:16 +00:00
Sebastian Franco 50b74c341a Moving bindSmartspaceWidget to ModelCallbacks
Changes are part of go/launcher_SoR .

Flag: NA
Bug: 301108526
Test: This is a no-op change, compiling should be the test
Change-Id: I960cb767e3c4db4a952e019ee489ec1611e2dbd2
2023-11-16 17:18:06 -06:00
Sunny Goyal 2e005e1e28 Removing unused title change logic in settings
Bug: 305084752
Test: Manual
Flag: N/A
Change-Id: I93e8a58c579223d5892528a47cff5bcafd69dbf1
2023-11-16 12:54:19 -08:00
Jordan Silva 9a3bd8f109 Fix folder label text size not downsizing to match app icon
Fix: 311350985
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: ResponsiveFolderImageTest
Change-Id: I98103749541dd1e120908ac06e24dfc38cc7aa59
2023-11-16 18:34:35 +00:00
Pat Manning 43c4b50c17 Update Icon App Chip Menu to new specs.
Fix: 304228083
Test: TaplOverviewIconAppChipMenuTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu DEVELOPMENT

Change-Id: Ib018c7f59e1141b6f21618b28d411facc937ac7c
2023-11-16 18:18:48 +00:00
Sebastián Franco 9739ad2ec8 Merge "Modify getViewsIntersectingRegion to returns rects instead of view since we don't use the views after only the rects." into main 2023-11-16 17:48:02 +00:00
Andreas Agvard 0fc7d52863 Makes deep press for LPNH toggelable
By default when deep press is detected (https://developer.android.com/reference/android/view/MotionEvent#CLASSIFICATION_DEEP_PRESS)
during LPNH triggers the long press action immediately. This change makes this toggelable.

Flag is set to enabled by default, which leads to the default behavior.

Fix: 310952290
Test: Manual
Flag: LEGACY ENABLE_LPNH_DEEP_PRESS ENABLED
Change-Id: I970fed697979ee528e54b8be0139d842f3a64c43
2023-11-16 17:55:34 +01:00
Sebastian Franco 5c8f86815c Modify getViewsIntersectingRegion to returns rects instead of view since we don't use the views after only the rects.
Intermidiate step for b/270395274

Bug: 270395275
Flag: NA
Test: ReorderAlgorithmUnitTest
Test: atest ReorderWidgets
Change-Id: I505372ccd61e954de19852427abe0b54fc06aa57
2023-11-16 10:32:51 -06:00
Sebastián Franco da18b9e435 Merge "Use the number of shown hotseat icons instead of database items to store into the DB" into main 2023-11-16 15:33:51 +00:00
Andreas Agvard f2f026ba26 Fixed incorrect naming of flags
Bug: 309972570
Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT ENABLED
Change-Id: Ie493e03c7e80fe0697e46dc02e9abaf1906aded4
2023-11-16 14:39:05 +01:00
Sebastian Franco 2d023e26c6 Use the number of shown hotseat icons instead of database items to store into the DB
It seems this issue was originated from ag/14129534 and we should no
longer use numDatabaseHotseatIcons form IDP and use numShownHotseatIcons
from the DP.

Fix: 305119735
Flag: NA
Test: manuall testing, we don't have this test for landscape
Change-Id: Ie530748f9b77d89ac3298c187ae767643d505cb3
2023-11-15 21:34:38 -06:00
Hyunyoung Song 647be66c38 Merge "Enabling Private Space Container in Launcher." into main 2023-11-15 23:14:34 +00:00
Fengjiang Li 1da44348cf Merge "Add unit test for RecentsAnimationDeviceState.java" into main 2023-11-15 23:05:32 +00:00
Anushree Ganjam f6e1c01b6b Merge "Move the cursor to the end of the text in edit text." into main 2023-11-15 22:57:26 +00:00
Anushree Ganjam c3bf394009 Move the cursor to the end of the text in edit text.
Before fix: https://b.corp.google.com/issues/301625831#comment9

After fix: https://b.corp.google.com/issues/301625831#comment10

Bug: 301625831
Test: Manual
Flag: NA, Fixing for hardware keyboard.
Change-Id: I817836a0a76b8677eb65c65720f436882fe6431f
2023-11-15 13:31:26 -08:00
Fengjiang Li b3007a9e3d Add unit test for RecentsAnimationDeviceState.java
Bug: 299466828
Flag: N/A
Test: test device boot without issue
Change-Id: Iaa1a7cff547e03eaacc950702c2e7cd34846e987
2023-11-15 13:01:51 -08:00
Holly Sun d670f3032f [ps] Add helper function to scroll a recycler view to bottom and resetAndScrollToPrivateSpace.
Bug: 309522136
Test: manual
Flag: ACONFIG com.google.android.apps.nexuslauncher.inject_private_space_tile DEVELOPMENT
Change-Id: I96a1eed97dd1e4626ddc5ad42c029d94eb174f00
2023-11-15 10:33:22 -08:00
Andreas Agvard 0b78b488a7 Merge "Enables server side control of search hint haptic parameters" into main 2023-11-15 17:38:38 +00:00
Andreas Agvard b36bcff974 Enables server side control of search hint haptic parameters
Fix: 309972570
Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT ENABLED
Change-Id: I342a86546601b092b6eb40b8d00d94ee4cf1127a
2023-11-15 17:23:40 +00:00
Himanshu Gupta 739b3c9f22 Enabling Private Space Container in Launcher.
This CL adds the following:
1. Adds filtering and addition of Private Profile apps in main user
all apps recycler view
2. Enables decoration of Private Profile apps
3. Enables hiding Private Space container based upon a settings entry.

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I33dc55a3a39e75d3fc336ca6a488b282e2dd322c
2023-11-15 15:08:59 +00:00
Alex Chau 013af87a10 Merge "Use WindowConfiguration to match DeviceProfile in IDP.getDeviceProfile" into main 2023-11-15 10:06:53 +00:00
Tracy Zhou 3c08695e6e Fix wrong TOUCHPAD_NATURAL_SCROLLING setting string
Bug: 301966246
Bug: 301966690
Test: manual
Change-Id: I535e451293c50c3c7a09ca2641092a181deda922
2023-11-14 21:44:02 -08:00
Tracy Zhou bf021974f4 Merge "[Trackpad] Do not reverse two-finger gestures on the homescreen when reverse scrolling is on" into main 2023-11-15 02:22:20 +00:00
Holly Sun 38c0102aef [a11y] Fix Switch Access keyboard input issue in AA+.
See https://buganizer.corp.google.com/issues/308704236#comment7. The issue is only reproducible when "Swipe up to start search" is OFF.

Video: https://drive.google.com/file/d/14ONBHL-qK3xaDWVruSMdQXWRGisyBSc2/view?usp=sharing

Bug: 308704236
Flag: NA
Test: manual
Change-Id: If84c1fcdb65add658022520018e34ad958be6bc2
2023-11-14 14:31:34 -08:00
Schneider Victor-tulias d58c0dbdca Merge "Clean up NPEs in AbsSwipeUpHandler" into main 2023-11-14 18:49:50 +00:00
Alex Chau c09a98a87d Use WindowConfiguration to match DeviceProfile in IDP.getDeviceProfile
- Also fix WindowBounds.isLandscape to use full display bounds to determine isLandscape, otherwise both orientation will be treated as isLandscape when using availableSize

Bug: 309801705
Test: manual and presubmit
Flag: NONE
Change-Id: Ic7f4235e620d4760a9af356f23066fe5b23304e6
2023-11-14 18:38:51 +00:00
Himanshu Gupta 775f5ca9c6 Merge "Adding Private Space views to Launcher." into main 2023-11-14 18:33:42 +00:00
Schneider Victor-tulias 3b9d80d2d8 Clean up NPEs in AbsSwipeUpHandler
AbsSwipeUphandler has many potential and common NPEs. Added more null checks to AbsSwipeUpHandler

Flag: N/A
Fixes: 295905702
Fixes: 309535060
Test: StartLauncherViaGestureTests, quick switched and launched app from recents
Change-Id: I11f62eac423ae3c5792ce97ca49963f1e005b289
2023-11-14 10:48:10 -05:00
Jordan Silva 646c95e643 Merge "Fix wrong number of columns for AllApps calculation" into main 2023-11-14 14:35:00 +00:00
Himanshu Gupta 08badb3f6f Adding Private Space views to Launcher.
This CL adds the following:
* Static View Elements to be added to AllApps recycler View
* View Controller to load the above elements dynamically
* Private Space Section Decorator
* PrivateProfile Manager containing the logic related to Private Space
* Abstract UserProfileManager as the super class of Work/Private
ProfileManager

Private Space Views Figma
[link](https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?type=design&node-id=14535-111985&mode=design&t=JLz9W0O551TpzQYH-0)

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I8aa4247c78064a551e5e0d0b46d3fc033873f99d
2023-11-14 11:58:16 +00:00
Jordan Silva 8b3fa14ef9 Fix wrong number of columns for AllApps calculation
Fix: 310657769
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: DeviceProfileDumpTest
Test: DeviceProfileResponsiveDumpTest
Change-Id: Id46c9e4529176b68f6d92d31a71016ed4f8134d1
2023-11-14 10:37:32 +00:00
Luca Zuccarini a3b8854951 Merge "Refine way to trigger the keyboard for a controlled insets animation." into main 2023-11-14 08:23:22 +00:00
Luca Zuccarini 6ab61069f3 Refine way to trigger the keyboard for a controlled insets animation.
Before we did it as normal just without requesting focus. However, we
also need to not log the new state, as this must happen only after the
controlled animation has completed (or been cancelled).

Bug: 309756056
Flag: NA
Test: manual
Change-Id: I7f1564d2b29d91c9fdb0afce586fe5cc1148bac0
2023-11-14 08:20:40 +00:00
Tracy Zhou 859edd00e9 Migrate ENABLE_SPLIT_FROM_FULLSCREEN_WITH_KEYBOARD_SHORTCUTS to aconfig
Bug: 270394122
Test: N/A
Change-Id: I9bacd906099518b4a4c43a9f80ab0c753beac89a
2023-11-13 13:12:09 -08:00
Jagrut Desai bd997801e9 Merge "Migrate ENABLE_TASKBAR_PINNING to aconfig flag" into main 2023-11-13 20:13:15 +00:00
Jordan Silva 1fb00ea561 Merge "Responsive grid cleanup" into main 2023-11-13 15:03:29 +00:00
Pat Manning da5baa981a Merge "Fix focus nav of AllApps when Searching." into main 2023-11-10 18:20:01 +00:00
Pat Manning e7cb65009e Fix focus nav of AllApps when Searching.
- Do not focus the Icon in Small Icon Result Rows
- Use FocusIndicatorHelper when focusing search result icons

Flag: NONE
Bug: 296844600
Fix: 310173226
Test: Test: TaplKeyboardFocusTest
Change-Id: Icfc82ae41ffc8ef7c7ad42950f98f3d2dc805795
2023-11-10 16:48:21 +00:00
Jagrut Desai 90dd098c85 Migrate ENABLE_TASKBAR_PINNING to aconfig flag
Test: Manual, Presubmit
Bug: 265437087
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I4800230c04feceefa2398e189c493c8c4a7b2fe5
2023-11-09 23:20:03 +00:00
Anushree Ganjam af4f41b9dc Merge "Hide overlay if the overlay was shown when Meta key is tapped." into main 2023-11-09 22:14:41 +00:00
Jordan Silva 8f7986abae Responsive grid cleanup
This CL renames some of the variables to keep it consistent across the code. It removes workarounds that were made to facilitate easy code reviews without breaking the tests.
It is a cleanup of the responsive grid feature.

Bug: 299889733
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: CalculatedAllAppsSpecTest
Test: CalculatedFolderSpecTest
Test: CalculatedHotseatSpecTest
Test: CalculatedWorkspaceSpecTest
Test: AllAppsSpecsTest
Test: FolderSpecTest
Test: HotseatSpecsTest
Test: WorkspaceSpecsTest
Change-Id: I198fadfbcfc0d1b32a62a3076949b42ee1fbcf33
2023-11-09 22:06:03 +00:00
Jordan Silva 767d484b27 Merge "Resize icon and text size for AllApps when it doesn't fit the cell" into main 2023-11-09 20:24:38 +00:00
Tracy Zhou d66d114944 Merge "Make enableTaskbarNoRecreate() depend on ENABLE_TASKBAR_PINNING and ENABLE_TASKBAR_NAVBAR_UNIFICATION" into main 2023-11-09 18:47:59 +00:00
Federico Baron b2cb1f87b7 Merge "Folder preview work badge theming fix" into main 2023-11-09 17:35:48 +00:00
Vadim Tryshev 572b5b09fd Merge "Allowing ACTION_CANCEL events to come from device 0" into main 2023-11-09 01:42:16 +00:00
Anushree Ganjam b736982bab Hide overlay if the overlay was shown when Meta key is tapped.
Before fix : https://b.corp.google.com/issues/300492676#comment13
When Meta key is tapped in -1 screen, the toggleAllAppsFromIntent is called and
AllApps Drawer is shown in home screen. But the user is still in -1 screen.

After fix: https://b.corp.google.com/issues/300492676#comment15
When meta key is tapped in -1 screen, we hide -1 screen and transition
to 0 screen and then show AllAppsDrawer.

Bug: 300492676
Test: Manual, https://b.corp.google.com/issues/300492676#comment15
Flag: NA

Change-Id: I1234e4defdd0b53be35271b9f7567b0719eec7ac
2023-11-08 17:08:57 -08:00
Tracy Zhou f2d7be1cec Make enableTaskbarNoRecreate() depend on ENABLE_TASKBAR_PINNING and ENABLE_TASKBAR_NAVBAR_UNIFICATION
We want to turn on the flag when either of the dependent features is on

Bug: 299193589
Test: N/A
Change-Id: I7b48ff2be0cf9da3b6bc00d75370fa585ce4140d
2023-11-08 14:52:58 -08:00
Vadim Tryshev 7a1beb559f Allowing ACTION_CANCEL events to come from device 0
Tests assert that input events come to Launcher only from tests, which
sets deviceId to 0. This way, we spot when a cable touches a lab device
and breaks the tests, in which case deviceId will be != -1.

But CANCEL event, which is programmatic, now can legitimately come from
device 0.

Bug: 308489875
Test: presubmit
Flag: N/A
Change-Id: I84ee9ed8e008043f83e82d57b17b64a10677ee8d
2023-11-08 13:20:57 -08:00
fbaron 1e360c1a92 Folder preview work badge theming fix
Currently the preview apps in a folder icon have the work badge with theming even when themed icons is off

Fix: 306665193
Test: Verify that folder with work icons has non-themed work badge when themed icons is off
Flag: NONE
Change-Id: I78ca7cb2361f6e590742fa64c88397d1ea80be68
2023-11-08 12:30:58 -08:00