This CL changes where the cell icon size, text size and drawable padding is defined to prevent an issue with taskbar.
The transient taskbar updates the DeviceProfile icon size with a different value than used for responsive grids, and this update wasn't working anymore because responsive grid implementation wasn't reading the value from iconSize inside the updateIconSize function, but from the responsive grid spec.
Bug: 313463280
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: manual
Test: NexusLauncherImageTests
Change-Id: I835a90d724c2d1b2d32f483b758b789be7cbdcfe
This reverts commit 74fb544c27.
Reason for revert: b/311099513 is now no longer flaky. I suspect these logs may have improved a possibly existing race condition. Let's see if the flake returns w/o these logs.
Change-Id: Ib3a06b7d86f4eb5c3c95db9a68bc6eb15aead193
The new test generate hundreds of new boards using a fixed seed so the
test cases can be recreated if there is an error.
Some of the new clases where inside of CellLayoutBoard and moved
outside.
Flag: LEGACY FOLDABLE_SINGLE_PAGE DISABLED
Bug: 270395274
Test: ReorderAlgorithmUnitTest
Change-Id: I083fb6701b02b7c0b2cf24634ca71acb0c75902e
Also, simplify copyCurrentStateToSolution since it always gets false
as the second parameter.
Flag: NA
Bug: 229292911
Test: ReorderAlgorithmUnitTest
Change-Id: I025566897246fa59ca513cb7de9a12465054498f
Now they can hold values for different configurations, making it akin to iconSize.
Bug: 309800141
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Change-Id: I9d5cccda88a0311dbe0beecef194cc8d60c5c280
This is a no-op change ensure this we have ReorderAlgorithmUnitTest.
Flag: NA
Bug: 229292911
Test: ReorderAlgorithmUnitTest
Change-Id: I6ffe2a1260f869a4686a9f1e652dd1ab6d406269
- Log required metric events for the barcode content interactions.
Flag: ACONFIG com.google.android.apps.miphone.aiai.matchmaker.overview.ui.enable_barcode_detection_in_overview DEVELOPMENT
Bug: 310757242
Test: Built and tested on Pixel device.
Change-Id: Iff4e4a3aec35d9d096f5b52eab0124f6e7f22e15
Changes are part of go/launcher_SoR .
Flag: NA
Bug: 301108526
Test: This is a no-op change, compiling should be the test
Change-Id: I79a651c9d57e443037e330728540616b0d01434a
This lets you specify a package name which will be logged by the
returned StatsLogger (rather than retrieving from the ItemInfo).
Bug: 292227499
Test: Manual with other change in topic
Change-Id: I3650f9f02f6cbe560e1c21262ba1cb893702a49e
Invariant hold values that are not related to current DP in use. This is a change needed for IDP to hold more values in the future akin to iconSize.
Bug: 309800141
Change-Id: Iefb388a5f6590d7da3452d2c388c02bd5e9d32bb
Flag: N/A
Test: NexusLauncherTests
This also means Taskbar is transient by default in automated tests,
instead of persistent. Updated some checks accordingly.
Flag: LEGACY ENABLE_TRANSIENT_TASKBAR ENABLED
Test: TaskbarExpandCollapse#hideShowTaskbar; TaplTestsTaskbar;
TaplTestsTransientTaskbar; TaplTestsPersistentTaskbar
Bug: 270395798
Change-Id: I48b4c809025a9bab0a37ada1317adee823b1a8f9
This CL fixes the following two issues:
1. Launcher crashing while calling `addPrivateSpaceSettingsButton` from
BaseAllAppsAdapter as the thread is UI
2. Decorator is not removed from Private Space Header during reset to
paused state. https://screenshot.googleplex.com/BZdLqaZQwdDApfV
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 311337961, 311342946
Test: Ran Launcher3 tests
Change-Id: I2763338ebf0f5468ad38f61a781e8a8334194c5c
The method isNearestDropLocationOccupied finds the NearestDrop location
using the view models (i.e. the CellLayoutLayoutParams) and the new
method isConfigurationRegionOccupied run over the logic models (i.e. the
CellAndSpan or ItemConfiguration) ensuring a separation between them.
Test: ReorderAlgorithmUnitTest
Flag: LEGACY FOLDABLE_SINGLE_PAGE DISABLED
Bug: 270395274
Change-Id: I0b3c6606ee6934ea3a5e41d110677c496d4a4330
Jordan Silva
Thales Lima
Holly Sun
Sebastián Franco
Vinit Nayak
Sunny Goyal
Pat Manning
Federico Baron
Alex Chau
Avinash Vadlamudi
Pechetty Sravani
Andy Wickham
Andreas Agvard
Tony Wickham
Himanshu Gupta
Fengjiang Li