Commit Graph

22332 Commits

Author SHA1 Message Date
Winson Chung f66e7c19bd Merge "Dedupe non-perceptable depth updates" into ub-launcher3-rvc-dev 2020-04-20 21:10:20 +00:00
TreeHugger Robot 19b873d0bd Merge "Dump nav mode with TIS" into ub-launcher3-rvc-dev 2020-04-20 21:10:08 +00:00
TreeHugger Robot bb74388420 Merge "Using inbuild smooth scroller instead of custom fastscrolling logic" into ub-launcher3-rvc-dev 2020-04-20 19:32:02 +00:00
TreeHugger Robot f5a10fe9c2 Merge "Update predicted icon outline drawing" into ub-launcher3-rvc-dev 2020-04-20 19:17:49 +00:00
TreeHugger Robot 5a5a39f084 Merge "add FeatureFlag type to the dump / also sort them" into ub-launcher3-rvc-dev 2020-04-20 18:45:12 +00:00
Samuel Fufa 28f1db6dfa Update predicted icon outline drawing
Video: b/153203071#comment2
Bug: 153203071
Test: Manual
Change-Id: I786300f953553c98c63c8b48e40354b1672e930c
2020-04-20 11:27:28 -07:00
Sunny Goyal 355e845851 Using inbuild smooth scroller instead of custom fastscrolling logic
Change-Id: I9208720c3bf164bd664e5bacd75b672573fe7601
2020-04-20 11:15:34 -07:00
TreeHugger Robot f01f25b579 Merge "Fixing actions view getting visible sometimes" into ub-launcher3-rvc-dev 2020-04-20 17:52:03 +00:00
Sunny Goyal 01d8541f14 Fixing actions view getting visible sometimes
> Linking actions view to state flags
> Creating multiple visibility channels that can be controlled separately

Bug: 153906903
Change-Id: I33d20f5fdc8bcdf0520dae3aac986548eb7e0058
2020-04-20 09:59:13 -07:00
jayaprakashs 12cf1e5440 Add getScore() method to FolderNameInfo class.
getScore() is not used in launcher3 but exposed for testing purpose.

Change-Id: I22e674dabc3c24879c1c1b5881f9fc6005404998
2020-04-19 18:30:26 -07:00
Vinit Nayak 8699bf5626 Merge "Re-enable home screen rotation" into ub-launcher3-rvc-dev 2020-04-18 05:22:26 +00:00
TreeHugger Robot 3e54ddc010 Merge "Remove tracing for widgets scroll bug" into ub-launcher3-rvc-dev 2020-04-18 03:14:44 +00:00
vadimt 822efc9e82 Remove tracing for widgets scroll bug
Bug: 152354290
Change-Id: Iff56460f3f673f7089d647d08bb621c3965c7444
2020-04-17 19:04:41 -07:00
Adam Cohen b212e28c62 Merge "Decouple the scaling / translation of widget views necessary in split-screen" into ub-launcher3-rvc-dev 2020-04-17 23:35:19 +00:00
Winson Chung 20aeddd853 Dedupe non-perceptable depth updates
Bug: 154304487
Change-Id: I6d96aca555932f4a51aed576d25f7150952bb562
2020-04-17 16:16:44 -07:00
Winson Chung e9edbabbe2 Dump nav mode with TIS
- Also skip logging touches when not handling gestures

Change-Id: Ie25f28fe62594f22ebe73f276ccef628b7f8e734
2020-04-17 16:16:14 -07:00
Adam Cohen d916206271 Decouple the scaling / translation of widget views necessary in split-screen
=> We pull apart the scale and translation that are set in a fairly
   static way due to split-screen vs. the general translation and scale
   properties that might be used more dynamically, in this case
   for re-order animations
=> This allows removal of some code that breaks reorder animations
   due to the accrual of translations / scales in certain edge cases.
=> TODO in future CL: address other translation cases and make the throw
   case for calling base setTranslationX/Y for Workspace Items unconditional

issue 149438360

test: manual
Change-Id: Ic3fde172f669e215cd25db0fcd4e1c3c873d314f
2020-04-17 15:36:44 -07:00
Hyunyoung Song 14a3ace27e add FeatureFlag type to the dump / also sort them
Bug: 152660449

$ adb shell dumpsys activity service com.google.android.apps.nexuslauncher/com.android.quickstep.TouchInteractionService
SERVICE com.google.android.apps.nexuslauncher/com.android.quickstep.TouchInteractionService d4107aa pid=27740
  Client:
    DeviceFlags:
      APP_SEARCH_IMPROVEMENTS, defaultValue=true, mCurrentValue=true, mDefaultValueInCode=true
      ENABLE_HYBRID_HOTSEAT, defaultValue=false, mCurrentValue=false, mDefaultValueInCode=false
      ENABLE_SUGGESTED_ACTIONS_OVERVIEW, defaultValue=false, mCurrentValue=false, mDefaultValueInCode=false
      FOLDER_NAME_SUGGEST, defaultValue=true, mCurrentValue=true, mDefaultValueInCode=true
      HOTSEAT_MIGRATE_TO_FOLDER, defaultValue=false, mCurrentValue=false, mDefaultValueInCode=false
    DebugFlags:
      ADAPTIVE_ICON_WINDOW_ANIM, defaultValue=true, mCurrentValue=true
      ALWAYS_USE_HARDWARE_OPTIMIZATION_FOR_FOLDER_ANIMATIONS, defaultValue=false, mCurrentValue=false
      APPLY_CONFIG_AT_RUNTIME, defaultValue=true, mCurrentValue=true
      ASSISTANT_GIVES_LAUNCHER_FOCUS, defaultValue=false, mCurrentValue=false
      ENABLE_DATABASE_RESTORE, defaultValue=true, mCurrentValue=true
      ENABLE_DEEP_SHORTCUT_ICON_CACHE, defaultValue=true, mCurrentValue=true
      ENABLE_FIXED_ROTATION_TRANSFORM, defaultValue=true, mCurrentValue=true
      ENABLE_LAUNCHER_PREVIEW_IN_GRID_PICKER, defaultValue=true, mCurrentValue=true
      ENABLE_LSQ_VELOCITY_PROVIDER, defaultValue=true, mCurrentValue=true
      ENABLE_OVERVIEW_ACTIONS, defaultValue=true, mCurrentValue=false
      ENABLE_PREDICTION_DISMISS, defaultValue=false, mCurrentValue=false
      ENABLE_QUICK_CAPTURE_GESTURE, defaultValue=true, mCurrentValue=true
      ENABLE_QUICKSTEP_LIVE_TILE, defaultValue=false, mCurrentValue=false
      ENABLE_SELECT_MODE, defaultValue=true, mCurrentValue=true
      ENABLE_UNIVERSAL_SMARTSPACE, defaultValue=false, mCurrentValue=false
      FORCE_LOCAL_OVERSCROLL_PLUGIN, defaultValue=false, mCurrentValue=false
      KEYGUARD_ANIMATION, defaultValue=false, mCurrentValue=false
      MULTI_DB_GRID_MIRATION_ALGO, defaultValue=false, mCurrentValue=false
      PROMISE_APPS_IN_ALL_APPS, defaultValue=false, mCurrentValue=false
      PROMISE_APPS_NEW_INSTALLS, defaultValue=true, mCurrentValue=true
      QUICKSTEP_SPRINGS, defaultValue=true, mCurrentValue=true
      UNSTABLE_SPRINGS, defaultValue=false, mCurrentValue=false
      USE_SURFACE_VIEW_FOR_GRID_PREVIEW, defaultValue=true, mCurrentValue=true
    PluginManager:
      numEnabledPlugins=1
      numDisabledPlugins=0
      enabledPlugins=[ComponentInfo{com.android.launcher.plugins.AllAppsSearchPlugin/com.android.launcher.plugins.AllAppsSearch}]
      disabledPlugins=[]



Change-Id: Ifefc02683834e52e3b78f93861a90f97a72c01d8
2020-04-17 15:08:52 -07:00
Jon Miranda a28e0f474a Fix NPE when closing folder.
There is a race condition where Folder is closing, it unbinds, and then
another call to AbstractFloatingView.closeAllOpenViews tries to close the
Folder again. But since the contents are unbound and removed from the folder,
it produces a NPE.

Bug: 153625271
Change-Id: Ia6c55f15cf7517e26af8f499bc0c1a4828737480
2020-04-17 15:03:33 -07:00
Vinit Nayak 326d93bd56 Re-enable home screen rotation
Launcher home screen rotation now works with fixed
transform. When using Quickstep while holding
the phone from an orientation different than
the orientation of the touch, the overview
shown will be that of the phone orientation,
not the touch orientation.
Easier to see this be quickswitching from
portrait to landscape app, turning phone, then
going to overview from the original region you
swiped.

Fixes: 150214193
Test: Created test apps and fixed them
to various rotations to test.

Change-Id: Ic6565cd0ed33c951f45ccb97278045c6070e438e
2020-04-17 14:38:12 -07:00
Tony Wickham c09e8fbe9d Merge "Remove mPendingCallback from ActivityTracker" into ub-launcher3-rvc-dev 2020-04-17 19:35:49 +00:00
TreeHugger Robot e0f58a0f79 Merge "When dragging down on task, base end displacement on thumbnail" into ub-launcher3-rvc-dev 2020-04-17 16:30:32 +00:00
Tony Wickham 0bbdf3a9fd When dragging down on task, base end displacement on thumbnail
TaskView height has a lot of other factors such as icon margin
and actions. Since the thumbnail is what we are dragging to fill
the screen, use its height to determine the progress factor.

Test: swipe down on a task in portrait, landscape, and seascape,
and verify that it follows your finger to the bottom of the
screen. Swiping up also follows your finger for dimiss.

Bug: 151770407
Change-Id: I114a261a06b11f550822178945266cc4a6fd54fe
2020-04-17 10:27:40 -05:00
TreeHugger Robot c9fa578444 Merge "Use 87% black instead of 54% for widget text" into ub-launcher3-rvc-dev 2020-04-17 00:31:01 +00:00
TreeHugger Robot 71c63c6fda Merge "Simplifies Tutorial fragment layout." into ub-launcher3-rvc-dev 2020-04-16 23:46:25 +00:00
Tony Wickham ab86ab2869 Use 87% black instead of 54% for widget text
This gives sufficient contrast with slightly grey background

Bug: 147275180
Change-Id: I28b25b74c0101665ada14efdd5355c31b0f1b480
2020-04-16 18:32:07 -05:00
TreeHugger Robot 2a14c83515 Merge "Prevent two overlapping long press actions." into ub-launcher3-rvc-dev 2020-04-16 22:25:34 +00:00
TreeHugger Robot 11e36db88a Merge "Cleanup code related to ag/11035582" into ub-launcher3-rvc-dev 2020-04-16 22:04:45 +00:00
TreeHugger Robot 64abef8ca1 Merge "Choosing better points to output "start" events for TAPL" into ub-launcher3-rvc-dev 2020-04-16 21:58:47 +00:00
TreeHugger Robot 08c6c94398 Merge "Removes more Back references for generic tutorial styles." into ub-launcher3-rvc-dev 2020-04-16 21:54:18 +00:00
TreeHugger Robot 74974e802e Merge "Add resume callback to animate back to appropriate depth." into ub-launcher3-rvc-dev 2020-04-16 21:47:38 +00:00
Vinit Nayak 916456bb5f Cleanup code related to ag/11035582
Fixes: 154235554
Change-Id: I114d1e1b9e446e15a774a5a51bdf988070091523
2020-04-16 14:16:56 -07:00
Jon Miranda a1567d50d0 Prevent two overlapping long press actions.
We add a check in CheckLongPressHelper to not trigger long press if the
view is already in the pressed state.

This fixes the bug where a stranded DragView is left in the DragLayer.

Repo's every 50 tries:
- Open folder
- Long click and slightly drag the same item over and over in slightly
  different directions.

Logs show that long click on folder item initiates the first long click,
and then later on CheckLongPressHelper triggers another long press before the
initial one is finished.

Bug: 151053858
Change-Id: Ifbb6919e4f0153aaef2904f704baa284e78f1e83
2020-04-16 14:00:50 -07:00
Jonathan Miranda a976a2212d Merge "Add AnimationFlag for SKIP_DEPTH_CONTROLLER." into ub-launcher3-rvc-dev 2020-04-16 20:10:05 +00:00
Jon Miranda 172302686c Add resume callback to animate back to appropriate depth.
This fixes the bug where depth gets stuck to 1 after opening a transluscent
activity.

Bug: 152950633
Change-Id: I8bf5f61c57ef79d41656865b1ff1fbadb298fc36
2020-04-16 13:03:48 -07:00
Hyunyoung Song 6dde528c82 Merge "Add AllAppsSearchPlugin Bug: 151089843" into ub-launcher3-rvc-dev 2020-04-16 19:45:26 +00:00
Hyunyoung Song 3f82135f06 Add AllAppsSearchPlugin
Bug: 151089843

Change-Id: I6d61fb9c7855bafee731f47147b3070a1b672071
2020-04-16 11:50:04 -07:00
Andy Wickham 4f66dc3bef Adds dummy HomeGestureTutorialFragment.
- Adds a new launch target in Dev options
 - Moves Back handling to the parent TutorialFragment
   (so all Tutorials can handle it as necessary)
 - Currently uses a dummy translating rectangle in
   place of a proper hand animation
 - No actual home gesture recognition is in place yet

Test: Manual
Bug: 148542211
Change-Id: Ic5a545eb9f5003914803272c8ffe367220d63336
2020-04-16 18:23:08 +00:00
Andy Wickham 00e241f82f Simplifies Tutorial fragment layout.
Removes nested LinearLayout and RelativeLayout, as well
as a Space (instead just aligning buttons to the bottom).

Test: Manually verified result looks same as before.

Change-Id: I773079107be5f8862bae68c0f8f5bf6edff79ce8
2020-04-16 18:16:56 +00:00
Andy Wickham ed7c8a41d0 Removes more Back references for generic tutorial styles.
Change-Id: Ie959f897ee19d636eabfd8cbe9a8a2615264d4cf
2020-04-16 18:15:34 +00:00
jayaprakashs 86932724e7 Don't open the Folder and IME when Folder is created.
Bug: 153751859
Change-Id: I8169d0890a43b614b293ca29f504e19c532b90ee
(cherry picked from commit 09066ffeb2)
2020-04-16 02:43:36 +00:00
TreeHugger Robot a359556bff Merge "Fix regression where recents button had no animation" into ub-launcher3-rvc-dev 2020-04-15 23:56:26 +00:00
Tony Wickham 73ff6ddeac Remove mPendingCallback from ActivityTracker
Instead, all callers should use EXTRA_SCHEDULER_CALLBACK, set via
addToIntent(), to provide a callback for the next handleIntent().
The updated runCallbackWhenActivityExists() will do that for the
caller if the activity doesn't already exist (otherwise it will
run the callback synchronously as before).

Bug: 151389129
Change-Id: Idbec264354fd6de166ff3bae98249230078d5674
2020-04-15 18:48:39 -05:00
Tony Wickham 6ebf3d4434 Fix regression where recents button had no animation
Change-Id: I76102b4a9f3581b71285bfa9aa0c9dc29dd3165d
2020-04-15 18:06:28 -05:00
Jon Miranda dc186e68a1 Add AnimationFlag for SKIP_DEPTH_CONTROLLER.
We use this flag to prevent the depth from being immediately set to 0 when
preparing to animate home.

Bug: 152327671
Change-Id: I614c6ae08b9f9e56ecb94fb51748791a38504583
2020-04-15 15:19:49 -07:00
TreeHugger Robot 2e201a887d Merge "Import translations. DO NOT MERGE" into ub-launcher3-rvc-dev 2020-04-15 22:00:38 +00:00
TreeHugger Robot 62d493d50b Merge "Removing tracing for a fixed bug" into ub-launcher3-rvc-dev 2020-04-15 21:57:31 +00:00
TreeHugger Robot 1fe0a4e080 Merge "Address race condition with drag from external window" into ub-launcher3-rvc-dev 2020-04-15 21:41:34 +00:00
Tony Wickham cfb803c42c Address race condition with drag from external window
When dragging from another window, e.g. when pinning an app shortcut,
there's a race condition as follows if launcher is killed:
- System drag starts
- Workspace loads and starts binding, canceling the drag

With this change, the drag will get onDragStart() again after this
case and allow completion of the drop.

Change-Id: I3f1c786ad1d451ecda9bbac5e9a9a3e0d8b66f73
2020-04-15 15:56:57 -05:00
vadimt f528fa6518 Removing tracing for a fixed bug
Bug: 138251824
Change-Id: Icd0d5001bfce0b1dabc102a2bbb0212a57d5839a
2020-04-15 13:51:47 -07:00