Commit Graph

78507 Commits

Author SHA1 Message Date
David Saff 1121f8b5b9 Assert keyguard gone at beginning and end of PortraitLandscapeRunner
Should help distinguish if we have tests leaving things in a bad state,
or the intervening infrastructure.

Bug: 285935417
Change-Id: I5569472a9804cb21ee0646c72decb5f51be9ab01
2024-01-31 19:35:40 +00:00
Sunny Goyal fffb4feb4e Adding a flag to support activity overlay on home screen
Bug: 273828110
Flag: aconfig use_activity_overlay disabled
Test: N/A
Change-Id: Ic29c2c21da22554213a1792a38caf6907438c86d
2024-01-31 11:34:00 -08:00
Tracy Zhou e22d4f7eea Fix non-null check crash
onConfigurationChanged can be triggered before all the buttons are initialized, including Space, in which case, we currently skip that rendering

Bug: 230395757
Test: cold start doesn't crash
Change-Id: If451ddbb6b2055a207372d6470eb0fe0faff0301
2024-01-31 19:31:59 +00:00
Jakob Schneider 94b5f1709b Refactor API syntax based on API council feedback. This is a noop.
Bug: 322010040
Test: LauncherAppsTest
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT

Change-Id: I60c45654badd85c5e62d994ee012927a0425285a
2024-01-31 19:19:20 +00:00
Jordan Silva 715e25adf4 Refactoring PagedOrientationHandler to extract functions from to quickstep
This CL extracts RecentsView methods from PagedOrientationHandler to RecentsPagedOrientationHandler. It will allow to have quickstep specific components in the newer interface, like IconAppChipView.

Bug: 320633351
Flag: N/A
Test: atest NexusLauncherTests
Test: atest TaplTestsSplitscreen
Test: atest TaplTestsQuickstep
Change-Id: Ie7de23bddccbdb8eac93eff66a5d929f5bf0ee3a
2024-01-31 18:58:15 +00:00
Jeremy Sim e96d30bddb Make app pairs respond properly to disabled state
1) App pair member icons are now always redrawn when app pair icon is redrawn, allowing greyed out icons to be updated immediately when an app is disabled.
2) App pairs now check for disabled status when clicked. If one or both of the apps is disabled, app pair will not be launched, and the appropriate error message or affordance will be displayed.

Fixes: 323088270
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I7f2af75db0d8579d5d04583c0d3ead32714768e4
2024-01-31 16:01:55 +00:00
Schneider Victor-tulias 7e768fbf3b Handle slow gesture handling
Fixed broken gesture handling when RecentsAnimationCallbacks signals take too long.

Flag: NONE
Fixes: 285636175
Test: added a programmatic delay in RecentsAnimationCallbacks.onAnimationStart, attempted home/overview/quick switch gestures then quickly attempted another gesture during the delay
Change-Id: I59261d21ca4e2bd4b5496822e78c6db74eac10c7
2024-01-31 10:23:24 -05:00
Rohit Goyal 9ab4550ac3 UI Improvement: Fix unexpected progress bar around app icon added to Workspace after unarchival.
* In case app icon is added to workspace after unarchival completes for archived app, it shows a completely filled progress bar around the icon.
* This behaviour exists because the 'FLAG_ARCHIVED' flag is copied from `AppInfo` item.
* This cl updates the 'FLAG_ARCHIVED' flag for 'AllApps' item once unarchival completes.

Test: verified bugfix locally.
Bug: 319213296
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: I739225707a11bc9a6aa23e81775b4e036ce81a7e
2024-01-31 14:53:01 +00:00
Bill Yi f148ef3d26 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I8331d5152ba23f3fffa4f375d8a732985e16cf1f
2024-01-31 02:57:16 -08:00
Luca Zuccarini ae741dec9f Merge "Update dependency on Shell utils." into main 2024-01-31 10:06:19 +00:00
Jeremy Sim cfcf2255dc Add error logging and better crash safety for app pairs
This causes app pairs to log an error message if creation or icon inflation is attempted with contents != 2. App pairs with wrong numbers of members should not be created anymore.

Fixes: 317283244
Fixes: 322892793
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I5e454042719bb67187f900c546380bb44cfc34ac
2024-01-31 15:42:20 +08:00
Tracy Zhou 89fa4e35d8 Merge "Make sure touch only goes to the nearest button when it makes sense" into main 2024-01-31 06:26:32 +00:00
Tracy Zhou c7d7418cae Merge "Center a11y button" into main 2024-01-31 06:25:55 +00:00
Automerger Merge Worker f390e921a6 Merge "[automerger skipped] Merge Android 24Q1 Release (ab/11220357) am: 6810c19646 -s ours" into main 2024-01-31 02:26:16 +00:00
Shamali Patwa d3f5010ac5 Merge changes from topic "categories" into main
* changes:
  Add a default widget category provider that uses application category.
  Add a feature flag for displaying categorized widget recommendations.
2024-01-31 02:24:05 +00:00
Anushree Ganjam 8ee9076f0e Merge "[PS] Show "Uninstall" in Long Press menu for Private Space apps." into main 2024-01-31 02:22:11 +00:00
Xin Li ff3b91b257 [automerger skipped] Merge Android 24Q1 Release (ab/11220357) am: 6810c19646 -s ours
am skip reason: Merged-In I0708bf3c060ba84089722d0bd9480a4f4bd2b8e2 with SHA-1 1e60b1a4c4 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/25971170

Change-Id: I7a352fad4a3f3c7a87e827d568920ac4d6569cc2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-31 02:02:32 +00:00
Tracy Zhou 1a92257520 Center a11y button
Bug: 25768138
Test: a11y button is centered when visible
Change-Id: If9099575c12b51a90bc9e15e712cb629811d36e3
2024-01-30 16:54:10 -08:00
Anushree Ganjam 45ef544ae5 [PS] Show "Uninstall" in Long Press menu for Private Space apps.
Video : https://b.corp.google.com/issues/319250810#comment18

- Add SecondaryDropTarget.performUninstall()
- Make SecondaryDropTarget.getUninstallTarget() public static.

Test: Manual
Flag: aconfig com.android.launcher3.enable_private_space TEAMFOOD
Bug: 319250810

Change-Id: If6488033a976914fdc0a50658fc0561dc1a6586a
2024-01-30 16:54:04 -08:00
Shamali P c5fbb42dcb Add a default widget category provider that uses application category.
The category provider can be customized by any launcher via resource
override. For instance, one can override it to provide custom categories
using an allowlist or use a different mechanism such as query play
services.

We still need to get proper strings for categories from UX writer.

Bug: 318410881
Test: WidgetRecommendationCategoryProviderTest
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Change-Id: I5c4e0d22eaffc8254ddd54356f8c62f00e22a3c4
2024-01-31 00:43:22 +00:00
Android Build Coastguard Worker eeaaf0e10d Snap for 11380007 from dc23966243 to 24Q2-release
Change-Id: If7b754776078eee55fdc5b899bd6be8f35bebf48
2024-01-31 00:20:45 +00:00
Will Leshner f0be49e693 Filter widgets in widget picker activity by size.
Bug: 322191186
Test: atest Launcher3Tests
Flag: NA

Change-Id: I003e05cc16ae576cda07d249d036d2f9dbacdcc2
2024-01-30 15:42:00 -08:00
Holly Jiuyu Sun dd8de0a6d0 Merge "[PS] Update icon background for PS, Widget and web." into main 2024-01-30 23:34:05 +00:00
Tracy Zhou 419140aede Make sure touch only goes to the nearest button when it makes sense
- In NearestTouchFrame, we can't use view bounds alone since the buttons do not have the same root (3 buttons are in the main container, while the contextual buttons are in the contextual button container). This currently caused the issue that contextual button region, when the contextual buttons are invisible, triggers overview
- Need to add an empty space in the left / top area of the button nav to prevent view clicks from going into back (that's how it works in navigationbar/)

Bug: 25768138
Test: left and right of 3 buttons don't trigger back or overview
Change-Id: Idc26c0c8ac0ecc000300a6db2e3e6251f678dada
2024-01-30 14:27:48 -08:00
Jakob Schneider ac7c1e3736 Merge "Initialize the archiving compat options during launcher3 startup." into main 2024-01-30 21:37:30 +00:00
Saumya Prakash dc23966243 Merge "Don't show the Tasbar Pinning edu for 3 button nav users" into main 2024-01-30 21:20:45 +00:00
Vadim Tryshev a41fc4e4ad Merge "Verifying that keyguard is invisible before pressing Home in PortraitLandscapeRunner" into main 2024-01-30 20:47:27 +00:00
Shamali P 6a9d114d40 Update OWNERS for picker directory to include new owners.
There are some more files relevant to picker, but this CL covers
directory with the primary picker UI.

Change-Id: I53e174d9cd20396b4f56acb5d9e3cc07ec475ea8
2024-01-30 20:10:24 +00:00
Ats Jenk fbf3393faf Merge "Send bubble bar bounds in display coordinates to wmshell" into main 2024-01-30 19:10:23 +00:00
Sunny Goyal 558196ef87 Merge "Splitting bindItems method to also accept already inflated views which will eventually allow us to inflate icons on the background thread" into main 2024-01-30 18:49:20 +00:00
Jakob Schneider 2f609d09f6 Initialize the archiving compat options during launcher3 startup.
This just sets an OP_CODE (cheap operation). It disables a help-dialog
for launchers who have not implemented archiving.

Test: PackageInstallerArchiveTest and also manually
Bug: 302114748
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Ifa9335d7ad250218eec3863dcdd986118bba007c
2024-01-30 18:48:16 +00:00
Ivan Tkachenko 2e11769840 Merge "Fix RemoteTargetGluer crash" into main 2024-01-30 17:56:28 +00:00
Sunny Goyal eb5684ce1e Splitting bindItems method to also accept already inflated views
which will eventually allow us to inflate icons on the background thread

Bug: 318539160
Test: Presubmit
Flag: None
Change-Id: I61e4981c1c3201e92102153d9558a0885637da3a
2024-01-30 00:44:26 -08:00
Tracy Zhou e502cf3a1b Only hide back button in SUW when ime is rendering it
Bug: 316482919
Test: Back button is visible in SUW when ime is not rendering it
Change-Id: Id3f5d637c9e459a1b7a766187f0c134dd39a05f9
2024-01-29 22:25:36 -08:00
Android Build Coastguard Worker cba1a129db Snap for 11373247 from 8960937d47 to 24Q2-release
Change-Id: Ib046788c386ca8592444511d82553bdaa318bec7
2024-01-30 02:20:44 +00:00
Sebastián Franco ea73bf5d77 Merge "Removing the Worskapce as a dependency of CellLayout" into main 2024-01-30 02:19:19 +00:00
Andy Wickham 36e4d966a7 Re-apply all apps insets when unfolding.
Previously, if insets had been applied while folded ("phone"),
they would stick around when unfolding ("tablet").

This applies the intended 0 left/right margins when in "tablet"
mode regardless of the insets.

Fix: 321159393
Test: Open all apps in phone landscape, unfold
Flag: NA
Change-Id: Ida1f20711a2a2b9b54f6b2c18abf5abf4fd2b175
2024-01-29 15:53:12 -08:00
Anushree Ganjam 43a826c579 Merge "Fix the Int value to reflect shared preferences value in TouchInteractionService." into main 2024-01-29 23:15:56 +00:00
Saumya Prakash 318aba81e8 Don't show the Tasbar Pinning edu for 3 button nav users
The taskbar is already pinned for 3 button nav users so seeing the
taskbar pinning edu tooltip is not useful for them.

Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TRUNKFOOD
Fix: 322449139
Test: Reset taskbar edu in 3 button mode and ensure that pinning edu
doesn't show up

Change-Id: I9a5da0fc74596056f6e6b1827c67584c2c9cf44e
2024-01-29 22:20:21 +00:00
Anushree Ganjam eb5cb75753 Fix the Int value to reflect shared preferences value in TouchInteractionService.
This cl fixes following things

- When featureFlag is present, always read the value from FeatureFlag.get() instead of preferences.

- Add new function getIntFlagBackedUpByLauncherPrefs to read from sharedPreferences

- Make FlagTogglerPrefUi.java updateMenu() public

- When intFlag is modified in Developer Options, Apply button will show up. So launcher can restart and values get applied.

- Omnient Int flags will read from Featureflag.get() instead of shared preferences directly.

Bug: 320696242
Test: Manual
Flag: NA. Developer Options related

Change-Id: Id916b25d0397505d240ea8444d896c8ace826e57
2024-01-29 14:02:32 -08:00
Sunny Goyal ac1c83e657 Merge "Cleaning up release flag: ENABLE_ICON_LABEL_AUTO_SCALING" into main 2024-01-29 21:06:54 +00:00
Shamali Patwa fcb26c5ddf Merge "Fix crash in two pane paged view when work profile is used" into main 2024-01-29 20:59:05 +00:00
Shamali Patwa 279544e718 Merge "Add the testDragCustomShortcut back for phones." into main 2024-01-29 20:52:49 +00:00
Charlie Anderson 9147575693 Merge "Add unit tests to WorkspaceItemProcessor for processing apps" into main 2024-01-29 20:27:13 +00:00
Shamali P 1f5a8e6ee1 Fix crash in two pane paged view when work profile is used
Looks like ag/25865281 updated widgets_two_pane_sheet_recyclerview.xml
but not widgets_two_pane_sheet_paged_view So, with work profile where
 widgets_two_pane_sheet_paged_view is used, it's crashing.

See https://b.corp.google.com/issues/322681099#comment9 for recording

Fix: 322681099
Test: Verify picker loads & scrolls with / without work profile.
Flag: NONE
Change-Id: If7969a70e1079ffff58ffbd0a90cbec34c6da2de
2024-01-29 19:43:39 +00:00
Ats Jenk d22d73a08c Send bubble bar bounds in display coordinates to wmshell
Bubble bar can be positioned to the left or right side of the screen.
Instead of sending offsets to wmshell, send the bounds of the bar, in
screen coordinates. WMShell can choose how to use that information.

Flag: LEGACY persist.wm.debug.bubble_bar DEVELOPMENT
Bug: 273310265
Test: repeat with LTR and RTL system languages:
  - have some bubbles, open an app, expand the bubbles by swiping up
    from bubble bar handle
  - have some bubbles, open an app, expand bubble bar by swiping up on
    navbar handle, tap on bubble bar to expand bubbles
  - have some bubbles, be on home screen, tap on bubble bar to expand a
    bubble

Change-Id: Id2d24831e567171b442ae7f34f055b7195a3e060
2024-01-29 11:32:20 -08:00
Federico Baron 8960937d47 Merge "Fix testDragToFolder test" into main 2024-01-29 19:27:24 +00:00
Sunny Goyal 7891425109 Cleaning up release flag: ENABLE_ICON_LABEL_AUTO_SCALING
Bug: 270393294
Flag: N/A
Test: N/A
Change-Id: Ied7e21150e8176f044615959d20e75bb1cad7dfa
2024-01-29 11:18:29 -08:00
Shamali P 458825a3fc Add the testDragCustomShortcut back for phones.
testDragCustomShortcut was ignored, but as discussed, enabling it for
phones - where the layout of picker is unchanged.

Bug: 322820039
Test: Un-ignoring the test
Flag: N/A
Change-Id: I3607812befc58c8a46b49a2587dfa6a1b572cd5b
2024-01-29 19:07:03 +00:00
Jagrut Desai ad37e4620c Merge "Fixing NullPointerException in TaskbarUIController" into main 2024-01-29 19:05:12 +00:00