Commit Graph

78507 Commits

Author SHA1 Message Date
Jakob Schneider 02d93b8463 Merge "Refactor API syntax based on API council feedback. This is a noop." into main 2024-02-06 12:44:55 +00:00
Jeremy Sim 2d0fd0780a Fix bug with portrait-fold devices animating app pairs launch wrongly
This CL makes it so that isLeftRightSplit is correctly called instead of isLandscape when animating an app pair launch.

Fixes: 318756992
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: Id766a3f9bd315abc277e36a118fd233156cf3898
2024-02-06 18:40:03 +08:00
Himanshu Gupta b3e03b5461 Merge "Making PS container tappable when locked." into main 2024-02-06 08:01:42 +00:00
Vinit Nayak d471844135 Merge "Revert^2 "Prevent taskbar animation for contextual split from home"" into main 2024-02-06 03:53:38 +00:00
Vinit Nayak c5376624c8 Merge "Update split with self test since it didn't account for contextual split" into main 2024-02-06 03:47:17 +00:00
Jeremy Sim 0c94fbc66f Merge "Snap to saved app pair" into main 2024-02-06 02:54:15 +00:00
Fengjiang Li cd60d191a8 [Predictive Back] Replace legacy flag with aconfig flag in launcher
Fix: 323971106
Flag: ACONFIG launcher.enable_predictive_back_gesture DISABLED
Test: manual
Change-Id: Ie8051af2540699a7d75f1ed05132584d0b40d17d
2024-02-05 16:41:29 -08:00
Android Build Coastguard Worker 8b5ebcece7 Snap for 11406759 from 562fe01e5e to 24Q2-release
Change-Id: Ia4234f037868c836faf33cdb5fd33ec2e9a034b8
2024-02-06 00:25:44 +00:00
Vinit Nayak fe35d069d2 Update split with self test since it didn't account for contextual split
* Right now we split from all apps and we stay in all apps with
contextual split.
* We now have 2 paths, if we are in contextual split then we
should select the same app from all apps again

Fixes: 323418145
Change-Id: I3bde59847b9e47951a6acdc93660b600114c3ddd
2024-02-05 16:08:30 -08:00
Schneider Victor-tulias 05511943c2 Merge "Add TAPL test cases for KQS from taskbar all apps." into main 2024-02-06 00:01:48 +00:00
Vinit Nayak 5f2b7242f3 Revert^2 "Prevent taskbar animation for contextual split from home"
This reverts commit 8b78849c44.

Reason for revert: Did not fix failing test b/323418145

Change-Id: Ic0897dda930a76aa27fba6e9de925b653d63a7f4
2024-02-06 00:00:35 +00:00
Saumya Prakash 548add276e Merge "Increase the character limit for translations in taskbar pinning edu" into main 2024-02-05 23:44:58 +00:00
Jordan Silva d5df5b3e11 Merge "Refactoring TAPL functions for OverviewTask" into main 2024-02-05 23:03:49 +00:00
Fengjiang Li 3088ae55d1 Merge "Add unit test for StatusBarTouchController.java" into main 2024-02-05 22:29:35 +00:00
Saumya Prakash 1613fe6b13 Increase the character limit for translations in taskbar pinning edu
The current character limit for the taskbar pinning edu subtitle does
not fit many translations. We are increasing the character limit to
enable proper translations.

Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TRUNKFOOD
Fix: 323943380
Test: N/A
Change-Id: I56225711c475e617451e5db0b1c226e3603e5c02
2024-02-05 21:40:38 +00:00
Schneider Victor-tulias 853d7d3b4c Add TAPL test cases for KQS from taskbar all apps.
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 323218341
Test: TaplTestsKeyboardQuickSwitch
Change-Id: Ie8f23ad14e4a32abbc5b49edc05ce407bbb774e6
2024-02-05 15:41:19 -05:00
Vinit Nayak 562fe01e5e Merge "Update fail fast check logic" into main 2024-02-05 20:00:08 +00:00
Fengjiang Li 1f0465e9f2 Add unit test for StatusBarTouchController.java
Test: this one
Flag: NONE
Bug: 282945183
Change-Id: I76eb4389d71d7a03e038ed6b01b6f5b7923fd11a
2024-02-05 11:51:01 -08:00
Android Build Coastguard Worker 8a8797ba8a Merge cherrypicks of ['googleplex-android-review.googlesource.com/26137350'] into 24Q2-release.
Change-Id: I5951fa0cfd04b316ab9efd731f122528bbd9262a
2024-02-05 19:47:13 +00:00
Neha Jain 8e79419cc4 Revert "Intercept clicks for non-supported split targets on work..."
Revert submission 25983910-disableSplitTargets

Reason for revert: b/323785395

Reverted changes: /q/submissionid:25983910-disableSplitTargets
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:158cc2505f242abc11375d947d960febb7038bb2)
Merged-In: I82bb808809e0be08803f3d5dd3ac779257bb64d0
Change-Id: I82bb808809e0be08803f3d5dd3ac779257bb64d0
2024-02-05 19:46:49 +00:00
Vinit Nayak ccab39e714 Merge "Revert "Prevent taskbar animation for contextual split from home"" into main 2024-02-05 19:39:00 +00:00
Anushree Ganjam 9858a3e0f4 Add Unit tests for System Shortcut.
Update SystemShortcut<T extends ActivityContext> and remove dependency on Launcher so we can write unit tests.

Introduce TestSandboxModelContextWrapper , wrapper around SandboxModelContext and ActivityContext.

Use SandboxModelContext for testing since we need UserCache, AllAppsContainerView, AllAppsStore to be spied and verified for function calls.

StatsLogManager is not verified in this cl, We can do as follow up.

Bug: 319250810
Test: Manual.
Flag: aconfig com.android.launcher3.enable_private_space TEAMFOOD

Change-Id: If767128a502e40d2016a331db4a342f20f24c588
2024-02-05 10:59:52 -08:00
Vadim Tryshev 3517550379 Merge "Starting measuring displacement from the edge of the slop zone" into main 2024-02-05 18:22:12 +00:00
Vinit Nayak 628a039721 Update fail fast check logic
* Incorrectly wasn't erroring out when flag was not enabled

Bug: 295467097
Change-Id: I5716309f832d1170ea92ad357897299c0438d2d0
2024-02-05 10:21:26 -08:00
Anna Zhuravleva a42e9d4410 Update icon for install to private shortcut
Bug: 316118005
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space_install_shortcut DEVELOPMENT
Test: https://b.corp.google.com/issues/316118005#comment5
Change-Id: I4f5316be5117be09510cac6922c43abe946e9938
2024-02-05 17:10:44 +00:00
Jagrut Desai c5be03f062 Merge "Change Persistent/Pinned Taskbar App Icon Size to 40dp" into main 2024-02-05 16:54:32 +00:00
Piyush Mehrotra b41d0634af Fix widget restore for pre-archived apps
Widgets which were expected to be restored, were missing for apps which were pre-archived.
The fix adds checks for archived apps when processing widgets and ensures that icon with cloud overlay is present on the widget.

Test: Flashed device with build containing this fix.
    Screenshot right after SuW- http://shortn/_LoLudMXEaT
Bug: 321297173
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: I32bc51ead2870670efc8eba24f17896aedcc3b9f
2024-02-05 15:53:19 +00:00
Jordan Silva ebd71c6cc9 Refactoring TAPL functions for OverviewTask
This CL refactors some methods in OverviewTask to rely on OverviewSplitTask. It also changes the BaseOverview getTasks function to retrieve the parent task and support cases where only the bottomright_snapshot is available in the recent tasks.

Bug: 320633351
Test: TaplTestsSplitscreen
Flag: N/A
Change-Id: I226f895810ce3b46cc107f76cd85e2918abf7088
2024-02-05 13:50:23 +00:00
Uwais Ashraf 810a82f13e Merge "Extract GroupedTaskView size calcs to a method to prevent measure calls" into main 2024-02-05 11:35:11 +00:00
Uwais Ashraf 0d355abe38 Extract GroupedTaskView size calcs to a method to prevent measure calls
Bug: 313644427
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Test: OverviewImageTest
Change-Id: I494f09455104372209b9087d13a704a4fe52bb62
2024-02-05 10:27:12 +00:00
Cliff Wang dd2222749b Merge "Revert "Make sure TAPL waits for Launcher activity to stop each time it stops"" into main 2024-02-05 08:21:54 +00:00
Cliff Wang ac82e995ca Revert "Make sure TAPL waits for Launcher activity to stop each time it stops"
This reverts commit dd33b64a64.

Reason for revert: “DroidMonitor: Potential culprit for Bug b/323619378 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.”.

Bug:323619378
Change-Id: Iadaa80f2cc51f39ae3ab73cdd49a98d05835506e
2024-02-05 04:46:17 +00:00
Jeremy Sim c8ab1c7081 Snap to saved app pair
This CL makes it so that LauncherAccessibilityDelegate properly calls snapToPage() when saving a new app pair.

Fixes: 322758994
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I9b571989761c36ce1c1de1e1eec6a4f559cb6428
2024-02-04 02:22:50 -08:00
Android Build Coastguard Worker ec3e11fde7 Snap for 11401641 from 6474a3b455 to 24Q2-release
Change-Id: I607bcd18234cebc07efda6f3de5c389b4d3b9ba9
2024-02-03 22:20:25 +00:00
Tracy Zhou e9f4635426 Show hotseat instead of stashed taskbar handle after entering stage split from fullscreen app via keyboard shortcut
Besides finishing the recents animation from fullscreen app, we also need to update the taskbar state

Fixes: 323561157
Test: Go to a fullscreen app, trigger the split shortcut, make sure the hotseat icons are visible on the home screen
Change-Id: I36f47846ed0bc7f7036ae22452a28efc9cb09bc7
2024-02-03 06:04:00 +00:00
Tracy Zhou 6474a3b455 Merge "Add split instructions to stage split from keyboard shortcut" into main 2024-02-03 06:02:48 +00:00
Vadim Tryshev f9eced5768 Merge "Make sure TAPL waits for Launcher activity to stop each time it stops" into main 2024-02-03 02:33:53 +00:00
Android Build Coastguard Worker 2ffbd0df8e Snap for 11399958 from cac7c6f682 to 24Q2-release
Change-Id: I9a5c16bf02104ffbb1e47a8b3e9b0f340f44955c
2024-02-03 02:20:38 +00:00
Zak Cohen 379b5b0467 Merge "Hide widgets in the Work Profile tab when Work apps are paused." into main 2024-02-02 23:51:01 +00:00
Vadim Tryshev dd33b64a64 Make sure TAPL waits for Launcher activity to stop each time it stops
This helps to ensure that the test doesn't proceed while the activity is
still stopping and it's state hasn't settled.

We introduce a count of STOP events and make sure it's 0 except for
cases where stops are safe to ignore or we have waited for them.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I51c73c89854fcaa390d47a57389da18b2ce0ee6c
2024-02-02 15:21:20 -08:00
Tony Wickham cac7c6f682 Merge "Send finish callback even if there is no icon to animate to" into main 2024-02-02 22:37:44 +00:00
Vinit Nayak 92dd621d8e Merge "Intercept clicks for non-supported split targets on workspace" into main 2024-02-02 22:07:53 +00:00
Zak Cohen 3ae06bf4ca Hide widgets in the Work Profile tab when Work apps are paused.
The filter was missing from the refactor in ag/25502473.
There aren't currently WidgetPicker tests that would catch this behavior
but there should be.

Bug: 317452407
Test: Ran existing widget tests, looking at adding work profile tests.
Flag: none
Change-Id: I2ce8464a1c76505bfe7ce8cf4280bb5b576cdb1d
2024-02-02 13:28:39 -08:00
Shamali Patwa e66a001ed6 Merge "Fix the horizontal margins on the left panel in the two pane picker." into main 2024-02-02 21:16:55 +00:00
Mady Mellor 5912d0f6d9 Merge "Launcher: use aconfig flag for bubble bar" into main 2024-02-02 21:04:32 +00:00
Vadim Tryshev 94477b23e9 Send finish callback even if there is no icon to animate to
Fixes: 321297170
Test: TaplAllAppsIconsWorkingTest#testAppIconLaunchFromAllAppsFromHome
Flag: none
Change-Id: Ia6084dd14715bab36c7dd1c983fabedcf9b10630
2024-02-02 20:42:02 +00:00
Tracy Zhou d0b9aae52c Add split instructions to stage split from keyboard shortcut
Fixes: 319098298
Test: When launching split from fullscreen app via keyboard shortcut, the split instruction shows
Change-Id: Ie64e5e65384a24825edc7ae6c8dea3203e2bd916
2024-02-02 11:29:10 -08:00
Vadim Tryshev 3f4401aa7e Merge "Adding text messages to some asserts in TaplAddConfigWidgetTest" into main 2024-02-02 18:21:35 +00:00
Shamali P 5e855d7912 Fix the horizontal margins on the left panel in the two pane picker.
The recycler view when displayed in single pane picker, for large screen
gets a larger padding. But when displayed in two pane picker, it is not
needed - so we override it.

Foldable's unfolded portrait doesn't seem to have screenshot test
- will look into if we can add one in follow up.

Bug: 322719955
Test: Screenshot test for existing modes & manual (see bug)
Flag: ACONFIG com.android.launcher3.enable_unfolded_two_pane_picker DEVELOPMENT

Change-Id: Ibd72146e7e5230eec0d2ce01c3917819a73d8f32
2024-02-02 18:20:38 +00:00
Sebastián Franco fe5c308a11 Merge "Adding unit test to makeSpaceForHotseatMigration" into main 2024-02-02 17:52:52 +00:00