Commit Graph

78507 Commits

Author SHA1 Message Date
helencheuk 04cd8f2852 Show taskbar when external keyboard is attached, in 3 button nav mode and desktop windowing mode
Bug: 280497051
Test: Manual, turn on desktop windowing mode. Enter input mode in an app, drag it from the top to be  window mode. Verify if taskbar is present
Flag: N/A
Change-Id: I31dc922c480cd0b39a64763155777b906e3bd14a
2024-02-02 17:31:13 +00:00
Vinit Nayak ec52ed9f99 Intercept clicks for non-supported split targets on workspace
* If we're in split selection state we disable the following
- G icon on PSB
- Lens icon on PSB
- Smartspace
- Widgets

Bug: 295467097
Test: Enter split contextual and observe split instructions
view going boing when tapping on unsupported target
Flag: com.android.wm.shell.enable_split_contextual

Change-Id: Ia7783472f3de9359c2784788be5f35596cbc8deb
2024-02-02 08:17:13 -08:00
Sam Cackett 8b997289f0 Merge "Fix issue with IconAppChipView animated states" into main 2024-02-02 12:27:45 +00:00
samcackett fee52acb29 Fix issue with IconAppChipView animated states
Cancel in progress animations and resume from previous position.
Display TaskMenuView once.

Fixes: 322813710
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: I73410d6116876ca83f3b16311d2e9eb372308295
2024-02-02 11:08:47 +00:00
Himanshu Gupta 65f1f81300 Making PS container tappable when locked.
Currently only the lock button in contianer
is tappable when PS is locked.
This change makes both the container and
button tappable.
In unlock state, the container is not tappable.

Bug: 313859437
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space TRUNKFOOD
Test: Launcher3 test.
Change-Id: I1ae267d50a999e723932136dffa3ae8243d439c0
2024-02-02 10:53:52 +00:00
Rohit Goyal e807bdc26a Merge "UI Improvement: Persist archived app icon on workspace in case app uninstallation is cancelled." into main 2024-02-02 08:37:49 +00:00
Anushree Ganjam 61036608d1 Merge "Add logs for IME search button tap." into main 2024-02-02 07:58:28 +00:00
Fengjiang Li 2aaccefecb Merge changes I471c27b8,I602cf29b into main
* changes:
  Fix small gap between widget resize frame and widget background.
  Update TaplAddWidgetTest#testResizeWidget() and WidgetResizeFrame#resize() API to pass launcher's cellBoarderSpace and use its height to expand widget
2024-02-02 03:31:13 +00:00
Vinit Nayak 8b78849c44 Revert "Prevent taskbar animation for contextual split from home"
This reverts commit febd61fb3f.

Reason for revert: b/323418145, testing to see if this is the culprit

Change-Id: Ie72ce0d24c6008e93340c1868b18bce68902c7cc
2024-02-02 01:55:18 +00:00
Holly Sun ac84289439 [PS] Update PS icon.
Now we have a specific icon for Private Space in material icon lib (https://fonts.corp.google.com/icons?icon.query=private+space&icon.platform=android).
Figma: https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?type=design&node-id=20135-133573&mode=design&t=hXFY1ODhROG362hc-0

Screenshot: https://screenshot.googleplex.com/4YwYyeupJWt2Lq5

Bug: 323434770
Test: unit + manual
Flag: aconfig com.google.android.apps.nexuslauncher.enable_inject_private_space_tile teamfood
Change-Id: I175c16d61ad9d263684c345622f17301eba4472d
2024-02-01 16:47:25 -08:00
Rohit Goyal c475f22d8b UI Improvement: Persist archived app icon on workspace in case app uninstallation is cancelled.
Test: verified bugfix locally.
Bug: 319213296
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Id9ba2ea833e8360ac8aa2c765beff402cff12ae2
2024-02-02 00:27:16 +00:00
Fengjiang Li b9ba4b9813 Fix small gap between widget resize frame and widget background.
There is a 1dp gap on left/top/right/bottom between widget resize frame and widget background. Increasing the margin by 1dp will fill this gap.

Fix: 291104076
Test: See https://b.corp.google.com/issues/291104076#comment9
Flag: NONE
Change-Id: I471c27b8b5d59850a4bf342fc2d8fee50d6fd65d
2024-02-01 16:24:18 -08:00
Fengjiang Li 387fea9731 Update TaplAddWidgetTest#testResizeWidget() and WidgetResizeFrame#resize() API to pass launcher's cellBoarderSpace and use its height to expand widget
To expand widget vertically, the drag distance has to be >= 0.66 * (cellHeight + cellBoarderSpace.y). The TAPL test should add cellBoarderSpace.y onto the vertical drag distance to make test less flaky.

Bug: 291104076
Test: Postsubmit passed https://android-build.corp.google.com/builds/abtd/run/L49100030001703948
Flag: NA
Change-Id: I602cf29b83df6875abd8eadfe255a2adb13f03cb
2024-02-01 16:24:14 -08:00
Sunny Goyal b2f38376c4 Merge "Blocking gestureNav on taskFragments within the Launcher activity" into main 2024-02-02 00:23:29 +00:00
Rohit Goyal ffb266462b Merge "UI Improvement: Do not add archived app icon to workspace when unarchival starts in case the icon already doesn't exist." into main 2024-02-02 00:21:21 +00:00
Android Build Coastguard Worker e45637d4e3 Snap for 11392706 from 3458141a9e to 24Q2-release
Change-Id: I30e0a032bfdf748d6181435a3f9196a2348c3a5e
2024-02-02 00:20:43 +00:00
Mady Mellor cc138663ca Launcher: use aconfig flag for bubble bar
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DISABLED
Test: make & enable / disable flag to check if it works:
      adb shell device_config put multitasking
         com.android.wm.shell.enable_bubble_bar true
Test: PlatformScenarioTests:
      android.platform.test.scenario.sysui.bubble.BubbleBarTest
Bug: 286246694
Change-Id: I0820973848675e8596e0e1605c7e43158d870382
2024-02-01 23:18:53 +00:00
Federico Baron 08b2acf898 Merge "Fix indexoutofbounds in Folder" into main 2024-02-01 23:07:17 +00:00
Brandon Dayauon ff89c5c9dc Fix color contrast in All Apps text by setting the color to onSurfaceVariant
bug: 322293478
Test:
All Apps divider:
before lightTheme: https://drive.google.com/file/d/1MTL1iEX_icYWfT52WeZIgqLK46koLM_s/view?usp=sharing
after lightTheme: https://drive.google.com/file/d/1ME1Gk8bUIXIe1P_Z5pvcpi3VS0_L0mVK/view?usp=sharing
before darkTheme: https://drive.google.com/file/d/1MLcv32M2JWyVqPklMdZLJAkj8KnyXwtB/view?usp=sharing
after darkTheme: https://drive.google.com/file/d/1MJjgP42xgp7SCifHAfREzgWvw6KupvlR/view?usp=sharing
All Apps text:
before light theme:https://drive.google.com/file/d/1MCu6xtpCMCxtDpnAv3fhCDSafBJGX4rx/view?usp=sharing
after light theme:https://drive.google.com/file/d/1M6ilveUw2q0FIlo-NSxt8KEWKRbQvwhk/view?usp=sharing
before dark theme:https://drive.google.com/file/d/1MCOxt9MeWxgN65T2s0OKzybiPu4qI4PD/view?usp=sharing
after dark theme: https://drive.google.com/file/d/1MAXnRmG8NVMu1bCseVWn6GC2322gQ0sX/view?usp=sharing
Flag: None

Change-Id: Iedb12d7b11b215c6668e7b5e6637189da3d67ebc
2024-02-01 14:55:23 -08:00
Sunny Goyal 2829c361f3 Blocking gestureNav on taskFragments within the Launcher activity
Bug: 273828110
Flag: aconfig use_activity_overlay disabled
Test: Verified on device
Change-Id: Ie812e17012feb8e99e06d0593207a87ef0c768e3
2024-02-01 13:35:30 -08:00
fbaron 1f265cc907 Fix indexoutofbounds in Folder
Flag: NONE
Test: n/a
Fix: 322875847
Change-Id: I14f6ebe135014c806aee310e5919a72a6e8820f7
2024-02-01 13:09:55 -08:00
fbaron f183b36c14 Fix pagination animation when removing a page
Flag: NONE
Test: verified on device
Fix: 323384413
Change-Id: I43443f815990df4014b4cfad05f68a445d44a5f4
2024-02-01 12:56:52 -08:00
Rohit Goyal 25ef2e1eca UI Improvement: Do not add archived app icon to workspace when unarchival starts in case the icon already doesn't exist.
Test: verified bugfix locally.
Bug: 319213296
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Iad3cc1a254b1543511976469c444eeaf869c7d50
2024-02-01 20:52:19 +00:00
Vadim Tryshev 1784a329e6 Adding text messages to some asserts in TaplAddConfigWidgetTest
Bug: 187761685
Flag: N/A
Test: presubmit
Change-Id: Ia8164f60f49b377e41db72f97c4f90d167292574
2024-02-01 11:33:23 -08:00
Brandon Dayauon 3458141a9e Merge "Add Utility method in userCache to get badgeDrawables" into main 2024-02-01 18:02:17 +00:00
Schneider Victor-tulias 3dafeb2d09 Merge "Update KQS overview launch animation" into main 2024-02-01 17:55:54 +00:00
Sebastian Franco 2d8be10856 Adding unit test to makeSpaceForHotseatMigration
Flag: NA
Bug: 318417510
Test: atest HotseatReorderUnitTest
Change-Id: If4fe388d00138b2d43693df0cf79abb16f354291
2024-02-01 17:08:52 +00:00
Schneider Victor-tulias 8b9ca27cb8 Merge "Handle slow gesture handling" into main 2024-02-01 16:27:21 +00:00
Schneider Victor-tulias 1ca66992c1 Update KQS overview launch animation
Updated the KQS overview launch animation to match the spec: open overview and scroll to the focused task in one fluid motion

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 313608085
Test: Opened KQS from home and overview
Change-Id: I2d617db29ff46e89fab50bb6f8aee900b6fe649f
2024-02-01 14:49:29 +00:00
Bill Yi ea784da63c [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: f148ef3d26 -s ours
am skip reason: contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26077678

Change-Id: I3d13835137d024b4191ae411bd1e8fff85310b85
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-02-01 13:53:28 +00:00
Johannes Gallmann 8a631d09d0 Fix crash for predictive back to home fallback animation
Bug: 323046568
Flag: ACONFIG com.android.window.flags.predictive_back_system_anims TEAMFOOD
Test: Manual, i.e. verify no crash for predictive back to home fallback
animation
Change-Id: I8bd5ddb3f97376a9d9bc4bdf1e3a55e7f53a192f

Change-Id: I1f53b3fafb8d508a0e0b67dda16eae36191f197c
2024-02-01 12:40:37 +01:00
Himanshu Gupta 69f37fd722 Merge "Preventing DragAndDrop for PS apps." into main 2024-02-01 09:14:43 +00:00
Himanshu Gupta 3ec66fb333 Preventing DragAndDrop for PS apps.
This Cl restricts item dragging for PS apps from
all launcher surfaces such as AllApps, AppPredictionRow, etc.

Video: https://photos.app.goo.gl/PKGw8n23hJVJMyUk7

Flag: ACONFIG com.android.launcher3.Flags.private_space_restrict_item_drag DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I2c5dbaa325095ec63aedf39b6b2c269f745d58ca
2024-02-01 06:46:25 +00:00
Vadim Tryshev 717ea2cdff Starting measuring displacement from the edge of the slop zone
This makes displacement calculations robust against skipped MOVE events

Test: presubmit
Bug: 297377792
Flag: N/A
Change-Id: I6c2c3486139baa5e456c6787c2afc7b3f7fe7cfd
2024-01-31 17:23:51 -08:00
fbaron fc6bbcfed2 Align workspace and hotseat icons in landscape
Fix: 311381639
Test: Verified on device
Flag: NONE
Change-Id: I4e2c74f59e8492042c3c7f8eccc98921d92d685f
2024-02-01 01:04:40 +00:00
Anushree Ganjam 1baf08e5b7 Add logs for IME search button tap.
Bug: 316779102
Flag: NA, Add logs
Test: Manual
Change-Id: I38af3b83e87afabe84807faccf5f8f3d080d93a2
2024-01-31 16:45:29 -08:00
Tracy Zhou e757578908 Merge "Fix non-null check crash" into main 2024-02-01 00:21:05 +00:00
Android Build Coastguard Worker 25704a9eae Snap for 11386701 from d4b2c8a858 to 24Q2-release
Change-Id: I589f367aa4eb3eaf0cb7bf162268e4e4735fefc7
2024-02-01 00:20:24 +00:00
David Saff 60379ac052 Merge "Assert keyguard gone at beginning and end of PortraitLandscapeRunner" into main 2024-02-01 00:15:39 +00:00
Brandon Dayauon 72542b6058 Add Utility method in userCache to get badgeDrawables
- In userCache, create a utility method to get badgeDrawables via userHandle. As of this moment, this is used in Toast.

Bug: 312898415
Test: Manual photos:
before 0-state: https://drive.google.com/file/d/15OUcd8i1IoUU0BgMlZj-8e0YWsmtzY4E/view?usp=sharing
after 0-state: https://drive.google.com/file/d/15SH19xvdLzQt1QbHY2oAxPAFVXPZDchF/view?usp=sharing
before textHeader: https://drive.google.com/file/d/15OLpN2SNF9QNWMrs0Aos5fS-l39Op-wo/view?usp=sharing
after textHeader: https://drive.google.com/file/d/15PIi-K6FfdCtPwWg2GEP9SUE5ow2YXJ5/view?usp=sharing
Flags: None

Change-Id: Ia6f89e634cc0af47cae91add6ea62d3af452c441
2024-01-31 15:54:30 -08:00
Shamali Patwa bb28770a01 Merge "Update OWNERS for picker directory to include new owners." into main am: ded14cc211 am: 962f362912
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2937801

Change-Id: I82c1df4c6ad2a4fa09f700f8f3d73f5fb671141d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-31 23:45:06 +00:00
Andy Wickham 552df9b647 Merge "Re-apply all apps insets when unfolding." into main 2024-01-31 23:30:49 +00:00
Shamali Patwa 962f362912 Merge "Update OWNERS for picker directory to include new owners." into main am: ded14cc211
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2937801

Change-Id: Ic9b3be62af2271286292cfaf30bda03351c1aaf6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-31 23:05:01 +00:00
Jeremy Sim 99cfd0905b Merge "Add error logging and better crash safety for app pairs" into main 2024-01-31 22:25:04 +00:00
Jordan Silva 2e75eeae32 Merge "Refactoring PagedOrientationHandler to extract functions from to quickstep" into main 2024-01-31 22:21:56 +00:00
Shamali Patwa ded14cc211 Merge "Update OWNERS for picker directory to include new owners." into main 2024-01-31 22:17:01 +00:00
Jagrut Desai 4d24ad9cbf Change Persistent/Pinned Taskbar App Icon Size to 40dp
Test: Manual, Presubmit
Bug: 322315240
Flag: NONE
Change-Id: Ibef82e18bbe33af51b27310ccd8052a02a35522c
2024-01-31 13:53:12 -08:00
Sunny Goyal 9491140eff Merge "Adding a flag to support activity overlay on home screen" into main 2024-01-31 21:40:26 +00:00
William Leshner de36f8a8ec Merge "Filter widgets in widget picker activity by size." into main 2024-01-31 21:38:45 +00:00
Rohit Goyal d4b2c8a858 Merge "UI Improvement: Fix unexpected progress bar around app icon added to Workspace after unarchival." into main 2024-01-31 20:42:08 +00:00