Commit Graph

78507 Commits

Author SHA1 Message Date
Sukesh Ram b332ff54d1 Debugging Logs for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash
Add logging for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 324940434
Change-Id: If20937ef63c07981ff708e7b50ee682201dcedfc
2024-03-21 15:00:54 -07:00
Sihua Ma 9b1a028bd4 Revert^2 "Move FastBitmapDrawableTest to Robolectric"
393477ca54

Change-Id: I051d2456c6930336c92ffe4c6101e6dd77a502c0
2024-03-21 21:50:20 +00:00
Sihua Ma 444b8e6d0f Revert^2 "Include AndroidX test rules in Robolectric tests"
c041b5c625

Change-Id: I0b93613ff8544cbe2a0a108da53bc085a532b074
2024-03-21 21:50:20 +00:00
Sukesh Ram 541c5d272d Revert "Call setOverviewDragState() whenever taskbar is recreated"
This reverts commit 0adca26744.

Reason for revert: potential cause of presubmit failures

Change-Id: I102d92f86afc7fa21c806d3cf1642e343dc91d45
2024-03-21 21:25:30 +00:00
Vadim Tryshev 2b9047a931 Merge "Removing SecondaryDisplayLauncherTest that are all @Ignored" into main 2024-03-21 21:06:42 +00:00
Andy Wickham 88972311a2 Consolidate settings for Assist.
Now there is just 1 toggle for all entrypoints.

Bug: 324036308
Test: Manual and unit tests
Flag: NA
Change-Id: Id4463345c44fa4daba4eac67b5ad00aff7f3a606
Merged-In: Id4463345c44fa4daba4eac67b5ad00aff7f3a606
2024-03-21 20:27:54 +00:00
Priyanka Advani 34c6253778 Merge changes from topic "revert-26605558-robolectric-enable-androidx-rules-OWMAZEJUYZ" into main
* changes:
  Revert "Include AndroidX test rules in Robolectric tests"
  Revert "Move FastBitmapDrawableTest to Robolectric"
2024-03-21 20:08:08 +00:00
Anushree Ganjam 6dadf21a7f Add FastScrollSectionInfo with "info icon" when work educard exists.
Before: https://b.corp.google.com/issues/325490294#comment1

After: https://b.corp.google.com/issues/325490294#comment5

Bug: 325490294
Test: Manual
Flag: NA
Change-Id: I557971cddd5829f46697004159d62a9343e75f69
2024-03-21 12:29:47 -07:00
Priyanka Advani c041b5c625 Revert "Include AndroidX test rules in Robolectric tests"
Revert submission 26605558-robolectric-enable-androidx-rules

Reason for revert: Droid-monitor created revert due to build breakages in b/330752689.

Reverted changes: /q/submissionid:26605558-robolectric-enable-androidx-rules

Change-Id: I7737d713be09faff78327df80232d084e836b500
2024-03-21 19:07:50 +00:00
Priyanka Advani 393477ca54 Revert "Move FastBitmapDrawableTest to Robolectric"
Revert submission 26605558-robolectric-enable-androidx-rules

Reason for revert: Droid-monitor created revert due to build breakages in b/330752689.

Reverted changes: /q/submissionid:26605558-robolectric-enable-androidx-rules

Change-Id: I7cb746baffc9bec3315dd324173fd9bde100e4cf
2024-03-21 19:07:50 +00:00
Holly Sun 44d2299ee7 [PS] Use onSurface for tint.
Screenshot:
https://screenshot.googleplex.com/6WSZJGdT9hY2Ww5
https://screenshot.googleplex.com/AiTX4JJjfRyfvPc

Bug: 325068252
Test: manual
Flag: aconfig enable_private_space trunkfood
Change-Id: I36bcf1156149630450ca3dfc063984e3deb6851f
2024-03-21 11:52:26 -07:00
Vadim Tryshev 9ae560d247 Removing SecondaryDisplayLauncherTest that are all @Ignored
Bug: 241166788
Test: presubmit
Flag: N/A
Change-Id: I2288bb0178b86517c44f5c6b572eb63236bb2986
2024-03-21 11:39:12 -07:00
Brandon Dayauon 65e373912b Remove applyBackground param in decorator
- This applyBackground() internally calls setBackground which is something that should not be
done in onDraw. Not needed anymore since privateprofile doesn't use the recyclerViewAnimationController anymore.
If it is still needed, when applyingBackground it should be done probably during onBind().
- When setBackground() is called during onDraw() there's a cyclic situation that ends up blocking the thread
and thats why you cannot see the privatespace be deleted.

bug: 329317904
Test: manual:
before: https://drive.google.com/file/d/1vAaA_juK8Bg2QB3oHhRmtiZxcHzEHHP1/view?usp=sharing
after: https://drive.google.com/file/d/1vAR6Okw17uskruHre8RrhsKa7-GiqE6k/view?usp=sharing
Flag: None
Change-Id: I06d31abb31496994d12b96fe6c0ca8cb26c93f69
2024-03-21 11:24:44 -07:00
Stefan Andonian 83578d13fa Explicitly set the Hotseat to not long or short clickable.
Bug: 318316718
Test: Verified this is no longer selected by switch access.
Flag: NA
Change-Id: I45a815ab816f9835e297d06eb1f5d0edcb29d837
2024-03-21 17:54:41 +00:00
Stefan Andonian e38a890b20 Make "Undo" button not be long-clickable explicitly.
This is causing accessibility bot issues for the switch access
feature.

Bug: 319369664
Flag: NA
Test: Verified via go/web-hv that this is no longer long-clickable.
Change-Id: I8a90d7093b60ddecdecc3374a34ce6828c1b7468
2024-03-21 17:46:55 +00:00
Ats Jenk ee7a069467 Merge "Set bubble bar alpha to 0 and collapse if it bubbles are hidden" into main 2024-03-21 17:15:45 +00:00
Sihua Ma f62002bb7d Merge "Include AndroidX test rules in Robolectric tests" into main 2024-03-21 17:06:45 +00:00
Sihua Ma cc54051d12 Merge "Move FastBitmapDrawableTest to Robolectric" into main 2024-03-21 17:06:45 +00:00
Federico Baron 09ec3e2623 Merge "Add screenrecord for simple reorder widgets test" into main 2024-03-21 16:12:31 +00:00
Treehugger Robot 3323296f0a Merge "Remove DesktopTaskView.isDesktopModeSupported" into main 2024-03-21 15:46:03 +00:00
Alex Chau 59781a7d79 Remove DesktopTaskView.isDesktopModeSupported
- Use Flags.eanbleDesktopWindowingMode directly
- Also clean up unnecessary and improper flag usage

Bug: 309008406
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Test: presubmit
Change-Id: I86ce317ce577f279d2ce819d6dc1738204c2631e
2024-03-21 14:05:27 +00:00
Helen Cheuk 8944afda32 Merge "Disable default focus highlight for Folder to fix the incorrect border issue" into main 2024-03-21 12:30:46 +00:00
Helen Cheuk 8896580b58 Merge "Change single stroke focus outline to double stroke" into main 2024-03-21 12:09:19 +00:00
Andreas Agvard 0e9901ebc0 [automerger skipped] Merge "Adds new AssistStateManager settings" into 24D1-dev am: eccda6f363 -s ours
am skip reason: Merged-In Ie5cbae55452cf283a0ffde18e5237cebae6ee40e with SHA-1 d78d9bb5e2 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26497249

Change-Id: Ib17e9ead4f0b9d79a0ed1b787032ec55754b155d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-21 11:11:01 +00:00
Andreas Agvard 3e10a0aac2 [automerger skipped] Adds new AssistStateManager settings am: efbd882a99 -s ours
am skip reason: Merged-In Ie5cbae55452cf283a0ffde18e5237cebae6ee40e with SHA-1 d78d9bb5e2 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26497249

Change-Id: I2e374249dd0440f0b08e554b8657a21766999949
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-21 11:10:57 +00:00
Andreas Agvard eccda6f363 Merge "Adds new AssistStateManager settings" into 24D1-dev 2024-03-21 10:55:01 +00:00
Treehugger Robot 362050932e Merge "Making some classess accessible in multivalent tests" into main 2024-03-21 10:38:08 +00:00
Tony Wickham 3c58551e12 Cancel animations after reading MotionPauseDetector#isPaused()
Otherwise, it clears MotionPauseDetector so isPaused returns false.

Fixes: 330186943
Flag: none
Test: manual
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:77802d6da48320e5f5cf5c420fe31a1aa14e478e)
Merged-In: I9e0982c18cc5264a1fab53077ac551d2880a6eae
Change-Id: I9e0982c18cc5264a1fab53077ac551d2880a6eae
24D1-dev is based on 24Q2-release. Therefore, we merged this CL to 24D1-dev.
2024-03-21 07:57:56 +00:00
Fengjiang Li 76f148b919 Merge "Revert accidental removal of PURPOSE_BUGFIX of flag enable_add_app_widget_via_config_activity_v2" into main 2024-03-21 03:19:55 +00:00
Vinit Nayak 05c6f5b6ae Merge "Call setOverviewDragState() whenever taskbar is recreated" into 24D1-dev am: 41e0e65bd4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26648914

Change-Id: I49eb26300d018b0142a1626001c5eb3cd926ef5a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-21 03:08:19 +00:00
Shamali Patwa f8cd95314c Merge "Update the available size for suggestions in small landscape heights." into main 2024-03-21 02:55:58 +00:00
Vinit Nayak 41e0e65bd4 Merge "Call setOverviewDragState() whenever taskbar is recreated" into 24D1-dev 2024-03-21 02:43:11 +00:00
Treehugger Robot 6a8662c560 Merge "Increase IME switcher Left Margins to meet spec" into main 2024-03-21 02:17:05 +00:00
Sukesh Ram aad306396e Increase IME switcher Left Margins to meet spec
Increase IME switcher Left Margins to meet specifications for taskbar. Result: https://screenshot.googleplex.com/5Ab33jnZiDY5tqm

Flag: NONE
Test: Manually tested in Felix Landscape mode.
Bug: 324269623
Change-Id: Ife3714c4d22d96851618a88ed217009c4f9c3929
2024-03-21 01:04:28 +00:00
Jeremy Sim 7675cc3c91 [automerger skipped] Prevent Save App Pair from showing up on 3p launcher am: c22b39a319 -s ours
am skip reason: Merged-In I60d6fd3b3eb39921edafb12faace743d16de270f with SHA-1 2b2d8cc90b is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26650431

Change-Id: I98469def8cbbe4bfe662fdf1a8022b7133109138
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-21 00:35:22 +00:00
Jeremy Sim c22b39a319 Prevent Save App Pair from showing up on 3p launcher
This CL adds a check so that app pairs can't be saved on 3p launchers. This affects the Overview icon dropdown menu and the Overview Actions Bar.

Fixes: 326155701
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, option does not show up when Nova Launcher is set as default home app, and shows up again for Pixel Launcher.
Change-Id: I60d6fd3b3eb39921edafb12faace743d16de270f
(cherry picked from commit 2b2d8cc90b)
Merged-In: I60d6fd3b3eb39921edafb12faace743d16de270f
2024-03-20 23:35:29 +00:00
Android Build Coastguard Worker 0ba5f32498 Snap for 11603317 from 3a7432d782 to 24Q3-release
Change-Id: I554a96eac529d63603af1067451a490c67e332e9
2024-03-20 23:21:24 +00:00
Sihua Ma c53a0bc25b Fix out-of-sync updates during grid change am: f0518bb89f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26645777

Change-Id: Icaaa311e42cdddd44aec6d50fdce847a87dc2b5e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-20 22:20:19 +00:00
Shamali P 55f1a39c15 Update the available size for suggestions in small landscape heights.
Bug: 330514207
Test: TAPL test
Flag: N/A
Change-Id: I1e1f43a46f4aa339bcafac013817846d893b0a9b
2024-03-20 22:12:00 +00:00
Willie Koomson 2471805414 Handle widgets added with tap-to-add in AppEventProducer
Widgets added with tap-to-add do not emit an ITEM_DROP_COMPELTED event,
so this change updates AppEventProducer to check for
WIDGET_ADD_BUTTON_TAP event so that it can emit an ACTION_PIN
event for these widgets as well.

Also moves the stats logging for tap to add to after
Launcher.addPendingItem is called, so that the PendingAddItem's container
is set to CONTAINER_DESKTOP.

Bug: 323886237
Test: manual, add widget and confirm event is produced through logging,
 and widget no longer appears in suggestions
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add STAGING
Change-Id: Iaf46a408d05f61864a79f87b23160364b6513323
2024-03-20 22:07:02 +00:00
Android Build Coastguard Worker fb79b46573 Merge cherrypicks of ['googleplex-android-review.googlesource.com/26553988'] into 24Q2-release.
Change-Id: Idbb328211a573fba49e7ff344305a55d528cee36
2024-03-20 21:30:36 +00:00
Andreas Agvard 28b28e0365 Removes recovery
Flag: NONE
Bug: 326143814
Test: Unit
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6ce297a2ff1583e49cf3e2e1e89d1ead7f83dac0)
Merged-In: Icbebeade552cb101eb4b8bae4965b4d6c972f22e
Change-Id: Icbebeade552cb101eb4b8bae4965b4d6c972f22e
2024-03-20 21:25:22 +00:00
Holly Sun 2509fa72f2 [PS] Update PS tile subtitle.
Screenshot: https://screenshot.googleplex.com/4mUyLoXh5zHchgx
Test: manual
Flag: aconfig com.google.android.apps.nexuslauncher.enable_inject_private_space_tile trunkfood
Bug: 324585814
Change-Id: I22a5448632cf1db628953287ba6ad362165e5351
2024-03-20 14:20:56 -07:00
Holly Sun f26fb3097a [PS] Return earlier if the input is null for matches.
In test environment, we get null string from resource, so just bypass this part.

Bug: 329442658
Test: manual
Flag: aconfig com.google.android.apps.nexuslauncher.enable_inject_private_space_tile trunkfood
Change-Id: If20586bcd882d6a705e8a670bc20a5cf5aa79ac2
2024-03-20 14:12:15 -07:00
Federico Baron 0584c86ce6 Revert "Add screenrecord for testOverviewDeadzones"
This reverts commit eb65ca1600.

Reason for revert: test fixed with ag/26635495

Change-Id: Ic6b131f7a50e8b4f651b601cdf30304ce587eb5d
2024-03-20 20:55:57 +00:00
fbaron 8248279894 Add screenrecord for simple reorder widgets test
Bug: 330019521
Test: TaplReorderWidgetsTest#simpleReorder
Flag: NONE
Change-Id: Ief042efa088246f964e0b35f1c1ae10a95c5a671
2024-03-20 13:46:47 -07:00
Vinit Nayak 5afb093a58 Merge "Add CUJ Jank interactions for App Pair saving and launching" into main 2024-03-20 20:31:01 +00:00
Sunny Goyal 5ca50490a3 Making some classess accessible in multivalent tests
Bug: 297950111
Flag: None
Test: Presubmit
Change-Id: I2e4b18fc279cb96b3f68d64f95703c11bb885b2a
2024-03-20 13:30:40 -07:00
Fengjiang Li 4cfdbafb20 Revert accidental removal of PURPOSE_BUGFIX of flag enable_add_app_widget_via_config_activity_v2
ag/26538984 accidentally removes PURPOSE_BUGFIX of enable_add_app_widget_via_config_activity_v2,
this CL will revert that part as a forward fix

Bug: 298089923
Flag: ACONFIG enable_add_app_widget_via_config_activity_v2 TEAMFOOD
Test: just a flag change
Change-Id: I29bbb8c60ae71978ee4129a4751fa4ad0d3706d3
2024-03-20 12:56:48 -07:00
Vinit Nayak 3b63408ad1 Call setOverviewDragState() whenever taskbar is recreated
* Un/Pinning taskbar re-creates controllers which led to
stale state for checking if we are allowing split selection

Test: Crash/immediately going into split no longer repros after
un/pinning taskbar in overview and trying to split
Fixes: 326356246

Change-Id: I06cfc4d1c3c7fe071f04414c3134eaff7960ade6
(cherry picked from commit 0adca26744)
2024-03-20 19:42:03 +00:00