Remove DesktopTaskView.isDesktopModeSupported
- Use Flags.eanbleDesktopWindowingMode directly - Also clean up unnecessary and improper flag usage Bug: 309008406 Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT Test: presubmit Change-Id: I86ce317ce577f279d2ce819d6dc1738204c2631e
This commit is contained in:
@@ -19,7 +19,7 @@ import static android.view.View.VISIBLE;
|
||||
|
||||
import static com.android.launcher3.LauncherState.BACKGROUND_APP;
|
||||
import static com.android.launcher3.util.Executors.MAIN_EXECUTOR;
|
||||
import static com.android.quickstep.views.DesktopTaskView.isDesktopModeSupported;
|
||||
import static com.android.window.flags.Flags.enableDesktopWindowingMode;
|
||||
|
||||
import android.os.Debug;
|
||||
import android.os.SystemProperties;
|
||||
@@ -136,7 +136,7 @@ public class DesktopVisibilityController {
|
||||
Log.d(TAG, "setVisibleFreeformTasksCount: visibleTasksCount=" + visibleTasksCount
|
||||
+ " currentValue=" + mVisibleFreeformTasksCount);
|
||||
}
|
||||
if (!isDesktopModeSupported()) {
|
||||
if (!enableDesktopWindowingMode()) {
|
||||
return;
|
||||
}
|
||||
|
||||
@@ -180,7 +180,7 @@ public class DesktopVisibilityController {
|
||||
Log.d(TAG, "setOverviewStateEnabled: enabled=" + overviewStateEnabled
|
||||
+ " currentValue=" + mInOverviewState);
|
||||
}
|
||||
if (!isDesktopModeSupported()) {
|
||||
if (!enableDesktopWindowingMode()) {
|
||||
return;
|
||||
}
|
||||
if (overviewStateEnabled != mInOverviewState) {
|
||||
@@ -202,7 +202,7 @@ public class DesktopVisibilityController {
|
||||
Log.d(TAG, "setBackgroundStateEnabled: enabled=" + backgroundStateEnabled
|
||||
+ " currentValue=" + mBackgroundStateEnabled);
|
||||
}
|
||||
if (!isDesktopModeSupported()) {
|
||||
if (!enableDesktopWindowingMode()) {
|
||||
return;
|
||||
}
|
||||
if (backgroundStateEnabled != mBackgroundStateEnabled) {
|
||||
@@ -229,7 +229,7 @@ public class DesktopVisibilityController {
|
||||
* Notify controller that recents gesture has started.
|
||||
*/
|
||||
public void setRecentsGestureStart() {
|
||||
if (!isDesktopModeSupported()) {
|
||||
if (!enableDesktopWindowingMode()) {
|
||||
return;
|
||||
}
|
||||
if (DEBUG) {
|
||||
@@ -243,7 +243,7 @@ public class DesktopVisibilityController {
|
||||
* {@link com.android.quickstep.GestureState.GestureEndTarget}
|
||||
*/
|
||||
public void setRecentsGestureEnd(@Nullable GestureState.GestureEndTarget endTarget) {
|
||||
if (!isDesktopModeSupported()) {
|
||||
if (!enableDesktopWindowingMode()) {
|
||||
return;
|
||||
}
|
||||
if (DEBUG) {
|
||||
|
||||
@@ -15,7 +15,7 @@
|
||||
*/
|
||||
package com.android.launcher3.taskbar;
|
||||
|
||||
import static com.android.quickstep.views.DesktopTaskView.isDesktopModeSupported;
|
||||
import static com.android.window.flags.Flags.enableDesktopWindowingMode;
|
||||
|
||||
import android.content.ComponentName;
|
||||
import android.content.pm.ActivityInfo;
|
||||
@@ -113,7 +113,7 @@ public final class KeyboardQuickSwitchController implements
|
||||
DesktopVisibilityController desktopController =
|
||||
LauncherActivityInterface.INSTANCE.getDesktopVisibilityController();
|
||||
final boolean onDesktop =
|
||||
isDesktopModeSupported()
|
||||
enableDesktopWindowingMode()
|
||||
&& desktopController != null
|
||||
&& desktopController.areFreeformTasksVisible();
|
||||
|
||||
@@ -154,7 +154,7 @@ public final class KeyboardQuickSwitchController implements
|
||||
|
||||
// Hide all desktop tasks and show them on the hidden tile
|
||||
int hiddenDesktopTasks = 0;
|
||||
if (isDesktopModeSupported()) {
|
||||
if (enableDesktopWindowingMode()) {
|
||||
DesktopTask desktopTask = findDesktopTask(tasks);
|
||||
if (desktopTask != null) {
|
||||
hiddenDesktopTasks = desktopTask.tasks.size();
|
||||
|
||||
@@ -21,7 +21,7 @@ import static com.android.launcher3.statemanager.BaseState.FLAG_NON_INTERACTIVE;
|
||||
import static com.android.launcher3.taskbar.TaskbarEduTooltipControllerKt.TOOLTIP_STEP_FEATURES;
|
||||
import static com.android.launcher3.taskbar.TaskbarLauncherStateController.FLAG_VISIBLE;
|
||||
import static com.android.quickstep.TaskAnimationManager.ENABLE_SHELL_TRANSITIONS;
|
||||
import static com.android.quickstep.views.DesktopTaskView.isDesktopModeSupported;
|
||||
import static com.android.window.flags.Flags.enableDesktopWindowingMode;
|
||||
|
||||
import android.animation.Animator;
|
||||
import android.animation.AnimatorSet;
|
||||
@@ -209,7 +209,7 @@ public class LauncherTaskbarUIController extends TaskbarUIController {
|
||||
DesktopVisibilityController desktopController =
|
||||
LauncherActivityInterface.INSTANCE.getDesktopVisibilityController();
|
||||
final boolean onDesktop =
|
||||
isDesktopModeSupported()
|
||||
enableDesktopWindowingMode()
|
||||
&& desktopController != null
|
||||
&& desktopController.areFreeformTasksVisible();
|
||||
if (onDesktop) {
|
||||
|
||||
@@ -27,7 +27,7 @@ import static com.android.launcher3.logging.StatsLogManager.LauncherEvent.LAUNCH
|
||||
import static com.android.launcher3.logging.StatsLogManager.LauncherEvent.LAUNCHER_TASKBAR_IME_SWITCHER_BUTTON_TAP;
|
||||
import static com.android.launcher3.logging.StatsLogManager.LauncherEvent.LAUNCHER_TASKBAR_OVERVIEW_BUTTON_LONGPRESS;
|
||||
import static com.android.launcher3.logging.StatsLogManager.LauncherEvent.LAUNCHER_TASKBAR_OVERVIEW_BUTTON_TAP;
|
||||
import static com.android.quickstep.views.DesktopTaskView.isDesktopModeSupported;
|
||||
import static com.android.window.flags.Flags.enableDesktopWindowingMode;
|
||||
import static com.android.systemui.shared.system.ActivityManagerWrapper.CLOSE_SYSTEM_WINDOWS_REASON_HOME_KEY;
|
||||
import static com.android.systemui.shared.system.ActivityManagerWrapper.CLOSE_SYSTEM_WINDOWS_REASON_RECENTS;
|
||||
import static com.android.systemui.shared.system.QuickStepContract.SYSUI_STATE_SCREEN_PINNING;
|
||||
@@ -281,7 +281,7 @@ public class TaskbarNavButtonController implements TaskbarControllers.LoggableTa
|
||||
private void navigateHome() {
|
||||
TaskUtils.closeSystemWindowsAsync(CLOSE_SYSTEM_WINDOWS_REASON_HOME_KEY);
|
||||
|
||||
if (isDesktopModeSupported()) {
|
||||
if (enableDesktopWindowingMode()) {
|
||||
DesktopVisibilityController desktopVisibilityController =
|
||||
LauncherActivityInterface.INSTANCE.getDesktopVisibilityController();
|
||||
if (desktopVisibilityController != null) {
|
||||
|
||||
@@ -62,7 +62,7 @@ import static com.android.launcher3.util.DisplayController.CHANGE_NAVIGATION_MOD
|
||||
import static com.android.launcher3.util.Executors.UI_HELPER_EXECUTOR;
|
||||
import static com.android.quickstep.util.AnimUtils.completeRunnableListCallback;
|
||||
import static com.android.quickstep.util.SplitAnimationTimings.TABLET_HOME_TO_SPLIT;
|
||||
import static com.android.quickstep.views.DesktopTaskView.isDesktopModeSupported;
|
||||
import static com.android.window.flags.Flags.enableDesktopWindowingMode;
|
||||
import static com.android.systemui.shared.system.ActivityManagerWrapper.CLOSE_SYSTEM_WINDOWS_REASON_HOME_KEY;
|
||||
import static com.android.wm.shell.common.split.SplitScreenConstants.SNAP_TO_50_50;
|
||||
|
||||
@@ -259,7 +259,7 @@ public class QuickstepLauncher extends Launcher {
|
||||
getDepthController(), getStatsLogManager(),
|
||||
systemUiProxy, RecentsModel.INSTANCE.get(this),
|
||||
() -> onStateBack());
|
||||
if (isDesktopModeSupported()) {
|
||||
if (enableDesktopWindowingMode()) {
|
||||
mDesktopRecentsTransitionController = new DesktopRecentsTransitionController(
|
||||
getStateManager(), systemUiProxy, getIApplicationThread(),
|
||||
getDepthController());
|
||||
@@ -285,7 +285,7 @@ public class QuickstepLauncher extends Launcher {
|
||||
mTISBindHelper = new TISBindHelper(this, this::onTISConnected);
|
||||
mDepthController = new DepthController(this);
|
||||
mDesktopVisibilityController = new DesktopVisibilityController(this);
|
||||
if (isDesktopModeSupported()) {
|
||||
if (enableDesktopWindowingMode()) {
|
||||
mDesktopVisibilityController.registerSystemUiListener();
|
||||
mSplitSelectStateController.initSplitFromDesktopController(this);
|
||||
}
|
||||
@@ -948,7 +948,7 @@ public class QuickstepLauncher extends Launcher {
|
||||
|
||||
@Override
|
||||
public void setResumed() {
|
||||
if (isDesktopModeSupported()) {
|
||||
if (enableDesktopWindowingMode()) {
|
||||
DesktopVisibilityController controller = mDesktopVisibilityController;
|
||||
if (controller != null && controller.areFreeformTasksVisible()
|
||||
&& !controller.isRecentsGestureInProgress()) {
|
||||
|
||||
@@ -18,7 +18,7 @@ package com.android.launcher3.uioverrides.states;
|
||||
import static com.android.launcher3.Flags.enableScalingRevealHomeAnimation;
|
||||
import static com.android.launcher3.logging.StatsLogManager.LAUNCHER_STATE_BACKGROUND;
|
||||
import static com.android.quickstep.TaskAnimationManager.ENABLE_SHELL_TRANSITIONS;
|
||||
import static com.android.quickstep.views.DesktopTaskView.isDesktopModeSupported;
|
||||
import static com.android.window.flags.Flags.enableDesktopWindowingMode;
|
||||
|
||||
import android.content.Context;
|
||||
import android.graphics.Color;
|
||||
@@ -92,7 +92,8 @@ public class BackgroundAppState extends OverviewState {
|
||||
|
||||
@Override
|
||||
protected float getDepthUnchecked(Context context) {
|
||||
if (isDesktopModeSupported() && Launcher.getLauncher(context).areFreeformTasksVisible()) {
|
||||
if (enableDesktopWindowingMode()
|
||||
&& Launcher.getLauncher(context).areFreeformTasksVisible()) {
|
||||
// Don't blur the background while freeform tasks are visible
|
||||
return BaseDepthController.DEPTH_0_PERCENT;
|
||||
} else if (enableScalingRevealHomeAnimation()) {
|
||||
|
||||
@@ -16,7 +16,7 @@
|
||||
package com.android.launcher3.uioverrides.states;
|
||||
|
||||
import static com.android.launcher3.logging.StatsLogManager.LAUNCHER_STATE_BACKGROUND;
|
||||
import static com.android.quickstep.views.DesktopTaskView.isDesktopModeSupported;
|
||||
import static com.android.window.flags.Flags.enableDesktopWindowingMode;
|
||||
|
||||
import android.graphics.Color;
|
||||
|
||||
@@ -46,7 +46,7 @@ public class QuickSwitchState extends BackgroundAppState {
|
||||
|
||||
@Override
|
||||
public int getWorkspaceScrimColor(Launcher launcher) {
|
||||
if (isDesktopModeSupported()) {
|
||||
if (enableDesktopWindowingMode()) {
|
||||
if (launcher.areFreeformTasksVisible()) {
|
||||
// No scrim while freeform tasks are visible
|
||||
return Color.TRANSPARENT;
|
||||
|
||||
@@ -59,9 +59,9 @@ import static com.android.quickstep.util.ActiveGestureErrorDetector.GestureEvent
|
||||
import static com.android.quickstep.util.ActiveGestureErrorDetector.GestureEvent.INVALID_VELOCITY_ON_SWIPE_UP;
|
||||
import static com.android.quickstep.util.ActiveGestureErrorDetector.GestureEvent.LAUNCHER_DESTROYED;
|
||||
import static com.android.quickstep.util.ActiveGestureErrorDetector.GestureEvent.ON_SETTLED_ON_END_TARGET;
|
||||
import static com.android.quickstep.views.DesktopTaskView.isDesktopModeSupported;
|
||||
import static com.android.quickstep.views.RecentsView.UPDATE_SYSUI_FLAGS_THRESHOLD;
|
||||
import static com.android.systemui.shared.system.ActivityManagerWrapper.CLOSE_SYSTEM_WINDOWS_REASON_RECENTS;
|
||||
import static com.android.window.flags.Flags.enableDesktopWindowingMode;
|
||||
|
||||
import android.animation.Animator;
|
||||
import android.animation.AnimatorListenerAdapter;
|
||||
@@ -947,7 +947,7 @@ public abstract class AbsSwipeUpHandler<T extends StatefulActivity<S>,
|
||||
public void onRecentsAnimationStart(RecentsAnimationController controller,
|
||||
RecentsAnimationTargets targets) {
|
||||
super.onRecentsAnimationStart(controller, targets);
|
||||
if (isDesktopModeSupported() && targets.hasDesktopTasks()) {
|
||||
if (enableDesktopWindowingMode() && targets.hasDesktopTasks()) {
|
||||
mRemoteTargetHandles = mTargetGluer.assignTargetsForDesktop(targets);
|
||||
} else {
|
||||
int untrimmedAppCount = mRemoteTargetHandles.length;
|
||||
@@ -1170,7 +1170,7 @@ public abstract class AbsSwipeUpHandler<T extends StatefulActivity<S>,
|
||||
mStateCallback.setState(STATE_SCALED_CONTROLLER_HOME | STATE_CAPTURE_SCREENSHOT);
|
||||
// Notify the SysUI to use fade-in animation when entering PiP
|
||||
SystemUiProxy.INSTANCE.get(mContext).setPipAnimationTypeToAlpha();
|
||||
if (isDesktopModeSupported()) {
|
||||
if (enableDesktopWindowingMode()) {
|
||||
// Notify the SysUI to stash desktop apps if they are visible
|
||||
DesktopVisibilityController desktopVisibilityController =
|
||||
mActivityInterface.getDesktopVisibilityController();
|
||||
|
||||
@@ -25,7 +25,7 @@ import static com.android.quickstep.GestureState.GestureEndTarget.LAST_TASK;
|
||||
import static com.android.quickstep.GestureState.GestureEndTarget.RECENTS;
|
||||
import static com.android.quickstep.util.RecentsAtomicAnimationFactory.INDEX_RECENTS_FADE_ANIM;
|
||||
import static com.android.quickstep.util.RecentsAtomicAnimationFactory.INDEX_RECENTS_TRANSLATE_X_ANIM;
|
||||
import static com.android.quickstep.views.DesktopTaskView.isDesktopModeSupported;
|
||||
import static com.android.window.flags.Flags.enableDesktopWindowingMode;
|
||||
import static com.android.quickstep.views.RecentsView.ADJACENT_PAGE_HORIZONTAL_OFFSET;
|
||||
import static com.android.quickstep.views.RecentsView.FULLSCREEN_PROGRESS;
|
||||
import static com.android.quickstep.views.RecentsView.RECENTS_SCALE_PROPERTY;
|
||||
@@ -109,7 +109,7 @@ public abstract class BaseActivityInterface<STATE_TYPE extends BaseState<STATE_T
|
||||
if (endTarget != null) {
|
||||
// We were on our way to this state when we got canceled, end there instead.
|
||||
startState = stateFromGestureEndTarget(endTarget);
|
||||
if (isDesktopModeSupported()) {
|
||||
if (enableDesktopWindowingMode()) {
|
||||
DesktopVisibilityController controller = getDesktopVisibilityController();
|
||||
if (controller != null && controller.areFreeformTasksVisible()
|
||||
&& endTarget == LAST_TASK) {
|
||||
|
||||
@@ -20,7 +20,7 @@ import static android.content.Intent.FLAG_ACTIVITY_EXCLUDE_FROM_RECENTS;
|
||||
|
||||
import static com.android.launcher3.util.Executors.UI_HELPER_EXECUTOR;
|
||||
import static com.android.quickstep.util.SplitScreenUtils.convertShellSplitBoundsToLauncher;
|
||||
import static com.android.quickstep.views.DesktopTaskView.isDesktopModeSupported;
|
||||
import static com.android.window.flags.Flags.enableDesktopWindowingMode;
|
||||
import static com.android.wm.shell.util.GroupedRecentTaskInfo.TYPE_FREEFORM;
|
||||
|
||||
import android.app.ActivityManager;
|
||||
@@ -270,7 +270,7 @@ public class RecentTasksList {
|
||||
|
||||
int numVisibleTasks = 0;
|
||||
for (GroupedRecentTaskInfo rawTask : rawTasks) {
|
||||
if (isDesktopModeSupported() && rawTask.getType() == TYPE_FREEFORM) {
|
||||
if (enableDesktopWindowingMode() && rawTask.getType() == TYPE_FREEFORM) {
|
||||
GroupTask desktopTask = createDesktopTask(rawTask);
|
||||
allTasks.add(desktopTask);
|
||||
continue;
|
||||
|
||||
@@ -27,7 +27,7 @@ import static com.android.launcher3.testing.shared.TestProtocol.OVERVIEW_STATE_O
|
||||
import static com.android.quickstep.OverviewComponentObserver.startHomeIntentSafely;
|
||||
import static com.android.quickstep.TaskUtils.taskIsATargetWithMode;
|
||||
import static com.android.quickstep.TaskViewUtils.createRecentsWindowAnimator;
|
||||
import static com.android.quickstep.views.DesktopTaskView.isDesktopModeSupported;
|
||||
import static com.android.window.flags.Flags.enableDesktopWindowingMode;
|
||||
|
||||
import android.animation.Animator;
|
||||
import android.animation.AnimatorListenerAdapter;
|
||||
@@ -144,7 +144,7 @@ public final class RecentsActivity extends StatefulActivity<RecentsState> {
|
||||
systemUiProxy, RecentsModel.INSTANCE.get(this),
|
||||
null /*activityBackCallback*/);
|
||||
mDragLayer.recreateControllers();
|
||||
if (isDesktopModeSupported()) {
|
||||
if (enableDesktopWindowingMode()) {
|
||||
mDesktopRecentsTransitionController = new DesktopRecentsTransitionController(
|
||||
getStateManager(), systemUiProxy, getIApplicationThread(),
|
||||
null /* depthController */
|
||||
|
||||
@@ -17,7 +17,8 @@ package com.android.quickstep;
|
||||
|
||||
import static android.app.WindowConfiguration.WINDOWING_MODE_FREEFORM;
|
||||
import static android.view.RemoteAnimationTarget.MODE_CLOSING;
|
||||
import static com.android.quickstep.views.DesktopTaskView.isDesktopModeSupported;
|
||||
|
||||
import static com.android.window.flags.Flags.enableDesktopWindowingMode;
|
||||
|
||||
import android.app.WindowConfiguration;
|
||||
import android.graphics.Rect;
|
||||
@@ -52,7 +53,7 @@ public class RecentsAnimationTargets extends RemoteAnimationTargets {
|
||||
* @return {@code true} if at least one target app is a desktop task
|
||||
*/
|
||||
public boolean hasDesktopTasks() {
|
||||
if (!isDesktopModeSupported()) {
|
||||
if (!enableDesktopWindowingMode()) {
|
||||
return false;
|
||||
}
|
||||
for (RemoteAnimationTarget target : apps) {
|
||||
|
||||
@@ -17,7 +17,7 @@
|
||||
package com.android.quickstep;
|
||||
|
||||
import static com.android.quickstep.util.SplitScreenUtils.convertShellSplitBoundsToLauncher;
|
||||
import static com.android.quickstep.views.DesktopTaskView.isDesktopModeSupported;
|
||||
import static com.android.window.flags.Flags.enableDesktopWindowingMode;
|
||||
import static com.android.wm.shell.util.SplitBounds.KEY_EXTRA_SPLIT_BOUNDS;
|
||||
|
||||
import android.app.WindowConfiguration;
|
||||
@@ -68,7 +68,7 @@ public class RemoteTargetGluer {
|
||||
* running tasks
|
||||
*/
|
||||
public RemoteTargetGluer(Context context, BaseActivityInterface sizingStrategy) {
|
||||
if (isDesktopModeSupported()) {
|
||||
if (enableDesktopWindowingMode()) {
|
||||
DesktopVisibilityController desktopVisibilityController =
|
||||
LauncherActivityInterface.INSTANCE.getDesktopVisibilityController();
|
||||
if (desktopVisibilityController != null) {
|
||||
|
||||
@@ -20,7 +20,7 @@ import static android.app.WindowConfiguration.WINDOWING_MODE_FREEFORM;
|
||||
import static android.content.Intent.FLAG_ACTIVITY_EXCLUDE_FROM_RECENTS;
|
||||
|
||||
import static com.android.launcher3.logging.StatsLogManager.LauncherEvent.LAUNCHER_SYSTEM_SHORTCUT_FREE_FORM_TAP;
|
||||
import static com.android.quickstep.views.DesktopTaskView.isDesktopModeSupported;
|
||||
import static com.android.window.flags.Flags.enableDesktopWindowingMode;
|
||||
|
||||
import android.app.Activity;
|
||||
import android.app.ActivityOptions;
|
||||
@@ -372,7 +372,7 @@ public interface TaskShortcutFactory {
|
||||
return Settings.Global.getInt(
|
||||
activity.getContentResolver(),
|
||||
Settings.Global.DEVELOPMENT_ENABLE_FREEFORM_WINDOWS_SUPPORT, 0) != 0
|
||||
&& !isDesktopModeSupported();
|
||||
&& !enableDesktopWindowingMode();
|
||||
}
|
||||
};
|
||||
|
||||
|
||||
@@ -38,7 +38,6 @@ import static com.android.launcher3.QuickstepTransitionManager.SPLIT_LAUNCH_DURA
|
||||
import static com.android.launcher3.Utilities.getDescendantCoordRelativeToAncestor;
|
||||
import static com.android.launcher3.util.MultiPropertyFactory.MULTI_PROPERTY_VALUE;
|
||||
import static com.android.quickstep.util.AnimUtils.clampToDuration;
|
||||
import static com.android.quickstep.views.DesktopTaskView.isDesktopModeSupported;
|
||||
|
||||
import android.animation.Animator;
|
||||
import android.animation.AnimatorListenerAdapter;
|
||||
@@ -183,7 +182,7 @@ public final class TaskViewUtils {
|
||||
// Re-use existing handles
|
||||
remoteTargetHandles = recentsViewHandles;
|
||||
} else {
|
||||
boolean forDesktop = isDesktopModeSupported() && v instanceof DesktopTaskView;
|
||||
boolean forDesktop = v instanceof DesktopTaskView;
|
||||
RemoteTargetGluer gluer = new RemoteTargetGluer(v.getContext(),
|
||||
recentsView.getSizeStrategy(), targets, forDesktop);
|
||||
if (forDesktop) {
|
||||
|
||||
@@ -35,7 +35,7 @@ import static com.android.quickstep.util.SplitSelectDataHolder.SPLIT_SINGLE_TASK
|
||||
import static com.android.quickstep.util.SplitSelectDataHolder.SPLIT_TASK_PENDINGINTENT;
|
||||
import static com.android.quickstep.util.SplitSelectDataHolder.SPLIT_TASK_SHORTCUT;
|
||||
import static com.android.quickstep.util.SplitSelectDataHolder.SPLIT_TASK_TASK;
|
||||
import static com.android.quickstep.views.DesktopTaskView.isDesktopModeSupported;
|
||||
import static com.android.window.flags.Flags.enableDesktopWindowingMode;
|
||||
import static com.android.wm.shell.common.split.SplitScreenConstants.KEY_EXTRA_WIDGET_INTENT;
|
||||
import static com.android.wm.shell.common.split.SplitScreenConstants.SNAP_TO_50_50;
|
||||
|
||||
@@ -966,7 +966,7 @@ public class SplitSelectStateController {
|
||||
@Override
|
||||
public boolean onRequestSplitSelect(ActivityManager.RunningTaskInfo taskInfo,
|
||||
int splitPosition, Rect taskBounds) {
|
||||
if (!isDesktopModeSupported()) return false;
|
||||
if (!enableDesktopWindowingMode()) return false;
|
||||
MAIN_EXECUTOR.execute(() -> enterSplitSelect(taskInfo, splitPosition,
|
||||
taskBounds));
|
||||
return true;
|
||||
|
||||
@@ -18,7 +18,7 @@ package com.android.quickstep.util;
|
||||
|
||||
import static com.android.launcher3.LauncherSettings.Favorites.ITEM_TYPE_APP_PAIR;
|
||||
import static com.android.launcher3.util.Executors.MODEL_EXECUTOR;
|
||||
import static com.android.quickstep.views.DesktopTaskView.isDesktopModeSupported;
|
||||
import static com.android.window.flags.Flags.enableDesktopWindowingMode;
|
||||
|
||||
import android.animation.Animator;
|
||||
import android.animation.AnimatorListenerAdapter;
|
||||
@@ -199,7 +199,7 @@ public class SplitToWorkspaceController {
|
||||
|
||||
private boolean shouldIgnoreSecondSplitLaunch() {
|
||||
return (!FeatureFlags.enableSplitContextually()
|
||||
&& !isDesktopModeSupported())
|
||||
&& !enableDesktopWindowingMode())
|
||||
|| !mController.isSplitSelectActive();
|
||||
}
|
||||
}
|
||||
|
||||
@@ -51,7 +51,6 @@ import com.android.quickstep.util.RecentsOrientedState;
|
||||
import com.android.systemui.shared.recents.model.Task;
|
||||
import com.android.systemui.shared.recents.model.ThumbnailData;
|
||||
import com.android.systemui.shared.system.QuickStepContract;
|
||||
import com.android.window.flags.Flags;
|
||||
|
||||
import kotlin.Unit;
|
||||
|
||||
@@ -88,11 +87,6 @@ public class DesktopTaskView extends TaskView {
|
||||
|
||||
private int mChildCountAtInflation;
|
||||
|
||||
/** Check whether desktop windowing is enabled */
|
||||
public static boolean isDesktopModeSupported() {
|
||||
return Flags.enableDesktopWindowingMode();
|
||||
}
|
||||
|
||||
public DesktopTaskView(Context context) {
|
||||
this(context, null);
|
||||
}
|
||||
|
||||
@@ -26,7 +26,7 @@ import static com.android.launcher3.LauncherState.OVERVIEW_MODAL_TASK;
|
||||
import static com.android.launcher3.LauncherState.OVERVIEW_SPLIT_SELECT;
|
||||
import static com.android.launcher3.LauncherState.SPRING_LOADED;
|
||||
import static com.android.launcher3.logging.StatsLogManager.LauncherEvent.LAUNCHER_SPLIT_SELECTION_EXIT_HOME;
|
||||
import static com.android.quickstep.views.DesktopTaskView.isDesktopModeSupported;
|
||||
import static com.android.window.flags.Flags.enableDesktopWindowingMode;
|
||||
|
||||
import android.annotation.TargetApi;
|
||||
import android.content.Context;
|
||||
@@ -268,7 +268,7 @@ public class LauncherRecentsView extends RecentsView<QuickstepLauncher, Launcher
|
||||
DesktopVisibilityController desktopVisibilityController = null;
|
||||
boolean showDesktopApps = false;
|
||||
GestureState.GestureEndTarget endTarget = null;
|
||||
if (isDesktopModeSupported()) {
|
||||
if (enableDesktopWindowingMode()) {
|
||||
desktopVisibilityController = mActivity.getDesktopVisibilityController();
|
||||
endTarget = mCurrentGestureEndTarget;
|
||||
if (endTarget == GestureState.GestureEndTarget.LAST_TASK
|
||||
|
||||
@@ -61,7 +61,7 @@ import static com.android.quickstep.util.TaskGridNavHelper.DIRECTION_RIGHT;
|
||||
import static com.android.quickstep.util.TaskGridNavHelper.DIRECTION_TAB;
|
||||
import static com.android.quickstep.util.TaskGridNavHelper.DIRECTION_UP;
|
||||
import static com.android.quickstep.views.ClearAllButton.DISMISS_ALPHA;
|
||||
import static com.android.quickstep.views.DesktopTaskView.isDesktopModeSupported;
|
||||
import static com.android.window.flags.Flags.enableDesktopWindowingMode;
|
||||
import static com.android.quickstep.views.OverviewActionsView.HIDDEN_ACTIONS_IN_MENU;
|
||||
import static com.android.quickstep.views.OverviewActionsView.HIDDEN_DESKTOP;
|
||||
import static com.android.quickstep.views.OverviewActionsView.HIDDEN_NON_ZERO_ROTATION;
|
||||
@@ -2791,7 +2791,7 @@ public abstract class RecentsView<ACTIVITY_TYPE extends StatefulActivity<STATE_T
|
||||
}
|
||||
|
||||
private boolean hasDesktopTask(Task[] runningTasks) {
|
||||
if (!isDesktopModeSupported()) {
|
||||
if (!enableDesktopWindowingMode()) {
|
||||
return false;
|
||||
}
|
||||
for (Task task : runningTasks) {
|
||||
@@ -3967,7 +3967,7 @@ public abstract class RecentsView<ACTIVITY_TYPE extends StatefulActivity<STATE_T
|
||||
// Update flags for 1p/3p launchers
|
||||
mActionsView.updateFor3pLauncher(!supportsAppPairs());
|
||||
|
||||
if (isDesktopModeSupported()) {
|
||||
if (enableDesktopWindowingMode()) {
|
||||
boolean isCurrentDesktop = getCurrentPageTaskView() instanceof DesktopTaskView;
|
||||
mActionsView.updateHiddenFlags(HIDDEN_DESKTOP, isCurrentDesktop);
|
||||
}
|
||||
@@ -4692,7 +4692,7 @@ public abstract class RecentsView<ACTIVITY_TYPE extends StatefulActivity<STATE_T
|
||||
mSplitSelectStateController.setAnimateCurrentTaskDismissal(
|
||||
true /*animateCurrentTaskDismissal*/);
|
||||
mSplitHiddenTaskViewIndex = indexOfChild(taskView);
|
||||
if (isDesktopModeSupported()) {
|
||||
if (enableDesktopWindowingMode()) {
|
||||
updateDesktopTaskVisibility(false /* visible */);
|
||||
}
|
||||
}
|
||||
@@ -4716,7 +4716,7 @@ public abstract class RecentsView<ACTIVITY_TYPE extends StatefulActivity<STATE_T
|
||||
mSplitSelectStateController.setInitialTaskSelect(splitSelectSource.intent,
|
||||
splitSelectSource.position.stagePosition, splitSelectSource.itemInfo,
|
||||
splitSelectSource.splitEvent, splitSelectSource.alreadyRunningTaskId);
|
||||
if (isDesktopModeSupported()) {
|
||||
if (enableDesktopWindowingMode()) {
|
||||
updateDesktopTaskVisibility(false /* visible */);
|
||||
}
|
||||
}
|
||||
@@ -4922,7 +4922,7 @@ public abstract class RecentsView<ACTIVITY_TYPE extends StatefulActivity<STATE_T
|
||||
mSplitHiddenTaskView.setThumbnailVisibility(VISIBLE, INVALID_TASK_ID);
|
||||
mSplitHiddenTaskView = null;
|
||||
}
|
||||
if (isDesktopModeSupported()) {
|
||||
if (enableDesktopWindowingMode()) {
|
||||
updateDesktopTaskVisibility(true /* visible */);
|
||||
}
|
||||
}
|
||||
@@ -5312,7 +5312,7 @@ public abstract class RecentsView<ACTIVITY_TYPE extends StatefulActivity<STATE_T
|
||||
}
|
||||
|
||||
RemoteTargetGluer gluer;
|
||||
if (isDesktopModeSupported() && recentsAnimationTargets.hasDesktopTasks()) {
|
||||
if (recentsAnimationTargets.hasDesktopTasks()) {
|
||||
gluer = new RemoteTargetGluer(getContext(), getSizeStrategy(), recentsAnimationTargets,
|
||||
true /* forDesktop */);
|
||||
mRemoteTargetHandles = gluer.assignTargetsForDesktop(recentsAnimationTargets);
|
||||
|
||||
@@ -40,7 +40,6 @@ import static com.android.launcher3.util.SplitConfigurationOptions.getLogEventFo
|
||||
import static com.android.quickstep.TaskOverlayFactory.getEnabledShortcuts;
|
||||
import static com.android.quickstep.util.ActiveGestureErrorDetector.GestureEvent.EXPECTING_TASK_APPEARED;
|
||||
import static com.android.quickstep.util.BorderAnimator.DEFAULT_BORDER_COLOR;
|
||||
import static com.android.quickstep.views.DesktopTaskView.isDesktopModeSupported;
|
||||
|
||||
import static java.lang.annotation.RetentionPolicy.SOURCE;
|
||||
|
||||
@@ -426,8 +425,7 @@ public class TaskView extends FrameLayout implements Reusable {
|
||||
mCurrentFullscreenParams = new FullscreenDrawParams(context);
|
||||
mDigitalWellBeingToast = new DigitalWellBeingToast(mActivity, this);
|
||||
|
||||
boolean keyboardFocusHighlightEnabled = FeatureFlags.ENABLE_KEYBOARD_QUICK_SWITCH.get()
|
||||
|| isDesktopModeSupported();
|
||||
boolean keyboardFocusHighlightEnabled = FeatureFlags.ENABLE_KEYBOARD_QUICK_SWITCH.get();
|
||||
boolean cursorHoverStatesEnabled = enableCursorHoverStates();
|
||||
|
||||
setWillNotDraw(!keyboardFocusHighlightEnabled && !cursorHoverStatesEnabled);
|
||||
|
||||
@@ -2730,7 +2730,7 @@ public class Launcher extends StatefulActivity<LauncherState>
|
||||
|
||||
private void updateDisallowBack() {
|
||||
if (Flags.enableDesktopWindowingMode()) {
|
||||
// Do not disable back in launcher when prototype behavior is enabled
|
||||
// TODO(b/330183377) disable back in launcher when when we productionize
|
||||
return;
|
||||
}
|
||||
LauncherRootView rv = getRootView();
|
||||
|
||||
Reference in New Issue
Block a user