Commit Graph

78507 Commits

Author SHA1 Message Date
Ats Jenk 259552350e Set bubble bar alpha to 0 and collapse if it bubbles are hidden
Only set bubble bar alpha to 0 and mark it collapsed when bubbles are
hidden.
When bubble bar should be hidden due to system ui state, only update
visibility.

Bug: 324068295
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: trigger a buble from bubbles test app
  - swipe to home screen
  - observe bubble bar is shown
  - swipe notification shade down and away again
  - observe bubble bar is hidden when shade is open, and shown when
    closed
  - expand bubble bar
  - repeat swipe shade down and away, observe expanded bubble is hidden
    while shade is open and bubble is expanded when shade is swiped away
Change-Id: Icc717ab250061f14f02a558eb9f7301fdc08c5c7
2024-03-20 12:12:53 -07:00
Federico Baron 3a7432d782 Merge "Make touch outside container touch at the middle of the container in terms of height" into main 2024-03-20 18:08:14 +00:00
Vinit Nayak e0c3403a9a Merge "Call setOverviewDragState() whenever taskbar is recreated" into main 2024-03-20 17:20:48 +00:00
Sihua Ma f0518bb89f Fix out-of-sync updates during grid change
This is a combination of two issues:

1. Widget updates are not passed to the holder when the launcher binding starts
2. Updates from widgetHost.startListening() are overriden by out-of-date info

Fix: 322919716
Test: Manual
Flag: N/A
Change-Id: I9665117412c87b19ed5d98263bb4f9b8da21c5c7
(cherry picked from commit f418b2e16d)
2024-03-20 16:58:00 +00:00
randypfohl c91aad150c When mLastComputedTaskSize is empty we will recalculate and set it before determining scale and pivot
Bug: 326550571

Test: manually set computed task size to 0 simulating unset circumstance, and ran logs verifying infinite, added fix, and verified logs showing the same scale before and after with get tasksize set

Flag: none

(cherry picked from commit fca7ee23ba)
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:9c4039e12dbc20dabf1d7e62b06bfd650706eaa7)
Merged-In: I0f928885e2fc6cfc0d6a064d6e9f1c614bf7a5af
Change-Id: I0f928885e2fc6cfc0d6a064d6e9f1c614bf7a5af
2024-03-20 16:37:55 +00:00
Willie Koomson 1b0e8eea61 Merge "Set initial bind options for widgets added with tap-to-add" into main 2024-03-20 16:23:19 +00:00
Rohit Goyal f21220c79d Bugfix: In case of unarchival, do not add an installer task to add workspace item. am: f8302c388f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26598401

Change-Id: I538d3804b9fdd8ed6d8425abaad38087083d15d7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-20 12:59:12 +00:00
Andreas Agvard efbd882a99 Adds new AssistStateManager settings
Flag: NONE
Bug: 326143814
Test: Unit

Merged-In: Ie5cbae55452cf283a0ffde18e5237cebae6ee40e
Change-Id: Ie5cbae55452cf283a0ffde18e5237cebae6ee40e
2024-03-20 12:55:42 +00:00
Eghosa Ewansiha-Vlachavas dc40eeae80 Merge "Disable quickswitch interactions with desktop mode" into main 2024-03-20 12:22:13 +00:00
Rohit Goyal f8302c388f Bugfix: In case of unarchival, do not add an installer task to add workspace item.
* In case install queue is cleared (which happens when launcher comes back to foregorund from background) when app has successfully unarchived, since app is not archived anymore, `AddWorkspaceItemTask` successfully manages to add item to the workspace.
* We should avoid adding pending task for adding workspace item in the queue at all for unarchival to prevent this.

Test: verified bugfixes locally.
Bug: 326495267
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: Iae6d6390d8e2d9b270f7aef0dce1fa32d9899f28
2024-03-20 11:12:38 +00:00
Alex Chau 4a2c9ae112 Merge "Ignoring a test that was flaky for a too long time" into main 2024-03-20 10:49:53 +00:00
Tiger 425aec696f Let taskbar can trigger insets resize animation
All the system bar can trigger insets resize animation before, but some
sources might not have the resize animation. The framework now will only
trigger insets resize animation for sources which apply
FLAG_ANIMATE_RESIZING. So this CL applies the flag for gesture taskbar
because it can toggle its size via "Always show Taskbar"

Bug: 291562764
Flag: NA
Test: Fold and unfold a foldable device and ensure that won't create
      InsetsResizeAnimationRunner.
Change-Id: I0d915422d160a81f12c3992ffe53200fd957f6d7
2024-03-20 17:45:12 +08:00
Treehugger Robot 60484e3e2a Merge "Fixing async inflation not happening for first page" into main 2024-03-20 07:53:38 +00:00
Sunny Goyal e5a95ed11d Fixing async inflation not happening for first page
Bug: 330416518
Test: atest AsyncBindingTest
Flag: aconfig enable_workspace_inflation STAGING
Change-Id: Iab9b203dfab36367cdf531d2dbf023bfbaefe224
2024-03-19 23:28:13 -07:00
Andy Wickham 16cad65a85 Merge "Consolidate settings for Assist." into main 2024-03-20 03:00:08 +00:00
Fengjiang Li b7e9427dc9 Merge "[Predictive Back] Refactor setClipChildrenOnViewTree/restoreClipChildrenOnViewTree to support clipToPadding" into main 2024-03-20 01:21:09 +00:00
Android Build Coastguard Worker a51a330e95 Merge cherrypicks of ['googleplex-android-review.googlesource.com/26621456'] into 24Q2-release.
Change-Id: I79e949cad4d4e9e3fb06f81f8a12a21b5ecd7f5c
2024-03-20 01:17:02 +00:00
Tony Wickham f027b4eb36 Cancel animations after reading MotionPauseDetector#isPaused()
Otherwise, it clears MotionPauseDetector so isPaused returns false.

Fixes: 330186943
Flag: none
Test: manual
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:77802d6da48320e5f5cf5c420fe31a1aa14e478e)
Merged-In: I9e0982c18cc5264a1fab53077ac551d2880a6eae
Change-Id: I9e0982c18cc5264a1fab53077ac551d2880a6eae
2024-03-20 01:15:25 +00:00
Shamali Patwa eef12ba5b7 Merge "Retain recommendations (if possible) while picker is open" into main 2024-03-20 00:41:41 +00:00
Vinit Nayak 0adca26744 Call setOverviewDragState() whenever taskbar is recreated
* Un/Pinning taskbar re-creates controllers which led to
stale state for checking if we are allowing split selection

Test: Crash/immediately going into split no longer repros after
un/pinning taskbar in overview and trying to split
Fixes: 326356246

Change-Id: I06cfc4d1c3c7fe071f04414c3134eaff7960ade6
2024-03-19 17:30:33 -07:00
Willie Koomson a55f214d71 Set initial bind options for widgets added with tap-to-add
Calls PendingAddWidgetInfo.getDefaultSizeOptions to set the bind options
for widgets added with tap-to-add.

Bug: 323886237
Test: manual, place Drive/Gmail widget and confirm correct initial size
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add DEVELOPMENT
Change-Id: Ib0143e3ff49b62d6394d6ca362d89b0ea9773e5f
2024-03-20 00:24:19 +00:00
fbaron 30bd886364 Make touch outside container touch at the middle of the container in terms of height
Bug: 326839375
Test: TaplTestsQuickstep#testOverviewDeadzones
Flag: NONE
Change-Id: I7a013ab7d146756cbff009c21b838881e09e044a
2024-03-19 16:44:07 -07:00
Kevin Lim 44d9d1370c Merge "[Deviceless] Create launcher-multivalent-src for referring from NexusLauncherRoboTests" into main 2024-03-19 23:40:49 +00:00
Android Build Coastguard Worker d7c71025c1 Snap for 11597038 from 2bbbc2a37e to 24Q3-release
Change-Id: I33dd94e371f878fb843df1a0eb77c8f8b8826dca
2024-03-19 23:21:03 +00:00
Fengjiang Li ea7cb497f5 [Predictive Back] Refactor setClipChildrenOnViewTree/restoreClipChildrenOnViewTree to support clipToPadding
Bug: 325930715
Test: Added unit test
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Change-Id: I509546ac4ee1fa851cf0648d365a5348362267cc
2024-03-19 15:28:38 -07:00
Shamali P b081314330 Retain recommendations (if possible) while picker is open
Picker rebinds recommendations when size constraints change or
fold/unfold, but recommendations from popup provider may have changed.
This is an attempt at trying to maintain currently shown items
as much possible.

Also, align the pagination and title to the top in two pane picker
 (confirmed with David that we prefer this version)

Additionally, we don't show the widgets count for suggestions.

Bug: 318410881
Flag: ACONFIG com.android.launcher3.enable_categorized_widget_recommendations DEVELOPMENT
Test: Manual

Change-Id: I60799f9ad38da913c3e084d758f5b82c79cd641c
2024-03-19 21:26:14 +00:00
Federico Baron 89f974aa56 Merge "Remove logspam for resolved bug" into 24D1-dev am: 7bd1fa82f6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26621166

Change-Id: I755c37ffac29a5fa3e541ca7853666cbd01324c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-19 21:22:53 +00:00
Android Build Coastguard Worker df4f4233b9 Merge cherrypicks of ['googleplex-android-review.googlesource.com/26544662'] into 24Q2-release.
Change-Id: Ibda688aab845164e368a7cd5663a1963b72ace2f
2024-03-19 21:06:03 +00:00
Brian Isganitis fbda2e6ccb Reset stashed in Taskbar All Apps for gestures instead of IME insets.
Test: Manual
Flag: NONE
Fix: 328960039
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:1956246b6e7098aeaeece3760b1ea97d096d3588)
Merged-In: I62c53c21bf850b7080e12086235cba28164f4d70
Change-Id: I62c53c21bf850b7080e12086235cba28164f4d70
2024-03-19 21:03:07 +00:00
Federico Baron 7bd1fa82f6 Merge "Remove logspam for resolved bug" into 24D1-dev 2024-03-19 21:02:29 +00:00
Sunny Goyal 39a24e7c9b Merge "Only use async bind if the callbacks supports it" into main 2024-03-19 20:31:52 +00:00
Tony Wickham 86d8386ab6 Merge "Add TaplTestsQuickstep#testExcludeFromRecents" into main 2024-03-19 20:28:58 +00:00
Sihua Ma 4ff471c2f0 Move FastBitmapDrawableTest to Robolectric
Flag: N/A
Bug: 297950111
Test: atest Launcher3RoboTests
Change-Id: Icef741a1c19bb494f7b74078ce1e7f52ed55a769
2024-03-19 20:27:29 +00:00
Sihua Ma 6da8d07f83 Include AndroidX test rules in Robolectric tests
Test: atest Launcher3RoboTests
Bug: 297950111
Flag: N/A
Change-Id: I6f3c9ddeac9cb676644b3a236a00575c4faaa921
2024-03-19 20:26:40 +00:00
Kevin Lim a14145aad4 [Deviceless] Create launcher-multivalent-src for referring from
NexusLauncherRoboTests

Bug: b/297950111
Bug: b/322393087
Flag: NA
Test: atest Launcher3RoboTests
Test: atest NexusLauncherRoboTests
Change-Id: I8ac58862d53f8574a6678502fcf9488f812eaa1f
2024-03-19 20:11:37 +00:00
Vadim Tryshev 69e1d97653 Ignoring a test that was flaky for a too long time
Bug: 315376057
Flag: N/A
Test: presubmit
Change-Id: I34576501606eea999379733b4e36fb81cc137ef7
2024-03-19 11:50:23 -07:00
Sunny Goyal bf9d02adfe Only use async bind if the callbacks supports it
Bug: 330158016
Bug: 330160059
Test: Presubmmit
Flag: aconfig enable_workspace_inflation STAGING
Change-Id: I7ac62090207db4b78ead8f44b126077ea62fc41b
2024-03-19 11:45:04 -07:00
helencheuk 51ec59dd1f Disable default focus highlight for Folder to fix the incorrect border issue
Agreed with UX that removing visible focus on first ESC keypress is the expected behaviour
So it is disabled in this CL to avoid the square corner focus state

Bug: 329892471
Test: Manual
Flag: N/A
Change-Id: I721bf0916374842c582b6b6523cc4cd5ce78fc02
2024-03-19 18:13:24 +00:00
Anna Zhuravleva 2bbbc2a37e Merge "Log number of apps in Private space" into main 2024-03-19 16:51:18 +00:00
Fengjiang Li c19e337202 Merge "[Predictive Back] Support WidgetsTwoPaneSheet" into main 2024-03-19 01:53:10 +00:00
Android Build Coastguard Worker 8ed0e8be9c Merge cherrypicks of ['googleplex-android-review.googlesource.com/26567274'] into 24Q2-release.
Change-Id: Ibb69521f75e2e0472d38674fc18c3df473caa233
2024-03-19 01:10:56 +00:00
fbaron d44f2ec5df Fix bug where folder with 1 icon can exist
Fix: 329357132
Flag: NONE
Test: TaplDragTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:5645c3ec558e2b0b6d6ae1c51dbaf93803cd51cf)
Merged-In: If381ff56e051c89e9f6162f8a44f8df9e2ae5060
Change-Id: If381ff56e051c89e9f6162f8a44f8df9e2ae5060
2024-03-19 01:09:55 +00:00
Treehugger Robot 4d22811f76 Merge "Cancel animations after reading MotionPauseDetector#isPaused()" into main 2024-03-18 23:53:17 +00:00
Vinit Nayak 422a634a24 Add CUJ Jank interactions for App Pair saving and launching
* Added finishCallback consumer to LauncherAccessibilityDelegate
to inform when adding an item to workspace was completed.
* The logic seemed to be dependent on the parameter
"focusForAccessibility", but all callers of that are currently
passing in true

Bug: 328646540
Test: https://paste.googleplex.com/6232597136408576
Newly added CUJs showing up when playing w/ device

Change-Id: Ia4944f8d23634bb92296938ea2d07a6babf6f77c
2024-03-18 16:27:47 -07:00
Vinit Nayak c2a6055768 Merge "Launch overview instance of app for taskbar in Overview" into main 2024-03-18 23:21:23 +00:00
Android Build Coastguard Worker 9f04df07f2 Snap for 11591048 from 7d5531757b to 24Q3-release
Change-Id: I57d8ba26cd49308334a91f6cb7da0ab4b053e9a2
2024-03-18 23:21:13 +00:00
Brian Isganitis d1af1ec631 Merge "Support toggling Taskbar All Apps with 3P Launcher." into main 2024-03-18 23:17:55 +00:00
Fengjiang Li c51363fc46 [Predictive Back] Support WidgetsTwoPaneSheet
Fix: 325930715
Test: Manual - attached video to bug
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Change-Id: I44098de12253f803526160bce6457a940b2153c7
2024-03-18 15:31:13 -07:00
Tony Wickham b84b8524a1 Add TaplTestsQuickstep#testExcludeFromRecents
- Add ExcludeFromRecentsTestActivity, and add it to the manifest
  with excludeFromRecents="true"
- Add the test to check the current Overview task content
  description, ensuring that the excludeFromRecents task is
  present directly after a gesture but not after going home.
Bug: 324495241
Flag: None
Test: TaplTestsQuickstep#testExcludeFromRecents

Change-Id: I06be53673f0ac06924f79b44f19744da066cc7ea
2024-03-18 22:30:13 +00:00
Vinit Nayak b761e9834e Launch overview instance of app for taskbar in Overview
* This only works for fullscreen tasks, app pairs aren't
properly launching yet
* We re-layer the leash to be above launcher since live tiles
are originally below
* The new task comes in from TaskAnimationManager#onTaskAppeared

Bug: 316485863
Test: Tested w/ tapping fullscreen apps in overview when
their thumbnail is scrolled off screen. Animation occurs for
both live tile and thumbnail

Change-Id: I5a3c079244a1517becb845ce25ff9f4e671383b1
2024-03-18 14:41:57 -07:00