Commit Graph

78507 Commits

Author SHA1 Message Date
Sebastián Franco 0ec7c1e4a8 Merge "Generate grid migration cases and test if they are valid" into main 2024-03-28 16:31:37 +00:00
Liran Binyamin 074a3a66b0 Initial animation of new bubble bar bubble
This change animates a new bubble bar bubble. Currently only handles the case where the bubble is added when the bubble bar is stashed.
There's no synchronization with the stash handle yet either.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605790
Test: atest BubbleBarViewAnimatorTest
Change-Id: Ic3f5edc0dde204f871cf7e1288bd50620e6beebb
2024-03-28 11:30:56 -04:00
Uwais Ashraf 1e6d1112ba Merge "Add test and android lifecycle coroutine libs" into main 2024-03-28 14:04:29 +00:00
Uwais Ashraf 1a4052a44f Merge "Remove unused code and fix warnings" into main 2024-03-28 14:03:36 +00:00
Alex Chau cf452cbb3b [automerger skipped] Align action_buttons at bottom of OverviewActionsView am: 3c34c89cca -s ours
am skip reason: Merged-In Iadcdf5731485f42f9586703e34e55ed9b4121bf9 with SHA-1 6431d6e879 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26748369

Change-Id: Icc22d3c9da0ed1d75a1a20fd91e95ae4287b74c3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-28 13:40:53 +00:00
Alex Chau ff7ec04234 [automerger skipped] Revert "Log split button visibility to debug spacing issue" am: 2165ad7b0e -s ours
am skip reason: Merged-In I88a4350277ea3e965493da6386cf4c83c5c564e4 with SHA-1 a5d55fe5ef is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26745016

Change-Id: I7bfe12c11511cc704f853059c6904c54f4edbd7f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-28 13:10:54 +00:00
Alex Chau 3c34c89cca Align action_buttons at bottom of OverviewActionsView
- http://ag/q/topic:%22b/329255757%22 caused a regression that in landscape, action_buttons shifted up when ShareTarget become visible, because OverviewActionsView become taller when this happens, and the topMargin is no longer valid to put actions_button at the position we want
- Bring back layout_gravity="bottom" solves the issue, as bottomMarign is always correct

Fix: 331517987
Test: manual as ShareTarget requires AiAi interaction and cannot easily be mocked
Flag: None
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:6431d6e87910bc7c7767c40d42f51961dc462134)
Merged-In: Iadcdf5731485f42f9586703e34e55ed9b4121bf9
Change-Id: Iadcdf5731485f42f9586703e34e55ed9b4121bf9
2024-03-28 13:03:03 +00:00
Alex Chau 76d04b46df Merge "Align action_buttons at bottom of OverviewActionsView" into main 2024-03-28 13:00:11 +00:00
Alex Chau 2165ad7b0e Revert "Log split button visibility to debug spacing issue"
This reverts commit 2d55c9c679.

Reason for revert: Logs not helpful in figuring out the issue and is too spammy
Bug: 321291049
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a5d55fe5efad4db1678dfe7960f82df68b664b7d)
Merged-In: I88a4350277ea3e965493da6386cf4c83c5c564e4
Change-Id: I88a4350277ea3e965493da6386cf4c83c5c564e4
2024-03-28 12:13:30 +00:00
Alex Chau c7dea26289 Merge "Revert "Log split button visibility to debug spacing issue"" into main 2024-03-28 12:12:29 +00:00
Schneider Victor-tulias 5a85b4f2df Close the KQS view when touching the gesture nav region
Also, stop handling KQS open/close during gestures

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 328689890
Fixes: 328689534
Fixes: 328692760
Test: attempted gestures while KQS is shown. attempted KQS while attempting gestures
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:14d912b062e69fe8bc4729b6f8b40e53d5b4a669)
Merged-In: Idbd1f9cef09d9fbf611350d0847d94ccf8300369
Change-Id: Idbd1f9cef09d9fbf611350d0847d94ccf8300369
24D1-dev is based on 24Q2-release. Therefore, we merged this CL to 24D1-dev.
2024-03-28 07:27:09 +00:00
wilsonshih cc39a10dd0 Do not report finish in mergeAnimation...
...if the handler don't know how to process the transition.
So the Transitions can pass that transition to next handler.

Flag: NONE
Bug: 328619216
Test: manual, use alt+tab to relaunch a task where it's activity
is destroyed.
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:7130116894eb7f756a16da6b5ff0e754a356d50d)
Merged-In: Idf3f78103a56e91806ec2f6e364c6e8e7f4e205c
Change-Id: Idf3f78103a56e91806ec2f6e364c6e8e7f4e205c
24D1-dev is based on 24Q2-release. Therefore, we merged this CL to 24D1-dev.
2024-03-28 07:21:57 +00:00
Schneider Victor-tulias 3d001dee6b Update KQS task view layouts to new specs
The small size of the screenshots and make text look odd. Implementing new UI specs to improve this.

- Updated icon position and size
- Added some blur to the thumbnail

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 328259439
Fixes: 328692456
Test: opened KQS in dark and light mode
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:dba7cbae1adfde615060598a55b5ee0edfedef9f)
Merged-In: I2b20100ddeb562291edf5f0bacbce916002eee45
Change-Id: I2b20100ddeb562291edf5f0bacbce916002eee45
24D1-dev is based on 24Q2-release. Therefore, we merged this CL to 24D1-dev.
2024-03-28 06:56:20 +00:00
Jeremy Sim de9b132f08 Update save app pair icon
This CL changes the save app pair menu icon to the latest spec. It looks good!

Fixes: 331525186
Flag: N/A
Test: Manual
Change-Id: Ic73f78a27372aca565fce2e3be3e9f3b8ef1d942
(cherry picked from commit 1d48159bd5)
2024-03-28 04:44:18 +00:00
Jeremy Sim 5f9329dccd Fix bug with long strings not aligning left on menu items
This CL sets gravity="start" and ellipsize="end" so that longer strings in the Overview app dropdown menu are still left-aligned and ellipsized when they are longer than the container.

Fixes: 330426535
Flag: N/A
Test: Manual
Change-Id: I1e62412c9b8be41a8dbb6b0597a69a283a56e3f0
(cherry picked from commit 6867b18db2)
2024-03-28 04:44:11 +00:00
Jeremy Sim 75216f9108 Merge "Fix bug with long strings not aligning left on menu items" into main 2024-03-28 01:45:15 +00:00
Jeremy Sim c61f4ede3c Merge "Update save app pair icon" into main 2024-03-28 01:44:55 +00:00
Fengjiang Li 61102b66e8 Merge "Extend CUJ_LAUNCHER_CLOSE_ALL_APPS_BACK to start as early as when user starts predictive back swipe" into main 2024-03-28 01:02:00 +00:00
Luca Zuccarini b65bc82efb Merge "Move interfaces to the shared library." into main 2024-03-28 00:17:47 +00:00
Andy Wickham 355d4e25c7 [automerger skipped] Merge "Consolidate settings for Assist." into 24D1-dev am: d6b0dc8970 -s ours
am skip reason: Merged-In Id4463345c44fa4daba4eac67b5ad00aff7f3a606 with SHA-1 3081537398 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26652400

Change-Id: I9de3a0741557c8a308a19d5ddb6c23c2cdf6ecac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-28 00:09:27 +00:00
Andy Wickham 61696f901a [automerger skipped] Consolidate settings for Assist. am: 88972311a2 -s ours
am skip reason: Merged-In Id4463345c44fa4daba4eac67b5ad00aff7f3a606 with SHA-1 3081537398 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26652400

Change-Id: I18c2bee1e18f72e1ab01240cbcea61c9e27352cb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-28 00:09:24 +00:00
Andy Wickham d6b0dc8970 Merge "Consolidate settings for Assist." into 24D1-dev 2024-03-27 23:56:23 +00:00
Android Build Coastguard Worker 382e81acde Snap for 11635697 from bc657f64c3 to 24Q3-release
Change-Id: Ia114ac82a14c887e53b6b1751d61dfd3c8268ac6
2024-03-27 23:21:09 +00:00
Fengjiang Li 10c03e499d Extend CUJ_LAUNCHER_CLOSE_ALL_APPS_BACK to start as early as when user starts predictive back swipe
Bug: 330405993
Test: prefetto trace https://ui.perfetto.dev/#!/?s=58c0513fe0190f84ea1621a96d790a53b83fefc1ee402085b0d75bfc7b51e019
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Change-Id: I76c32975e5ae6dcb0395d2eee68417f761455262
2024-03-27 16:03:47 -07:00
Sebastian Franco efab2489d6 Generate grid migration cases and test if they are valid
This makes sure the grid migration logic always produces
valid results.

Bug: 313900847
Bug: 323525592
Flag: NA
Test: ValidGridMigrationUnitTest.kt
Change-Id: I76b19e1fa315f8a997afad34e5a4df7cc465b0c2
2024-03-27 14:03:07 -07:00
Brandon Dayauon 8838a68cbe [automerger skipped] Disable two line text legacy flag. am: 50f9dbd0a5 -s ours
am skip reason: Merged-In Idef427bad6551ae56b13e35393e076b8e000af5a with SHA-1 68c18236ad is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26733768

Change-Id: If1705f04d5dd2b94bb7661c80e532295defce197
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-27 20:30:55 +00:00
Brian Isganitis 346776b4d6 Merge "Force refresh AllAppsActionManager for tests." into main 2024-03-27 19:25:43 +00:00
Jeremy Sim 1d48159bd5 Update save app pair icon
This CL changes the save app pair menu icon to the latest spec. It looks good!

Fixes: 331525186
Flag: N/A
Test: Manual
Change-Id: Ic73f78a27372aca565fce2e3be3e9f3b8ef1d942
2024-03-27 11:33:26 -07:00
Brandon Dayauon bdb5836ada Add 16dp between nav bar and container by setting extra padding to the recyclerView.
bug:298593161
Test: manual:
(Adjusting bottom padding of recyclerView):
3button nav after closed: https://drive.google.com/file/d/1xTXtzOC-n3_vGXs34FjL_52jiY60piAA/view?usp=sharing
3button nav after opened: https://drive.google.com/file/d/1xS4Wu41-4ogYzVRh1UxDW39DZW214vSz/view?usp=sharing
gesture nav after closed: https://drive.google.com/file/d/1xQGL-Qi5sGwWqQsOLQAsvxpNlJGklBSg/view?usp=sharing
gesture nav after opened: https://drive.google.com/file/d/1xQ9YNUv89RsT9Tsa85BlEt64twDHk-l6/view?usp=sharing

(USING DIVIDER METHOD):
3button nav after closed: https://drive.google.com/file/d/1YG1pFmU4023-wO2okC_wkwsW5L8IUTkl/view?usp=sharing
3button nav after opened: https://drive.google.com/file/d/1YCBIqzFkxNH9fNuE0o2YTz_221ZRAmSA/view?usp=sharing
gesture nav after closed: https://drive.google.com/file/d/1YIBRglQk6SsSe7_nbggcQZBE7aERGT74/view?usp=sharing
gesture nav after opened: https://drive.google.com/file/d/1YGzbgQPRFKhuSZ95BF6fx_8NfPyocCxN/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space

Change-Id: Ibfd4896c1477b3e498389d6451ca458a01d98952
2024-03-27 11:01:22 -07:00
Brandon Dayauon 50f9dbd0a5 Disable two line text legacy flag.
Will now repurpose the twolinetoggle flag to be the flag that will
make twoline text enabled/disabled.

bug: 316027081
Test: presubmit
manually: https://screenshot.googleplex.com/BsZGCm7DrTZLwG4
Flag: com.android.launcher3.enable_twoline_toggle Staging
Merged-In: Idef427bad6551ae56b13e35393e076b8e000af5a
Change-Id: Idef427bad6551ae56b13e35393e076b8e000af5a
2024-03-27 17:07:04 +00:00
Jagrut Desai bc657f64c3 Merge "Remove Taskbar Pinning menu when in three button navigation mode" into main 2024-03-27 16:46:53 +00:00
Jagrut Desai 112691f2f0 Merge "Customize BubbleTextView for Taskbar Icon Size" into main 2024-03-27 16:46:16 +00:00
Uwais Ashraf 2725da5dd1 Remove unused code and fix warnings
Bug: 330326121
Test: Presubmit - change is a no-op
Flag: NA
Change-Id: If656113fce6bae82466d9482a92a15f689da00b6
2024-03-27 16:17:07 +00:00
Alex Chau 6431d6e879 Align action_buttons at bottom of OverviewActionsView
- http://ag/q/topic:%22b/329255757%22 caused a regression that in landscape, action_buttons shifted up when ShareTarget become visible, because OverviewActionsView become taller when this happens, and the topMargin is no longer valid to put actions_button at the position we want
- Bring back layout_gravity="bottom" solves the issue, as bottomMarign is always correct

Fix: 331517987
Test: manual as ShareTarget requires AiAi interaction and cannot easily be mocked
Flag: None
Change-Id: Iadcdf5731485f42f9586703e34e55ed9b4121bf9
2024-03-27 16:05:50 +00:00
helencheuk a3d40b0501 Add focus outline to overview clear all button
Use the same class BorderAnimator in TaskView to draw focus outline with padding between button and outline as UX design

Bug: 324911125
Test: Manual, launcher overview, use keyboard left arrow to show clear all button, outline should be shown
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Change-Id: I62ac2ce7a8f62170421b4318c9fa58805384187b
2024-03-27 14:15:08 +00:00
Liran Binyamin 65bf9fac38 Merge "Move PhysicsAnimator to wm/shell/shared" into main 2024-03-27 14:00:03 +00:00
Andreas Agvard 54ca5033e2 Merge "Adds agvard@ to OWNERS file." into main 2024-03-27 11:50:33 +00:00
Uwais Ashraf 6e9927e61f Add test and android lifecycle coroutine libs
Fix: 330128421
Bug: 330127493
Test: Presubmit build passes
Flag: NA
Change-Id: I87cf3b5faaee6bcdb99c5afbe1999a11d031d98e
2024-03-27 10:23:36 +00:00
Jeremy Sim 6867b18db2 Fix bug with long strings not aligning left on menu items
This CL sets gravity="start" and ellipsize="end" so that longer strings in the Overview app dropdown menu are still left-aligned and ellipsized when they are longer than the container.

Fixes: 330426535
Flag: N/A
Test: Manual
Change-Id: I1e62412c9b8be41a8dbb6b0597a69a283a56e3f0
2024-03-27 04:47:24 +00:00
Luca Zuccarini 8fe1d9c8ae Move interfaces to the shared library.
Bug: 323863002
Flag: NA
Test: NA, just a move
Change-Id: I8390bdbc226f53da2cbdf2c4321a67e7b7223bec
2024-03-27 04:42:35 +00:00
Android Build Coastguard Worker dad6cb5379 Snap for 11629448 from 62a11974fa to 24Q3-release
Change-Id: I1fdd4a821a13811d2c3bd249fc3394425d51bfb6
2024-03-27 01:22:09 +00:00
Android Build Coastguard Worker 29bcecd67e Merge cherrypicks of ['googleplex-android-review.googlesource.com/26570364', 'googleplex-android-review.googlesource.com/26587909'] into 24Q2-release.
Change-Id: I9e393c9b9df64bb7cdbd0c733170acada1f17428
2024-03-26 23:38:53 +00:00
Brian Isganitis d28eb4a852 Support toggling Taskbar All Apps with 3P Launcher.
Taskbar All Apps exists regardless of the default launcher. Thus, we can
toggle it on large screen devices. This CL ties registering the system
action to default launcher and taskbar's enablement.

Test: adb shell input keyevent 117
Test: AllAppsActionManagerTest
Flag: LEGACY ENABLE_ALL_APPS_SEARCH_IN_TASKBAR ENABLED
Fix: 317259709
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:c113b277e61eb0391f050d6c12bf36711d727733)
Merged-In: I26f0ed9e921beac762f3f9e6aaceb1002ad4801a
Change-Id: I26f0ed9e921beac762f3f9e6aaceb1002ad4801a
2024-03-26 23:36:45 +00:00
Schneider Victor-tulias ed9b5e0a5a Close the KQS view when touching the gesture nav region
Also, stop handling KQS open/close during gestures

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 328689890
Fixes: 328689534
Fixes: 328692760
Test: attempted gestures while KQS is shown. attempted KQS while attempting gestures
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:14d912b062e69fe8bc4729b6f8b40e53d5b4a669)
Merged-In: Idbd1f9cef09d9fbf611350d0847d94ccf8300369
Change-Id: Idbd1f9cef09d9fbf611350d0847d94ccf8300369
2024-03-26 23:36:33 +00:00
Gina Ko be35eeb4ea Merge "Reapply "Support toggling Taskbar All Apps with 3P Launcher." am: 036a83cd99" into main 2024-03-26 22:48:51 +00:00
Gina Ko 5b845d2831 Reapply "Support toggling Taskbar All Apps with 3P Launcher." am: 036a83cd99
The revert was not supposed to be auto-merged.

This reverts commit 5a3bf93d82, reversing
changes made to 84f8002586.

Bug: 331384026
Change-Id: Ieb11a8544db90259aae856c4af805c37ce9e68cc
2024-03-26 15:03:31 -07:00
Holly Jiuyu Sun 5455931d9d Merge "[PS] Return earlier if the input is null for matches." into main 2024-03-26 21:30:04 +00:00
Liana Kazanova 5a3bf93d82 Revert "Support toggling Taskbar All Apps with 3P Launcher." am: 036a83cd99
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/26720630

Change-Id: I235f6d6263be6e39a583ac7b1a0783bfc77533c9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-03-26 20:57:12 +00:00
Holly Jiuyu Sun 84f8002586 Merge "[PS] Update PS tile subtitle." into main 2024-03-26 20:42:48 +00:00
Jagrut Desai c6f09490f7 Remove Taskbar Pinning menu when in three button navigation mode
Test: Manual
Bug: 331167630
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning NEXTFOOD
Change-Id: I257d1d3c0b3b37ef639578d0ccc6ec8d23d3d266
2024-03-26 13:42:09 -07:00