Commit Graph

78507 Commits

Author SHA1 Message Date
fbaron fba55b4383 Demote testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty to postsubmit
Flag: NONE
Test: TaplTwoPanelWorkspaceTest#testEmptyPageDoesNotGetRemovedIfPagePairIsNotEmpty
Bug: 329935119
Change-Id: I284803b7ebe5c094dc46178d34cca952726df745
2024-05-03 13:34:15 -07:00
Holly Sun 3b36a82cff allKeys in DeviceConfigHelper should be populated with keys.
We have 2 instances of `DeviceConfigHelper`. One is `DeviceConfigHelper<SearchConfigProvider>` which contains all the old keys. One is DeviceConfigHelper<DeviceConfigWrapper> which contains all the new(omni) keys.

Bug: 338430152
Test: manual
Flag: NA
Change-Id: Ic0450df795888c8e5e7892157a8596cd86eb0d99
2024-05-03 13:25:03 -07:00
Hongwei Wang 74871dd543 Merge "Add debugging information on PiP content overlay" into 24D1-dev am: a089315793
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27194437

Change-Id: I55acfa699c68a701e77d2bba86a02935b233392d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-03 20:15:32 +00:00
Hongwei Wang a089315793 Merge "Add debugging information on PiP content overlay" into 24D1-dev 2024-05-03 19:57:50 +00:00
Treehugger Robot 7cc2ab636f Merge "Determine split leash position by taskId instead of bounds" into main 2024-05-03 19:56:54 +00:00
Vinit Nayak 9a3b1ce673 Determine split leash position by taskId instead of bounds
* Previously we were comparing bounds of the leash to determine
which leash was leftTop vs bottomRight
* That didn't work when we were translating the split apps when
IME is showing in portrait split screen
* Transitions between IME showing to recents animation could
probably use some work, but that itself is not a regression.

Bug: 330714602
Test: Tested on large and small screen with IME up on both apps
No more empty hole

Change-Id: Ie08ac644e5d1bcc48ba57e05e25bbee66afa3d37
2024-05-03 19:13:34 +00:00
Charlie Anderson 496198ac4a Merge "Fixes padding for app icons in Launcher preview for Foldable devices in unfolded state." into main 2024-05-03 18:46:00 +00:00
Tracy Zhou b5ed0714ce Merge "Add ime back button logic to the init block of NavbarButtonsViewController" into 24D1-dev am: 098c477a04
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27204834

Change-Id: Ifa4b2a33968ca6ac08c9b00b65274b3cb89f9753
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-03 18:23:10 +00:00
Tracy Zhou 098c477a04 Merge "Add ime back button logic to the init block of NavbarButtonsViewController" into 24D1-dev 2024-05-03 18:05:55 +00:00
Alex Chau 17d5f77ff5 Remove TaskView.isDesktopTask
- Replace with DesktopTaskView instanceOf check

Bug: 249371338
Test: Manual
Flag: None
Change-Id: I02034775d3b76646ec4603026fc9e617b055f77c
2024-05-03 19:05:54 +01:00
Anushree Ganjam 37845c540b Add dump for PredictionRowView.
adb shell dumpsys activity NexusLauncherActivity : https://paste.googleplex.com/4907497231482880

When AllApps prediction is off : https://paste.googleplex.com/5930628737925120

Bug: 332171918
Test: Manual
Flag: NA
Change-Id: I753ff876aab162026d99fd1b35f63edf2e712f70
(cherry picked from commit 1115b416bb)
2024-05-03 17:08:44 +00:00
Ats Jenk 919ce27068 Merge "Add myself to launcher OWNERS" into main 2024-05-03 16:53:53 +00:00
Ats Jenk b67d07912c Merge "Drag bubble in bubble bar to other side" into main 2024-05-03 16:41:55 +00:00
Ats Jenk a5be42a09d Add myself to launcher OWNERS
Bug: N/A
Change-Id: Iaf5fadef98f11f6f5b215f1f0359ea564b56bdb2
Flag: N/A
Test: N/A
2024-05-03 16:15:45 +00:00
Charlie Anderson 0920311107 Fixes padding for app icons in Launcher preview for Foldable devices in unfolded state.
Also adds unit tests for the padding.

Bug: 332566064
Test: manually verify
Flag: N/A
Change-Id: Ic9227086b4025b4f266f2f2305159f032c21556b
2024-05-03 16:07:24 +00:00
Treehugger Robot 9947b09f8f [automerger skipped] Merge "RESTRICT AUTOMERGE Set the container field of aconfig flags" into main am: 0f602c773a am: 35334686ab -s ours
am skip reason: contains skip directive

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3068204

Change-Id: I833ac830c48f7f7b63833e66e2ce01a0d9b72f72
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-03 14:59:56 +00:00
Oriol Prieto Gasco 613ef7fc91 [automerger skipped] RESTRICT AUTOMERGE am: d167e4c3df am: 19f7e8178c -s ours
am skip reason: contains skip directive

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3068204

Change-Id: Ie393c208e0d60d483927a11d670c5ea5bae11ebf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-03 14:59:52 +00:00
Treehugger Robot 35334686ab Merge "RESTRICT AUTOMERGE Set the container field of aconfig flags" into main am: 0f602c773a
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3068204

Change-Id: I5755b223ef07f0d3ad7407865d802eac7b41a9b8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-03 14:31:43 +00:00
Oriol Prieto Gasco 19f7e8178c RESTRICT AUTOMERGE am: d167e4c3df
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3068204

Change-Id: I31cd78c8570a2c05069d8fd4b1e6fb2eb44f99bc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-03 14:31:39 +00:00
Treehugger Robot 0f602c773a Merge "RESTRICT AUTOMERGE Set the container field of aconfig flags" into main 2024-05-03 14:10:05 +00:00
Bill Yi 259b5de19e Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I7a18f5fbfd9fb0483147d4608c545289768e66ba
2024-05-03 01:50:06 -07:00
Bill Yi ed3431b768 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ie080576afbf469c8e1bd801555f22463afa06da9
2024-05-03 01:49:37 -07:00
Bill Yi 831f809488 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ife5b424551eab5f89913e70b14d370bcd8e034bd
2024-05-03 01:48:39 -07:00
Bill Yi 1d754e69ad Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I85e4106f6ac809bffdab9d91ef8700211d940c28
2024-05-03 01:48:12 -07:00
Vinit Nayak 0b1524e09f [automerger skipped] Merge "Allow single root candidate for app pair launch for pip edge case" into 24D1-dev am: afb770c737 -s ours
am skip reason: Merged-In I415343a48e980afd7f4e511558d350cf15b97ca1 with SHA-1 23b85ffdba is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27182236

Change-Id: I26962082a49dfb08c4d4b40f8b5a01c5af248c5e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-03 06:54:55 +00:00
Vinit Nayak dd3edb6ed8 [automerger skipped] Allow single root candidate for app pair launch for pip edge case am: 55270a9f70 -s ours
am skip reason: Merged-In I415343a48e980afd7f4e511558d350cf15b97ca1 with SHA-1 23b85ffdba is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27182236

Change-Id: I308d53d5b15973845868f38e7d34e3354c55c35b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-03 06:54:51 +00:00
Vinit Nayak afb770c737 Merge "Allow single root candidate for app pair launch for pip edge case" into 24D1-dev 2024-05-03 06:30:43 +00:00
Tracy Zhou 7b4cd90332 Add ime back button logic to the init block of NavbarButtonsViewController
Fixes: 338320015
Test: Run adb shell am start -a android.intent.action.MAIN -n com.google.android.setupwizard/.SetupWizardTestActivity. Make sure the back key shows by default but hides when IME renders back arrow.
Change-Id: I8baeb10d3f5b13c3bac084872d77d881c1513733
(cherry picked from commit 4b43cfbc04)
2024-05-03 06:24:59 +00:00
Holly Jiuyu Sun 6b85675657 Merge "[reset] Clean up ActivityAllAppsContainerView#reset." into main 2024-05-03 00:49:26 +00:00
Anushree Ganjam c1adbe3b4b Merge "Revert "When AllAppsSearchBarController's mInput edit text focus is false, we should hidekeyboard."" into main 2024-05-03 00:34:32 +00:00
Android Build Coastguard Worker 71906f74b9 Snap for 11794304 from 76f2828d52 to 24Q3-release
Change-Id: I7902b55170099c3864b668dafd8e0a61c34ce9b4
2024-05-02 23:21:52 +00:00
Willie Koomson a6f1bd55d4 Merge changes from topic "update-widget-font" into main
* changes:
  Fix resize frame corner radius for widgets added with button
  Hide add button text if cell is too narrow
  Update font settings to match POR
2024-05-02 23:07:40 +00:00
Kevin Lim c338db0a67 [Deviceless] Move BubbleTextViewTest to multivalentTests for deviceless
testing.

Bug: b/297950111
Flag: NA
Test: atest Launcher3RoboTests
Test: atest NexusLauncherRoboTests
Test: Passes in SysUI Studio
Change-Id: Ib94e704836e0e21b8f8f05d987bec3e8ba633afa
2024-05-02 22:53:41 +00:00
Vinit Nayak 55270a9f70 Allow single root candidate for app pair launch for pip edge case
* Shell will launch single task if requested split apps have one of them
already in Pip
* Create a separate method to set animation for launching from the
appPair icon on workspace
* Reuse the animation method for launching an AppPair icon from taskbar
by specifying which windowing mode to look for if we're launching the
actual split pair vs just one in fullscreen

Bug: 323089902
Test: Launches fine visually
Change-Id: I415343a48e980afd7f4e511558d350cf15b97ca1
Merged-In: I415343a48e980afd7f4e511558d350cf15b97ca1
2024-05-02 22:49:25 +00:00
Vinit Nayak 070c3661d5 Determine split leash position by taskId instead of bounds
* Previously we were comparing bounds of the leash to determine
which leash was leftTop vs bottomRight
* That didn't work when we were translating the split apps when
IME is showing in portrait split screen
* Transitions between IME showing to recents animation could
probably use some work, but that itself is not a regression.

Bug: 330714602
Test: Tested on large and small screen with IME up on both apps
No more empty hole

Change-Id: Ie08ac644e5d1bcc48ba57e05e25bbee66afa3d37
2024-05-02 15:45:23 -07:00
Holly Sun d7b532afcb [reset] Clean up ActivityAllAppsContainerView#reset.
Digged into the history of this part, some code is duplicated and thus removed. See https://docs.google.com/document/d/1mp1HwLhkLE_o0o_InhntFz3oIGsg94b9XucAal0IgOE/edit?tab=t.0#bookmark=id.130cyqeojzrk

ag/24198780 introduced the `MAIN_EXECUTOR.getHandler().post` part, which is still needed for logging purpose.

Bug: 328505782
Test: manual
Flag: NA
Change-Id: Ie7622c497b803f722fd734d30c4c3d9692d152c6
2024-05-02 15:38:49 -07:00
Sukesh Ram 8bce9e5940 Replace Contextual Rotation Button with Floating Action Button
When foldable is in 3 button, the rotation button is covered by the device’s camera cutout upon rotation.

This CL replaces Contextual Rotation Button with Floating Action Button for taskbar and navbar.

Flag: NONE
Test: Manually tested on Felix & panther.
Bug: 324070001
Change-Id: I8bd9acdeec8ade4c8183c42056bf67b1c825906c
Merged-In: I8bd9acdeec8ade4c8183c42056bf67b1c825906c
2024-05-02 22:30:49 +00:00
Anushree Ganjam bc2acdaf5c Revert "When AllAppsSearchBarController's mInput edit text focus is false, we should hidekeyboard."
This reverts commit d169cb3667.

Reason for revert: Probably causes jank regression. See b/336280300 for details.

Bug: b/336280300

Change-Id: I82918a33b04c58f0778d584d57e418d7dbb1e672
2024-05-02 22:29:15 +00:00
Anushree Ganjam 8b770b7166 Remove Verify getProfileUser calls since it's making test flaky.
There is enough asserts in the test to verify SystemShortcut is not null.

Bug: 333909497
Test: Manual
Flag: NA
Change-Id: I287a910f0f101ce8bc2c1e8678dbff0ced30a1dc
2024-05-02 15:17:46 -07:00
Treehugger Robot 0ff6c0a50d Merge "Debug TaplAddConfigWidgetTest test" into main 2024-05-02 22:16:42 +00:00
Tracy Zhou c9b5b0a3dd Merge "Add ime back button logic to the init block of NavbarButtonsViewController" into main 2024-05-02 21:16:54 +00:00
Sukesh Ram 05d48b3986 Debug TaplAddConfigWidgetTest test
Flag: NONE
Bug: 324419890
Test: Check logs when flake is reproduced
Change-Id: I90b419aa300df53247fc07e00aabe575a33fb95f
2024-05-02 20:32:09 +00:00
Fengjiang Li c2ef74306b Merge "[Launcher Jank] Pass single threaded Executor to RotationButtonController so that binder calls are ordered." into main 2024-05-02 20:08:50 +00:00
Willie Koomson 14c321de31 Fix resize frame corner radius for widgets added with button
Before this CL, the resize frame showed a mismatched corner radius
for widgets that have a non-default corner radius, when using the
add button. This is because widgets added with the button may not have
had `onLayout` called before the resize frame is set up.

This change adds a layout listener to the widget view, so that the frame
can set its corner radius once the view has been laid out.

Bug: none
Test: manual test
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: Ia9c37ae595be48e4ecab7930e17efca9a27ed05d
2024-05-02 19:55:41 +00:00
Willie Koomson 1156e8419a Hide add button text if cell is too narrow
If the WidgetCell is not wide enough, hide the add button text and show
an icon-only plus button.

Bug: 333735974
Test: manual
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add NEXTFOOD
Change-Id: Ieb0b2e679bd4a5785a0f7f01e177ad412a355ce7
2024-05-02 19:55:41 +00:00
Willie Koomson 61dc97ecb2 Update font settings to match POR
Updates font color, size, weight, and line height for text in the widget
picker to match POR and pass a11y test.

Bug: 317948371
Flag: NONE
Test: Accessibility Scanner contrast test
Change-Id: I3c7676c507b81a616876206681972ebb9fefd0c3
2024-05-02 19:55:33 +00:00
Treehugger Robot a3009176a9 Merge "Give bubble team owners on the correct launcher bubble dirs" into main 2024-05-02 19:47:20 +00:00
Sebastián Franco 76f2828d52 Merge "Print the test cases and the solutions of ReorderAlgorithmUnitTest" into main 2024-05-02 19:38:45 +00:00
Liran Binyamin 841411d122 Give bubble team owners on the correct launcher bubble dirs
Whoops.

Flag: N/A
Test: treehugger
Bug: none
Change-Id: I25df1a161d94bd1acac976bc61217a59b3657074
2024-05-02 15:33:16 -04:00
Treehugger Robot f7ed35fc87 Merge "Locking the All Apps view before asserting PS components." into main 2024-05-02 19:02:42 +00:00