Commit Graph

78507 Commits

Author SHA1 Message Date
fbaron 136b7d347e Demote and add screenrecord for TaplUninstallRemoveTest
Flag: NONE
Bug: 338869019
Test: TaplUninstallRemoveTest#testAddDeleteShortcutOnHotseat
Change-Id: Icfc2f22ecd6eb4bec3309e60adb4ec44fb89eb94
2024-05-08 09:51:37 -07:00
Sihua Ma 8128575f46 Merge "Move cell layout tests to deviceless tests" into main 2024-05-08 16:50:44 +00:00
Himanshu Gupta a3da6fc6bd Marking testPrivateSpaceLockingBehaviour as disabled.
Temporarily disabling the test as there are failures
seen.
Will be renabled, once the RCA of errors is found.

Bug: 339179262
Test: NA
Flag: NA
Change-Id: I4e4a0b9f8b7290e5be27770a4ded2355a2cc74de
2024-05-08 16:30:07 +01:00
Uwais Ashraf 9533b0fb27 Add corner rounding to TaskThumbnailView
Fix: 334826840
Test: TaskThumbnailViewModelTest
Flag: ACONFIG com.android.launcher3.enable_refactor_task_thumbnail DEVELOPMENT
Change-Id: Iba4d49d43abc09363f61186c3fcc07f2281b7006
2024-05-08 14:45:44 +00:00
Jordan Demeulenaere 5512003c0d Delay TransitionAnimator.onAnimationEnd by one frame (2/4)
Bug: 330672236
Test: atest ActivityTransitionAnimatorTest
Test: atest DialogTransitionAnimatorTest
Flag: N/A
Change-Id: I81e85df79256d013f6c3ef5cb58a5d96c0c7deec
2024-05-08 16:28:53 +02:00
Orhan Uysal 906df388ef Merge "Add quick switch flag for desktop windowing cases." into main 2024-05-08 11:17:56 +00:00
Ivan Chiang 61abfb9738 [Archive] Update the content description for the archived app
Change the string from "App is archived. Tap to download." to
"App is archived. Tap to download and restore."

Flag: ACONFIG com.android.launcher3.enable_support_for_archiving NEXTFOOD
Bug: 337976645
Test: Manual. Enable the Talkback. Check the result
Change-Id: I72d2fb2bd2d75a3b44a97637273e78a94d6f1880
2024-05-08 10:57:36 +00:00
Anna Zhuravleva 9f3bca37e6 Merge "Log animation jank" into main 2024-05-08 08:22:57 +00:00
fbaron 39e1d52c1b Reduce steps for goHome()
The goHome gesture is slow enough sometimes that it gets confused with an overview gesture. Reducing the step count should resolve this (verified in atest and haven't had it fail after changing this)

Flag: NONE
Bug: 336606166
Test: TaplTestsTrackpad#switchToOverview
Change-Id: I7ad388968205addb363cfd9ff4b7eefece170d1b
2024-05-07 20:48:30 -07:00
Kevin Liu a75ea0b8cb Add strict_mode: false
As strict mode is in place, the default strict_mode is now set to true. We are encourage teams to write tests in strict_mode to make tests Bivalent (able to run on device and devicelessly)

Flag: NONE
Test: atest Launcher3RoboTests
Bug: 334089788
Change-Id: I4b4f2ef9a21926eef63fcada81355b928bbe2870
2024-05-08 01:44:46 +00:00
Andy Wickham 48d3d47c1f Merge "Use ValueAnimator instead of property setter" into main 2024-05-08 01:25:13 +00:00
Tracy Zhou 9d602e684c Fix back button sometimes not showing up in the initial setup screen
A few things to note
- We use gesture nav layoutter because it's the mode in which we show back button rendered by IME. There might be other historical reasons but it is what it is.
- The back button isn't necessarily laid out correctly with this layoutter (currently we don't adjust anything in layoutButtons.

Fixes: 338876161
Test: Repeatedly get in setup mode, and make sure the back button is visible
Change-Id: I402273c2868f3f46a12b00918dab3f36fbe82204
2024-05-07 18:15:51 -07:00
Sihua Ma 1593bb4af2 Move cell layout tests to deviceless tests
Excluding Tapl tests

Also adding Launcher3 test assets to Launcher3TestResources

Bug: 297950111
Flag: None
Test: atest Launcher3RoboTests
Test: atest NexusLauncherRoboTests
Test: SysUI studio
Change-Id: I101fc7229252016ec7e5015ed5f6a5b4dbba894d
2024-05-08 00:52:43 +00:00
Bill Yi f54bad066b Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I141e417d95c07f25e96eb904f342c44bfef9bcf9
2024-05-07 17:00:59 -07:00
Bill Yi 61a4e89812 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ica19fc904637fbaf114b3fa13d44c7a986ad9af1
2024-05-07 17:00:00 -07:00
Bill Yi 92ae2bde65 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I3a7919f2fb54f7921e2e3ae5854a57e2bcbdbca2
2024-05-07 16:59:34 -07:00
Android Build Coastguard Worker fb54c517aa Snap for 11811809 from 405817f5f8 to 24Q3-release
Change-Id: Ie1ded8fd3b3336edfe2e117094a92c7d1563bc98
2024-05-07 23:22:14 +00:00
Andy Wickham 2ce2b5ea03 [automerger skipped] Merge "Implement animateNavBarLongPress for stashed taskbar." into 24D1-dev am: 8b75bde581 -s ours
am skip reason: Merged-In I6ecbc849ac1c066a4c018325f0237a61641d99aa with SHA-1 3a7a76f88e is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27235887

Change-Id: I80d339e8e21cd5fd9655c08387b93c53cc979cd4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-07 22:24:51 +00:00
Andy Wickham 52a38761cc [automerger skipped] Implement animateNavBarLongPress for stashed taskbar. am: 1b6a08abd6 -s ours
am skip reason: Merged-In I6ecbc849ac1c066a4c018325f0237a61641d99aa with SHA-1 3a7a76f88e is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27235887

Change-Id: I3646a2ce719314c0308637d61bb6a1319196cac6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-07 22:24:48 +00:00
Andy Wickham 8b75bde581 Merge "Implement animateNavBarLongPress for stashed taskbar." into 24D1-dev 2024-05-07 22:07:51 +00:00
Sunny Goyal 85fe0d96cf Merge "Fixing LauncherIcons leaking outside sandbox context" into main 2024-05-07 21:42:59 +00:00
Holly Jiuyu Sun 8834a6c450 Merge "[PS] Update Install button string." into main 2024-05-07 21:35:02 +00:00
Anushree Ganjam 0a5241519d Merge "Add dump for PredictionRowView." into 24D1-dev am: 03d13287d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27212127

Change-Id: I46ed1e62c54944f5c916b56f9e66a3f874ac8cef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-07 20:42:55 +00:00
Anushree Ganjam 03d13287d8 Merge "Add dump for PredictionRowView." into 24D1-dev 2024-05-07 20:28:04 +00:00
Andy Wickham 649903838e Cancel manual animation if LauncherState changes during drag.
Previously, the following would cause the All Apps panel to appear
in NORMAL state:

1. Start dragging to all apps
2. During the drag, something sets Launcher to NORMAL
3. Release finger  -> animation to all apps completes, but state
   is still NORMAL

Side effects of this:
 - On large screens, All Apps draws its background on Launcher's
   ScrimView only if the current state is All Apps. So in this
   case, the apps just floated above the workspace.
 - On handheld, touches are handled by workspace even though you
   can see the All Apps list. So e.g. if you swipe down, the
   notification shade appears rather than all apps panel hiding
   (although it seems this touch issue was addressed separately).

I'm not sure if this is the main/only case of this state mismatch
happening, but verified with local async state changes that this
could in theory happen. We haven't been able to organically repro
the bug reliably. That being said, it feels plausible that a well
timed screen lock during the all apps transition could also hit
this case.

Demo videos with hard-coded state change to NORMAL 2 seconds after
you start swiping up to all apps (note I release my finger at the
end of each video):
https://drive.google.com/drive/folders/1ul8ep9N2M5oc6ZSbf_ZHQwp9IwTpz7GB?resourcekey=0-4LAufl0rkvtjvgZC0L-eMQ&usp=drive_link

Bug: 239394946
Bug: 331600490
Test: Manual with local async launcher state changes
Flag: NA
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:22dee942b595acae7a804b3008d9b732dad42620)
Merged-In: I6364dbde8aea67f5d1c525edf57ed7eb26096cf9
Change-Id: I6364dbde8aea67f5d1c525edf57ed7eb26096cf9
2024-05-07 20:24:31 +00:00
Sunny Goyal bf3efe8af0 Fixing LauncherIcons leaking outside sandbox context
Since LauncherIcons was using a global static pool, a custom
instance for a test could leak into the global pool, affecting
other tests

Bug: 335280439
Test: Verified image test on device
Flag: None
Change-Id: Iedd19c8e69c928e44b65eae7eba0167b03b5df6b
2024-05-07 12:13:37 -07:00
Anushree Ganjam 405817f5f8 Merge "Remove Verify getProfileUser calls since it's making test flaky." into main 2024-05-07 18:19:57 +00:00
Jeremy Sim 41eadd1a91 Fix bug with double-relayout of Overview Actions View
This CL refactors Overview Actions View so that a separate view, R.id.group_action_buttons, is used for buttons related to grouped tasks. This also changes the way visibility is handled with actions buttons -- instead of all buttons living on one bar and being toggled on and off, sometimes the whole bar is toggled on and off (to change from single task actions to group actions and vice versa).

This prevents the same view from having its visibility changed twice in in one layout and causing the wrong visibility to be rendered.

Fixes: 333844287
Test: Manual
Flag: ACONFIG com.android.wm.shell.enable_app_pairs NEXTFOOD
Change-Id: I1b6be4637ac8c8d424e7633c437fca376ecdd757
2024-05-07 11:18:24 -07:00
Vinit Nayak 99f11290e3 Merge "Determine split leash position by taskId instead of bounds" into 24D1-dev am: eaf9f083dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27212613

Change-Id: If9e5ff14a29f04a01bd7213572c607999b40ea79
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-07 18:15:41 +00:00
Vinit Nayak cc7107d82e Merge "Disable gestures when split apps are animating in from shell" into main 2024-05-07 18:12:00 +00:00
Shamali Patwa b257ac4289 Merge "Fix close animation issue during predictive back / swipe up" into main 2024-05-07 18:07:28 +00:00
Ats Jenk 31e9455718 Merge "Use translation to move bubble bar during bubble drag" into main 2024-05-07 18:04:31 +00:00
Vinit Nayak eaf9f083dc Merge "Determine split leash position by taskId instead of bounds" into 24D1-dev 2024-05-07 18:02:44 +00:00
Brandon Dayauon c2ce6254c3 Use ValueAnimator instead of property setter
Referencing the view by ID animates correctly. Passed in views are supposedly not the same
and therefore, not animating the correct thing. (fixes on the device that can repro issue).

Bug:339179262
Bug:299294792
Test manually verified on device that can repro:https://drive.google.com/file/d/16L4wEroGEDsp_BIkmoARg9vR43upF6_8/view?usp=sharing
Flag: aconfig com.android.launcher3.enable_private_space nextfood

Change-Id: I20b06cc50928c35afa3dc1e8800b3a5bff0769be
2024-05-07 10:30:18 -07:00
Tracy Zhou ef8872bb01 Merge "Update SUW swipe home logic for taskbar stashing" into 24D1-dev am: 63da44e7eb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27239028

Change-Id: I422db33acd92b6c87ba65a6c96a146fd1d2be8e4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-07 15:53:30 +00:00
Tracy Zhou 63da44e7eb Merge "Update SUW swipe home logic for taskbar stashing" into 24D1-dev 2024-05-07 15:33:00 +00:00
Treehugger Robot 22283fd1b8 Merge "Use TaskContainer as source of truth around Task handling" into main 2024-05-07 15:00:24 +00:00
Schneider Victor-tulias c6c8a22daf Merge "Add debug logs for b/319168409" into main 2024-05-07 13:56:56 +00:00
Shamali P ac5c6c775b Fix close animation issue during predictive back / swipe up
Bug: 333714698
Test: Manual
Flag: N/A
Change-Id: I07859bc0a3783356cc27358bb23a0d6555aa1492
2024-05-07 13:47:24 +00:00
Liran Binyamin 8f266507fd Merge "Animate the bubble bar for the first bubble" into main 2024-05-07 13:08:21 +00:00
Orhan Uysal d3f3200c5f Add quick switch flag for desktop windowing cases.
Add quick switch flag to desktop windowing cases. Quick switch should
work out of the box for desktop windowing when the flag is enabled.

Bug: 322759294
Bug: 322759294
Test: Manually enable/disable the flag
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_quick_switch DEVELOPMENT

Change-Id: Ifb531368552449f70ce9d883418d26c7f272c6e9
2024-05-07 12:38:05 +00:00
Alex Chau 5b15bfe20b Use TaskContainer as source of truth around Task handling
- Renamed TaskIdAttributeContainer into TaskContainer so it's shorter
- Make mTaskContainers the source of truth for Task handling, removing mTask, mSecondaryTask, mTaskIdContainer and use mTaskContainers to derive all related information
- Remove mTasks/mSnapshotViewMap in DesktopTaskView and replace with mTaskContainers
- Mark methods that assumes a single Task as deprecated e.g. getTask, getItemInfo, getThumbnail to discourage further usage of such methods; "First" is added to the method name to make it explicit only first Task is considered; getTaskContainers is encouraged to access such information

Bug: 249371338
Test: Manual
Flag: None
Change-Id: Ieb15e0e8432913c89dc46c1011f0148095c665f8
2024-05-07 11:51:26 +01:00
Himanshu Gupta 8b0d1fb614 Merge "Adding Tapl test for locking/unlocking Private Space" into main 2024-05-07 09:57:59 +00:00
Alex Chau 6526706721 Merge "Remove TaskView.isDesktopTask" into main 2024-05-07 08:26:21 +00:00
Holly Sun 64f36f3679 [PS] Update Install button string.
Screenshot: https://screenshot.googleplex.com/B6UrJt92QMMgSuG

Bug: 338357091
Test: manual
Flag: aconfig com.android.launcher3.private_space_app_installer_button nextfood
Change-Id: Ia408ccfa20ea3c142bd22c326954d278fa571815
2024-05-06 20:35:01 -07:00
Andy Wickham 96adbcb2a8 Merge "Remove unused AssistStateManager methods." into main 2024-05-07 01:43:46 +00:00
Tracy Zhou afe3701c74 Merge "Fix 3-button showing up briefly on the AllSet page in setup" into 24D1-dev am: 2155a925fc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27237053

Change-Id: I96c0ce0c4909e3e8663f1616ed22791cb6e1a7e8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-07 01:38:44 +00:00
Tracy Zhou 2155a925fc Merge "Fix 3-button showing up briefly on the AllSet page in setup" into 24D1-dev 2024-05-07 01:26:01 +00:00
Willie Koomson c81ffaf821 Merge "Remove shadow on Add button" into main 2024-05-07 01:15:37 +00:00
Ats Jenk 5a03549797 Use translation to move bubble bar during bubble drag
Revert logic to set translation on each BubbleView and background.
Background translation was set with bounds offset and BubbleView was
using setTranslationX(). This made it hard to synchronise background and
child view translations. And led to flickers.

Applying translation on the BubbleBarView itself, but applying the
reverse of the translation to the dragged BubbleView. This ensures that
the dragged bubble position is not affected by the parent translation.

Introducing a new property for BubbleView that is used to apply
translation during drag. It takes into account the offset of the
BubbleBarView.

Bug: 330585402
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: drag bubble to other side and release before the bubble bar
  animation finishes, observe no flickers
Test: drag expanded view to other side and release before the bar
  animation finishes, observe no flickers
Change-Id: I1712ed6ac26831f10466dbaf0378f8aabb29629d
2024-05-06 17:39:29 -07:00