Commit Graph

78507 Commits

Author SHA1 Message Date
Treehugger Robot 03cd176277 Merge "Add support for animating non-running tasks" into main 2024-05-02 18:24:56 +00:00
Sunny Goyal 93221e00a5 Merge "Converting ModelTask to an interface instead of an abstract class" into main 2024-05-02 17:41:09 +00:00
Sunny Goyal f4b51c603f Merge "Fixing StatsLogger not getting activityContext" into main 2024-05-02 17:36:21 +00:00
Hongwei Wang cdb9690a87 Add debugging information on PiP content overlay
Added the reason for creating the overlay. Updated
SwipePipToHomeAnimator constructor also due to the fact the source rect
hint from Builder class is never empty.

Bug: 330488822
Test: manually, follow the reproduce path
Flag: NA
Change-Id: Id98ce799d7c96fff3279c0df0fa49084a49d563a
2024-05-02 17:01:17 +00:00
Tony Wickham ee77e8483a Merge "Remove obsolete binder calls to TaskTransitionSpec" into main 2024-05-02 15:28:04 +00:00
Oriol Prieto Gasco d167e4c3df RESTRICT AUTOMERGE
Set the container field of aconfig flags

Test: printflags --format='{package}:{container}:' | grep "::"
Bug: 312769710
Flag: NONE
Change-Id: Ib3df226999e8616bd99c6067afefb4f0be7911ab
2024-05-02 12:03:57 +00:00
Treehugger Robot a9b939a82f Merge "Turn off deprecated sdk dialog" into main 2024-05-02 10:31:01 +00:00
Tracy Zhou 4b43cfbc04 Add ime back button logic to the init block of NavbarButtonsViewController
Fixes: 338320015
Test: Run adb shell am start -a android.intent.action.MAIN -n com.google.android.setupwizard/.SetupWizardTestActivity. Make sure the back key shows by default but hides when IME renders back arrow.
Change-Id: I8baeb10d3f5b13c3bac084872d77d881c1513733
2024-05-01 23:18:29 -07:00
Sebastian Franco 08ca5e7f3c Print the test cases and the solutions of ReorderAlgorithmUnitTest
Bug: 332527963
Test: ReorderAlgorithmUnitTest
Flag: NA
Change-Id: Ie2830136bcf59354f1c33c3f09fbe28caa71971b
2024-05-01 16:56:10 -07:00
Android Build Coastguard Worker 067046dc74 Snap for 11789350 from 2692954360 to 24Q3-release
Change-Id: Ic2d452c55870d519077c291610698078e9671404
2024-05-01 23:22:22 +00:00
Jagrut Desai 0fd34b783c Merge "Taskbar in Desktop Windowing Mode" into main 2024-05-01 22:49:48 +00:00
Sunny Goyal 993893895c Converting ModelTask to an interface instead of an abstract class
This allows extensibility and better use of lambdas

Bug: 338282246
Test: Presubmit
Flag: None

Change-Id: Ia41067f0068b3b631eeb4faf877dc77f8587e1f6
2024-05-01 15:43:26 -07:00
Tracy Zhou 36a810964d Do not hide nav bar on the homescreen from setup am: 58a018746d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27169438

Change-Id: Ie5fd536e90f47887e36798f74226aa70e0810d93
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-01 22:14:51 +00:00
Helen Cheuk e07207678b Merge "Fix performance issue caused by triggering hover focus animation accidentally" into main 2024-05-01 21:56:26 +00:00
Ats Jenk 363a841a04 Drag bubble in bubble bar to other side
Adds support to pin bubble bar to other side of the screen by dragging
from one bubble. The entire bubble bar will move to the other side.
Implements the BaseBubbleBarPinController to handle dragging an
individual BubbleView.
Updates how translation and alpha get applied during BubbleBarView
location animation when a bubble is being dragged.
Dragged bubble is part of the BubbleBarView and when it is being
dragged, and we animate the bubble bar to the other side, we need to
ensure that the animation does not affect the dragged bubble.
Updating the translation and alpha for the BubbleBarView ViewGroup will
affect the dragged bubble as well. Updating how translation and alpha
gets applied to BubbleBarView so that it gets applied to individual
child views and then we can skip applying it to the dragged view.

Bug: 330585402
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: drag bubble from expanded bubble bar to left and right

Change-Id: I1fe2ba9fd466ff97d3b3af763bdcce30c3f98606
2024-05-01 14:53:14 -07:00
Schneider Victor-tulias 65ae550a92 Add support for animating non-running tasks
It is possible to animate a non-running task to home mid-quick switch, which was not properly supported, causing a janky animation. Added custom animations to handle this more smoothly.

Flag:  ACONFIG com.android.launcher3.enable_additional_home_animations DISABLED
Fixes: 237638627
Test: swipe to home mid-quick switch on handheld/large screen in portrait/landscape from an app present/missing on the workscape in RTL/LTR
Change-Id: I89c9cf1ed1c0b88ff6c3ce71a663cb16e69d5843
2024-05-01 20:06:34 +00:00
Sunny Goyal a5438a3cfc Fixing StatsLogger not getting activityContext
Bug: 338254085
Test: Verified on device
Flag: None
Change-Id: I5a821a89df80ce43b73092db43af3dd8d53d81f4
2024-05-01 12:59:58 -07:00
Holly Jiuyu Sun 2692954360 Merge "[omni] Let parent to allow intercept when it's in the 2nd stage." into main 2024-05-01 18:48:52 +00:00
Brandon Dayauon ecc04b9f39 Update private space animation timings
The entire animation is 800ms where there are differences between lock/unlock.
Unlock 1.0:
   app Opacity: time = 400 -> 800ms Linear
   text opacity: time = 500 -> 800ms Linear
   settingsAndLockGroup "size": time = 400 -> 800ms Standard
   settingsGear: time = 400 -> 800ms Linear
Lock 2.0:
   app Opacity: time = 0 -> 400ms Linear
   text opacity: time = 0 -> 50ms Linear
   settingsAndLockGroup "size": time = 0 -> 400ms Standard
   settingsGear: time = 0 -> 400 Linear

bug:299294792
Test manually video:
after: https://drive.google.com/file/d/1_Y5I7vQhDHPX8DLM_rSM3mV9DrVN0v-q/view?usp=sharing
after 10x: https://drive.google.com/file/d/1_WLz2ijLs19qE1vYA9zdXF9YZB_CqMns/view?usp=sharing

Flag: aconfig com.android.launcher3.enable_private_space nextfood
Change-Id: I8a578e70bb834f403075824785fa9b4d8825858c
2024-05-01 11:48:50 -07:00
Vinit Nayak 4cb712b8d6 Merge "Allow single root candidate for app pair launch for pip edge case" into main 2024-05-01 18:43:59 +00:00
Alex Chau 6a44889c99 Merge "Add additional StateManager log to track cancelAnimation" into main 2024-05-01 18:26:20 +00:00
Himanshu Gupta 3a0f024044 Locking the All Apps view before asserting PS components.
Bug: 334946529
Test: NA
Flag: NA
Change-Id: Id8895a993f61ee22fcef1ba562aaa8baf156d6d7
2024-05-01 18:52:32 +01:00
Holly Sun 1d90321484 [omni] Let parent to allow intercept when it's in the 2nd stage.
Discussed with Andy for ideas - instead of passing the outer touch slop out, it might be easier to let parent to allow intercept when it's in the 2nd stage (e.g., OverviewInputConsumer doesn't have touch slop handling logic). So we can go through this if: https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/quickstep/src/com/android/quickstep/inputconsumers/NavHandleLongPressInputConsumer.java;l=105;drc=deee0d06f624223b808593997cf22042c9aa5142
`mDelegate` can be `OverviewInputConsumer` or `OtherActivityInputConsumer` or `TaskbarUnstashInputConsumer`.

Bug: 330446193
Flag: legacy ENABLE_LPNH_TWO_STAGES disabled
Test: manual
Change-Id: I1f33172f1614a750a01632c8c945ee5e5cbd7adc
2024-05-01 10:02:40 -07:00
Jagrut Desai 2e8ca87c21 Taskbar in Desktop Windowing Mode
Test: presubmit
Bug: 330146462
Flag: NONE
Change-Id: Ib33f90704c3010df6a52e2a1c420960b11dbd0d4
2024-05-01 09:29:24 -07:00
helencheuk ef31d0a35e Fix performance issue caused by triggering hover focus animation accidentally
HoverAnimator and FocusAnimator are triggered unexpectedly on state transition. When it is already disabled, it is disabled again when user swipes to All Apps and triggers animators. Add checking to not trigger animator when the new enable status is the same as the current one.

Bug: 333688227
Test: Ran v2/android-crystalball-eng/health/microbench/systemui/main/systemui-misc-1-jank-suite in ab/
Flag: N/A
Change-Id: I090490f1c78a3427225c24bc536e1767700ec6c3
2024-05-01 17:15:12 +01:00
Tony Wickham a179a77e09 Remove obsolete binder calls to TaskTransitionSpec
Fixes: 334312256
Flag: none
Test: manual (no visual regression)
Change-Id: Ie20dc8d4bb0c85a8a256b001fbb92405679618a8
2024-05-01 15:15:18 +00:00
Alex Chau d840e6270b Add additional StateManager log to track cancelAnimation
Bug: 325463989
Test: Manual
Flag: NONE
Change-Id: I4f9eb13eb460e0bae0582992d18b8b81250f8eaa
2024-05-01 15:08:42 +01:00
Alex Chau e14ee6f914 Merge "Improve taskId logging for Overview" into main 2024-05-01 13:49:18 +00:00
Alex Chau 2daa3eba99 Merge "Refactor TaskView.getTaskIds and its attribute container to support any number of tasks" into main 2024-05-01 13:49:02 +00:00
Gustav Sennton 19f8002e30 Merge "Pass OverviewComponentObserver as a parameter." into main 2024-05-01 07:06:40 +00:00
Tracy Zhou 58a018746d Do not hide nav bar on the homescreen from setup
FLAG_STASHED_SMALL_SCREEN is not updated after setup UI finishes.

Fixes: 337738795
Test: Finish setup, swipe home in folded, and observe home handle is visible.
Change-Id: I297e3b44f49f94ab5a1b9fe5ff16ff64c6cf2c0a
(cherry picked from commit ee67a48d60)
2024-05-01 00:08:47 +00:00
Tracy Zhou d0d94922fe Merge "Do not hide nav bar on the homescreen from setup" into main 2024-05-01 00:08:35 +00:00
Android Build Coastguard Worker c225249ca5 Snap for 11784291 from 7f26505f04 to 24Q3-release
Change-Id: Ic169c8ce626b1e120e07b478f873b85f1b18a142
2024-04-30 23:23:43 +00:00
Fengjiang Li 08af8696ff [Launcher Jank] Pass single threaded Executor to RotationButtonController so that binder calls are ordered.
Bug: 338036218
Test: presubmit
Flag: NONE
Change-Id: Ic398bf4be53c6b2cc5f4fa11aea5c3b451d5ddf8
2024-04-30 22:41:01 +00:00
Ats Jenk af0ba3e8cf Merge "Implement API to animate bubble bar position" into main 2024-04-30 22:20:05 +00:00
Tracy Zhou ee67a48d60 Do not hide nav bar on the homescreen from setup
FLAG_STASHED_SMALL_SCREEN is not updated after setup UI finishes.

Fixes: 337738795
Test: Finish setup, swipe home in folded, and observe home handle is visible.
Change-Id: I297e3b44f49f94ab5a1b9fe5ff16ff64c6cf2c0a
2024-04-30 15:01:38 -07:00
Holly Jiuyu Sun 2737373f6e Merge "[reset] Remove redundant calls in resetAndScrollToPrivateSpaceHeader." into main 2024-04-30 21:20:39 +00:00
Holly Jiuyu Sun 477d70f92e Merge "[reset] Call SearchUiManager#resetSearch instead of reset." into main 2024-04-30 21:20:22 +00:00
Ats Jenk d7fe32ab8e Implement API to animate bubble bar position
Create a new API to animate bubble bar position.
Animating it will not update its laid out location.
To update bubble bar laid out location, BubbleBarUpdate can be used.
Applying a location change from BubbleBarUpdate no longer animates the
change.

Bug: 330585402
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: long press bubble bar and drag it to left and right
Change-Id: I2572da4c063fc8e07cf07c4303778d343baa4ec4
2024-04-30 13:12:56 -07:00
Treehugger Robot 7f26505f04 Merge "Re-fetch DesktopVisibilityController when needed instead of just once" into main 2024-04-30 17:50:17 +00:00
Alex Chau 0a81d07234 Improve taskId logging for Overview
Fix: 338034523
Test: manual
Flag: NONE
Change-Id: I0ba84047a83bd9bdbd891bddf86f6cbe36bca572
2024-04-30 17:22:43 +01:00
Gustav Sennton f74d8b7264 Re-fetch DesktopVisibilityController when needed instead of just once
When creating DesktopTaskbarRunningAppsController the Quickstep Launcher
might not be available, meaning we pass a null
DesktopVisibilityController to DesktopTaskbarRunningAppsController.
With this CL we refetch DesktopVisibilityController whenever needed.

Bug: 338035946
Test: manual, and DesktopTaskbarRunningAppsControllerTest
Flag: ACONFIG com.android.window.flags.Flags.enableDesktopWindowingTaskbarRunningApps DEVELOPMENT
Change-Id: I8b806e2d0addbf8fb5ab6a3d419a4691c445f223
2024-04-30 16:07:13 +00:00
Treehugger Robot 5a8e719b4c Merge "Remove references to FEATURE_PC and related Desktop classes in Launcher" into main 2024-04-30 15:33:30 +00:00
Liran Binyamin 85c50adb91 Merge "Animate the bubble bar to show new bubble" into main 2024-04-30 14:01:09 +00:00
Gustav Sennton 0eaf9ebdaa Remove references to FEATURE_PC and related Desktop classes in Launcher
Also clean up TaskbarRecentAppsController APIs

Flag: NA
Test: DesktopTaskbarRunningAppsControllerTest
Bug: 330551930
Change-Id: Ibd9c3d6aa1d5423b51a48ed0a972196752d5199a
2024-04-30 13:15:28 +00:00
Orhan Uysal 6d54305170 Pass OverviewComponentObserver as a parameter.
Instead of instantiating a new OVerviewComponentObserver, instantiate
one in QuickstepLauncher and pass it down to relevant classes.

Test: Manual
Bug: 336155199
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: Ifcc40c63f0649544a92e7f6d4a00d9edcd9f7fe1
2024-04-30 09:29:38 +00:00
Treehugger Robot 43f65905ab Merge "Replace Contextual Rotation Button with Floating Action Button" into main 2024-04-30 05:34:35 +00:00
Sunny Goyal 15949163a6 Merge "Removing disabled color extractor from Widgets" into main 2024-04-30 03:51:37 +00:00
Vinit Nayak 23b85ffdba Allow single root candidate for app pair launch for pip edge case
* Shell will launch single task if requested split apps have one of them
already in Pip
* Create a separate method to set animation for launching from the
appPair icon on workspace
* Reuse the animation method for launching an AppPair icon from taskbar
by specifying which windowing mode to look for if we're launching the
actual split pair vs just one in fullscreen

Bug: 323089902
Test: Launches fine visually
Change-Id: I415343a48e980afd7f4e511558d350cf15b97ca1
2024-04-29 18:52:58 -07:00
Ats Jenk 45a4f6426f Merge "Update bubble bar pin controller after parent class refactor" into main 2024-04-30 01:36:14 +00:00