Commit Graph

78507 Commits

Author SHA1 Message Date
Saumya Prakash 43e0ffafca [automerger skipped] Merge "Move the Done button in gesture navigation tutorial" into 24D1-dev am: a876ea9eda -s ours
am skip reason: Merged-In I2f2a7be0bf365727cff030f827e539add8533c18 with SHA-1 b8782e7341 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27285491

Change-Id: I8df6cf83e4ba734a80b66ebbfea9e27136529722
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-13 17:51:20 +00:00
Saumya Prakash 423e4628a6 [automerger skipped] Move the Done button in gesture navigation tutorial am: 72be60694f -s ours
am skip reason: Merged-In I2f2a7be0bf365727cff030f827e539add8533c18 with SHA-1 b8782e7341 is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27285491

Change-Id: Idd6453d9f70889bf504f1e8dc3260ad5b77904f7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-13 17:51:18 +00:00
Jeremy Sim 6198cf6544 Fix bug with flickering actions bar
This CL fixes a bug caused by ag/27148514. The bug occurred because:

1) The new way we use FloatProperty to set the alpha did not have a working `get()` function, so it just returned a junk value, set to `-1f` (I didn't think `get()` would ever be called meaningfully for this property).

2) However, during certain UI interactions, `RecentsView#updateActionsViewFocusedScroll()` is called many times in a loop, which repeatedly tries to re-start the fade-in animation for actions bar. Pre ag/27148514, even though the fade-in animation was called repeatedly, it would start and then immediately stop running because it realized that it was already set to the desired alpha. However now that we return a junk value for `get()`, it didn't know to skip and just ran the full fade-in animation again and again.

Fixed by refactoring FLOAT_SETTER (now ALPHA_PROPERTY) and creating a new data class, OverviewActionsAlphaProperty, that handles some of the intricacies of this increasingly complicated alpha system.

Fixes: 339545510
Test: Swipe to Overview, move tiles around, actions bar does not flicker.
Flag: ACONFIG com.android.wm.shell.enable_app_pairs NEXTFOOD
Change-Id: I1093363780db5e0780deda2ff14b4f7361d63940
2024-05-13 10:40:31 -07:00
Saumya Prakash a876ea9eda Merge "Move the Done button in gesture navigation tutorial" into 24D1-dev 2024-05-13 17:37:00 +00:00
Saumya Prakash 72be60694f Move the Done button in gesture navigation tutorial
To align with updated UX specs, this change moves the Done button in
each gesture's tutorial from the middle of the screen to the bottom
right.

Fix: 293285057
Test: Run through the gesture tutorial in all font/display sizes for
different form factors and check that the Done button after each step is
in the new location.
Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED

Change-Id: I2f2a7be0bf365727cff030f827e539add8533c18
(cherry picked from commit b8782e7341)
Merged-In: I2f2a7be0bf365727cff030f827e539add8533c18
2024-05-13 17:36:43 +00:00
Liran Binyamin 3fcdc0a39f Merge "Handle touch on bubble bar while animating" into main 2024-05-13 17:30:40 +00:00
Charlie Anderson bf98cc95b6 [automerger skipped] Fix NPE for where intent.package is null but targetpkg is not. am: 024bf4627a -s ours
am skip reason: Merged-In I77e17901f4754c301ca20b3c6f93bbe29bead59b with SHA-1 ce255ff6fd is already in history

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27300555

Change-Id: Ifd0adb87872e6dc769f8db1222330dad8ea123ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-13 16:54:55 +00:00
Andrew Cole f3fe08388c Merge "Always Return Adaptive Icon" into main 2024-05-13 16:42:35 +00:00
Alex Chau 5867d8e175 Convert GroupedTaskView to Kotlin
Bug: 339787593
Test: Manual
Flag: None
Change-Id: I18522f8cadbfe5a0c0a74a5fa9c498a7fb3ce30f
2024-05-13 17:38:04 +01:00
Treehugger Robot b28f611163 Merge "Removing old workaround" into main 2024-05-13 15:53:22 +00:00
Kean Mariotti 2f26b5c7e7 vc tracing: refactoring prior perfetto migration
Instantiate polymorphic ViewCapture instances through ViewCaptureFactory,
instead of referencing concrete classes.

Bug: 323166383
Test: presubmit
Flag: N/A
Change-Id: Iecf0c8c4f1b1d6d416838739f612bbc862278a29
2024-05-13 15:27:51 +00:00
Chris Göllner 11398e2a36 Shortcut Helper - Integrate with launcher 3 button nav translation
Fixes: 335625543
Test: Unit tests in this CL
Test: Manually
Flag: ACONFIG com.android.systemui.keyboard_shortcut_helper_rewrite DEVELOPMENT
Change-Id: I0367bf4b73994a49ca65b8047bd76d3dc2b3faca
2024-05-13 14:47:57 +01:00
Chris Göllner 0cd995e4ef Convert SysUiState flags from int to long
We already reached the limit of 32 flags for an int. To be able to have
more, changing from int to long.

This is needed, as new flags have to be added.

Flag: NONE
Test: Manually running SysUI and Launcher
Test: Unit tests in CL
Bug: 335625543
Change-Id: Iec1d40218264c7c64c50fd09764aa07c0caa7787
2024-05-13 14:47:33 +01:00
Liran Binyamin 6097a29158 Handle touch on bubble bar while animating
This change handles touches on the bubble bar while the bubble bar is animating.
We now update the taskbar touch region during the animation to make the bubble bar touchable.
When the bubble bar is touched during the animation, we now cancel the animation and allow dragging or clicking to expand.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/gtGS6FCrygN5RKueFtPs5E

BubbleBarTest 100x run: https://android-build.corp.google.com/abtd/run/L42600030003675041
Note that in the abtd run above there's a flake but that's for a different test which I'll look into separately.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605790
Bug: 280605846
Bug: 339066271
Fixes: 339244038
Test: See demo
Test: atest BubbleBarViewAnimatorTest
Change-Id: Icb8f4fa46ae4bb8c94ca931193d4a3cc49c5b718
2024-05-13 09:41:23 -04:00
Luca Zuccarini 50a7190efa Merge "Update alpha animation for All Apps / Divider icon." into main 2024-05-13 13:32:23 +00:00
Luca Zuccarini a152f8f044 Tune the window to icon and home scaling animation.
Result of several rounds of testing with UX and product. Ready to start
rolling out after this CL.

Bug: 298089923
Flag: ACONFIG com.android.launcher3.enable_scaling_reveal_home_animation DISABLED
Test: tested with the help of UX and PM
Change-Id: I2bcdfa5a314aeeb60acf7b38f3f3d463fedc277e
2024-05-13 13:31:20 +00:00
Pat Manning f0bff25b1e Merge "Unstash taskbar after timeout when cursor hovers bottom edge." into main 2024-05-13 12:44:21 +00:00
Alex Chau f1c402ad89 Remove unused @ScreenRecord and @Stability for closed bug
Fix: 309820115
Test: None
Flag: None
Change-Id: I7739c3eccb72e8c20e71ed85f5464e1619f8ea3f
2024-05-13 12:22:28 +01:00
Orhan Uysal c42c8e76e4 Disable drag from taskbar while in desktop.
Currently drag from taskbar is broken. It will be fixed once drag from
taskbar to desktop is implemented in b/297921594.

Bug: 323388149
Test: Try to drag an app from taskbar while in desktop, see that app is
not launch and icon goes back to it's place in taskbar.
Flag: NONE

Change-Id: I27e73d8262e14944b34e193397a83f8435813339
2024-05-13 09:23:34 +00:00
Bill Yi 33f84ee936 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1dab3cd897c392081269979c6ee0766ba76da1fb
2024-05-12 12:05:07 -07:00
Bill Yi 0079ddf92a Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Idb8ed765e39c8b1c15a250244d3da1cc650a1d3e
2024-05-12 12:03:59 -07:00
Bill Yi d181477b81 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I32494f1c6916412e97df28e10ae6841beea333b1
2024-05-12 12:03:26 -07:00
Android Build Coastguard Worker a71a028f50 Snap for 11830997 from 69a73630c0 to 24Q3-release
Change-Id: I3d13f22a2f1aaab85d19c6e121c53f5df7f9bb02
2024-05-11 21:21:40 +00:00
Fengjiang Li 69a73630c0 Merge "Do not use PackageManagerHelper created on boot for LoaderTask." into main 2024-05-11 15:10:57 +00:00
Android Build Coastguard Worker 458e5a7a9c Snap for 11828632 from 2ee174e696 to 24Q3-release
Change-Id: Id105f7e01c7701f3aeb35c94da4a1be04bc9657f
2024-05-11 01:21:01 +00:00
Saumya Prakash 9352374c08 Merge "Move the Done button in gesture navigation tutorial" into main 2024-05-11 00:41:54 +00:00
Brandon Dayauon 3a2fe2b550 Merge "Update private space corners to 28dp" into main 2024-05-10 23:53:30 +00:00
Anushree Ganjam c7b561cec1 Merge "Verify the PrivateProfileManager.isEnabled() is called atleast once." into main 2024-05-10 23:30:27 +00:00
Anushree Ganjam 7ca0231aa4 Add 0-state web data loader logs
Bug: 328525875
Test: Manual
Flag: Aconfig com.google.android.apps.nexuslauncher.zero_state_web_data_loader DEVELOPMENT

Change-Id: I8492bade13962587f301c4bec461af291fa394d1
2024-05-10 16:05:48 -07:00
Charlie Anderson 024bf4627a Fix NPE for where intent.package is null but targetpkg is not.
- Also update WorkspaceItemProcessorTest with a new test and to use real intent instead of mock

Bug: 330250727
Test: unit tests
Flag: N/A
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:ce255ff6fdf4688afd5318dc3027f03691c85bc4)
Merged-In: I77e17901f4754c301ca20b3c6f93bbe29bead59b
Change-Id: I77e17901f4754c301ca20b3c6f93bbe29bead59b
2024-05-10 23:03:47 +00:00
Treehugger Robot 4423758449 Merge "Revert "Add screenrecord for TaplPrivateSpaceTest#testPrivateContainerIsPresent"" into main 2024-05-10 22:51:13 +00:00
Fengjiang Li 1db1dfcb67 Do not use PackageManagerHelper created on boot for LoaderTask.
This CL partially reverts ag/26827295.

Re-using the PackageManagerHelper obj created earlier than LoaderTask obj will lead to the bug where private space user handle is not recognized. This is a temporary fix to create a separate PackageManagerHelper obj for LoaderTask. The real fix should be on framework side.

Also note that PackageManager service instance is now created much later in launcher lifecycle than before.

Fix: 338091143
Test: manual
Flag: NONE
Change-Id: Iab467fe8979aec52c5837c8fd676f821b2e3eb3c
2024-05-10 22:49:21 +00:00
Alex Chau 42af1f0725 Merge "Convert DesktopTaskView to Kotlin" into main 2024-05-10 21:32:52 +00:00
Saumya Prakash b8782e7341 Move the Done button in gesture navigation tutorial
To align with updated UX specs, this change moves the Done button in
each gesture's tutorial from the middle of the screen to the bottom
right.

Fix: 293285057
Test: Run through the gesture tutorial in all font/display sizes for
different form factors and check that the Done button after each step is
in the new location.
Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED

Change-Id: I2f2a7be0bf365727cff030f827e539add8533c18
2024-05-10 21:18:36 +00:00
Andrew Cole 10149b6656 Always Return Adaptive Icon
As part of a cleanup for how we deal with legacy icons, we are consolidating our handling of how we wrap non-adaptive icons in an adaptive icon format. This requires adding a parameter to make these functions conform to their earlier specifications.

Bug: 318867282
Flag: None
Test: AllAppsSearchImageTest
Change-Id: I002c430646f8933c638b78a409c9766b6328838a
2024-05-10 14:04:23 -07:00
Brandon Dayauon d7dc05f851 Remove comment on workProfileTest
Work profile doesn't fail to create anymore. Can remove commented line

bug: 339884168
Test: presubmit
Flag: n/a
Change-Id: I1783bb35fac3dff1762af911b3cccddaec367b0c
2024-05-10 13:43:49 -07:00
Federico Baron 6619568efd Revert "Add screenrecord for TaplPrivateSpaceTest#testPrivateContainerIsPresent"
This reverts commit 4f836430a7.

Reason for revert: issue resolved

Change-Id: I7174e50c166358634626aa308edbd5987e5cc2fb
2024-05-10 20:43:32 +00:00
fbaron 3da10ff1d3 Fix bug where hotseat disappears am: 95df178e4f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27299232

Change-Id: I3b5a60e37cff9f9a7a0eae95bb0f1d712ec1ef57
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-10 20:41:40 +00:00
Vadim Tryshev 306fa566f9 Removing old workaround
Bug: 165029151
Test: presubmit
Flag: N/A
Change-Id: Id54344f0b0423caa4c23eb574f0764648f49e41a
2024-05-10 13:40:37 -07:00
Vadim Tryshev 840b44043f Merge "Cleaning up TestProtocol" into main 2024-05-10 20:37:02 +00:00
Anushree Ganjam cf0aa11122 Verify the PrivateProfileManager.isEnabled() is called atleast once.
Bug: 339847768
Test: Manual
Flag: NA, Test
Change-Id: Ib99299c86a5accd0f98b39ae012a25e5991e26d5
2024-05-10 13:10:13 -07:00
Brandon Dayauon 892b96f319 Add private_space_floating_mask_view flag.
bug: 339850589
Test: In follow up CL
Flag: ACONFIG com.android.launcher3.private_space_floating_mask_view DEVELOPMENT
Change-Id: Idc03b9d3439046e6a1397599b33c7af9f53b1333
2024-05-10 12:43:45 -07:00
Brandon Dayauon a1b3c39bbd Update private space corners to 28dp
bug: 339876216
Test: manually
Flag: None
Change-Id: I1ce8ac2f128de3a614c74db0db59ce451dc7ed6e
2024-05-10 12:41:22 -07:00
Hyunyoung Song 2ee174e696 Merge "Run test in postsubmit for openPrivateSpaceSettings_triggerCorrectintent Bug:339109319 Test: not needed as disabling test in presubmit Flag: NA" into main 2024-05-10 19:28:13 +00:00
Vadim Tryshev c63c0f7f47 Reformatting a comment.
"b/197780098" can be mistaken for an indication that the code is
temporary and requires cleanup.

This is not the case here, so reformatting the code so that the query
searching for cleanup candidates doesn't see it.

Bug: 197780098
Test: presubmit
Flag: N/A
Change-Id: I076267dc8878763632b52d3449cb20cac331ed04
2024-05-10 12:27:39 -07:00
Federico Baron 9d98dc3b15 Revert "Add screenrecord for testAllAppsFromHome()"
This reverts commit 0c12987627.

Reason for revert: test is now passing

Change-Id: Ieafbe225e722d1c1436ef3c4383a3f11ca9ef009
2024-05-10 18:31:48 +00:00
Brandon Dayauon deb2e2c35e Make all apps text focusable by accessibility.
From b/330638194, the requirement is that
1. "all apps" can be focusable with talkback
2. "all apps" text is persisted when in accessibility mode.

Merged-In:Ibabb92bd9d202221fdc9cfacb585755167898187
bug:330638194
Test: manual video: https://drive.google.com/file/d/1QI_F4dUijfnU2ahE2Mg6yrmRJfOVyuVJ/view?usp=sharing
Flag: None

Change-Id: Ibabb92bd9d202221fdc9cfacb585755167898187
2024-05-10 18:19:27 +00:00
Vadim Tryshev 575d15f231 Cleaning up TestProtocol
Bug: 262282528, 279059025, 322823209
Test: presubmit
Flag: N/A
Change-Id: I9af6e3f1fc49b2ebf0d99df8c4514de0bddee8f2
2024-05-10 11:03:24 -07:00
Charlie Anderson 0171058c0f Merge "add more logging around package updates and widget click handling in Launcher" into main 2024-05-10 17:19:06 +00:00
Helen Cheuk 399638ac23 Merge "Add focus outline to AppPairIcon" into main 2024-05-10 16:46:09 +00:00