Commit Graph

4240 Commits

Author SHA1 Message Date
Sebastián Franco 8a5dd1b3cf Merge "Revert^3 "Removing all restored backups except one so we don't have old backups"" into main 2024-03-11 20:17:43 +00:00
Sebastián Franco 1234090589 Revert^3 "Removing all restored backups except one so we don't have old backups"
This reverts commit 4b960d1f11.

Reason for revert: Breaking presubmit, no bug number yet 

Change-Id: I0bafad8bf63fae1d9408b65c6c18c79ab5d40d05
2024-03-11 20:15:24 +00:00
Sebastián Franco 37e9aa2504 Merge "Revert^2 "Removing all restored backups except one so we don't have old backups"" into main 2024-03-11 17:09:21 +00:00
Uwais Ashraf f7c9e2c112 Adjust mockito dependencies to make them work for Robolectric
Fix: 327257788
Flag: NA
Test: Presubmit passing
Change-Id: I1eee4fe0f79b2d22fc6bc080c8cc88c19086c7d5
2024-03-11 12:08:02 +00:00
Sebastián Franco bbdcade30d Merge "Add testing for GridMigration." into main 2024-03-09 13:41:00 +00:00
Brandon Dayauon 68c18236ad Disable two line text legacy flag.
Will now repurpose the twolinetoggle flag to be the flag that will
make twoline text enabled/disabled.

bug: 316027081
Test: presubmit
manually: https://screenshot.googleplex.com/BsZGCm7DrTZLwG4
Flag: com.android.launcher3.enable_twoline_toggle Staging
Change-Id: Idef427bad6551ae56b13e35393e076b8e000af5a
2024-03-08 21:32:22 -08:00
Treehugger Robot 00110bce5f Merge "Add logs for TaplAddConfigWidgetTest test" into main 2024-03-09 01:55:14 +00:00
Willie Koomson 52f2e98647 Check for null preview in WidgetItem.hasGeneratedPreview
AppWidgetManager.getWidgetPreview has been updated to return null
if the provider does not exist or the caller does not have permission to
access its previews. This change updates WidgetItem to check for that.

Bug: 308041327
Test: GeneratedPreviewTest#widgetItem_hasGeneratedPreview_nullPreview
Flag: ACONFIG com.android.launcher3.enable_generated_previews TRUNKFOOD
Change-Id: Ic2489c8698a81ba1bac005b2eb77348bcbfab999
2024-03-08 22:22:53 +00:00
Anushree Ganjam 25fc87b340 Merge "Remove expecting DOWN events in TAPL tests." into main 2024-03-08 21:43:04 +00:00
Sebastian Franco 851b1f3b1c Add testing for GridMigration.
Bug: 325286145
Flag: ACONFIG grid_migration_fix disabled
Test: GridMigrationTest
Change-Id: I49fd32be895f3a05204775373b9eec62d9026f3b
2024-03-08 14:46:41 -06:00
Vadim Tryshev 513437bdfa Merge "Saving artifacts for failing initialization of PortraitLandscapeRunner" into main 2024-03-08 20:18:11 +00:00
Shamali P 20a5f4e8d1 Update labels for the categories to match the UX writer provided strings
Also fix issue that user was not passed when getting application info.
(error noticed by Zak)
http://screen/8fiiTSHvo2SfYdE

Bug: 318410881
Flag: N/A
Test: Unit test
Change-Id: Id85feec0d95d3d4d183a673f7eed40906b0043e2
2024-03-08 19:58:23 +00:00
Sebastián Franco 4b960d1f11 Revert^2 "Removing all restored backups except one so we don't have old backups"
This reverts commit 3306fa5325.

Reason for revert: Fixing issue that caused b/328782012

Change-Id: Ib6a1bbfeedf608f5f77ac6be500271e811320f32
2024-03-08 18:53:57 +00:00
Sebastián Franco 0f0c1dd30b Merge "Revert "Removing all restored backups except one so we don't have old backups"" into main 2024-03-08 18:45:17 +00:00
Sebastián Franco 3306fa5325 Revert "Removing all restored backups except one so we don't have old backups"
This reverts commit bd43b9344f.

Reason for revert: b/328782012

Change-Id: I1666fbd63d82da06ed8c3d9ce58b5ed6b298618b
2024-03-08 18:42:30 +00:00
Sebastián Franco acdcaa21a0 Merge "Removing all restored backups except one so we don't have old backups" into main 2024-03-08 14:16:14 +00:00
Vadim Tryshev ee39f393e7 Saving artifacts for failing initialization of PortraitLandscapeRunner
Test: presubmit
Flag: N/A
Bug: 321772674
Change-Id: Ifa865224ebdae160b4fbc75b587d893ac6bfd847
2024-03-07 18:28:21 -08:00
Himanshu Gupta 68c145a14b Merge "Clearing All Apps Search For ALL_APPS Intent" into main 2024-03-07 22:29:31 +00:00
Anushree Ganjam 461038d5d5 Remove expecting DOWN events in TAPL tests.
ACTION_UP is always preceded by ACTION_DOWN which means when launcher
receives an UP events, down event is obviously sent.

In b/325377690 , we started seeing only in P9 devices the DOWN events didn't reach TAPL. I added InputDispatcher logs which shows both DOWN and UP events are sent by system_server to NexusLauncher.
However TAPL doesn't receive it. After spending lot of time debugging this, I think we are safe to remove DOWN event expectation in TAPL.

Bug: 325377690
Test: Manual, TAPL presubmits
Flag: NA
Change-Id: I6d3587c488d45e3dc53d2c1c4f3b6b49285eae94
2024-03-07 12:31:38 -08:00
Sukesh Ram 73b07daab3 Add logs for TaplAddConfigWidgetTest test
Flag: NONE
Bug: 324419890
Test: Check logs when flake is reproduced
Change-Id: I2fdb1e4f96c8095a387280c79e074ee42eb0010c
2024-03-07 18:53:15 +00:00
Sebastian Franco bd43b9344f Removing all restored backups except one so we don't have old backups
Adding test to make sure this is the case.

Bug: 325285743
Flag:  ACONFIG narrow_grid_restore disabled
Test: BackupAndRestoreDBSelectionTest
Change-Id: I84c3a92f40598137d5c5c52d34af7583b384122c
2024-03-07 11:23:55 -06:00
Brandon Dayauon d0bec45d37 Upon expanding, expand just enough so the header shows.
This issue only happens when there is a lot of private space apps that scrolling to the bottom
will not sure the private space header.

Formula to calculate how many rows to scroll to =
	(appListHeight - privateHeaderHeight - headerProtectionHeight) / cellHeight.

bug: 299294792
Test:
manually - https://screenshot.googleplex.com/76UJPT2Jnpnp2Ab
before: it just scrolls all the way to the bottom
after: https://drive.google.com/file/d/1AbprxFm1RWTQKvpt7M4khbUfc1o6-XGF/view?usp=sharing
after PHONE WITH TABS:
2x2- https://drive.google.com/file/d/1SLPsWPHenCuZuisiS7HeEy5JwtNPeONs/view?usp=sharing
3x3- https://drive.google.com/file/d/1SK82jeNZMzFJK2odIuHnfTNLYfppne83/view?usp=sharing
4x4- https://drive.google.com/file/d/1T7EhFRq2tDv2zYIvs_FMsTKcFZXwGUaD/view?usp=sharing
4x5- https://drive.google.com/file/d/1SMUPuKjO1Yg36U6P6cDOb6dTkHn6Bh7D/view?usp=sharing
5x5- https://drive.google.com/file/d/1SJCQn1O_Yq5P7C__VUfZHc5I67CEdIpb/view?usp=sharing

AFTER PHONE NO TABS:
2x2: https://drive.google.com/file/d/1THU2xrAIt0hTmN5_GwBrgN9Lqj-W4Kfr/view?usp=sharing
3x3: https://drive.google.com/file/d/1TPTUx7PcHW3GsVwVAg_L5rCcn0QYoiY2/view?usp=sharing
4x4: https://drive.google.com/file/d/1TWVWpAX6bZp_JfFKtmXYO0askl4e5qKO/view?usp=sharing
4x5: https://drive.google.com/file/d/1TDJK-swmY3Y3C4ARH_2eljqUkBGEnD3e/view?usp=sharing
5x5- https://drive.google.com/file/d/1TBJtAynwvZrGyOc-29f637wyrJZpMXBJ/view?usp=sharing

Tablet:
landscape: https://drive.google.com/file/d/1SfyPdoUnCV7e7BWLnpxXWN2HiBOQkRo2/view?usp=sharing
portrait: https://drive.google.com/file/d/1SgZq0iE9WMvIFtc8mBb577nYlS9jBa_g/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation TRUNKFOOD

Change-Id: If70df1299572f8f2edc6376dd2a6df5d74287264
2024-03-06 18:04:09 -08:00
Fengjiang Li c6ae88f904 Use Matrix.setRectToRect() replace RectUtils.letterBox()
Bug: 284236964
Flag: aconfig launcher.enable_add_app_widget_via_config_activity_v2 DISABLED
Test: manual
Change-Id: Ia83f3415442c2359bffb1efcfd1ee96bf17ab9ff
2024-03-06 17:04:02 -08:00
Vadim Tryshev 7a4b8a4513 Further syncing Launcher3 atest XML config with the GCL one
Test: abtd
Flag: N/A
Bug: 271324404
Change-Id: I51f02c290fa2efba2d7dac68090105e67b017f51
2024-03-06 10:36:55 -08:00
Fengjiang Li 7dea7f0b42 Merge "[2/n] Avoid flicker to drop a widget that needs a config activity" into main 2024-03-06 02:03:48 +00:00
Fengjiang Li fb16517fea [2/n] Avoid flicker to drop a widget that needs a config activity
1. Don't show background in PendingAppWidgetHostView if we are showing preview bitmap
2. Extract bitmap from DropView instead of LauncherAppHostView
3. Letterbox bitmap into PendingAppWidgetHostView's canvas if canvas has different aspect ratio

Fix: 284236964
Flag: aconfig launcher.enable_add_app_widget_via_config_activity_v2 DISABLED
Test: manual
Change-Id: I76de215186b96ffe65c909b28155fb19ac90d4f1
2024-03-05 14:49:09 -08:00
Vadim Tryshev c96bfc32bf Merge "Syncing Launcher3 atest XML config with the GCL one" into main 2024-03-05 19:29:36 +00:00
Anushree Ganjam 33b8d436d4 Merge "Add InputDispatcherRule to print the key events dispatched from system_server." into main 2024-03-05 08:23:17 +00:00
Vadim Tryshev acfb4f22c6 Syncing Launcher3 atest XML config with the GCL one
Making sure all config settings are identical.

Test: abtd
Flag: N/A
Bug: 271324404
Change-Id: Ife0c27045a2f9cc4e4ba5c8908caf477db7a0f60
2024-03-04 18:28:20 -08:00
Anushree Ganjam be6fff5e6a Add InputDispatcherRule to print the key events dispatched from system_server.
See
https://source.corp.google.com/h/android/platform/superproject/main/+/main:cts/libs/input/src/com/android/cts/input/DebugInputRule.kt

Locally we can execute `adb shell setprop log.tag.InputTransportPublisher DEBUG` to enable the InputDispatcher logs.

I want to debug why "Ctrl+W" DOWN events in not received by TAPL and to which window is the events delivered.

Bug: 325377690
Test: Manual
Flag: NA
Change-Id: I3f55a48ef3ca79fdaff9d1269c55846cb67b2179
2024-03-04 14:01:05 -08:00
Vinit Nayak 91b06fb4ac Revert "Revert "Implements the "Save App Pair" button in Overvie..."
Revert submission 26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Reason for revert: Test failure in question wasn't related to this topic b/328016248

Reverted changes: /q/submissionid:26420318-revert-26391074-save-app-pair-button-ZKCRCDSCSN

Change-Id: I2a4dbb83720768a9d29a4371c77e3b9410ab2fea
2024-03-04 12:26:23 -08:00
Uwais Ashraf 9c2f5a4c62 Remove classes related to E2E testing from deviceless test classpath
Fix: 327187136
Flag: NA
Test: gradlew :NexusLauncher:testGoogleWithQuickstepDebugUnitTest
Test: atest Launcher3RoboTests
Test: presubmits passing
Change-Id: I4f05524bdc55d8473f3b5115cc239eb8cc48a856
2024-03-04 13:45:32 +00:00
Himanshu Gupta b3cd9802e8 Clearing All Apps Search For ALL_APPS Intent
Currently, if ALL_APPS intent is executed while All Apps
QSB is highlighted, user is left on the search sub-view of
the All Apps view.
To fix this, we add a runner to check the search view and
exit from it after State Transition has happened.

Before: https://photos.app.goo.gl/c5WeUnAzowxRWW1m7
After: https://photos.app.goo.gl/dxvb23wzwPfKqi3o6

Bug: 324516950
Flag: NA
Test: Manual flash and running intent via cmd
Change-Id: Icc291f792545b0c515535857f578bc2e01fef7f7
2024-03-02 18:42:33 +00:00
PODISHETTY KUMAR b588e4618b Merge "Revert "Implements the "Save App Pair" button in Overview Actions"" into main 2024-03-01 09:27:08 +00:00
Vinit Nayak 5c8978c4db Revert "Implements the "Save App Pair" button in Overview Actions"
Revert submission 26391074-save-app-pair-button

Reason for revert: breaks image comparison tests b/327665771
Reverted changes: /q/submissionid:26391074-save-app-pair-button

Change-Id: Ic4580fc39d8394771551f100932157e6ef35c4b7
2024-03-01 01:02:35 +00:00
Jeremy Sim 8c383aceda Merge "Implements the "Save App Pair" button in Overview Actions" into main 2024-02-29 19:47:20 +00:00
Vadim Tryshev 0fa523bb32 Merge "Removing logging for verifying internal Launcher state from tests" into main 2024-02-29 19:18:04 +00:00
Federico Baron 835b9610bc Merge "Update some dimens for portrait edit state" into main 2024-02-29 17:17:19 +00:00
Jeremy Sim 41d8ae8a7a Implements the "Save App Pair" button in Overview Actions
Second attempt at enabling this feature. See ag/25143701, linked bugs, and revert history for details. This patch is tested with mokey devices and does not crash!

This patch includes:
- Ability to "save app pair" from Overview Actions.
- Internally the actions bar is not longer hidden for GroupedTasks; instead the individual buttons for "Select", "Screenshot", and "Split screen" are toggled off and "Save app pair" is toggled on.
- "Save app pair" option does not appear in icon menu when it is visible in the Actions Bar.
- Addition to go/quickstep/res/layout/overview_actions_container.xml to support addition of the new button.

Note: This patch introduces a slight regression where users are now able to long-press to select text on task 1 of a paired GroupedTaskView (previously we did not let them select text on either task for consistency.) Will follow up with a fix -- see bug for details.

Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Fixes: 315545418
Fixes: 315292030
Test: Manual, all action buttons still work and "Save app pair" appears and disappears correctly
Change-Id: I4b4ac525cfd5eb9cfcd757d0bffc7215b04f9a3d
2024-02-28 19:39:04 -08:00
Federico Baron b68a6e581c Merge "Add ScreenRecord for workTabExists tapl test" into main 2024-02-29 02:56:55 +00:00
Treehugger Robot e5f02039eb Merge "Debugging Logs for TaplDragTest#testDragAppIconToMultipleWorkspaceCells" into main 2024-02-28 23:59:38 +00:00
fbaron bd528add50 Add ScreenRecord for workTabExists tapl test
Bug: 325383911
Test: TaplWorkProfileTest#workTabExists
Flag: NONE
Change-Id: I83c92376b16c9b0de352a03ce297e7a9ae51123d
2024-02-28 12:07:49 -08:00
Sukesh Ram 872b9f9a61 Debugging Logs for TaplDragTest#testDragAppIconToMultipleWorkspaceCells
Add logging for TaplDragTest#testDragAppIconToMultipleWorkspaceCells.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 326908466
Change-Id: Icb3262d6af66c9b947cb0cc92c1c67556fba315f
2024-02-28 19:28:07 +00:00
Vadim Tryshev 544f6e228c Add TestStabilityRule so that @Stability annotation works
Bug: 319923578
Test: presubmit
Flag: N/A
Change-Id: I5613a2ee658a458871ea89219764d13796d07b83
2024-02-28 18:27:39 +00:00
Federico Baron 6f7916d647 Merge "Fix TaplOpenCloseAllAppsTest#testAllAppsFromHome" into main 2024-02-28 06:17:13 +00:00
Sukesh Ram 1909570ed3 Debugging Logs for TaplOverviewIconTest#testOverviewActionsMenu
Add logging for TaplOverviewIconTest#testOverviewActionsMenu.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 326073471
Change-Id: I5f08192bb1143c1d23f8884bb207ce69c5830a41
2024-02-28 01:06:14 +00:00
fbaron f1bbcbd743 Fix TaplOpenCloseAllAppsTest#testAllAppsFromHome
Bug: 322228038
Flag: NONE
Test: TaplOpenCloseAllAppsTest#testAllAppsFromHome
Change-Id: I13b31dc16fca02a4e8770aca56e35e8606dd21b3
2024-02-27 16:24:10 -08:00
Treehugger Robot 90182bffc1 Merge "Debugging Logs for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash" into main 2024-02-28 00:02:38 +00:00
Vadim Tryshev dae8b65dea Removing logging for verifying internal Launcher state from tests
Bug: 322823209
Test: presubmit
Flag: N/A
Change-Id: I25afcc30446d429171445f8e1b6033b277166725
2024-02-27 20:23:49 +00:00
Sukesh Ram 41c2a9a900 Debugging Logs for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash
Add logging for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 324940434
Change-Id: I1309e8c1b2ce7b6c06cb520818ef109bbf2f2d23
2024-02-27 19:36:55 +00:00