Commit Graph

4240 Commits

Author SHA1 Message Date
Treehugger Robot 3d7e1c290e Merge "Revert "Use instrumentation arg to prevent unnecessary delays in unit tests"" into main 2024-02-16 08:40:03 +00:00
Tracy Zhou 89f72882ce Guard taskbar / navbar unification logic with whether the device is a phone on top of the flag
Test: Rerun the tapl tests
Bug: 325162802
Change-Id: Iffeeb0a60b634e66bc80e4ba45db816cdc8ba564
2024-02-15 22:06:33 -08:00
Vadim Tryshev 334e9f38e2 Revert "Use instrumentation arg to prevent unnecessary delays in unit tests"
This reverts commit b5d08b246e.

Reason for revert: A similar G3 CL was reverted: cl/582384131

Change-Id: If3e3d6f1aacd297ef357d6330ca3e98e857ea71d
2024-02-16 02:01:20 +00:00
Sunny Goyal cc1dad0cae Merging multiple implementations of CancellableTask
Bug: 318539160
Flag: None
Test: Manual
Change-Id: Ie855427c2676e0ce76655e4dd67472c0b5e435d8
2024-02-15 13:01:10 -08:00
Vadim Tryshev 451eebd450 Adding logging for for the case whe Launcher activity is not resumed after Back
Bug: 322823209
Test: presubmit
Flag: N/A
Change-Id: I4e9b26ab142f4d69f906eeb6d5ab487babbcbca1
2024-02-15 12:39:27 -08:00
Vadim Tryshev 754f4ffa50 Merge "Add logs for uninstallWorkspaceIcon() test" into main 2024-02-15 18:10:10 +00:00
Vadim Tryshev 8602dc38a8 Merge "Disable unstable testCacheUpdate_update_apps in presubmit" into main 2024-02-15 01:37:02 +00:00
Vinit Nayak 574551e2a2 Add logs for uninstallWorkspaceIcon() test
Bug: 319501259
Change-Id: I2ac5c849e4551527eaf7f09a202f00a414d9d980
2024-02-14 23:29:04 +00:00
Vadim Tryshev cb5d2ab72f Merge "Doubling the wait time for activity creation in PortraitLandscapeRunner" into main 2024-02-14 19:54:39 +00:00
Vadim Tryshev 95dba8f278 Disable unstable testCacheUpdate_update_apps in presubmit
Bug: 325283522
Test: presubmit
Flag: N/A
Change-Id: Ia9b2b320780fef23d84f19ce140b9ce97b2bd20e
2024-02-14 18:18:46 +00:00
Alex Chau 76502e84f2 Merge "Refactored StateManager logs" into main 2024-02-14 17:40:08 +00:00
Federico Baron 33c719622f Merge "Add screenrecord for testAllAppsFromHome()" into main 2024-02-14 00:14:55 +00:00
Vadim Tryshev dbaa758854 Doubling the wait time for activity creation in PortraitLandscapeRunner
Apparently, 10 sec is not sufficient, let's try 20.

Bug: 321772674
Test: presubmit
Flag: N/A
Change-Id: Iec67e4d0cf782d7d966566c305e8b73ee67d0f67
2024-02-13 13:50:15 -08:00
Willie Koomson fda1b4b0d0 Merge "Use generated RemoteViews preview for widget picker if available" into main 2024-02-13 21:18:45 +00:00
Vadim Tryshev 00538c2a5a Merge "Allowing the test to set additional anomaly checker for TAPL" into main 2024-02-13 21:16:41 +00:00
Jakob Schneider 38e4471794 Merge "Version-2: Prioritize the session-provided icon & label for archived apps during unarchival in the iconCache." into main 2024-02-13 19:09:52 +00:00
Willie Koomson fedc18e9a8 Use generated RemoteViews preview for widget picker if available
WidgetCell will use the generated RemoteViews preview to display
previews in the widget picker. It will fallback to current preview
methods if not available.

Introduces WidgetManagerHelper.loadGeneratedPreviews as a utility
function. WidgetManagerHelper is passed into the constructor of
WidgetItem to avoid calling
context.getSystemService(AppWidgetManager.class) for each widget.

Bug: 308041327
Test: atest Launcher3Tests:GeneratedPreviewTest
Flag: ACONFIG com.android.launcher3.enable_generated_previews DEVELOPMENT
Change-Id: I37429057cda83a5321884ace2537038e050b9a58
2024-02-13 18:49:44 +00:00
Charlie Anderson e5b1215a2a Merge "Add additional unit tests for WorkspaceItemProcessor to cover shortcuts and folders. Also cleanup the test suite." into main 2024-02-13 16:51:45 +00:00
Alex Chau 4e6e1555c4 Refactored StateManager logs
- Make the log permanaent behind a DEBUG flag
- Logs are currently enabled with b/279059025 marked as the related bug

Bug: 279059025
Flag: None
Test: Manual
Change-Id: I60a75d73d40d00e7d42292f3d42cc9dd8c9b0825
2024-02-13 15:35:15 +00:00
Charlie Anderson 887f49e231 Add additional unit tests for WorkspaceItemProcessor to cover shortcuts and folders. Also cleanup the test suite.
Bug: 294386159
Test: unit tests and presubmit
Flag: N/A

Change-Id: I33370f2a060d1e07fc7dbd37cc9a883501344551
2024-02-13 10:05:32 -05:00
fbaron 0c12987627 Add screenrecord for testAllAppsFromHome()
Bug: 322228038
Test: TaplOpenCloseAllAppsTest
Flag: NONE
Change-Id: I3bcb13c1256df8d0029dfe32d21e95d6b4183037
2024-02-12 16:35:49 -08:00
fbaron 88b89d68fb Restore state of widget picker on fold/unfold
Specifically:
-keep selected tab (personal/work)
-keep search results

Fix: 323406345
Test: WidgetPickerImageTest
Flag: ACONFIG com.android.launcher3.enable_unfolded_two_pane_picker TRUNKFOOD
Change-Id: I919e59484f3af7a2b3b007f5c234055a0f7276b3
2024-02-12 21:13:46 +00:00
Shamali Patwa 9ac01f11da Update dump tests for the bottomsheet top padding alignment.
Bug: 318410881
Test: See screenshots
Flag: N/A
Change-Id: I9d60dd930f06ea404bde90c6b0cf1f61901b1b07
2024-02-12 16:09:42 +00:00
Fengjiang Li 90ebc96e34 Merge "Override Launcher's window bottom inset to 0 on large screen (tablet + unfolded phone) if all display cutouts are at bottom left/right corners" into main 2024-02-11 08:48:58 +00:00
Fengjiang Li 1707575da3 Override Launcher's window bottom inset to 0 on large screen (tablet + unfolded phone) if all display cutouts are at bottom left/right corners
Bug: 321917681
Flag: NONE
Test: manual
Change-Id: I3c41d42e11413c73146c7ef59fc712971e96db19
2024-02-11 04:05:55 +00:00
Himanshu Gupta b12ff142a8 Making Settings Cog open PS Settings page.
Settings Cog action should direct to PS Settings page
instead of PS entry point page in Privacy&Security Center

Bug: 322484516
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space TRUNKFOOD
Flag: ACONFIG com.google.android.apps.nexuslauncher.Flags.enable_inject_private_space_tile TRUNKFOOD
Test: Launcher3 test.
Change-Id: I2bc7a95d591ccedb343909c159c3cbda2814e6bf
2024-02-09 19:38:45 +00:00
Jakob Schneider 4f5b60169d Version-2: Prioritize the session-provided icon & label for archived apps during unarchival in the iconCache.
* Also ensures that apps are sorted based on their actual name, so that
  they don't jump around when "Pending.." switches to "Downloading.."
* In case of faillure during unarchival, icons shown are reverted to that of PM supplied ones.

New UI: http://recall/-/gMbThhDGagWFqnJTbQCqSz/fPuzxUuU7cGXCNdygMkXAB

Test: atest CacheDataUpdatedTaskTest.java and locally verified.
Bug: 319495216
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving TRUNKFOOD
Change-Id: I6410482706af900e273fdc6f7cf0b0692442364c
2024-02-09 13:55:41 +00:00
Uwais Ashraf c2f73d9091 Merge "App chip refactor" into main 2024-02-09 13:43:03 +00:00
Uwais Ashraf 99fdf7a75e App chip refactor
- Adds background outline replacing 2 circles + rect approach. This
enables easier shadow drawing code.
- Simplify structure of AppChipView.
- Adds an anchor View to simplify laying out of menu around app chip

Bug: 313644427
Bug: 317007147
Fix: 322760765
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Test: OverviewImageTest
Change-Id: I56c2644779863c083ae475a740a84321b1d0c396
2024-02-09 12:09:42 +00:00
Vadim Tryshev 09c5398533 Allowing the test to set additional anomaly checker for TAPL
This way, we can unify the messages from the test and the messages fom TAPL for TaplTests

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I9360e5d4ef47021d2dd7e01c859181bbc417a67d
2024-02-08 16:46:37 -08:00
Sebastián Franco e6bab556a1 Merge "Remove unnecesary AbstractLauncherUiTest.initialize whit two arguments" into main 2024-02-08 19:33:13 +00:00
Sebastián Franco 9a8ecd954e Merge "Investigating test" into main 2024-02-08 19:05:12 +00:00
Jagrut Desai a6bf72fe5b Merge "Making AbstractDeviceProfileTest tnd FakeInvariantDeviceProfileTesto only run on CF_PHONE" into main 2024-02-08 16:31:09 +00:00
Jagrut Desai f584d784f8 Making AbstractDeviceProfileTest tnd FakeInvariantDeviceProfileTesto only run on CF_PHONE
Test: Presubmit
Bug: 315230497
Bug: 322418756
Bug: 321596072
Flag: NONE

Change-Id: I668f87304df0ba1dcace3d802906c8a66912d381
2024-02-08 12:06:44 +00:00
Vadim Tryshev e2c07182ed Merge "Removing FilteredLogcat files" into main 2024-02-08 02:16:23 +00:00
Sebastian Franco 3f6194dcaf Investigating test
Flag: NA
Bug: 322823478
Test: waiting for falkes to see results
Change-Id: I447b0f22fe307ade4920e1b12cdc63f375126a5a
2024-02-07 16:33:23 -08:00
Shamali Patwa e2849a0de0 Merge "Remove the "expand/collapse" actions on the apps list in 2 pane picker." into main 2024-02-07 22:53:34 +00:00
Sebastián Franco 458de20538 Remove unnecesary AbstractLauncherUiTest.initialize whit two arguments
Bug: 324261526
Test: atest TaplDragTest
Flag: NA
Change-Id: I0802d725eea222d19c8d8e60878c2f88be854ddc
2024-02-07 22:48:26 +00:00
Anushree Ganjam faa35a81bb Merge "Add Unit tests for System Shortcut." into main 2024-02-07 19:38:32 +00:00
Federico Baron 789ab23ce1 Merge "Align workspace and hotseat icons in landscape" into main 2024-02-07 16:16:16 +00:00
Vinit Nayak 44911450c6 Merge "Update test infra to allow split placeholder view in all apps" into main 2024-02-07 14:57:19 +00:00
Vinit Nayak fad0709510 Update test infra to allow split placeholder view in all apps
* Previously we assume the split placeholder view shouldn't be
present in any states except launcher split selection, however
with contextual that changes.
* Now we only ensure that view isn't there in all apps when
we are not in split selection.

Test: Test runs and passes locally
Fixes: 323418145
Change-Id: Ida92030f9b139532ebb09c1d2646795bbb940bfc
2024-02-07 03:32:02 +00:00
Vadim Tryshev 1e038e4c16 Removing FilteredLogcat files
We don't use them

Bug: 187761685
Flag: N/A
Test: presubmit
Change-Id: I236f3c8e8cc7372e371d9a5bc1ff37889e1ab87b
2024-02-06 18:47:36 -08:00
Fengjiang Li 7f827e1527 Merge "[Predictive Back] Replace legacy flag with aconfig flag in launcher" into main 2024-02-06 21:57:34 +00:00
Sunny Goyal d1176bccf9 Merge "Using system API for rotating DisplayCutout instead of rotating it ourselves" into main 2024-02-06 20:20:47 +00:00
Shamali P 55fded376b Remove the "expand/collapse" actions on the apps list in 2 pane picker.
In a single pane picker, apps list is expandable / collapsable, but,
its not applicable for 2-pane variant. in 2-pane one, it should just
say "double tap to activate".

Also opened b/324073588 to make it clear from a11y perspective that it
is two pane and on click, right pane change should be announced.
(just like it does in settings with talkback).

see screencast/cast/NTQ1Mjk0MjIzOTg1ODY4OHw4OTc5ZjAzNS0wOQ

Bug: 319195592
Flag: None
Test: WidgetsListHeaderAccessibilityTest & manual.
Change-Id: I9ae3fbacc29364bd7459f6e6d85e0a1e919de3f8
2024-02-06 20:07:41 +00:00
Sunny Goyal a90500d233 Using system API for rotating DisplayCutout instead of rotating it ourselves
Bug: 321913010
Flag: NONE
Test: Manual
Change-Id: Iebbc8c17dc3b92a73866b7e22dfbde18eb3a52ff
2024-02-06 10:26:18 -08:00
Fengjiang Li cd60d191a8 [Predictive Back] Replace legacy flag with aconfig flag in launcher
Fix: 323971106
Flag: ACONFIG launcher.enable_predictive_back_gesture DISABLED
Test: manual
Change-Id: Ie8051af2540699a7d75f1ed05132584d0b40d17d
2024-02-05 16:41:29 -08:00
Jordan Silva d5df5b3e11 Merge "Refactoring TAPL functions for OverviewTask" into main 2024-02-05 23:03:49 +00:00
Anushree Ganjam 9858a3e0f4 Add Unit tests for System Shortcut.
Update SystemShortcut<T extends ActivityContext> and remove dependency on Launcher so we can write unit tests.

Introduce TestSandboxModelContextWrapper , wrapper around SandboxModelContext and ActivityContext.

Use SandboxModelContext for testing since we need UserCache, AllAppsContainerView, AllAppsStore to be spied and verified for function calls.

StatsLogManager is not verified in this cl, We can do as follow up.

Bug: 319250810
Test: Manual.
Flag: aconfig com.android.launcher3.enable_private_space TEAMFOOD

Change-Id: If767128a502e40d2016a331db4a342f20f24c588
2024-02-05 10:59:52 -08:00