Commit Graph

4240 Commits

Author SHA1 Message Date
Priyanka Advani c041b5c625 Revert "Include AndroidX test rules in Robolectric tests"
Revert submission 26605558-robolectric-enable-androidx-rules

Reason for revert: Droid-monitor created revert due to build breakages in b/330752689.

Reverted changes: /q/submissionid:26605558-robolectric-enable-androidx-rules

Change-Id: I7737d713be09faff78327df80232d084e836b500
2024-03-21 19:07:50 +00:00
Priyanka Advani 393477ca54 Revert "Move FastBitmapDrawableTest to Robolectric"
Revert submission 26605558-robolectric-enable-androidx-rules

Reason for revert: Droid-monitor created revert due to build breakages in b/330752689.

Reverted changes: /q/submissionid:26605558-robolectric-enable-androidx-rules

Change-Id: I7cb746baffc9bec3315dd324173fd9bde100e4cf
2024-03-21 19:07:50 +00:00
Vadim Tryshev 9ae560d247 Removing SecondaryDisplayLauncherTest that are all @Ignored
Bug: 241166788
Test: presubmit
Flag: N/A
Change-Id: I2288bb0178b86517c44f5c6b572eb63236bb2986
2024-03-21 11:39:12 -07:00
Sihua Ma f62002bb7d Merge "Include AndroidX test rules in Robolectric tests" into main 2024-03-21 17:06:45 +00:00
Sihua Ma cc54051d12 Merge "Move FastBitmapDrawableTest to Robolectric" into main 2024-03-21 17:06:45 +00:00
Federico Baron 09ec3e2623 Merge "Add screenrecord for simple reorder widgets test" into main 2024-03-21 16:12:31 +00:00
fbaron 8248279894 Add screenrecord for simple reorder widgets test
Bug: 330019521
Test: TaplReorderWidgetsTest#simpleReorder
Flag: NONE
Change-Id: Ief042efa088246f964e0b35f1c1ae10a95c5a671
2024-03-20 13:46:47 -07:00
Sunny Goyal 5ca50490a3 Making some classess accessible in multivalent tests
Bug: 297950111
Flag: None
Test: Presubmit
Change-Id: I2e4b18fc279cb96b3f68d64f95703c11bb885b2a
2024-03-20 13:30:40 -07:00
Federico Baron 3a7432d782 Merge "Make touch outside container touch at the middle of the container in terms of height" into main 2024-03-20 18:08:14 +00:00
Fengjiang Li b7e9427dc9 Merge "[Predictive Back] Refactor setClipChildrenOnViewTree/restoreClipChildrenOnViewTree to support clipToPadding" into main 2024-03-20 01:21:09 +00:00
fbaron 30bd886364 Make touch outside container touch at the middle of the container in terms of height
Bug: 326839375
Test: TaplTestsQuickstep#testOverviewDeadzones
Flag: NONE
Change-Id: I7a013ab7d146756cbff009c21b838881e09e044a
2024-03-19 16:44:07 -07:00
Kevin Lim 44d9d1370c Merge "[Deviceless] Create launcher-multivalent-src for referring from NexusLauncherRoboTests" into main 2024-03-19 23:40:49 +00:00
Fengjiang Li ea7cb497f5 [Predictive Back] Refactor setClipChildrenOnViewTree/restoreClipChildrenOnViewTree to support clipToPadding
Bug: 325930715
Test: Added unit test
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Change-Id: I509546ac4ee1fa851cf0648d365a5348362267cc
2024-03-19 15:28:38 -07:00
Tony Wickham 86d8386ab6 Merge "Add TaplTestsQuickstep#testExcludeFromRecents" into main 2024-03-19 20:28:58 +00:00
Sihua Ma 4ff471c2f0 Move FastBitmapDrawableTest to Robolectric
Flag: N/A
Bug: 297950111
Test: atest Launcher3RoboTests
Change-Id: Icef741a1c19bb494f7b74078ce1e7f52ed55a769
2024-03-19 20:27:29 +00:00
Sihua Ma 6da8d07f83 Include AndroidX test rules in Robolectric tests
Test: atest Launcher3RoboTests
Bug: 297950111
Flag: N/A
Change-Id: I6f3c9ddeac9cb676644b3a236a00575c4faaa921
2024-03-19 20:26:40 +00:00
Kevin Lim a14145aad4 [Deviceless] Create launcher-multivalent-src for referring from
NexusLauncherRoboTests

Bug: b/297950111
Bug: b/322393087
Flag: NA
Test: atest Launcher3RoboTests
Test: atest NexusLauncherRoboTests
Change-Id: I8ac58862d53f8574a6678502fcf9488f812eaa1f
2024-03-19 20:11:37 +00:00
fbaron d44f2ec5df Fix bug where folder with 1 icon can exist
Fix: 329357132
Flag: NONE
Test: TaplDragTest
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:5645c3ec558e2b0b6d6ae1c51dbaf93803cd51cf)
Merged-In: If381ff56e051c89e9f6162f8a44f8df9e2ae5060
Change-Id: If381ff56e051c89e9f6162f8a44f8df9e2ae5060
2024-03-19 01:09:55 +00:00
Tony Wickham b84b8524a1 Add TaplTestsQuickstep#testExcludeFromRecents
- Add ExcludeFromRecentsTestActivity, and add it to the manifest
  with excludeFromRecents="true"
- Add the test to check the current Overview task content
  description, ensuring that the excludeFromRecents task is
  present directly after a gesture but not after going home.
Bug: 324495241
Flag: None
Test: TaplTestsQuickstep#testExcludeFromRecents

Change-Id: I06be53673f0ac06924f79b44f19744da066cc7ea
2024-03-18 22:30:13 +00:00
Willie Koomson 078737f22b Merge "Add tap-to-add button to widget picker" into main 2024-03-15 23:26:05 +00:00
Himanshu Gupta 13bf70c7e8 Merge "Ignoring the failing test." into main 2024-03-15 23:03:22 +00:00
Willie Koomson cdc26951ff Add tap-to-add button to widget picker
This change introduces an "Add" button that appears when a widget
preview is clicked in the widget picker. This button disappears when the
preview is clicked again, or another preview is clicked. When the button
is pressed, it adds that widget to the picker. The add button is
available in the app-specific widget sheet as well.

Bug: 323886237
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_widget_tap_to_add DEVELOPMENT

Change-Id: I86a8a4c22119960c54a885fd2efeb91916b4f9a0
2024-03-15 20:10:45 +00:00
Fengjiang Li 00711e68a5 Merge "Enable predictive back in TAPL tests" into main 2024-03-15 14:52:58 +00:00
Fengjiang Li e90f098d4f Enable predictive back in TAPL tests
With ag/26349940 we have fixed the bug where back swipe is not working

Fix: 326118348
Test: this is the test
Flag: NONE
Change-Id: I7e826f6ba3022a04d016d4a0a2134e287d85e8be
2024-03-15 00:00:37 -07:00
Himanshu Gupta 0f1fe9722f Ignoring the failing test.
LauncherIntentTest#testAllAppsIntent is a newly added
TAPL test that seems to be breaking on a few devices.

Disabling it until the root issue is fixed.

Bug: 329152799
Test: Manual
Flag: NA
Change-Id: I3c1d145a444d4d2a85b3f5d2a968d120eee7cca0
2024-03-14 13:53:38 -07:00
Sebastián Franco 892ffb8b15 Merge "Making 2 flags read only since they are used on backup and restore" into main 2024-03-14 20:12:05 +00:00
Federico Baron f6fd1f3d46 Merge "Fix bug where folder with 1 icon can exist" into main 2024-03-14 20:02:04 +00:00
Sebastian Franco 5ea61960ab Making 2 flags read only since they are used on backup and restore
The flags are narrow_grid_restore and grid_migration_fix.

Flag: ACONFIG enable_grid_migration_fix enabled
Flag: ACONFIG enable_narrow_grid_restore enabled
Bug: 325286145
Bug: 325285743
Test: BackupAndRestoreDBSelectionTest.kt
Test: GridMigrationTest.kt
Change-Id: Ia6a439553c3c5098115144eae532342ce73be4f2
2024-03-14 17:16:51 +00:00
fbaron 5645c3ec55 Fix bug where folder with 1 icon can exist
Fix: 329357132
Flag: NONE
Test: TaplDragTest
Change-Id: If381ff56e051c89e9f6162f8a44f8df9e2ae5060
2024-03-14 10:13:00 -07:00
Federico Baron 719075b56c Merge "Update min next page visible to 48dp" into main 2024-03-14 16:32:39 +00:00
Brandon Dayauon 69aa9a07ee Merge "Disable two line text legacy flag." into main 2024-03-14 15:11:13 +00:00
Brandon Dayauon a7bd5cf6ee Merge changes I209e3ec7,If70df129 into main
* changes:
  Change collapse to use adapterItems instead of getting the childCount()
  Upon expanding, expand just enough so the header shows.
2024-03-13 22:49:02 +00:00
Sebastián Franco 920d333e3a Merge "In the case the gird migration goes to a taller grid keep the grid configuration" into main 2024-03-13 22:26:42 +00:00
Sebastian Franco 2eaf15c37a In the case the gird migration goes to a taller grid keep the grid configuration
For example going from 4x5 to 4x6 it will keep the 4x5 configuration
which fits in the 4x6 grid.

Also, it fixes GridMigrationTest which was flaky because of
how it sorted arrays.

Bug: 325286145
Flag: ACONFIG grid_migration_fix disabled
Test: NA
Change-Id: I6063e3c303320096f7429a3b1d909e107d2ef2a0
2024-03-13 11:13:38 -07:00
Uwais Ashraf cf70589921 Merge "Enable tests which do not require any modification" into main 2024-03-13 15:42:07 +00:00
Shamali Patwa 1a72429687 Merge changes from topic "preview-sizes" into main
* changes:
  Limit the recommendations space in two pane picker
  Update the widget previews to use the container sizes
  Avoid cropping image previews.
  Add preview container size helper to display previews in picker.
2024-03-13 13:32:05 +00:00
Uwais Ashraf 4ee1701fd1 Enable tests which do not require any modification
Fix: 329052420
Flag: NA
Test: Presubmits + :NexusLauncher:testGoogleWithQuickstepDebugUnitTest
Change-Id: I27e847c923076e4e978fd7359c9c62745d4f5f0a
2024-03-13 12:27:46 +00:00
Shamali P 927dd27ece Update the widget previews to use the container sizes
Additionally, adjusts the margins on sides, to make space for displaying
multiple previews side by side.

As a result of this change, previews aren't cropped anymore (indirectly
also fixing b/317366201).

There is one more follow up pending - to limit the height of
recommendations in two pane sheet to only visible area to keep the
suggestions quick to look and concise. It will also help with better
scroll experience when size is same across pages.

* http://screencast/cast/NTQ0Njc4ODgyNjc5MTkzNnxjYzZiYTU2Ny02Yw
* http://screencast/cast/NTk4ODMyMDkxOTE1ODc4NHw3NzdlNTgxZS1kMw
* http://screencast/cast/NTYxOTc5NjIxNjM4MTQ0MHxiMjQ2Njc3OC0zOQ
* http://screencast/cast/NDk4MjIxNjI0MDEzNjE5MnxjY2IwYmIxNi00Mw

Bug: 319152349
Flag: N/A
Test: Image test and table utils test
Change-Id: I07465bd4d84597b560a2b998ff1ccbf9867c0192
2024-03-12 23:47:07 +00:00
Shamali P c93f687f12 Avoid cropping image previews.
In most cases, cropping image-based previews to just fit width leads to
degraded UX. Instead we try to fit them to the widget size if possible.

* Before: See attached bug for examples of cropped previews.
* After: http://screen/Bg7Eoydr4qBQdVZ

Additionally center align previews vertically for non-categorized
suggestions too.

Bug: 319152349, 317366201
Flag: N/A
Test: Includes a unit test & manual with the child cls
Change-Id: I4447f99028129d5d5379ead9ca404f7a011d1551
2024-03-12 23:47:07 +00:00
Shamali P a1dbbeab7e Add preview container size helper to display previews in picker.
While we want previews to be displayed at true size, today, there is
less consistency among different widgets. This change is a first step
towards consistent sizes. In this change, we provide helper classes
that provide the size of the container in terms of grid spans.

Note: This does not change the size for rendering widget previews; but,
we take that original rendered preview and scale it maintaining the
aspect ratio to display it in one of closest container sizes.

Bug: 319152349
Flag: N/A
Test: Includes a unit test & manual with the child cls
Change-Id: I335373aa1be9a41fe039c98cded0113a007ad8c4
2024-03-12 23:47:07 +00:00
Sebastián Franco e9ebd2d70a Merge "Revert^4 "Removing all restored backups except one so we don't have old backups"" into main 2024-03-12 22:00:36 +00:00
Himanshu Gupta 201626b553 Merge "Using LauncherApps API for PS Settings and Setup Flow." into main 2024-03-12 21:17:22 +00:00
Willie Koomson be65a75e82 Merge "Check for null preview in WidgetItem.hasGeneratedPreview" into main 2024-03-12 19:15:59 +00:00
Sebastián Franco ad46eb75f4 Revert^4 "Removing all restored backups except one so we don't have old backups"
To prevent the error I introduce the method restorePreviousState().

This reverts commit 1234090589.

Reason for revert: Fixing presubmit breaks

Bug: 325285743
Flag:  ACONFIG narrow_grid_restore disabled
Test: BackupAndRestoreDBSelectionTest
Change-Id: I63666c29eb91dada4243af019ab0538c40bc0f78
2024-03-12 11:01:26 -07:00
Treehugger Robot 0cd5024c6b Merge "Debugging Logs for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash" into main 2024-03-12 17:52:22 +00:00
Shamali Patwa 7574bed02e Merge "Update labels for the categories to match the UX writer provided strings" into main 2024-03-12 11:37:25 +00:00
Sukesh Ram 8229228132 Debugging Logs for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash
Add logging for TaplTestsTransientTaskbar#testSwipeToStashAndUnstash.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 324940434
Change-Id: I7c30fb2f3c94770fa79780d2e7748e931552ba56
2024-03-12 02:17:59 +00:00
Himanshu Gupta 616a1b828d Using LauncherApps API for PS Settings and Setup Flow.
Bug: 310027945
Test: Launcher3 tests
Flag: ACONFIG com.android.launcher3.enable_private_space TRUNKFOOD
Change-Id: I6e04a4b0c33d4526d83b51e512e1e4372ce1cca4
2024-03-11 16:13:08 -07:00
Uwais Ashraf 03033273c0 Merge "Adjust mockito dependencies to make them work for Robolectric" into main 2024-03-11 22:56:04 +00:00
fbaron a64ce4eb71 Update min next page visible to 48dp
Fix: 326623964
Flag: NONE
Test: HomeScreenEditImageTest DeviceProfileDumpTest
Change-Id: I0a2de73589bf769eb2efb8d66d9ab3836cbee6d2
2024-03-11 22:40:40 +00:00