Commit Graph

20478 Commits

Author SHA1 Message Date
Jagrut Desai 7cada7c46b Two Taskbar Bug
This cl fixes two taskbar bug being present when invoking CtS.

Solution: simply measure displacement and compare that with slop to animate taksbar background or not.

Test: Presubmit
Bug: 360116669
Flag: EXEMPT Bug Fix

Change-Id: I7d5a95e1a3729e30e5cf588dcf5b823f3d7de93f
2024-09-30 16:32:47 -07:00
Ats Jenk 5464ce0084 Update bubble stash test for transient taskbar
Include unit test to check that view properties are set to expected
values at the end of an unstash animation.
Add tests to check that alpha for bubbles and background changes
separately during unstash and stash animations.

Bug: 345488489
Test: TransientBubbleStashControllerTest
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: Ifd10d4524128d42d23fe67c0eff2c4ae16d3b27b
2024-09-30 15:43:15 -07:00
vinayjoglekar 562ab4d188 Fixed split in Desktop windowing
When desktop windowing is enable and split is selected, during second app selection apps' scroll was far off on left. There were several things needed to fix this :
1. Hide DesktopTaskView during split select mode by changing splitAlpha
2. Fix min/max scroll calculation by excluding DesktopTaskView in split select mode
3. Exclude DesktopTaskView in updateGridProperties row length calcualtion

Testing: Manually needed to test multiple scenarios
1. Split focused task.
2. Split Even/Odd tasks in top and bottom rows.
3. Split tasks from home screen
4. Split and rotate screen.
5. Split from app icon chip

Test: SplitSelectStateControllerTest, Manual
BUG: 330342294
FIX: 330342294
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: I789873100f42896c9ed3084accb0f6970abcba0c
2024-09-30 15:22:40 -07:00
Treehugger Robot 2b1208e803 Merge "Animated fullscreen and desktop carousel attaching together" into main 2024-09-30 17:39:55 +00:00
Bill Yi f367f79ec6 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-09-30 17:20:16 +00:00
Treehugger Robot 2b1b7d2bb9 Merge "Increase frame limit for bubble bar screen test" into main 2024-09-30 16:56:12 +00:00
Liran Binyamin 74299edbc6 Merge "Update flyout content during animation" into main 2024-09-30 16:54:15 +00:00
Alex Chau 52afe8b794 Pass correct scrollDiff to translateTaskWhenDismissed
- This is a follow-up of refactoring CL ag/29580515, which passed wrong parameter to a function

Bug: 353948182
Test: manual
Flag: EXEMPT REFACTOR
Change-Id: I544f4142b1007c034f8e7364e48c32e6500e03f8
2024-09-30 13:01:33 +01:00
Alex Chau 396441545f Animated fullscreen and desktop carousel attaching together
desktopCarouselDetachProgress:
- Controls whether desktop and fullscreen carousel is attached (RecentsView..DESKTOP_CAROUSEL_DETACH_PROGRESS)
- When fully detached (progress==1), hide the carousel (RecentsView.applyAttachAlpha)
- As the detach progress increase, we animate the other carousel away by using `getMaxHorizontalOffsetSize`, with additional maxOverscroll to make sure the other carousel won't be seen even if user overscroll RecentsView (RecentsView.updatePageOffsets)

min/max scroll changes
- When desktop and fullscreen carousel detaches, disallow scrolling to the detached carousel. This avoids quickswitching or scroll to the other carousel (RecentsView.getFirstViewIndex and RecentsView.getLastViewIndex)

State machine changes:
- On Overview states, desktop and fullscreen carousel is attached. Otherwise, they're detached, including in quick switch and home. (BaseState, RecentsState, OverviewState, BackgroundAppState)
- StateController set/animate desktopCarouselDetachProgress between the above states (BaseRecentsViewStateController, FallbackRecentsStateController)
- On swipe up gesture release and going to Overview, animate attaching back the 2 carousels (RecentsView.onPrepareGestureEndAnimation)

Bug: 353948100
Test: quick switch; swipe from home/app; scroll in Overview; with normal/3p launcher
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: Ic4217efb07db079825a3210afd306d9ef627c873
2024-09-30 11:43:31 +01:00
Luca Zuccarini 75883dd89e Merge "Make workspace and hotseat scale animations interruptible." into main 2024-09-30 09:42:59 +00:00
Schneider Victor-tulias 3eb6fa28e3 Merge "Refactor CompoundString to use a string-format API matching ProtoLog" into main 2024-09-28 17:49:24 +00:00
Jeremy Sim ce40e83e56 Merge "Update splitscreen SnapPosition constants" into main 2024-09-28 02:54:10 +00:00
Mykola Podolian 9766d7061e Merge "Add teleport animation to the navigation bar." into main 2024-09-28 00:20:21 +00:00
Liran Binyamin 5c34cf2741 Update flyout content during animation
This change translates the content of the flyout according
to the progress of the animation. Adding an outline provider
allows clipping the content to the bounds of the animating
background.

Also animate the color of the background.

Demo:
on left - http://recall/-/bJtug1HhvXkkeA4MQvIaiP/cH2EK0FiD92dykhLkLeyh1
on right - http://recall/-/bJtug1HhvXkkeA4MQvIaiP/btpcter79rAlcavd4xxHu7

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutViewScreenshotTest
Test: atest BubbleBarFlyoutControllerTest

Change-Id: Id142af2041410c0570759a360146d5e084411cc1
2024-09-27 17:27:20 -04:00
Alex Chau a3169790fd Merge "Don't hide DesktopTaskView in split select" into main 2024-09-27 20:56:59 +00:00
Ats Jenk e7d52f523d Merge "Handle swipe down on collapsed bubble bar" into main 2024-09-27 19:44:56 +00:00
Sunny Goyal 63c24aeacb Merge "Updating IconProvider API to use a single API to load icons" into main 2024-09-27 19:43:54 +00:00
Jeremy Sim 66b695b5fd Update splitscreen SnapPosition constants
Bug: 349828130
Test: No logical changes, continues to pass tests
Flag: com.android.wm.shell.enable_flexible_split
Change-Id: I7b0b436c7eabf7d9fc46e2c6d6e504343d06e48a
2024-09-27 19:17:20 +00:00
mpodolian 26ed420173 Add teleport animation to the navigation bar.
Whenever the location of the bubble bar is changed, the navigation bar
moves with a "teleport" animation to the opposite side.

Bug: 346381754
Flag: com.android.wm.shell.enable_bubble_bar_in_persistent_task_bar
Test: manual. Drag bubble bar from one location to another observe that
navigation is animated to the opposite side.
Video: http://recall/-/gx8ASgewUeUS3QYohfrd1J/g3zFtGYWFpCsBTkoCAhBUH

Change-Id: I6e32bb7ff7be56a0b616fec8485cc6a97d7ac872
2024-09-27 11:30:56 -07:00
Schneider Victor-Tulias 688bc453cd Refactor CompoundString to use a string-format API matching ProtoLog
Flag: com.android.launcher3.enable_active_gesture_proto_log
Bug: 293182501
Test: checked TIS logs
Change-Id: I6728697f659ed3617169a41e524ab93a587b6e75
2024-09-27 18:08:43 +00:00
Jordan Silva 04484049fa Extracting handheld task dismiss translation to smaller functions (2/4)
This CL extracts the logic to translate the tasks used when Overview grid is disabled (i.e., for handheld) to 2 smaller functions that will be used for desktop and grid translation in the follow up CL.

Bug: 353948136
Bug: 353948182
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: OverviewDesktopTaskImageTest
Change-Id: Ie25fffaaca4580a8a483003d220b4bf6cdccbc66
2024-09-27 16:32:00 +00:00
Mykola Podolian 6f231f694d Merge "Update placement of the hotseat according to the bubble bar location." into main 2024-09-27 15:45:04 +00:00
Alex Chau 8b50c8f609 Don't hide DesktopTaskView in split select
- Setting DesktopTaskView to GONE completely breaks Overview layout. Instead keep them in split select but do nothing when being clicked
- With large desktop tile feature we'll properly hide DesktopTaskView

Bug: 330342294
Test: without large desktop tile, enter split select, layout isn't broken; clicking desktop task doesn nothing
Flag: EXEMPT BUG_FIX
Change-Id: I164ed75e8531e08b6d982e3bda418ae19fa272e9
2024-09-27 16:22:16 +01:00
Liran Binyamin b140ccec49 Increase frame limit for bubble bar screen test
This test is flaky because the animation sometimes doesn't
finish before the screenshot is taken. Increasing the frame
limit should help to ensure that the animation has time to
finish.

ABTD 100x runs (passed): https://android-build.corp.google.com/abtd/run/L84400030006722716

Change-Id: I410fb74a947d805551ce1b2303f0dc4c8d616de9
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 366544536
Test: ABTD above
2024-09-27 15:19:15 +00:00
Matt Casey 3648100d45 Merge "Provide Display ID for overview screenshots" into main 2024-09-27 14:03:29 +00:00
Luca Zuccarini 2831d1eaf7 Make workspace and hotseat scale animations interruptible.
This affects app launches and returns to home. When launching
immediately after returning to home (before the return animation is
complete), the two animations could overlap, causing the two property
setters to conflict.

Bug: 367591368
Flag: com.android.launcher3.coordinate_workspace_scale
Test: tested with flag off and on, see before and after in the bug
Change-Id: Ie1483fa0bf589caee315ae298e9e68ca361709d8
2024-09-27 13:30:09 +00:00
Liran Binyamin 272eea45e6 Merge "Implement bubble bar flyout background animation" into main 2024-09-27 12:45:41 +00:00
Alex Chau e3dc1c5185 Merge "Fix grid task dismiss animation when desktop large tile is enabled (1/4)" into main 2024-09-27 09:01:50 +00:00
Jon Miranda e40cc40619 Close KeyboardQuickSwitch if user taps outside the container.
Bug: 368119679
Change-Id: I3f0b1cacb76077daa5879ad93c195018948497f9
Test: open KQS via taskbar affordance, tap outside the container,
      observe KQS close
Flag: com.android.launcher3.taskbar_overflow
2024-09-27 06:08:11 +00:00
Winson Chung 043025eb06 Merge "Update TIS logs to narrow down duplicate service creation" into main 2024-09-27 05:46:20 +00:00
Sunny Goyal a1cebfa0c0 Updating IconProvider API to use a single API to load icons
Bug: 366237794
Test: atest IconProviderTest
Flag: EXEMPT refactor, changes in underlying API

Change-Id: If8c6a4f13de7e7d262ee0b6d0c6897981f75e639
2024-09-26 22:13:11 -07:00
Jon Miranda cd00e8f2e4 Merge "Position KQS to the bottom if opened via taskbar." into main 2024-09-27 04:09:55 +00:00
Treehugger Robot 39341d19a9 Merge "Filter out running pinned app tasks from KeyboardQuickSwitch." into main 2024-09-27 03:21:16 +00:00
Tracy Zhou 649c900004 Merge "Cancel TASKBAR_COLLAPSE/EXPAND CUJ tracking when the stash animation is cancelled" into main 2024-09-27 03:05:40 +00:00
Bill Yi 2321e1a323 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I5a631a9968edafb4f7cdc83a9b0a21cd7bb65b12
2024-09-26 19:15:19 -07:00
mpodolian dfb48214ea Update placement of the hotseat according to the bubble bar location.
Update the hotseat and Qsb placement according to the 3 nav buttons bar.

Test: Manual.
Set navigation mode to 3 buttons.
On launcher home screen move the bubble bar from one side to another.
Observe that the Hotseat and Qsb moving together with the navigation
bar.
Once moved the bubble bar, expand the bubble bar and collapse it.
Observe how the Hotseat is stashing and un-stashing.
After bubble bar changes position hit the recent apps button, observe
the transition.
On launcher home screen start application with the hotseat icon and exit
opened application. Observe that flying icon comes back to the correct
position in the hotseat.
Video with the above scenarios:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/blTYrKopTyufOcRoPuVpYK
Bug: 346381754
Flag: com.android.wm.shell.enable_bubble_bar_in_persistent_task_bar

Change-Id: Ic8c6acdffbbb111cbe4f3fd6bc60195578d7035d
2024-09-26 19:04:01 -07:00
Jon Miranda daa8779012 Merge "Taskbar overflow: only show if apps don't fit + limit # of icons" into main 2024-09-26 20:40:13 +00:00
Treehugger Robot 3aefeb8761 Merge "Track all ActiveGestureLogs in ProtoLog" into main 2024-09-26 20:22:09 +00:00
Liran Binyamin f7fc19bec1 Implement bubble bar flyout background animation
Update the bubble bar flyout drawing behavior to allow to animate
from a collapsed position into an expanded position.

This change only handles the rounded rect and the triangle. The
text is still left unchanged.

When wired up this looks like this:
left: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/gIsckRmFKj8CceafiJnPTa
right: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/dpn51yXFCCkT6ViUegf351

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutViewScreenshotTest
Test: atest BubbleBarFlyoutControllerTest
Change-Id: I85ae3bf908c04e5473655c9e536495f56d80f466
2024-09-26 14:38:41 -04:00
Jordan Silva 21ac8f1451 Fix grid task dismiss animation when desktop large tile is enabled (1/4)
- Fix bottom grid row size in createTaskDismissAnimation to subtract all large tiles from bottom row count.
This fixes the animation when dismissing a focused and a bottom row task turns into a focused task.

- Fix when snapping to last task, snap to focused task page instead of INVALID_PAGE (-1).
This prevents snapping to a wrong page (DesktopTask page) when last grid task is dismissed.

Bug: 353948136
Bug: 353948182
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: OverviewDesktopTaskImageTest
Change-Id: Ib4b0453eb6b99855615b22fe842ccbe1205c962d
2024-09-26 13:15:28 -03:00
Jon Miranda deaca33cc2 Position KQS to the bottom if opened via taskbar.
Bug: 368119679
Test: open KQS via taskbar, observe view at bottom of screen
      open KQS via keyboard, observe view at top of screen
Flag: com.android.launcher3.taskbar_overflow

Change-Id: I3e6f0d2ba51ec15cf7cb1f41ddc2a4414dfd60d6
2024-09-26 16:05:57 +00:00
Jon Miranda 9ce27637d7 Filter out running pinned app tasks from KeyboardQuickSwitch.
- Opening KQS from keyboard shortcuts shows all the tasks.
- Opening KQS from taskbar will filter out all the running pinned apps
  from the list of views.

Bug: 368119679
Change-Id: I6090679f9fc359212db00a325917892ae6e1eb39
Test: open KQS via taskbar affordance, obseerve filtered list,
      use alt + option
      observe list changes to show all tasks
      click affordance again, observe list changes back to filtered
Flag: com.android.launcher3.taskbar_overflow
2024-09-26 16:05:23 +00:00
Tracy Zhou 408b1e0103 Cancel TASKBAR_COLLAPSE/EXPAND CUJ tracking when the stash animation is cancelled
Bug: 362713428
Test: manual
Flag: EXEMPT bugfix
Change-Id: Ib09a26056ed0d4bae64566eed92279241dd84a90
2024-09-25 21:11:37 -07:00
Liran Binyamin bb87ec09de Add OWNERS file for multivalentScreenshotTests/src/com/android/launcher3/taskbar/bubbles
Flag: EXEMPT only changing OWNERS
Test: EXEMPT only changing OWNERS

Change-Id: If35010b4bfc166bd8e3734a8fa5be58f6c238f0c
2024-09-26 00:15:42 +00:00
Tracy Zhou 9c9f9a887e Merge "Update suw insets in landscape" into main 2024-09-25 23:27:41 +00:00
Ats Jenk 0b19598d36 Handle swipe down on collapsed bubble bar
Allow swiping down on collapsed bubble bar to stash it.

Bug: 325673340
Test: atest NexusLauncherTests:com.android.launcher3.taskbar.bubbles.BubbleBarSwipeControllerTest
Test: swipe up to show bubble bar and swipe down to stash it
Test: tap on stashed handle
Test: enable 3 button nav and tap on bubble bar
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I0367d36bdc1aef34dc71843052b691a95e293375
2024-09-25 13:06:22 -07:00
Treehugger Robot 5628ce97e9 Merge "Increase frame limit in bubble bar screen test" into main 2024-09-25 18:25:42 +00:00
Matt Casey 43ea3e0444 Provide Display ID for overview screenshots
Bug: 367394043
Test: Manual test with logging
Flag: EXEMPT behavior changes are flagged, this is just passing in data.
Change-Id: I7c1998eaeadad40670b2942e80f2bac878a8f186
2024-09-25 16:54:22 +00:00
Schneider Victor-Tulias 62335be7c9 Track all ActiveGestureLogs in ProtoLog
Flag: com.android.launcher3.enable_active_gesture_proto_log
Bug: 293182501
Test: checked protolog traces in winscope
Doc: go/launcher-protolog-support

Change-Id: I2eb153aa9a94fe49f9c5e9b93b0be5e14fb4eb9c
2024-09-25 14:28:00 +00:00
Schneider Victor-tulias 8388a07673 Merge "Add protolog support to Quickstep" into main 2024-09-25 13:44:02 +00:00