Commit Graph

20478 Commits

Author SHA1 Message Date
Ats Jenk d137856e26 Merge "Update bubble bar swipe logic" into main 2024-10-09 21:32:43 +00:00
Randy Pfohl 6fe18165b4 Merge changes Ifd147d6f,I72629a27 into main
* changes:
  decoupling task animation lifecycle from recents lifecycle
  fixing a state cycle issue in recents window  where we set home instead of bg_launcher
2024-10-09 21:27:01 +00:00
Brian Isganitis 601d1f04e9 Merge "Migrate Taskbar tests to use SandboxApplication." into main 2024-10-09 21:12:14 +00:00
Liran Binyamin 024b0e63da Merge "Prepare for wiring bubble bar flyout" into main 2024-10-09 19:23:54 +00:00
mpodolian 51e2bb31ed Created a helper method that calculates the hotseat icons shift X.
Moved out logic that computes the translation X for the hotseat icons.

Fixes: 368379159
Test: Manual. Have the hotseat adjusted. Open any application from the
hotseat bar. Go back to home.
Flag: EXEMPT refactoring

Change-Id: If9dfa70be537f87b075bd865e7f9c5cd1ae78f00
2024-10-09 12:17:01 -07:00
randypfohl ff160c51a0 decoupling task animation lifecycle from recents lifecycle
this will fix a few bugs but create acouple others. Luckily this is all behind a flag for now but will prevent us building on broken code

Test: Built locally and tested

Flag: com.android.launcher3.enable_fallback_overview_in_window

Bug:292269949

Change-Id: Ifd147d6f3dd3234dfb1afe369f83c241a205c6af
2024-10-09 12:03:49 -07:00
Liran Binyamin c25aa0c20f Create container view for bubble bar
The container will be used to inflate the bubble bar flyout view

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: builds successfully -- code is not wired up yet

Change-Id: I3012caa801c73f9e13f26c8803595b59e250ae1e
2024-10-09 11:09:48 -04:00
Schneider Victor-Tulias 1decb57e61 Add state manager logs to protolog
Flag: com.android.launcher3.enable_state_manager_proto_log
Bug: 292269949
Test: checked winscope traces
Change-Id: I0941620efca3bf0d3cd859c211a7b06932d3838a
2024-10-09 14:14:22 +00:00
Fengjiang Li 741806408d Merge "[Dagger] Make AsyncClockEventDelegate provided by DaggerSingletonObject" into main 2024-10-08 23:56:25 +00:00
Mykola Podolian 7153b179a9 Merge "Update stashing hotseat logic." into main 2024-10-08 23:38:38 +00:00
Ats Jenk 6570ac750f Update bubble bar swipe logic
After changes following swipe interactions are available for the bubble
bar:
1. stashed handle
- swipe up to show bubble bar, after swipe reaches unstash threshold, we
  show the bubble bar
- swipe down to stash bubble bar in the same gesture (without lifting
  finger), do this when swipe moves back below unstash threshold
- expand bubble bar on finger lifted when currently above unstash
  threshold

2. collapsed bubble bar (used in home or overview)
- swipe up and release over unstash threshold to expand bubble bar
- bubble bar can't be swiped down to stash it

3. expanded bubble bar
- no swipe interactions available

Bug: 371229061
Flag: com.android.wm.shell.enable_bubble_bar
Test: BubbleBarSwipeControllerTest
Test: manually test:
  - stashed bubble bar:
      - swipe up and back down => bubble bar shown and stashed
      - swipe up slightly and release => bubble bar not shown
      - swipe up and release => bubble bar shown, expands on release
  - collapsed bubble bar:
      - swipe down => no action
      - swipe up slightly => no action
      - swipe up and release => bar expands on release
Change-Id: I42aa59dc288446603e06a3d02419be38cf17fa1f
2024-10-08 16:17:32 -07:00
randypfohl c8d1465a76 fixing a state cycle issue in recents window where we set home instead of bg_launcher
Flag: com.android.launcher3.enable_fallback_overview_in_window

Test: Local state cycling

Bug: 292269949

Change-Id: I72629a270f0afa1d05803636f9c9308d2a0e08fd
2024-10-08 16:15:23 -07:00
Liran Binyamin 98ecad0352 Prepare for wiring bubble bar flyout
Implement BubbleBarFlyoutPositioner in BubbleBarViewController

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: builds successfully -- code is not wired up yet
Change-Id: Ib2d9b1f2f6e972f6ce949e10d50334a501c8c805
2024-10-08 16:40:31 -04:00
Alina Zaidi 90f9700b4d Merge "[dev_option] Move DestopModeFlags out of android.windows.flags" into main 2024-10-08 20:24:06 +00:00
Alina Zaidi 8c0dc4c655 [dev_option] Move DestopModeFlags out of android.windows.flags
This is to maintain separation of non-generated files from generated flag values.

Test: Current tests pass
Flag: EXEMPT refactoring
Bug: 370777204
Change-Id: If9ca76cbf084da7a37241216f41319610adc52b0
2024-10-08 17:51:23 +00:00
Sunny Goyal 9dcf307a62 Merge "Fixing test flakiness in Launcher initialization" into main 2024-10-08 17:29:27 +00:00
Fengjiang Li 2075e39c76 [Dagger] Make AsyncClockEventDelegate provided by DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: NONE - dagger
Change-Id: I53791218e0ff1e5d61cefee3f32a4c49882777cc
2024-10-08 10:19:01 -07:00
Fengjiang Li a49a2a32be Merge "[Dagger] Make SettingsCache provided by DaggerSingletonObject" into main 2024-10-08 17:13:20 +00:00
Brian Isganitis 46b20441e4 Migrate Taskbar tests to use SandboxApplication.
This class has even better sandboxing and is a TestRule, making it easy to tear down singletons.

Flag: TEST_ONLY
Fix: 369504330
Test: go/testedequals
Change-Id: I86fbfecc275da536ab745d61bef8b9bebb28379c
2024-10-08 16:34:44 +00:00
Jagrut Desai d37759429b Merge "Fix Taskbar to Hotseat Animation for Non-Predective back apps" into main 2024-10-08 16:08:09 +00:00
Orhan Uysal 3d7bba6a6e Merge "Use desktop API to remove desktop for dismiss" into main 2024-10-08 15:18:06 +00:00
Liran Binyamin 9c3c7cc3e2 Merge "Store the flyout in BubbleBarBubble" into main 2024-10-08 13:31:53 +00:00
Sukesh Ram fb1088ef87 Merge "Refactor Taskbar Button Coloring Code" into main 2024-10-08 08:06:51 +00:00
Sunny Goyal 8f921688b7 Merge "Removing dependency on PackageInfo in IconCache" into main 2024-10-08 07:33:39 +00:00
Fengjiang Li 4d819d9dea [Dagger] Make SettingsCache provided by DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: NONE - dagger
Change-Id: Id709a6e1d14446b8361cf292d5f5422f2ea3524c
2024-10-07 23:10:53 -07:00
Treehugger Robot 4205a76f23 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-10-08 05:00:24 +00:00
Sunny Goyal b619d2c297 Removing dependency on PackageInfo in IconCache
Bug: 363324203
Flag: EXEMPT bugfix
Test: atest IconCacheTest
      atest IconCacheUpdateHandler

Change-Id: I85005ef1069960a17a0f3e7265749a8ef3004172
2024-10-08 04:09:54 +00:00
Mykola Podolian 5ddf3ba31f Merge "Fixed the hotseat placement in RTL mode" into main 2024-10-08 02:05:42 +00:00
Jagrut Desai 0a65c5bd72 Fix Taskbar to Hotseat Animation for Non-Predective back apps
- Refactored Taskbar animation duration to under one method and added logic to sync animation duration according to enableScalingRevealHomeAnimation.
- Change the interpolator for TaskbarLauncherStateController based on enableScalingRevealHomeAnimation.

Test: Presubmit, Manual
Bug: 369378541
Flag: EXEMPT Bug Fix
Change-Id: I942829b475f91e9102801b758eb7ee0d27eee912
2024-10-07 17:01:00 -07:00
Sukesh Ram 9a723c8f21 Refactor Taskbar Button Coloring Code
Given the emergence of b/341190547, this CL seeks to simply refactor the code for readability to aid in investigation efforts.

Flag: EXEMPT bugfix
Bug: 341190547
Test: Manual
Change-Id: I2e42d9c9e8eebd96d4e507b6dd357d7bedcd4a30
2024-10-07 16:03:38 -07:00
mpodolian 3469b1f6be Update stashing hotseat logic.
Before this change we only aligned the taskbar with the hotseat if the
hotseat position is changed. But it does not work if hoseat icons have
reduced space in between each other to accommodate the bubble bar. This
change aligns the task bar with the hotseat icons before any hotseat
animation.

Fixes: 372075963
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Have the hotseat with the reduced icons space. Expand /
collapse the bubble bar.

Change-Id: I72156cfc78f4db93b5bba11f1bfdda83c20b9a02
2024-10-07 15:23:11 -07:00
Ats Jenk ea6e59537e Merge changes I74af6a72,I603a67a8 into main
* changes:
  Animate bubble bar alpha when notif shade opens
  Set bubble bar invisible while stashed
2024-10-07 22:23:02 +00:00
Liran Binyamin 5e04f0960d Store the flyout in BubbleBarBubble
Extracts the flyout message from the bundle and stores it in
BubbleBarBubble.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: builds successfully -- code is not wired up yet
Change-Id: I5e810290991b4ee638f43add4d6a6514edb167af
2024-10-07 16:57:08 -04:00
Bill Yi b485d4f2ce Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I2575d05bf399281cc1f6ab5a81bb7646d1410f03
2024-10-07 13:39:26 -07:00
Treehugger Robot 84f7220dd5 Merge "Add Recents Window logs to ProtoLog" into main 2024-10-07 19:31:06 +00:00
Tony Wickham fc267fbd69 Merge "Don't invalidate swipe handler until parallel anim finishes" into main 2024-10-07 19:17:03 +00:00
Liran Binyamin 9b093db2f8 Merge "Rename bubble bar flyout fields" into main 2024-10-07 18:27:14 +00:00
Fengjiang Li e79a786b3b Merge "[Dagger] Make WellbeingModel provided by DaggerSingletonObject" into main 2024-10-07 17:34:43 +00:00
mpodolian 3dcb19f33a Fixed the hotseat placement in RTL mode
Updated logic that computest the hotseat shift.

Fixes: 372014534
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual. Put device into 3 buttons navigation mode, force RTL.
Hotseat is placed next to the navigation buttons bar.

Change-Id: Ie7b6be11a093ffa4006182bdc0b73018ba799246
2024-10-07 10:34:42 -07:00
Schneider Victor-Tulias f3f182a7ef Add Recents Window logs to ProtoLog
Flag: com.android.launcher3.enable_recents_window_proto_log
Bug: 292269949
Test: checked protologs in winscope
Change-Id: Iaafe58a655e9ad7293b579c74b7e7ecaa2df1ea5
2024-10-07 17:14:24 +00:00
Tony Wickham ee98cd4bdf Don't invalidate swipe handler until parallel anim finishes
- When invalidateHandler() is called, it calls endRunningWindowAnim()
  which includes mParallelRunningAnim. This causes a jump if
  mParallelRunningAnim was not already finished, so we now wait to
  invalidate the handler after mParallelRunningAnim ends.

Flag: EXEMPT bugfix
Test: AbsSwipeUpHandlerTestCase (added two tests for this)
Fixes: 370208192
Change-Id: I37ed281a993b1d2fa3634754378314511f3295f0
2024-10-07 16:45:19 +00:00
Orhan Uysal c2adf8cf9c Use desktop API to remove desktop for dismiss
When overview tile for desktop is dismissed, use the shell API instead
of calling the system server directly to remove tasks in the desktop.
This let's desktop fix it's state and call the system server instead.

Bug: 370757235
Test: m and dismiss overview tile from desktop
Flag: com.android.window.flags.enable_desktop_windowing_back_navigation

Change-Id: Ia2abd0ab5a27759c92e0328beb460810ad2af898
2024-10-07 16:39:54 +00:00
Liran Binyamin f44690bd69 Merge "Pass bubble flyout from wm shell to launcher" into main 2024-10-07 16:22:13 +00:00
Ats Jenk df819b6145 Merge changes Iccb870b0,Ibea2dbe0 into main
* changes:
  Inject bubble controllers directly
  Allow injecting bubble controllers in taskbar test
2024-10-07 16:12:41 +00:00
Liran Binyamin 75675e123d Rename bubble bar flyout fields
Long term we'd like to use bubbles for any app, so this change
uses more general names instead of the chat-specific naming

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: built and tested on a device
Change-Id: Idec2aa7d9a8df5df0df49231e8871298084f8aa1
2024-10-07 10:37:55 -04:00
Fengjiang Li 9a949ff4ca [Dagger] Make WellbeingModel provided by DaggerSingletonObject
Test: presubmit
Bug: 361850561
Flag: NONE - dagger
Change-Id: Ie23411457185ab31380f3b0efb660e7dd9d73f29
2024-10-06 00:40:51 -07:00
Sunny Goyal 95045ce03a Fixing test flakiness in Launcher initialization
Using same key for blob store and content provider based layouts

Using a single key for layout provider. This ensures that if one
test doesn't cleanup properly, any followup test which relies on
model initialization overrides the key appropriately

Bug: 370080120
Test: Presubmit
Flag: EXEMPT bugfix
Change-Id: Idef0a89a5d1ec89e24aae8a4549fd122634dad2f
2024-10-04 20:52:17 +00:00
Mykola Podolian 409b62cb33 Merge "3 button nav is laid out correctly." into main 2024-10-04 20:01:58 +00:00
Schneider Victor-tulias f36e9414b1 Merge "Add a AbsSwipeUpHandlerTestCase for the RecentsWindowSwipeHandler" into main 2024-10-04 19:53:01 +00:00
Vinay Joglekar b0354e7be9 Merge "Fix a bug where the running task would be drawn below recents task" into main 2024-10-04 18:25:58 +00:00