When the live tile is the adjacent app to be launched, it will wrongly update the pivot and translate all the tasks to the side, resulting in a broken animation.
This bug was introduced in ag/29639296, while fixing the launch of the the adjacent task while the live tile was in the center of the screen. To solve this excessive translation, we need to update pivot only when adjacent task is not a live tile.
Bug: 361744056
Change-Id: I56cbabcc351b0becd791b58dd94f65cd0b533bc2
Test: Launch central/side large tile with different live tile combinations
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
This was causing the focused task shift to be calculated incorrectly, which was resulting in the focused task being shifted too far to the left.
Bug: 330342294
Fix: 371490320
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: Manual. Open 1 DesktopTask, 1 FocusedTask, 2 other tasks in the grid. Dismiss the focused task. The rebalance should work keeping the new focused task next to desktop task.
Change-Id: If6f95814942c2cbadc30a0082649569f21dea60a
This CL also fixes : Home -> Recents -> Recents opens the last large tile (Which was broken when there is desktop window tile in recents.)
Test: Manual
BUG: 365756337
Fix: 365756337
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: I0b8fe3a0a7074355f14ced23ae282fe2943d8ce9
Updated logic of laying out the 3 nav buttons container. Also updated
placement of the hotseat, so it is not shifted on the phone.
Test: Manual. Fold and unfold felix with and without bubbles. Reboot
the devices and perform the same test.
Fixes: 370773620
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I7d5ba51f7ded275f7456a8690d04001b9651f6c5
Similar to taskbar, animate the alpha for bubble bar when notification
shade is expanded.
Bug: 345687278
Test: have bubbles on home screen, swipe down notification shade,
bubbles are hidden with an animation
Test: have bubbles in app, stashed, swipe down notification shade,
no change
Test: have bubbles in app, unstashed, swipe down notification shade,
bubbles hidden with an animation
Test: receive bubble notification while shade is open, check that
bubble bar is not shown
Test: compare bubble bar shadow and stroke before and after change
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I74af6a7230f81628540f9b935cbe7dc801bd7a01
Update bubble bar visibility when it is stashed.
Ensures that if alpha is updated, it won't show up.
Bug: 345687278
Test: TransientBubbleStashController
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I603a67a824a5cee0fb35de7c3f2dc98d9d2323ed
Update TaskbarUnitTestRule @InjectController annotation to support
injecting bubble controllers.
Bubble controllers are optional and only initialized if the feature flag
is enabled.
Add a test to check that bubble controllers are only initialized when
the flag is on.
Bug: 371017282
Test: TaskbarUnitTestRuleTest
Flag: TEST_ONLY
Change-Id: Ibea2dbe0db854d530ef93ac53204a361572fa5b2
Apparently, it doesn't log when it fails due to some reason.
In 369422714, we see it being started but the appwidget's config
activity not being launched. The absorbed exception makes it harder to
know. There isn't a system log as well.
At least looking at logs, we think for some reason appwidget's
configuration activity wasn't launched by launcher.
Bug: 369422714
Test: N/A logging
Flag: EXEMPT BUGFIX
Change-Id: I56294ef37d7ddceb61c4e6d0e10d0f24fde42cb2
When the device is rotated, everything gets recreated, in this case,
bubble bar state is typically set to be stashed. However, if taskbar
and bubble bar were unstashed while rotating, bubble bar would be
incorrectly stashed. To fix this, only do the stash if taskbar is
also stashed in this case.
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual - be in an app, unstash bubbles, rotate device
=> observe that bubble bar is unstashed like taskbar
after rotation
Bug: 353884121
Change-Id: Ia37397c62a1a6819c1bd42261f8a9955db511da3
Alpha was applied to fill paint only. Add it to stroke paint as well.
Introduce a new method in Utilities to map range of ints and not only
floats.
Bug: 345687278
Test: compare bubble bar shadow and stroke before and after change
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I7c9e8d6337a857a661de0c945181cdd5ef2fd4ca
Fixes issues with desktop split caused by the instructions view not
being present. Makes desktop split select more uniform with other split select transitions.
Fix: 369961040
Fix: 370038890
Test: Manual
Flag: EXEMPT bug fix
Change-Id: Icfc6228f3e2692fda59ce5ab7c847ebe5314b25e
- There are multiple signals that come just after FLAG_DEVICE_LOCKED
is removed, and those should still be considered part of the unlock
transition. We already did this for TaskbarStashController so I copied
it to TaskbarLauncherStateController.
- Also animate when changing SYSUI_STATE_OVERVIEW_DISABLED, since this
happens when the device is locked/unlocked and changes the visibility
of TaskbarView icons.
Test: manually unlock over both home screen and in-app, verify clean
transition without jump (e.g. Hotseat is immediately visible as part of
Workspace, and Taskbar fades in during unlock to an app)
Flag: EXEMPT bug fix
Fixes: 364586744
Change-Id: If0497fcc17bb0ec44294c4ea1163104b4d8be459
Flag: com.android.wm.shell.enable_bubble_bar
Test: atest NexusLauncherTests:PersistentBubbleStashControllerTest
Test: atest NexusLauncherTests:TransientBubbleStashControllerTest
Test: manual - swipe up to overview from home & from in an app, ensure
bubble bar is unstashed
- switch between home / overview / in app in transient
and persistent taskbar to make sure things work
Bug: 368364143
Change-Id: I34c22b000d1fcc75489ea6da497f14def9649a20
There was a small typo that resulted in the wrong measurement being returned for the remaining TaskView. This CL fixes it.
Fixes: 365476600
Test: Manual
Flag: NONE bugfix
Change-Id: I1abf993abcaa8d06e5475f31c0322017f6e96e6f
Animate the elevation of the flyout along with the expansion animation.
Also start revealing the triangle as soon as we're past the bubble bar.
Flag: com.android.wm.shell.enable_bubble_bar
Bug: 277815200
Test: atest BubbleBarFlyoutViewScreenshotTest
Test: atest BubbleBarFlyoutControllerTest
Change-Id: Ie7e27240ae3ab86f8e7c3f39aa1c80885cfdc98e
This CL uses the same logic used for handheld dissmiss translation to fix the following cases when large tile is enabled for desktop task:
- When the LAST focused task is dismissed (i.e., no other task in the grid), translate all large tiles from the right side to the left, to occupy the dismissed focused task position.
- When Desktop Task is dismissed, translate focused task and grid from the left to the right side to occupy the dismissed desktop task position.
- When 2 tasks are visible in recents (i.e., 1 focused task, 1 desktop task) and the user dismisses the desktop task while in Clear All Button page (page 2), the focused task translates when no translation should be done, due to snapping to ClearAllButton page on Tablet. To fix this we introduced a logic in getOffsetToDismissedTask to use the previous page for the calculation when the grid snaps to Clear All Button page.
Bug: 353948136
Fix: 353948182
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Test: OverviewDesktopTaskImageTest
Change-Id: If8b06410c26a8f817d84ec6a635a66b2941e3ae9
- There's an edge case when there are only 2 grid tasks, mNextPage will still be on the grid tasks when they're not fully visible, so the new isAnySmallTaskFullyVisible check can't kick in. This only happens when grid tasks are barely out of screen.
Fix: 370733696
Test: Scroll betwene large tiles, it should always snap after scrolling
Test: Scroll from focus task to grid task, it should only snap if grid tasks aren't fully visible
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: I3b0a80ceffb1caae57aa53b1c949c5e51336231a
- When launching large tiles, we zoom in RecentsView into the task we're launching, override pivot of RecentsView in the process
- This pivot override to be applied to TaskViewSimulator if a live tile is on screen, to avoid live tile animating to wrong position
- Also ensure the live tile draws above RecentsView, to avoid wallpaper blur from applying on the live tile
Fix: 361744056
Test: Launch central/side large tile with different live tile combinations
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: I804edb988fb157d939dba34bc596c8b43aac8a45
As part of the Connected Display project, some UI features in
Launcher such as Alt-Tab need to be shown only on the focused
display.
This change adds FocusState, which registers to WMShell, and
provides a listener to other components in Launcher so they can
easily consume the display focus state (following the same pattern
of HomeVisibilityState).
Bug: 356109871
Flag: com.android.window.flags.enable_display_focus_in_shell_transitions
Test: Switching focus between displays and confirm signals are sent to Launcher.
Change-Id: I51d51ac0ce3e24afa363607cdfb41728748a4a5f
Matt Sziklay
Schneider Victor-Tulias
Vinay Joglekar
Treehugger Robot
Jordan Silva
mpodolian
Ats Jenk
Mady Mellor
Orhan Uysal
Shamali Patwa
Fengjiang Li
Liran Binyamin
Bill Yi
Uwais Ashraf
Kevin Lim
Tony Wickham
Jeremy Sim
Jagrut Desai
Alex Chau
Kazuki Takise