Commit Graph

20478 Commits

Author SHA1 Message Date
thiruram c6a38ba5d8 Replaces StatsLogManager.log with StatsLogManager.logger()
Bug: 159170445
Change-Id: Ice6c8a9ae30d8e6b3843bfe42926053849bf9fe0
2020-06-17 17:32:54 +00:00
TreeHugger Robot 4de12a2424 Merge "Fixing OAV buttons not working and removing logs." into ub-launcher3-rvc-dev 2020-06-17 17:26:14 +00:00
thiruram 9f66df6b7f Replace StatsLogManager with builder pattern. am: d8405a63d2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11885456

Change-Id: I0a715a3010a4ad9f896e368d61a4f114902f1429
2020-06-17 17:20:54 +00:00
vadimt d8e5660b13 Fixing broken tests on 2 and 3 button devices.
Bug: 143488140
Change-Id: I30886da129825b800984baa08742ac4dfcf4a599
2020-06-17 10:19:51 -07:00
thiruram d8405a63d2 Replace StatsLogManager with builder pattern.
Follow up CLs will remove the deprecating log methods and update their references.

Bug: 159170445
Change-Id: I5dfd30209eeba561df1b528a6305ca5923ba42a2
2020-06-17 08:46:43 -07:00
Bill Lin f69563e935 Revert "Update state and touch region after one handed overlay changed"
This reverts commit a66dafe617.

Reason for revert: b/159183864 introduce com.android.launcher3.memory.MemoryTests failed after this CL merged.

Due to I need more time to investigate the root cause and do not block MemoryTests, revert this CL temporary. 

Change-Id: I0408123e36c55a262ee0f1080cd6612785b3f527
2020-06-17 11:21:24 +00:00
Vinit Nayak 8401308c14 Don't rely on nav mode change listener for oriented state
When nav mode state changes, launcher gets
re-instantiated, which means the listener for
nav mode changes often gets destroyed before it
even gets fired. Rely on the initial setup to
set the correct nav mode.

The other bug with relying
on the initial value was that we were initially
getting the old nav mode when initFlags was called
from the ctor, but then the correct updated nav
mode when called from initListeners(). The first
call would enable rotation but then the second
call wasn't disabling it. Now we toggled based on
nav mode each time.

Another bug fix in RecentsView was not calling
update when launcher rotation is enabled. That was
added when previously we were using HOME_ROTATED
and PORTRAIT as different PagedViewHandlers to
differentiate when launcher rotation was enabled.
HOME_ROTATED is now removed, so we no longer need
to change the internal state of RecentsOrientedState.

Fixes: 159176222
Change-Id: I2a37880ce3cf835ca5b9b165ce3840537facee6c
2020-06-16 19:41:16 -07:00
TreeHugger Robot e328ff79f4 Merge "[Overview Actions] Disable swiping on modal recentsView for talkback." into ub-launcher3-rvc-dev am: cbe1251ce7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11886213

Change-Id: I99c3ff2a23f9ade5b37fa51d8c98954bb19466af
2020-06-16 23:33:50 +00:00
TreeHugger Robot 139b7fc9f2 Merge "Increase Predicted app icon sing size" into ub-launcher3-rvc-dev am: ded59ac331
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11885882

Change-Id: Ia707467c3d80c0ae9ea414ec42f84e343e1389df
2020-06-16 23:33:43 +00:00
Samuel Fufa e8c0f83fb2 Avoid Crash when longpressing disabled predicted item
If a view does not handle its long press and return true, View.java calls getParent().showContextMenuForChild(this). However, in Hybrid hotseat case, predicted icons are removed from the hotseat when user long presses an icon. This will result in getParent() returning null.

Bug: 159064799
Change-Id: I80d8f27cbc20b94b0381e767584a1f6854d17e2c
2020-06-16 16:28:37 -07:00
TreeHugger Robot cbe1251ce7 Merge "[Overview Actions] Disable swiping on modal recentsView for talkback." into ub-launcher3-rvc-dev 2020-06-16 23:23:12 +00:00
TreeHugger Robot ded59ac331 Merge "Increase Predicted app icon sing size" into ub-launcher3-rvc-dev 2020-06-16 23:18:45 +00:00
Becky Qiu 8798440600 [Overview Actions] Disable swiping on modal recentsView for talkback.
When it is select mode, disabling swiping on the parent container for a11y to avoid exiting select mode UI.
This will only disable swiping and talkback on other tasks and the cleanall button, but will keep the modal task container app info and content description, also keep the action buttons description working.

Test: local
Bug: 155947513
Change-Id: I6d513c7eb3e7deeaa233550749f8be0d95e56daf
2020-06-16 15:47:20 -07:00
Tony Wickham b22770d18f Merge "Fix qsb when flinging to home during gesture to overview from home" into ub-launcher3-rvc-dev am: f2b8c927a9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11873446

Change-Id: Id5ea73f5285e8d3feac9d73588ee3241eafbe1ae
2020-06-16 22:27:35 +00:00
TreeHugger Robot 86b52bab05 Merge "Create hotseat predictor onCreate" into ub-launcher3-rvc-dev am: 89e39a6dfa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11885442

Change-Id: I2eff9e2abff2530f4f5934d95f9eff2d38297aab
2020-06-16 22:27:25 +00:00
Tony Wickham f2b8c927a9 Merge "Fix qsb when flinging to home during gesture to overview from home" into ub-launcher3-rvc-dev 2020-06-16 22:12:28 +00:00
TreeHugger Robot 89e39a6dfa Merge "Create hotseat predictor onCreate" into ub-launcher3-rvc-dev 2020-06-16 22:11:56 +00:00
Samuel Fufa eb957403a8 Increase Predicted app icon sing size
Bug: 159041772
Change-Id: I0b71c6a2b2da9e4b058554e60cf0c59d242368c6
2020-06-16 14:34:36 -07:00
Samuel Fufa 345f728f2c Create hotseat predictor onCreate
ModelTask posted in setupViews does not get called.
Bug: 159151258

Change-Id: I45bfe7cf8ea18b09faaf3c0e612be90722e1e410
2020-06-16 14:22:02 -07:00
TreeHugger Robot a336cbe4f5 Merge "Attempt to workaround a leak on Taimen" into ub-launcher3-rvc-dev am: 9354de6c91
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11885441

Change-Id: I0455fa144bc241483f1d38a7c6b169e3e0e9b313
2020-06-16 21:11:36 +00:00
TreeHugger Robot 9354de6c91 Merge "Attempt to workaround a leak on Taimen" into ub-launcher3-rvc-dev 2020-06-16 20:58:39 +00:00
Miranda Kephart efdc4e2318 Merging from ub-launcher3-rvc-dev @ build 6595814
Bug:150504032
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-rvc-dev_rvc-dev_6595814.html

Change-Id: I4be85d0e52cc3cb8801012a7313a269851680c8b
2020-06-16 20:52:28 +00:00
vadimt 6a3de331af Attempt to workaround a leak on Taimen
It's a flake.
It was likely caused by enabling fallback tests, and we don't know
what's leaked and why.

Bug: 143488140
Change-Id: I0d0c88ac9b0de316861f16ba023a596c1f39cde4
2020-06-16 20:21:49 +00:00
Sreyas 826bb2e932 Fixing OAV buttons not working and removing logs.
Bug: 154838868
Change-Id: Icde83dc527a1aacf6a8a79325e6a33c5235a64fb
2020-06-16 12:20:25 -07:00
TreeHugger Robot 80f0dc6fed Merge "Fixing sysui scrim not updating in landscape UI" into ub-launcher3-rvc-dev am: cf4e6cd055
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11872996

Change-Id: I535bdfc4dfb5b6e57b611318c8ef9671fd656f0e
2020-06-16 19:14:03 +00:00
TreeHugger Robot cf4e6cd055 Merge "Fixing sysui scrim not updating in landscape UI" into ub-launcher3-rvc-dev 2020-06-16 19:00:24 +00:00
Vinit Nayak 746b82e831 Updated recents oriented state on split screen
Launcher defaults to sensor rotation when in split
screen instead of the fixed portrait orientation.
We were setting the multi window flag but never
updating RecentsOrientedState's internal state to
reflect it.

Fixes: 158537350
Change-Id: Ib0e1cf4c2e0674a5af41ac11c532a50db0a6f0fa
2020-06-16 11:57:47 -07:00
TreeHugger Robot 1dafdfb572 Merge "Preventing parallel motion event dispatching from view system and event proxy" into ub-launcher3-rvc-dev am: a36605ee90
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11855094

Change-Id: I737466c21e1baad37d83f0b35783baca295a6e4a
2020-06-16 18:36:50 +00:00
TreeHugger Robot a36605ee90 Merge "Preventing parallel motion event dispatching from view system and event proxy" into ub-launcher3-rvc-dev 2020-06-16 18:20:51 +00:00
Bill Lin a66dafe617 Update state and touch region after one handed overlay changed
The matrix for overall modes x state changes:
-----------------------------------------------------
   Mode     |      State changed     | *Before|*After
-----------------------------------------------------
  OneHanded |  Portrait->Landscape   |  80dp  |  32dp
  OneHanded |  Landscape->Portrait   |  32dp  |  80dp
-----------------------------------------------------
  OneHanded |  Disable->Enable       |  32dp  |  32dp
 (Landscape)|  Enable->Disable       |  32dp  |  32dp
-----------------------------------------------------
  OneHanded |  Disable->Enable       |  32dp  |  80dp
 (Portrait) |  Enable->Disable       |  80dp  |  32dp
-----------------------------------------------------
  NO_BUTTON |  Portrait->Landscape   |  32dp  |  32dp
  NO_BUTTON |  Landscape->Portrait   |  32dp  |  32dp
  2 BUTTON  |  Portrait->Landscape   |  48dp  |  48dp
  2 BUTTON  |  Landscape->Portrait   |  48dp  |  48dp
  3 BUTTON  |  Portrait->Landscape   |  48dp  |  48dp
  3 BUTTON  |  Landscape->Portrait   |  48dp  |  48dp
-----------------------------------------------------
* dimen : navigation_bar_gesture_height

Test: adb bugrepot | grep mOneHandedModeRegion
Test: manually triger one handed
Test: atest WindowInsetsBehaviorTests
Bug: 157958539

Change-Id: I0f4b5d18053058730a06c3c216e849850c0390f4
2020-06-16 14:11:21 +08:00
Samuel Fufa 523c18d273 Merge "[WW logging] Log rankings for app launches" into ub-launcher3-rvc-dev am: dc122e816a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11863507

Change-Id: Ic9a5da21bd2900d0dc7348cbdb997e6f876df971
2020-06-16 04:49:34 +00:00
Samuel Fufa dc122e816a Merge "[WW logging] Log rankings for app launches" into ub-launcher3-rvc-dev 2020-06-16 04:41:54 +00:00
Tony Wickham 80846543b5 Fix qsb when flinging to home during gesture to overview from home
- AllAppsTransitionController should not animate alphas for atomic
  components even when failing fast (we already had this check for
  the normal flow where mProgress != targetProgress).
- Don't set state to NORMAL until both the workspace stagger anim
  and overview peek anim are finished

Test: swipe up and hold from the nav bar on the home screen, then,
without lifting finger, fling upwards to return home; ensure qsb
springs in staggered formation with rest of workspace, and alpha
matches accordingly

Bug: 154637581
Change-Id: Iafeaeac50ee8bce05492628d443c3ca4ab3d26df
2020-06-15 19:27:45 -05:00
Samuel Fufa e9c4f401bd [WW logging] Log rankings for app launches
Bug: 158219113
Change-Id: Ib6db4e73e48ff27ca9d3a5348eea42e1f534dba1
2020-06-15 17:17:47 -07:00
TreeHugger Robot 870764d506 Merge "Add null check before applying fullscreen params" into ub-launcher3-rvc-dev am: eb9f60adab
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11873472

Change-Id: I6d02dc367338c96cf041387889d3b5949430ac60
2020-06-15 22:44:54 +00:00
TreeHugger Robot 6cfcd406d0 Merge "fix a11y issue where scroll next can still be triggered on final page in RecentsView" into ub-launcher3-rvc-dev am: 4dc44cb405
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11873216

Change-Id: Iea4f9f153302ccdf8ea2fc5769303b40dfb24a6f
2020-06-15 22:44:42 +00:00
TreeHugger Robot eb9f60adab Merge "Add null check before applying fullscreen params" into ub-launcher3-rvc-dev 2020-06-15 22:37:26 +00:00
Pinyao Ting 817054d000 fix a11y issue where scroll next can still be triggered on final page in
RecentsView

Bug: 151450844
Test: manual verification with following steps
1. launch a few apps
2. swipe up from bottom to bring up RecentsView
3. enable talkback
4. perform a scroll next a11y gesture (without lifting finger, swipe
right then left)
5. verify nothing happens (as opposed to pushing the page back a little)

Change-Id: I6dea2559592bdaa7227a2e12ce0565d6d7b7f4a1
2020-06-15 14:51:04 -07:00
Tony Wickham f1a8f47a4a Add null check before applying fullscreen params
Bug: 159026796
Change-Id: I5c1a0ca26c8e4a187e2217870b27289ecf18238e
2020-06-15 16:41:50 -05:00
TreeHugger Robot 9e0dcab1b1 Merge "Don't set mLikelyToStartNewTask=true before slop for first gesture" into ub-launcher3-rvc-dev am: 946696124a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11855486

Change-Id: I0fd87abb4465f988414d0db3713c7bb189a0a810
2020-06-15 20:46:02 +00:00
Sunny Goyal 8cd8d15886 Fixing sysui scrim not updating in landscape UI
Bug: 156422012
Change-Id: I2e1e9149e8337dd663bf564bd1b7f661ec2864e9
2020-06-15 13:42:07 -07:00
TreeHugger Robot 946696124a Merge "Don't set mLikelyToStartNewTask=true before slop for first gesture" into ub-launcher3-rvc-dev 2020-06-15 20:24:51 +00:00
Tony Wickham f3cd3762c9 Don't set mLikelyToStartNewTask=true before slop for first gesture
We should only set it to true before the slop when continuing the
gesture, otherwise gestures to home could attach the adjacent
task view before the transition even starts.

Bug: 158855957
Change-Id: I86eba9bad9c85e05d5274d7396160762a28e5cf1
2020-06-15 14:09:14 -05:00
Tony Wickham 9459f3101f Don't reset RecentsView in onIdpChanged()
Resetting unloads visible task data and thus will leave recents
blank if overview state is enabled. Instead, unload and reload
visible task data to take new icon shape into account.

(The reason we're getting onIdpChanged() on nav bar mode change
is because the change in nav bar height causes the computed icon
size to change very slightly.)

Also fix InvariantDeviceProfile copy constructor by copying
iconBitmapSize.

Test:
- Change between 0 button and 3 button nav modes, verify recents
  doesn't appear blank
- Change icon shape in Styles and Wallpapers and go to recents,
  verify icon shape is reflected in task icons

Bug: 156354328
Change-Id: Ife29f51e85814ff483d055005fa2645135d5ec3d
2020-06-15 14:02:12 -05:00
Sunny Goyal b10e865e48 Preventing parallel motion event dispatching from view system and event proxy
1) When view system is already dispatching an event, proxy-dispatch is restricted
   to gesture only and follow the gesture dispatching rule.
2) If a full-proxy-dispatch is going on, and view-dispatch comes in, view-dispatch
   takes over and proxy-dispatch is cancelled.
3) During gesture-only proxy dispatch, if view-dispatch already started a gesture,
   proxy dispatch is ignored. Otherwise view-dispatch is restricted to non-gesture
   dispatching only (and proxy-dispatch is already restricted to gesture only).

Bug: 158130948
Change-Id: Ied351663e16beda5acf49a52bdefea881c18b9cf
2020-06-15 11:50:54 -07:00
TreeHugger Robot c7cfadbfab Merge "[race condition] Improve hotseat availability when launcher is recreated" into ub-launcher3-rvc-dev am: 832aa03a4b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11855093

Change-Id: I0073105aea8e37f0bb01efc2472c47f1ec55d883
2020-06-15 18:21:53 +00:00
TreeHugger Robot 05bc926cae Merge "Gates blur code behind BlurUtils#supportsBlursOnWindows." into ub-launcher3-rvc-dev am: 8555146d9a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11812122

Change-Id: I81f464584141ad192e95cc33f6e7f51da59d45d7
2020-06-15 18:21:21 +00:00
TreeHugger Robot cba652e143 Merge "Remove a comment that a line of code is a workaround" into ub-launcher3-rvc-dev am: 72cf3d31a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11870186

Change-Id: I9ae8121b6c562990b0b3e10e25f0b2eca74d3916
2020-06-15 18:20:50 +00:00
TreeHugger Robot 832aa03a4b Merge "[race condition] Improve hotseat availability when launcher is recreated" into ub-launcher3-rvc-dev 2020-06-15 18:16:59 +00:00
TreeHugger Robot 8555146d9a Merge "Gates blur code behind BlurUtils#supportsBlursOnWindows." into ub-launcher3-rvc-dev 2020-06-15 18:14:01 +00:00