Commit Graph

20478 Commits

Author SHA1 Message Date
TreeHugger Robot b22655f8e1 Merge "Revert "Allow shortcut predictions in hybrid hotseat"" into ub-launcher3-rvc-dev 2020-06-21 07:24:25 +00:00
Winson Chung f1535b13f3 Merge "Tweak quickswitch thresholds" into ub-launcher3-rvc-dev am: c46daa9572
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11917532

Change-Id: I5fec4454c7d13e447a2ef9670fc8b429e13fc29c
2020-06-21 04:18:29 +00:00
Winson Chung c46daa9572 Merge "Tweak quickswitch thresholds" into ub-launcher3-rvc-dev 2020-06-21 04:08:09 +00:00
Winson Chung 4941f65d52 Tweak quickswitch thresholds
- Reduce slop for gestural mode (and apply multiplier to slop
  at checktime)
- When quickswitch threshold is passed, reduce the total movement
  check and reduce the velocity needed to fling to the next page
  to accommodate short swipes
- Use touch slop to determine scrolling in paged view, and only
  use paging slop to determine flinging to the next page (when
  easy flings are disabled (which is the default))

Bug: 157165240
Test: Ensure the flings in normal overview/paged views don't change,
      check short flings from quickswitching
Change-Id: Idd04ce23f53c06759e84ac8ad73cf2cc6dff6975
2020-06-20 19:41:32 -07:00
TreeHugger Robot 7f8a892300 Merge "Deleting old cache images before saving new ones." into ub-launcher3-rvc-dev am: 5ec76de182
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11934850

Change-Id: I422c02a268a274b5f5035492d93aa4319c2b4d0a
2020-06-20 20:29:33 +00:00
TreeHugger Robot 5ec76de182 Merge "Deleting old cache images before saving new ones." into ub-launcher3-rvc-dev 2020-06-20 20:19:01 +00:00
Tony Wickham 61fa23ab3a Don't reset GestureState when touching outside of swipe region
We were setting mGestureState = DEFAULT_STATE when touching outside
of the swipe region. Instead, we should only set mGestureState when
starting a new gesture, and only set it to DEFAULT_STATE on reset.

This also makes it clearer that mGestureState always refers to the
current gesture state, rather than sometimes being the current
gesture and sometimes being the previous gesture depending on
where it was used. Now previousGestureState is passed when needed.

Bug: 159494933
Change-Id: Ib62278b7c591ca4c6b99b26e058a34772e6cec2a
2020-06-20 12:04:12 -05:00
Samuel Fufa 857c512987 Revert "Allow shortcut predictions in hybrid hotseat"
This reverts commit 2d8e882d2e.

Reason for revert: Moving this to master. 

Change-Id: I46cfbda92d74a1f9fa9f0c091811941fe74ce76b
2020-06-20 16:53:51 +00:00
Hyunyoung Song 33b5ea1555 Merge "Remove ConcurrentModificationException for snapshot logging Bug: 159282737" into ub-launcher3-rvc-dev am: ac3f71269e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11929252

Change-Id: Id2f4416a7bddb16abace23be506ba50e9c7ab85c
2020-06-20 06:29:06 +00:00
TreeHugger Robot 048740e492 Merge "Workaround for activity manager crashing when trying to start an app It flakes when one of the tests starts calculator while there zero activities in the system." into ub-launcher3-rvc-dev am: d4b946dbe3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11940019

Change-Id: I7a217db5fb87d8099cdb9c21d4fab5d5e3dc26e7
2020-06-20 06:28:59 +00:00
Hyunyoung Song ac3f71269e Merge "Remove ConcurrentModificationException for snapshot logging Bug: 159282737" into ub-launcher3-rvc-dev 2020-06-20 06:27:01 +00:00
TreeHugger Robot d4b946dbe3 Merge "Workaround for activity manager crashing when trying to start an app It flakes when one of the tests starts calculator while there zero activities in the system." into ub-launcher3-rvc-dev 2020-06-20 06:13:48 +00:00
Samuel Fufa d5ffdd057c Merge "Allow shortcut predictions in hybrid hotseat" into ub-launcher3-rvc-dev am: 9024c85742
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11940156

Change-Id: I9257b6aca9b1b496bb074c0cf8398087c24abdbb
2020-06-20 05:07:54 +00:00
Samuel Fufa 9024c85742 Merge "Allow shortcut predictions in hybrid hotseat" into ub-launcher3-rvc-dev 2020-06-20 04:57:02 +00:00
Samuel Fufa 2d8e882d2e Allow shortcut predictions in hybrid hotseat
Screenshot: https://screenshot.googleplex.com/TckWKGYWwHW

Note: Shortcut predictions will not be cached.

Bug: 159500320
Test: Manual
Change-Id: Id8ec81544bddb8be87a5e748fd9f9e93aaaf8fea
2020-06-19 18:50:22 -07:00
vadimt 8914c51660 Workaround for activity manager crashing when trying to start an app
It flakes when one of the tests starts calculator while there zero
activities in the system.

Bug: 143488140
Change-Id: Id9d350f0de8a83eb50e35e9efa4226b8d45ca641
2020-06-20 01:12:50 +00:00
thiruram 7fa1c8a25d Fixes folder logging. am: b53764bd4b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11902346

Change-Id: Ib9b34794311a41e0b54c19d1c0097f6d36680917
2020-06-20 00:56:17 +00:00
Sreyas ae74a618bd Deleting old cache images before saving new ones.
Change-Id: I5947fe43b0e1bfac35247bf64f08e49560d58cac
2020-06-19 17:28:19 -07:00
thiruram b53764bd4b Fixes folder logging.
Only LAUNCHER_FOLDER_LABEL_UPDATED events will have FromState, ToState
and FolderLabelInfo. Other folder events such as OPEN, DRAG etc will have
basic fields only populated.

Sample Log: https://paste.googleplex.com/5468394805526528
Screencast: http://rcll/hSUQjtQXfQM5i9DjjAQTf2/Zn5FeiVDONaQj0mK1JNjg

Bug: 159164315
Change-Id: I903fc7b62bcee748aa3ef695453be3e14d388712
2020-06-19 17:06:46 -07:00
TreeHugger Robot 38126202d8 Merge "Fix RecentsView scroll linking" into ub-launcher3-rvc-dev am: 72ac78189f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11936452

Change-Id: I5f9e7ef48d82c8ecd4f496e8b7c960b7dd232f56
2020-06-19 23:37:45 +00:00
TreeHugger Robot 108c7b65ed Merge "Fixing fallback recents not getting proper insets on configuration change" into ub-launcher3-rvc-dev am: f9ae1a838a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11934077

Change-Id: I11c0b6c85c66551b9a425eb0d9ce232e6a720392
2020-06-19 23:37:39 +00:00
Jon Miranda 36d1015997 Add depth animation when multiwindow mode changes.
This is a workaround until we can support app transitions when starting
an activity in mw mode.

Bug: 158613217
Change-Id: I843d6669722c543728ab532e1c4fbd4643f6f135
2020-06-19 16:36:57 -07:00
TreeHugger Robot 72ac78189f Merge "Fix RecentsView scroll linking" into ub-launcher3-rvc-dev 2020-06-19 23:28:55 +00:00
TreeHugger Robot f9ae1a838a Merge "Fixing fallback recents not getting proper insets on configuration change" into ub-launcher3-rvc-dev 2020-06-19 23:22:54 +00:00
Hyunyoung Song 5eae3c0a0a Remove ConcurrentModificationException for snapshot logging
Bug: 159282737

Change-Id: I37edcf6aa11272b488a0633716567c48e56e5433
2020-06-19 16:12:43 -07:00
Tony Wickham 94d1b4be17 Fix RecentsView scroll linking
- Reverts change from ag/11900651 that deferred setting
  mRecentsViewScrollLinked = true
- Instead, setCurrentPage(mCurrentPage) after updating layout rotation
  to ensure we recompute page scrolls before using them

Test:
- Auto rotate on, home rotation off, open Calculator in landscape,
  swipe up slowly and ensure it never turns invisible
- Quick switch from Calculator to Clock, start swiping directly up
  immediately after settling on Clock, ensure Calculator window
  remains at its scroll position to the side (b/159461591)

Fixes: 159461591
Change-Id: Iab92963cc6c33df42b77f5ccfa3932382e8f869a
2020-06-19 17:42:18 -05:00
Samuel Fufa 56b35b9d0a Send app launch events from TaskSwitcher
Sends AppTargetEvent with action launch and container CONTAINER_OVERVIEW to AppPredictor when user launches app form recents.

Bug: 155996363
Test: Manual
Change-Id: I3eb38f5737ecaeb07e59db460e8d809416132825
2020-06-19 14:14:52 -07:00
Tony Wickham fb8d090c68 Merge "Remove progress != mFullscreenProgress optimization" into ub-launcher3-rvc-dev am: e19b065c7c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11932417

Change-Id: I41422ebccc64c9178f33598f609da228db6515dd
2020-06-19 18:54:23 +00:00
Zak Cohen 1f3a4b6530 Image actions - fix uri permissions. am: aef8b86b4a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11933718

Change-Id: I6ca5eff182795fe4c60032da5539d9d6d0428b21
2020-06-19 18:54:12 +00:00
Tony Wickham e19b065c7c Merge "Remove progress != mFullscreenProgress optimization" into ub-launcher3-rvc-dev 2020-06-19 18:45:44 +00:00
Sunny Goyal 9d89f75ce4 Fixing fallback recents not getting proper insets on configuration change
> Using common code for Launcher and recents for insets dispatching
> Fixing recents auto closing when there is no running task

Bug: 158750568
Bug: 159133601
Change-Id: Iee25c603a77a1ac546ada1840f3afaf5797b8802
2020-06-19 11:41:53 -07:00
Zak Cohen aef8b86b4a Image actions - fix uri permissions.
Feedback wasn't working, also Share wasn't showing its preview.

Bug: 159122067
Test: built and run locally
Change-Id: Iccea012a8fc0009a6a980f6233f42c4e7619f4ec
2020-06-19 18:02:44 +00:00
Tony Wickham 6a8ba169f2 Remove progress != mFullscreenProgress optimization
Sometimes other methods modify things like icon scale that setting
the fullscreen progress should override.

Test: open Calculator, open Clock, quick switch to Calculator and
ensure its task icon is not showing

Bug: 157105795
Change-Id: Iaed3e42f540fdff3648e9db7e6d7dc0b0d0a75df
2020-06-19 12:20:38 -05:00
Vadim Tryshev eee5fbe313 Merge "Removing debug requests from non-debug test info handlers" into ub-launcher3-rvc-dev am: 84aaecca64
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11827372

Change-Id: Iee1cd7c886309c32d6811ac949239350ea72d82e
2020-06-19 16:51:52 +00:00
Vadim Tryshev 84aaecca64 Merge "Removing debug requests from non-debug test info handlers" into ub-launcher3-rvc-dev 2020-06-19 16:37:41 +00:00
Bill Lin 375cf35327 Merge "Update state and touch region after one handed overlay changed" 2020-06-19 09:10:04 +00:00
Samuel Fufa cb2a99d53a Create hotseat predictor onCreate am: c3f13e01a3 am: dad117a2c4 am: b099c497e3 am: a5e181f635
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11917536

Change-Id: I6a1e7da3ba908e16ae2e0cc41824e847cc004017
2020-06-19 08:22:02 +00:00
TreeHugger Robot ab820472fb Merge "Fixing jump when swiping up in landscape and in waterfall cutout" into ub-launcher3-rvc-dev am: a5e45ad485
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11900651

Change-Id: I34dc565be6d7eb5ff3e9f82ba9061aaca171ecdc
2020-06-19 07:27:52 +00:00
TreeHugger Robot a5e45ad485 Merge "Fixing jump when swiping up in landscape and in waterfall cutout" into ub-launcher3-rvc-dev 2020-06-19 07:17:02 +00:00
Tony Wickham 1c5a3e082b Merge "Inline TaskView#resetVisualProperties() into RecentsView" into ub-launcher3-rvc-dev am: f13a51c4b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11917351

Change-Id: I6d7f8483d94e7fcd480dca0d1b3bd72f7865f884
2020-06-19 05:52:44 +00:00
Tony Wickham f13a51c4b8 Merge "Inline TaskView#resetVisualProperties() into RecentsView" into ub-launcher3-rvc-dev 2020-06-19 05:26:32 +00:00
Bill Lin 70b5ca2505 Update state and touch region after one handed overlay changed
The matrix for overall modes x state changes:
-----------------------------------------------------
   Mode     |      State changed     | *Before|*After
-----------------------------------------------------
  OneHanded |  Portrait->Landscape   |  80dp  |  32dp
  OneHanded |  Landscape->Portrait   |  32dp  |  80dp
-----------------------------------------------------
  OneHanded |  Disable->Enable       |  32dp  |  32dp
 (Landscape)|  Enable->Disable       |  32dp  |  32dp
-----------------------------------------------------
  OneHanded |  Disable->Enable       |  32dp  |  80dp
 (Portrait) |  Enable->Disable       |  80dp  |  32dp
-----------------------------------------------------
  NO_BUTTON |  Portrait->Landscape   |  32dp  |  32dp
  NO_BUTTON |  Landscape->Portrait   |  32dp  |  32dp
  2 BUTTON  |  Portrait->Landscape   |  48dp  |  48dp
  2 BUTTON  |  Landscape->Portrait   |  48dp  |  48dp
  3 BUTTON  |  Portrait->Landscape   |  48dp  |  48dp
  3 BUTTON  |  Landscape->Portrait   |  48dp  |  48dp
-----------------------------------------------------
* dimen : navigation_bar_gesture_height

Test: adb bugrepot | grep mOneHandedModeRegion
Test: manually triger one handed
Test: atest WindowInsetsBehaviorTests
Test: atest com.android.launcher3.memory.MemoryTests
Test: flake -once
Test: rnlot -t com.android.launcher3.memory.MemoryTests
Bug: 157958539
Bug: 159183864
Change-Id: I19755938c3c93eb59a9f621af5722f5679c1da14
2020-06-19 10:23:43 +08:00
TreeHugger Robot cc3e9f0614 Merge "Follow up for ag/11916646" into ub-launcher3-rvc-dev am: 5c33e250fc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11923398

Change-Id: Ia631a5640026628b967814f370e38921ff9186f5
2020-06-19 01:47:06 +00:00
TreeHugger Robot 5c33e250fc Merge "Follow up for ag/11916646" into ub-launcher3-rvc-dev 2020-06-19 01:42:09 +00:00
TreeHugger Robot cc764ffc94 Merge "Add spring to workspace scale when going from Hint state to Normal state." into ub-launcher3-rvc-dev am: 92b0b1d0a1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11871917

Change-Id: If2b1b8b2e0c9bcb552472f48538f48ca57b8d46d
2020-06-19 01:40:29 +00:00
TreeHugger Robot 92b0b1d0a1 Merge "Add spring to workspace scale when going from Hint state to Normal state." into ub-launcher3-rvc-dev 2020-06-19 01:28:25 +00:00
Tony Wickham d2fffa6ea5 Inline TaskView#resetVisualProperties() into RecentsView
- This was only used in RecentsView#resetTaskVisuals() anyway
- Previously resetVisualProperties() just called resetViewTransforms()
  plus setFullscreenProgress(0) and setModalness(0)
- The latter 2, specificially setFullscreenProgress(0) led to problems
  such as the bug below. Instead, we should reset to the current
  mFullscreenProgress and mTaskModalness.

Bug: task view sometimes shifted up during quick switch
Steps:
- Do the quick switch gesture very quickly
- At the start of the gesture, we call getTasks(), which calls
  applyLoadPlan() asynchronously
- applyLoadPlan() calls resetTaskVisuals(), so if this happened
  after the gesture ended, we would setFullscreenProgress(0) on all
  the task views, hence the upwards shift (if the gesture was still in
  progress, it would reapply the real fullscreen progress)

Fixes: 157105795
Change-Id: Idb9d91ff89701d726838b47f955d4300f5ef13bd
2020-06-18 20:25:34 -05:00
Samuel Fufa 0b0a57f422 Merge "Allow Users to migrate their hotseat when returning from AiAi" into ub-launcher3-rvc-dev am: a529cd0f5f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11855090

Change-Id: I988af6be3b74c45692adf281448ec2d9d936448e
2020-06-19 01:08:12 +00:00
Samuel Fufa 1d08cc681c Follow up for ag/11916646
- Fixes launcher breakage

Bug: 159170242
Change-Id: Ib21bfee8d5f63d31a8807ad87ac47d600fb62e7a
2020-06-18 17:57:39 -07:00
Jon Miranda 271638574f Add spring to workspace scale when going from Hint state to Normal state.
Bug: 151768994
Change-Id: If03d39e5ef6319355a7691d60fc0152de2fc3cec
2020-06-18 17:53:07 -07:00