As observed in b/248291728, widgets are disappeared after OTA update,
this CL includes additional logging to reveal more information.
Bug: 248291728
Test: manual
Change-Id: I5cf968efc358c3315e5e6ecc4861d5bc888569f1
This patch fixes a tablet bug related to splitting from All Apps. Splitting from AllApps was playing a very slow animation.
The bug occurred because there was no case set in QuickstepAtomicAnimationFactory for animating from the ALL_APPS state.
Fixed by setting the appropriate case in QuickstepAtomicAnimationFactory.
Fixes: 247053528
Test: Manual
Change-Id: I7391dc7049a6ff5a7f8c7e1ae8b69e29899248fa
- Behind ENABLE_TASKBAR_IN_OVERVIEW which is disabled by defualt
- Make taskbar unstashed in overview with background visible
- Ensure taskbar is touchable in overview
Bug: 245320601
Test: Home<->Overview, Home<->App, App<->Overview, Home->Overview->App->Home, Home->App->Overview->Home, Overview->Home->App->Overview, Overview->App->Home->Overview, App->Overview->Home->App, App->Home->Overview->App
Test: Go to AllApps, call KEYCODE_HOME, go to app and taskbar should be there
Test: App->Overview->Select->Home->App
Test: QuickSwitch -> App
Test: Repeat above with ENABLE_TASKBAR_IN_OVERVIEW x taskbarStashed on/off
Test: Repeat above with gesture and 3-button
Change-Id: Ib25d68f68e89564851b226536e456d0b2f6306f8
The ViewPropertyRefs, when copied from 1 frame to another, where also
transferring the same "next" reference. Sometimes, the recycled
ViewPropertyRef would be the same ViewPropertyRef instance as one of the copied
ViewPropertyRefs, which would caused an NPE, since the recycled VPR
would have it's next value set to null.
Bug: 249125402
Test: Repro steps are dragging and dropping around an item on the
workspace to different locations. This consistently repro's the crash in
about 10 seconds of doing this. Afte the fix, the crash stopped.
Change-Id: Ia43d8f788eb4889c0890fea0bb839cb9fed78ada
- Use a single iconAlignment animation
- Introduced isInLauncher/goingToLauncher/FLAGS_LAUNCHER as combined FLAG_RESUMED|FLAG_RECENTS_ANIMATION_RUNNING
- iconAlignment is now centralized in onStateChangeApplied with single source of truth
Bug: 245320601
Test: Home<->Overview, Home<->App, App<->Overview, Home->Overview->App->Home, Home->App->Overview->Home, Overview->Home->App->Overview, Overview->App->Home->Overview, App->Overview->Home->App, App->Home->Overview->App
Test: Go to AllApps, call KEYCODE_HOME, go to app and taskbar should be there
Test: App->Overview->Select->Home->App
Test: QuickSwitch -> App
Test: Repeat above with taskbarStashed on/off
Test: Repeat above with gesture and 3-button
Change-Id: Ie51b602394c155aca060a84585eb0e677e23425c
This patch fixes two bugs related to the way tiles slide in when a split is staged. Previously, translations were not being completely reset, so on repeated splits, the thumbnails would retain their old translation setting and cause awkward movements to occur during the slide-in animation.
Fixed by adding setTaskViewsPrimarySplitTranslation() and setTaskViewsSecondarySplitTranslation() in resetFromSplitSelectionState().
Fixes: 249154347
Fixes: 249824716
Test: Manual on grid and non-grid Overview, in a variety of conditions
Change-Id: I2d9aa621a17f178ff8216740d76429d2ac484b39
Sometimes the view is there but it was not measured yet, and that was making the animation run with wrong icon position values.
Fix: 233247401
Test: manual
Change-Id: Ibcce24391e99b02ecdb492191c39b62d332abe4f
* navButtonsLayoutParams marginEnd was removed, and
SUW was relying on that value to add margins to
SUW back button, but was returning 0.
Fixes: 242999939
Test: Visually observed in SUW test activity
adb shell am start -n com.google.android.setupwizard/.SetupWizardTestActivity
Change-Id: I5ffc421e9b731b0d9c7b7c48eab807d4419721b1
Here we fix the animation that was broken in earlier CL's for delightful pagination, now the page indicator has the same smooth entry animation as the dots
Bug: 247561880
Test: manual
Change-Id: I3e2099ba4f5ccfdbc9b4dfe5b48a1c44dbdeda1e
There are specific scenarios when you can force an extra empty
workspace after changing the grid, fortunately there is a
function that removes empty workspaces.
Fix:229349287
Test: Add a widget in a new empty workspace page, change the
grid then remove the widget in the new grid size then return
to the previous grid and it shouldn't have an empty workspace.
Change-Id: I7b73ae2ca058bc84b3b361930e3dc856c045281b
Changed overview exit animation so that tiles don't slide off and only fade/scale in place for 3 button navigation. Previously, tiles would slide off when exiting for both gesture navigation and 3 button navigation. Now 3 button navigation exits with tiles staying in place.
Test: Manual
Fix: 245745939
Change-Id: I4144ed7e3ff29419df7fb13b6417ccc0a1f9dd45
This change updates the animation for initiating a split from the Overview screen on phones. Includes new timings and interpolators, and extends timing data classes related to SplitAnimationTimings.
Fixes a noticeable issue where the split animation appeared slow on phones.
Outstanding issues (fixes in progress):
- Repeated invocations of split on phones cause an erroneous animation to play. (b/249154347)
- Thumbnail corners do not match placeholder corners; the transition between the two is slightly janky. (b/236761794)
- Placeholder icons should be 72dp. (b/236761794)
Bug: 236761794
Test: Manual
Change-Id: Ibb97ef54498b0aa9556df531d8084799259c06e2
Here we rename DOT_INACTIVE_ALPHA and DOT_ACTIVE_ALPHA to reflect the new code, and we also use mPaginationPaint.setAlpha a bit differently
Bug: 247561880
Test: Manual
Change-Id: I5ee25ee3fb36715d54f9ed86c0d59448829d7260
Basically, adds the spacing that is otherwise included by
the tab protection (which is about 4dp less than the spacing
that was previously being added).
Adds a compile-time flag to render the header at all times to
help visualize issues like this in the future. Check the
screenshots below to see some examples of this.
Screenshots: https://drive.google.com/drive/folders/1n4wwtjMwOR-eDIE1xAoG3oLXO7txpoT_?resourcekey=0-WP0RNbp7vFh2Yw1wUBZTaA&usp=sharing
Bug: 240672593
Bug: 243728487
Test: Manually checked search transition, scrolling behavior, and
highlight of the search results with and without a work profile.
Change-Id: I166d136e568c5621c81378fa09021666d95f0ffc
Create a placeholder tile in recents for desktop.
It is based on launcher task information. With extra flag indicating it
is for desktop.
When it is clicked, it will call sysui to show apps on desktop.
Test: manually verify that desktop tasks do not show up separately in
recents
Bug: 244348395
Change-Id: I8535a54e1545841cd988d4770e6fc5e857277cda
There's a possible race here where we call moveToRestState before
Launcher is actually stopped, so it starts to animate the state
change, causing a visual jump before it gets stopped. We already call
moveToRestState in StatefulActivity#onStop, so this one shouldn't be
necessary anyway.
Test: Enable Winscope tracing, quick switch from app A to app B; before
this change, 9/10 times it would repro the jump in the bug, 0/10 times
after this fix. (Also verified through debug logging.)
Fixes: 244583136
Change-Id: I656b028f26a64f872960cb3fe87c39b097431511
Here we add rotation for the page indicator in order to make it align with the new animation design.
Bug: 247561880
Test: manual
Change-Id: I91202c8ac259d4876f6182938db79c466f99c6ed
Revert "Introducing new variable to enable/disable shortcuts."
Revert submission 19632697-cherrypick-GO-DISABLE-SHORTCUTS-tyyzrpy9oe
Reason for revert: Reverting changes for the recent feature built by me. This CL was a part of the feature. Please take a call if we should revert it or not.
Reverted Changes:
Ib373b042f:Introducing new variable to enable/disable shortcu...
I4274cb468:Introducing new variable to enable/disable shortcu...
Change-Id: I81f338be71185cb008e81b020c5b3a7b01b64c58
Pinyao Ting
Winson Chung
Jeremy Sim
Vinit Nayak
Alex Chau
Stefan Andonian
Federico Baron
Thales Lima
Brian Isganitis
Andy Wickham
Pat Manning
Tracy Zhou
Holly Jiuyu Sun
Sebastian Franco
Bill Yi
Saumya Prakash
Ats Jenk
Tony Wickham
Becky Qiu
Mady Mellor
Raj Garg
Brandon Dayauon
TreeHugger Robot