Commit Graph

49755 Commits

Author SHA1 Message Date
Sebastián Franco 8c158770d7 Merge "Check for null when calling getCreatedActivity which is marked as Nullable" into tm-qpr-dev 2022-09-23 15:19:43 +00:00
Johannes Gallmann d79a87bf16 Disable split button instead of hiding it
The split button remains visible when there is only a single task present, but in a disabled state.

Test: Manual
Bug: 227600027
Change-Id: I36e8904bf342021db210cea7355a3806c783f235
2022-09-23 08:05:26 +00:00
Winson Chung d859a20086 Merge "Revert "Fix case of gesture being stuck when the Launcher is stopped mid-gesture"" into tm-qpr-dev 2022-09-23 04:33:22 +00:00
Anushree Ganjam 65e73ce5b3 Merge "Add Ime transition type, Controlled and Atomic to LatencyType." into tm-qpr-dev 2022-09-22 23:32:45 +00:00
Vinit Nayak 26fee57f37 Null out mSplitHiddenTaskView when resetting split selection state
* May have accidentally been removed in ag/19984439

Fixes: 248153819
Test: Repro in bug doesn't occur
Change-Id: Icdc04de84c28963d36368f9672baf5993cd87d8a
2022-09-22 16:27:47 -07:00
Winson Chung 8ae6b852d7 Revert "Fix case of gesture being stuck when the Launcher is stopped mid-gesture"
This reverts commit 240b064cdb.

Reason for revert: b/248344141

Change-Id: I559e583ddea4a68b4291ceb8ba119500d051ed36
2022-09-22 22:10:20 +00:00
Vinit Nayak 061e6f5dd5 Merge "Prevent taps on initial TaskView animated into split select" into tm-qpr-dev 2022-09-22 21:56:55 +00:00
Brandon Dayauon 23ff6774b7 Fix pause work apps overlapping IME
The bottom margin for button in gesture navigation is wrong.
The bottom margin for the button is supposed to be 20dp from the gesture nav bar,
not 20dp from the bottom of the screen. The calculation was correct for 3 button nav but
was forgotten to be applied to gesture nav.

bug: 246243359
test: Manual - after: https://hsv.googleplex.com/5763335673872384
Change-Id: If678a70b4ad43791cf9e66390164e1ab25a6e366
2022-09-22 13:35:01 -07:00
Holly Sun cd9e261014 Add flag to control show/hide keyboard suggestion strip.
Test: manual
Bug: 247895327
Change-Id: I9425be72a1bd946a16d3327cbb10d56d2e2250b9
2022-09-22 13:32:00 -07:00
Mady Mellor ceff6537ee Set package name on the floating intent
Test: treehugger
Bug: 237678727
Change-Id: I70923e62893cd6578fa3fa21e025cd5cf5e15edf
2022-09-22 12:08:41 -07:00
Andy Wickham 0f7b01c775 Merge "Removes search animation when tapping home screen QSB." into tm-qpr-dev 2022-09-22 19:01:12 +00:00
Thales Lima c9a317c7a2 Change taskbar edu size to wrap around icons
Bug: 217262479
Test: manual
Change-Id: I766394f4f64d5ba76c1bf50de9d06526376e6662
2022-09-22 14:36:10 -04:00
Anushree Ganjam ae81433665 Merge "HideKeyboard when animations are disabled." into tm-qpr-dev 2022-09-22 18:03:52 +00:00
Sebastian Franco e7c222cdb5 Check for null when calling getCreatedActivity which is marked as Nullable
Fix: 243508135
Test: compiles
Change-Id: Id1ff2cf68fa10690a1bbec60a0c17cceab9db8d1
2022-09-22 13:03:15 -05:00
Bill Yi 925d6e5d51 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-09-22 17:43:17 +00:00
Schneider Victor-tulias 418b1f8e82 Merge "Allow Taskbar stashing for external tests" into tm-qpr-dev 2022-09-22 17:25:24 +00:00
Vadim Tryshev af91a58659 Merge "Verifying a theory that sometimes a leak disappears while saving an object dump" into tm-qpr-dev 2022-09-22 16:25:06 +00:00
Hyunyoung Song 64d5e25ab7 Merge "Fix the case of the missing header." into tm-qpr-dev 2022-09-22 15:45:22 +00:00
Mady Mellor 13b7e00fff Merge "Add a button for floating tasks to taskbar (behind a flag)" into tm-qpr-dev 2022-09-22 14:58:13 +00:00
Nicolò Mazzucato 98e4e461fe Merge "Fix taskbar instrumentation crash" into tm-qpr-dev 2022-09-22 08:28:41 +00:00
Federico Baron 06c0f35c4e Merge "Adding 'delightful pagination' to folders, removed old animation and now have regular scrolling for navigating pages." into tm-qpr-dev 2022-09-22 01:10:48 +00:00
Anushree Ganjam 25ba5203e4 Add Ime transition type, Controlled and Atomic to LatencyType.
Bug: 240192346
Bug: 234812580

Test: Manual
Change-Id: I90042aa41acb1a01e3c45f67ccdc9c0f2f0eaf81
2022-09-22 01:07:08 +00:00
Federico Baron f837fd1795 Adding 'delightful pagination' to folders, removed old animation and now have regular scrolling for navigating pages.
Here we add a feature flag for delightful pagination and if the feature flag is on we show a new pagination without the old animation, instead it will show a square that will move on scroll from one page to another.

Bug: 247561880
Test: manual
Change-Id: Ic88b6b2e4c677fd2012bca579407168cbda63785
2022-09-21 17:56:08 -07:00
Andy Wickham d20fe5b299 Removes search animation when tapping home screen QSB.
Test: Manual
Bug: 234882587
Fix: 247965855
Change-Id: Ib6d3c3f81924fdb693a90d4672b6d643b0b87407
2022-09-22 00:41:35 +00:00
Andy Wickham 30b87aad7d Fix the case of the missing header.
We should not override the tabs based on the search state now
that they are hidden (but still active) during the animation.

For an explanation of why this fixes the issue, please see
https://b.corp.google.com/issues/247615711#comment15.

Fix: 247615711
Test: Manually with predicted apps being updated every second
(part of the way I found to repro the bug).

Change-Id: I5ba45c42726c34f471a7743c06aecc05c89f6105
2022-09-21 17:04:48 -07:00
Anushree Ganjam 2043d36b86 HideKeyboard when animations are disabled.
ValueAnimator.areAnimatorsEnabled() returns false

- When talkback is turned on.
- when "Settings -> Accessibility -> remove animations" are turned on.

In launcher code, when launcherstate goes from ALLAPPS -> NORMAL, AllAppsTransitionController.setStateWithAnimation is called only when animations are enabled and this function hides keyboard as well.

However, when animations are disabled
AllAppsTransitionController.setState -> onProgressAnimationEnd() is called which is where we need to hide keyboard. But the condition "if (FeatureFlags.ENABLE_DEVICE_SEARCH.get()) return;" caused the keyboard to not hide instead just return from onProgressAnimationEnd().

See https://source.corp.google.com/android-internal/packages/apps/Launcher3/src/com/android/launcher3/statemanager/StateManager.java;l=221-235;rcl=08a9bcac1f8400b44356ad4da445de8d7f360578

Bug: 239610759
Test: Manual
Video : https://drive.google.com/drive/folders/1Tif2uf13dYxIgtDlELkE4SiRthr_w-dZ?resourcekey=0-7Po8nbQPxhsgLqeMJGgKIw&usp=sharing

Change-Id: Ice9a0f951435d2fc1594d09414f299ce0cff775c
2022-09-22 00:04:13 +00:00
Vinit Nayak 5144be3903 Prevent taps on initial TaskView animated into split select
Fixes: 247843657
Test: Tapping on animating taskView as soon as
split top is selected from app menu doesn't result
in starting split prematurely.

Change-Id: I94455d9bab381e5223f70cab981830d51a8fad6b
2022-09-21 16:57:53 -07:00
Stefan Andonian beccfe5928 Merge "Correctly position the landscape / rtl FloatingIconView's background drawable when swiping back to home." into tm-qpr-dev 2022-09-21 22:48:42 +00:00
Stefan Andonian 94502428a9 Merge "Copying ViewCapture from last frame when possible." into tm-qpr-dev 2022-09-21 22:44:53 +00:00
Bill Yi 713efc36a7 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If88cecf0c4d69a754a7c784d69dbbdd1905315ea
2022-09-21 15:37:12 -07:00
Bill Yi c766a8c92a [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: c619b29971 -s ours am: 9bc2d5aa21 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19994599

Change-Id: Ieb463c7b997eea02ad202f38d415e17097eb5e82
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-21 22:31:32 +00:00
Bill Yi 9bc2d5aa21 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: c619b29971 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19994599

Change-Id: Ic48e973c441335fdcf93e590d39a6dfe738deeb1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-21 21:47:16 +00:00
Bill Yi 718a92dcfd [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 5b7184135f -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19997487

Change-Id: I9b1644141726eea65dc064815a19bde260048e65
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-21 21:33:07 +00:00
Brian Isganitis 4ef5056be8 Merge "Add content description for taskbar all apps button." into tm-qpr-dev 2022-09-21 18:40:42 +00:00
vadimt 592b3f9885 Verifying a theory that sometimes a leak disappears while saving an object dump
Bug: 241585675
Test: presubmit
Change-Id: If9c559619507002ed7ec4b1a8b96a5f62e2dbe41
2022-09-21 10:56:04 -07:00
Stefan Andonian d768f73f37 Correctly position the landscape / rtl FloatingIconView's background drawable when swiping back to home.
Bug: 235812580
Test: Verified the correct "Swipe Back to Home" position for the
floating icon view in landscape and portrait (rtl and ltr for both
orientations) with a tablet. There is a screen recording on the bug.

Change-Id: Id06f43e70ef617e39e1b26d0c8b7466147e325d2
2022-09-21 17:54:24 +00:00
Schneider Victor-tulias e64a8cfb20 Allow Taskbar stashing for external tests
Moved Taskbar stashing enabling logic to QuickstepTestInformationHandler to allow external tests to use the Taskbar API

Test: TaplTestsTaskbar
Bug: 240129939
Change-Id: I0ede8e4767cbe068328997a3afd51f9d5df2799a
2022-09-21 10:44:23 -07:00
Andy Wickham a297508c15 Merge "Reduces vertical padding of predicted apps in All Apps." into tm-qpr-dev 2022-09-21 17:25:39 +00:00
Stefan Andonian 7308c39049 Copying ViewCapture from last frame when possible.
Bug: 242867462
Test: Used system.nanotime to time the performance improvements
before and after. Verified correct behavior by coloring dirty
views differently in the go/web-hv tool and ensuring that the
hierarchies were emitted correctly for dirty and clean views.

Change-Id: I624572170bc914ed2c9d329e37e64a88203f87f4
2022-09-21 16:38:01 +00:00
TreeHugger Robot 4298b36ef4 Merge "Fix LauncherInstrumentation for OOP tests from gradle" into tm-qpr-dev 2022-09-21 03:50:08 +00:00
Yein Jo 364af1837e Merge "Move OnBackInvoked to BaseActivity." into tm-qpr-dev 2022-09-20 23:21:44 +00:00
Sebastian Franco 3493764337 Adding flag for material U popup
Test: compile
Bug: 247880037
Change-Id: I989fe88e070f5fe14494aa2c3d00071259907472
2022-09-20 18:02:41 -05:00
Bill Yi cafb3cdc5e Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-09-20 22:47:08 +00:00
Schneider Victor-tulias c4928df98b Merge "Update page index update logs" into tm-qpr-dev 2022-09-20 21:50:36 +00:00
Winson Chung a4512046cf Merge "Fix case of gesture being stuck when the Launcher is stopped mid-gesture" into tm-qpr-dev 2022-09-20 19:51:08 +00:00
Mady Mellor 78c899314e Add a button for floating tasks to taskbar (behind a flag)
Test: manual - build launcher3, enable the feature flag on tablet with
               a valid app installed, open an app, observe that there
               is NO button in taskbar because launcher3 doesn't have
               populated config
Bug: 237678727
Change-Id: Ic261608898eb9a9220cffacd0c6060a32c10a74f
2022-09-20 10:41:12 -07:00
Yein Jo 18446d0189 Move OnBackInvoked to BaseActivity.
In order to have all the activities in Launcher get
the same OnBackInvoked behavior, the logic is moved to BaseActivity.

Test: Manual, Tapl
Bug: 238475344
Change-Id: I3f49091397e31fe1f183596f7fba3bf514697468
2022-09-20 16:53:41 +00:00
Jeremy Sim 5227613acb Merge "Update animations for TM-QPR: Home > OverviewSplitSelect transition" into tm-qpr-dev 2022-09-20 15:09:33 +00:00
Jeremy Sim c3c4be206c Merge "Fix small bug with DWB banners not animating out promptly" into tm-qpr-dev 2022-09-20 15:09:10 +00:00
Nicolo' Mazzucato 52909d0b5f Fix taskbar instrumentation crash
This was crashing when there were no views in the taskbar. Now, we're using getDragLayer, that will be always there.

Bug: 245690391
Test: TaskbarExpandCollapse
Change-Id: I4475adb0c6c425fca54af02bb071ed3e5f42d927
2022-09-20 14:01:40 +00:00