Commit Graph

49755 Commits

Author SHA1 Message Date
Pat Manning 31cf44c48c Add launcher metrics for tracking kids nav mode change events.
Bug: 241762670
Test: wwdebug && wwlogcat
Change-Id: I5bf05ce1660078951896e0e331bbe74f8f2ebc5f
2022-10-14 16:24:32 +00:00
Pat Manning 956631ec3a Merge "Add screenshot test for edit state drop targets." into tm-qpr-dev 2022-10-14 12:49:09 +00:00
TreeHugger Robot a1734ad12e Merge "Update taskbar state when launcher pauses" into tm-qpr-dev 2022-10-14 03:23:40 +00:00
Alex Chau 41ab3f3e14 Merge "Run setCurrentPage in applyLoadPlan after scroll initialized" into tm-qpr-dev 2022-10-14 00:31:32 +00:00
Evan Rosky 14145d131a Update taskbar state when launcher pauses
With shell-transit, we need to defer updating state when resumed
(until we commit a transient launch state); however, for pause
this isn't necessary. In fact, now that taskbar exists in overview,
we must update state on-pause since the taskbar is no-longer
already-closed.

Bug: 253473765
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsQuickstep#testOverview
Change-Id: I347da03a211f5b2685f7b18666b2ebb93a1731ef
2022-10-14 00:11:25 +00:00
Nicolò Mazzucato 4afab0b210 Merge "Cancel unfold animation when rotation changes" into tm-qpr-dev 2022-10-13 23:06:50 +00:00
Vinit Nayak 0f6526e0c4 Improve TaskMenuView layouts for split pairs
* Instead of basing calculations on the TaskView view,
use the TaskThumbnailView as the anchor.
This helps us prevent having to re-calculate positions
that were already done to layout the thumbnails
* TODO: Gracefully handle re-positioning task menu view
on rotation

Bug: 249693334
Test: Manual, opening task menu view in
land/seascape in portrait, w/ and w/o home rotation

Change-Id: I02da96d2735657d5340e23056de69392ff8452c4
2022-10-13 14:15:14 -07:00
Vinit Nayak 0bc70442d6 Merge "Fix casts to Math.round() in real landscape" into tm-qpr-dev 2022-10-13 20:02:05 +00:00
Vinit Nayak b26664800e Fix casts to Math.round() in real landscape
Fixes: 248575056
Test: Wallpaper no longer bleeds through on split
animation in real landscape.

Change-Id: Ia59efda737de94a4b64f9d0a1f84cd116539107b
2022-10-13 13:01:39 -07:00
Federico Baron 922bde1df3 Merge "Fix bug where pagination animation comes in from outside the folder when opening folder after swiping back home from another app (left to right swipe)" into tm-qpr-dev 2022-10-13 17:48:40 +00:00
Alex Chau e966537123 Merge "Only support manual stashing while in app" into tm-qpr-dev 2022-10-13 13:48:46 +00:00
Nicolo' Mazzucato 74c3a0024b Cancel unfold animation when rotation changes
In DeviceFoldStateProvider.kt, FOLD_UPDATE_FINISH_HALF_OPEN is emitted if the rotation changes while the animation is in progress.

 This targets the case when the device goes to tabletop mode during the transition.

+ Using RotationChangeProvider to fix problems when the new orientation change was received in a background thread unexpectedly. This fixes: (1) wrong launcher icons movement after the rotation, and (2) wrong dark overlay scrim after rotation.

+ Minor formattig fixes by ktfmt

Bug: 241743859
Test: DeviceFoldStateProviderTest && NaturalRotationUnfoldProgressProviderTest && manual stress testing
Change-Id: Iee234e4b832cad8298b69356fce7c14d75e89ccc
2022-10-13 09:16:44 +00:00
Ling Wo 5c239ba4f7 Add enable-suggestion option via TestProcotol so that test can opt-in to show live suggestion
Bug: 242246407
Test: atest
Change-Id: Icde0185c82b1d34570d83bd8b9750acb57a8e39c
2022-10-13 01:46:45 +00:00
Federico Baron c722e7d814 Fix bug where pagination animation comes in from outside the folder when opening folder after swiping back home from another app (left to right swipe)
Fix: 249814494
Test: Manual
Change-Id: I03008dd24ddb9a0ba4c5a44878cbdf04c65de435
2022-10-12 15:42:34 -07:00
TreeHugger Robot 24dd3f57b2 Merge "Desktop tile that is a snapshot of desktop" into tm-qpr-dev 2022-10-12 21:10:16 +00:00
Alex Chau 38dae63910 Only support manual stashing while in app
- For taskbar in overview, don't allow stashing

Fix: 253042515
Test: With taskbar in overview, long press do nothing. Taskbar is still stashable in app
Test: Without taskbar in overview, taskbar still transform to nav handle in overview
Change-Id: I8f353a473a8570df72acda2338c4b984a69dc5c0
2022-10-12 18:16:50 +01:00
Sebastian Franco d468299c0f Moving the class LayoutParams to a file outside CellLayout
I'm moving the LayoutParams to another file to start the decoupling
of the Reorder outside of the CellLayout.

Also, I change the name from LayoutParams to LauncherLayoutParams to prevent confusion with ViewGroup.LayoutParams making it explicit that this are different LayoutParams.

Bug: 188081026
Test: atest ReorderWidget
Change-Id: I92251c5540ffcf5ece7b933e6f6c836eb825c997
2022-10-12 16:14:42 +00:00
TreeHugger Robot 2613431914 Merge "Enable taskbar in overview by default" into tm-qpr-dev 2022-10-12 12:21:14 +00:00
Pat Manning a283b551d2 Merge "Use wm shell splash screen animation to reveal app after tasks have appeared." into tm-qpr-dev 2022-10-12 11:34:41 +00:00
Jeremy Sim 0ac4708396 Prevent doubling up on split placeholder insets
This patch makes it so that the split placeholder uses only one inset for buffering the top of the icon: either the default split placeholder inset, or the device's built-in screen inset.

Currently, when we determine the size of the split placeholder, we add the placeholder's default inset to the device's built-in screen inset (camera cutouts, etc.). On some devices, this causes a very large combined inset, and it doesn't leave enough room for all the other UI elements, especially when 3-button mode is active. This patch cuts out one of the insets by selecting only one of the insets to respect (the larger one).

Fixes: 241164191
Test: Manual, checked all emulated inset types on a variety of screen sizes
Change-Id: Ica0e791bf4b8b757ad3fb87ab1cf3105b97a61dc
2022-10-11 21:26:43 -07:00
TreeHugger Robot 5c4b6b50d7 Merge "First pass at Taskbar layout UI polish for SUW" into tm-qpr-dev 2022-10-12 02:27:37 +00:00
TreeHugger Robot 1337b31b3f Merge "Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly." into tm-qpr-dev 2022-10-12 00:17:33 +00:00
Vinit Nayak 2081742cb7 First pass at Taskbar layout UI polish for SUW
Bug: 231906478
Change-Id: I5d55d1e33f928d4b8034c356565a0f9d8bc5c3fb
2022-10-12 00:04:27 +00:00
Brandon Dayauon 956851e7ca Merge "Scale icons from search to make app icons big like AA -> workspace" into tm-qpr-dev 2022-10-11 22:40:13 +00:00
Schneider Victor-tulias a0be92c830 Add debug logs to help identify when setRecentsAttachedToAppWindow will not animate properly.
Bug: 244593270
Test: Manually checked logs
Change-Id: Ie6d0395a45a025d1562a722154d3dd3b42618ccc
2022-10-11 15:12:13 -07:00
Brandon Dayauon d3755f46cc Scale icons from search to make app icons big like AA -> workspace
when dragging from search.

To scale the icon during dragging (instead of long press) I created a scale variable within DragOptions
so that right before dragStart gets called in DragController.java (in callOnDragStart())
the dragview scales before dragging..
 * note: the scale from search is 1.687 and the scale from allApps is 1.107
- included searchResult and smallSearchResult
- Added animation for scaling icon (used Interpolators.EMPHASIZED 500ms as suggested by motion designer)
- Cancel animation when drag finishes

bug: 222666176
test: Manual - after: https://drive.google.com/file/d/1ZZHnXlzdTxlM-RUIdJ6EOYkPPg6tCUxC/view?usp=sharing
before: https://drive.google.com/file/d/1NpBz3kT_slHXtpXObr_G8K6SZYG9_bLX/view?usp=sharing

Change-Id: I01309a3be928987ba00422ad947b80a3df865973
2022-10-11 13:29:35 -07:00
Sebastián Franco 73049b14b9 Merge "Prevent double touch inputs in the BaseDragLayer" into tm-qpr-dev 2022-10-11 20:22:45 +00:00
Alex Chau 517131ae1c Enable taskbar in overview by default
- Also changed expectation in test that taskbar is visible in overview

Fix: 245320601
Test: presubmit
Change-Id: If1ed44f542e5907860f7ab8182e4b45172346f3f
2022-10-11 18:48:45 +01:00
Sebastian Franco 68fc44ffad Prevent double touch inputs in the BaseDragLayer
If you hold a long press and while pressing you start another
long press again with another finger, then a new onLongPress event
will trigger and in some cases we are not processing that case.

By ignoring the evetns with the flag ACTION_OUTSIDE we can prevent
such cases.

Fix: 247477725
Test: ReorderWidgets
Change-Id: I31833bc54db2771809562bd1f92c8523eb2f05ab
2022-10-11 09:54:46 -05:00
Alex Chau e2791f0cf6 Merge "Fix positioning of split instruction and share targets with taskbar in overview" into tm-qpr-dev 2022-10-11 14:04:57 +00:00
Alex Chau 0733ebd3c1 Run setCurrentPage in applyLoadPlan after scroll initialized
- Also combined the 2 setCurrentPage call in applyLoadPlan into 1
- Otherwise setCurrentTask may set to page 1 unexpectedly due to page 0's scroll being invalid and out of range

Bug: 246283207
Bug: 238461210
Test: Split screen with 2 apps, click back, go to overview again, should snap to focsued task
Change-Id: I3b57655c810668fe244659437fbd4a745ca02d21
2022-10-11 12:36:35 +01:00
Jon Miranda efd41a717e Add ENABLE_TRANSIENT_TASKBAR feature flag.
Bug: 252905206
Test: N/A
Change-Id: I7995e4fc0a181aee6932e0bee041b74a4241053e
2022-10-10 18:46:19 -07:00
Bill Yi 4a0dd44619 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 897d7d4d85 -s ours am: 8a8269bf04 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20149392

Change-Id: Ib0ce5bf091d67d65533cdcb6c98a5f04643d883a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-11 00:42:17 +00:00
Bill Yi 8a8269bf04 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 897d7d4d85 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20149392

Change-Id: Id0934177b8372b28813095e6f3457eb3696e88ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-11 00:12:17 +00:00
Ats Jenk 3c59d9b345 Desktop tile that is a snapshot of desktop
Create a desktop recents tile that shows a snapshot of the freeform
tasks running on desktop.
Scales them down and positions them in the same location as they would
be on the desktop.

Bug: 244348395
Test: manual
Change-Id: Ieb5830a331691844769003189f557c4b7e4cd35c
2022-10-10 15:50:31 -07:00
Federico Baron 3c8ae3efff Merge "Add flags for new home gardening mode" into tm-qpr-dev 2022-10-10 19:59:14 +00:00
TreeHugger Robot 803f88b89e Merge "Round split layout values instead of using int cast" into tm-qpr-dev 2022-10-10 17:51:52 +00:00
Vinit Nayak 8addaad158 Merge "Improve splitscreen recents animation in seascape" into tm-qpr-dev 2022-10-10 17:49:54 +00:00
TreeHugger Robot 14a74fc2ba Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-10-10 17:43:56 +00:00
TreeHugger Robot 1f7b2f9a7a Merge "Fix repeated empty workspaces after changing the grid size." into tm-qpr-dev 2022-10-10 16:57:59 +00:00
Bill Yi b1e509f4c0 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 63438f1c65 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20149394

Change-Id: I3baa5ed087413f5c27da840250d093e87afa42fc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-10-10 16:27:59 +00:00
Alex Chau 21064ef82a Merge "Fix flaky/failing two panel TAPL tests" into tm-qpr-dev 2022-10-10 15:59:37 +00:00
Andras Kloczl 0e4f04d85f Fix flaky/failing two panel TAPL tests
Since Cuttlefish emulators are quite slow, some
of the two panel related TAPL tests were failing
due to multiple page changes instead of single ones.

Test: atest -c NexusLauncherTests:com.android.launcher3.ui.workspace.TwoPanelWorkspaceTest
Bug: 236136463
Fix: 252747355
Change-Id: Ib154cf97040fcea3b4d2d7082352c06de74f8c2a
(cherry picked from commit 486f7c8766)
Merged-In: Ib154cf97040fcea3b4d2d7082352c06de74f8c2a
2022-10-10 10:52:16 +00:00
Luca Zuccarini 82469ea23b Merge "[Toast] Switch to using device config to control keyboard sync." into tm-qpr-dev 2022-10-10 10:22:27 +00:00
Alex Chau 86924eed57 Merge "Fix taskbar in overview touch and stash behavior" into tm-qpr-dev 2022-10-10 10:02:12 +00:00
Bill Yi 63438f1c65 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I867e47ef07267f94bc4a7d4c1fab5cfb3dd6cd85
2022-10-09 22:34:48 -07:00
Bill Yi 50c515b164 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I8ca4ae6223e9c9e3f965c1374e73ed80d65c636d
2022-10-09 22:34:15 -07:00
Bill Yi 897d7d4d85 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I7a6bab3de85a4fd441ecc3e9bdabd2d1a901e853
2022-10-09 22:33:43 -07:00
Brandon Dayauon 926d04ec14 Merge "Add variable to check if button should apply keyboard insets" into tm-qpr-dev 2022-10-08 12:15:26 +00:00
Alex Chau 8949c583ee Fix positioning of split instruction and share targets with taskbar in overview
- When taskbar is in overview, overview actions has dedicated space and no need to align to nav buttons
- Add a bottom margin to split instruction and share targetse that is equal to the space below overview actions

Bug: 245320601
Test: Test split select and share target with different screen sizes
Change-Id: I6aec325da9cc4c43c84ba8bed5f0e087c57d6925
2022-10-08 10:15:58 +01:00