Commit Graph

49755 Commits

Author SHA1 Message Date
Federico Baron 98db0df4ab Hide QSB (toast) when editing workspace
Here we hide QSB when we enter drag mode in order to follow the guidelines set by https://docs.google.com/presentation/d/1FOmmCdmGmSMR77_901IOMbvbPVxPmjaAdxZjy-D9tw0/edit#slide=id.g159289e55db_0_229

Bug: 251259222
Test: Enter edit mode with SHOW_HOME_GARDENING flag on, notice how QSB disappears when we enter drag
Change-Id: If1a00ac62cec21a641295494d3a2dbb1f267bd62
2022-10-25 10:47:48 -07:00
Federico Baron 69c5f2d840 Add flag for moving the workspace edit buttons to bottom
This flag is for moving the workspace edit buttons to the bottom as per https://docs.google.com/presentation/d/1FOmmCdmGmSMR77_901IOMbvbPVxPmjaAdxZjy-D9tw0/edit#slide=id.g159289e55db_0_229.

Bug: 255586768
Test: N/A
Change-Id: I5b23307081333f80f3a8a1f23aa9a09c5425129d
2022-10-25 10:44:36 -07:00
Schneider Victor-tulias 4c9a93c04f Merge "Remove obsolete cancel recents animation logic" into tm-qpr-dev 2022-10-25 17:02:29 +00:00
Alex Chau 1faa68c8a0 Auto resize digital wellbeing toast
Fix: 253970740
Test: Enable app timer with largest display size and font size
Change-Id: I6c920b6bf7bb2801711b215ae461c64d2c7b898d
2022-10-25 17:46:37 +01:00
Andras Kloczl fb65436fae Improve All Set page UI for large screens
Test: manual
Screenrecordings: https://drive.google.com/drive/folders/1S6kjenZn0kP-W2tPpUemre2x0368ACyr?usp=sharing
Bug: 233610579
Change-Id: I9a33efe193a96e752766feb1e91cf0ac9b30246f
2022-10-25 13:16:47 +00:00
Tony Huang c33c69c1c3 Merge "Snapshot 2 tasks when swipe up split case" into tm-qpr-dev 2022-10-25 05:42:39 +00:00
Sihua Ma 4421353ce8 Merge "Get rid of setInteractionHandler call to the host in launcher" into tm-qpr-dev 2022-10-25 02:44:16 +00:00
Federico Baron f748755a4f Merge "Rename first page pinned widget to mFirstPagePinnedWidget" into tm-qpr-dev 2022-10-25 00:25:34 +00:00
Sunny Goyal 97ae16e80c Updating AIDL interface and removing unused methods
Bug: 193244407
Test: Presubmit
Change-Id: If87ef08e16e541921cde4e7a15a675b07c388fef
2022-10-24 15:50:25 -07:00
Saumya Prakash 96cad794d7 Removed disabled overview actions at end of scroll
Updated visibility of the overview action bar so that when viewing
the clear all button at the end of the tasks it becomes hidden.
Previously, the overview actions were disabled so they were not
usable anyways. Updated the corresponding tests because expected
behavior was changed.

Test: Manual
Fix: 230508197
Change-Id: I17628f1fa3869b575ec404a2a630a6927e3c1d14
2022-10-24 22:47:24 +00:00
Sihua Ma 8ca56fe1cd Get rid of setInteractionHandler call to the host in launcher
Bug: 235358918
Test: N/A
Change-Id: I0defac1831825bf0a13a601dd1502b4ca022bc2e
2022-10-24 14:56:11 -07:00
Sunny Goyal d859060860 Merging MultiValueAlpha with MultiPropertyFactory
Bug: 246644619
Test: Presubmi
Change-Id: Id5abc5f3169544656f1139ae17ca59e34ac65dac
2022-10-24 14:38:18 -07:00
TreeHugger Robot b9bced07c2 Merge "Removing unnecessary RemoteAnimationTargetCompat" into tm-qpr-dev 2022-10-24 21:32:34 +00:00
Ats Jenk 1236c812f1 Merge "Clicking on desktop tile brings apps to front" into tm-qpr-dev 2022-10-24 20:57:25 +00:00
Hui Kang 07949ff3c8 Merge "Fix AddWidgetTest flake Test: ABTD" into tm-qpr-dev 2022-10-24 20:52:48 +00:00
Federico Baron 2c97e58933 Merge "Set smartspace to 30% visibility on workspace edit for home gardening" into tm-qpr-dev 2022-10-24 19:17:29 +00:00
Hui Kang 4b87b9e521 Fix AddWidgetTest flake
Test: ABTD

200 all PASS: https://android-build.googleplex.com/builds/tests/view?invocationId=I20300010100881398

Without this CL, 1/100 FAIL: https://android-build.googleplex.com/builds/abtd/run/L73700000956982533

Change-Id: Ia9d7746144e9838798332f4eea223a9529551713
2022-10-24 18:09:15 +00:00
Jeremy Sim 0525e3a462 Add transitions to DWB banner when app thumbnail progresses from Overview tile to fullscreen
This patch makes it so that the DWB banner transitions out neatly when a user in Overview drags a tile downward to launch the app. Previously, the banner would stick around throughout the transition, creating visual clutter and drawing attention to the corners of the app.

Fixed by creating an exit transition in setFullscreenProgress(), similar to other UI elements like Overview action chips.

There is another outstanding issue where sometimes the transition can get clipped and jump to the final frame. The cause is still unknown, but issue is tracked at b/250976138 for a future fix.

Fixes: 249825524
Test: Manual
Change-Id: Iea47a9bc643537f0b716ce11b104803d9ca25fd2
2022-10-24 10:47:29 -07:00
Sunny Goyal 0cf401d0eb Merge "Revert "Revert "Updating the scroll calculation from recyclerView to avoid view inflation""" into tm-qpr-dev 2022-10-24 17:38:42 +00:00
Sunny Goyal 8a11443333 Removing unnecessary RemoteAnimationTargetCompat
Merged-In: I12a4c29eaf9bd7d97d3c02074b4cc1ca452fc88a
Bug: 221961069
Test: Presubmit
Change-Id: I12a4c29eaf9bd7d97d3c02074b4cc1ca452fc88a
2022-10-24 17:17:36 +00:00
Schneider Victor-tulias 0130252c00 Remove obsolete cancel recents animation logic
This logic was used as a workaroung for 2-button navigation mode. This mode is now obsolete, however the leftover logic clashes with gesture navigation mode. Removed old logic and unused variables.

Test: manually tapped nav handle, then quickly swipped up
Fixes: 255348258
Change-Id: Ib4e179c0c4d9769acae24f93cfde65d2c7a4dfd9
2022-10-24 10:12:45 -07:00
Mady Mellor b5c2565447 Merge "Hide launcher when freeform tasks are visible" into tm-qpr-dev 2022-10-24 16:04:59 +00:00
Sunny Goyal f34811d3a3 Revert "Revert "Updating the scroll calculation from recyclerView to avoid view inflation""
Test: ABTD
https://android-build.googleplex.com/builds/abtd/run/L52600000956969786

This reverts commit cee6ddf3de.

Reason for revert: Fixed in ag/20239136

Change-Id: I0e8446e66d9a86a94b40fcbd6de14da07abe8e5c
2022-10-22 15:37:47 +00:00
Becky Qiu 4ed3dfc28a [Toast] Use a BaseSearchConfig for launcher3 to read allapps device config.
Bug: 251387263
Test: local
Change-Id: I92c52caff377e627305bc7999ae0205fe6269968
2022-10-21 17:11:38 -07:00
Shan Huang e3279da4fc Merge "DO NOT MERGE Use spring-y progress in back to home animation." into tm-qpr-dev 2022-10-21 23:54:12 +00:00
Shan Huang f31bf4e1e3 DO NOT MERGE Use spring-y progress in back to home animation.
Bug: 241788651
Test: m -j. Visual inspection.

Change-Id: If2b0218367680853ae4ee89c5ecff224ab9b6f04
2022-10-21 22:14:38 +00:00
Ling Wo ac29981a42 Merge "Add enable-suggestion option via TestProcotol so that test can opt-in to show live suggestion" into tm-qpr-dev 2022-10-21 21:44:35 +00:00
Sunny Goyal 64453ae482 Introducing feature flag for optimizing overlay service connection
Bug: 254903450
Test: n/a
Change-Id: I2286be8583cc6dc46921b9ba8ef5505e5b8f0bf8
2022-10-21 14:07:16 -07:00
Vinit Nayak cb26c1a245 Merge "Use updateButtonLayoutSpacing() for all states" into tm-qpr-dev 2022-10-21 20:32:10 +00:00
Federico Baron 0abfda8f2f Rename first page pinned widget to mFirstPagePinnedWidget
mQsb is the name used for the first page pinned widget. This variable name is bad since in some launchers the first page pinned widget is a qsb but sometimes it is a smartspace. Renaming the variable to mFirstPagePinnedWidget is a more accurate name for this variable.

Bug: 251259222
Test: N/A
Change-Id: I6d3c74163995d2267510ee546924917062c4955c
2022-10-21 13:01:24 -07:00
Federico Baron a56f08e677 Set smartspace to 30% visibility on workspace edit for home gardening
Here we set the smartspace to have 30% visibility to follow the guidelines set by https://docs.google.com/presentation/d/1FOmmCdmGmSMR77_901IOMbvbPVxPmjaAdxZjy-D9tw0/edit#slide=id.g159289e55db_0_229

Bug: 251259222
Test: Enter drag mode in workspace with SHOW_HOME_GARDENING flag on to see the changes
Change-Id: Ia2ef4f1a49549fef9f8fbea7c007db8b81972f71
2022-10-21 13:00:58 -07:00
Schneider Victor-tulias ee0bc03d58 Decrease TAPL All Apps scrolling flakiness
scrolling in all apps did not factor in additional top padding in the all apps list recycler. This made it so that apps could occasionally scroll and be obcured by that top padding, making them un-tappable. Added this padding to the scrolling logic to make scrolling less flaky.

Test: TaplTestsTaskbar, TaplTestsLauncher3 and presubmit
Fixes: 248064856
Change-Id: Id76b92b4bc354917f3688ac53673d0ed7a905f02
2022-10-21 12:12:38 -07:00
Sunny Goyal 415fe0c183 Merge "Optimizing some icon generation code:" into tm-qpr-dev 2022-10-21 18:27:54 +00:00
Federico Baron 79cc65d133 Autohide and autoshow pagination in workspace
Added code similar to WorkspacePageIndicator.java in order to autoshow and autohide the pagination in Workspace using PageIndicatorDots.java

Bug: 249773534
Test: Manual
Change-Id: I3b26d929d71510cf2f9d5342ee4c59007b8429cd
2022-10-21 10:55:26 -07:00
Mady Mellor 9a90c2d521 Hide launcher when freeform tasks are visible
This CL introduces a new controller to manage the visibility of the
launcher workspace when desktop mode is active and freeform tasks
are visible.

This controller will be notified when the sysui state flag related
to freeform task visibility is changed.

The controller will modify the workspace visibility as well as
the flags on the activity indicating if it's been paused / resumed
based on freeform tasks being visible or not.

Bug: 245569277
Test: manual -  enable desktop mode and open some freeform tasks
             => observe that the contents of launcher is hidden and
                taskbar shows
             -  remove all of the freeform tasks
             => observe that the contents of launcher reappears along
                with the hotseat.
Change-Id: I378ab97b40cbb954a06f4e2426b195efddad905c
2022-10-21 10:06:54 -07:00
Vinit Nayak 2a2fbfe319 Use updateButtonLayoutSpacing() for all states
* During a merge conflict we prevented
updateButtonLayoutSpacing() from running if device was
in setup mode, however the code that does setup layout
is in there.

Fixes: 254589281
Test: Went through setup, back button shows up
where expected

Change-Id: Ib496bfc0e3ac9023a9fc5071867c3779721ab8ab
2022-10-20 23:11:33 -07:00
Vinit Nayak b9b7c38d55 Merge "Improve TaskMenuView layouts for split pairs" into tm-qpr-dev 2022-10-21 00:07:53 +00:00
Ats Jenk b5b3b054d1 Clicking on desktop tile brings apps to front
Override launchTasks() method from TaskView to ensure we always call
into WMShell to bring desktop apps to front. And don't run single task
animation logic.

Bug: 254738174
Test: manual, enable shell transitions, click on desktop tile in recents
Change-Id: Ibe85cbe14d3378a89ba7bfd5f394f0c3e44f304d
2022-10-20 17:06:47 -07:00
Sukesh Ram c6d4df87f0 Added Tests for Secondary Display Launcher
These UIAutomator tests for secondary display launcher cover app drawer, drag-n-drop functionality, app predictions, pin/unpinning icons, and correct back press behavior.

We are deviating from  go/modify-tapl due to the time constraints of this project as outlined here (https://docs.google.com/document/d/1wLb2h8qCPGur-VsufCH4mLnnuLDLcmMq0FrCo7ichu8/edit#heading=h.brf6af3bno4g).

A preliminary design document has also been created to reference for future TAPL integration (https://docs.google.com/document/d/1H642SSu5DCM_zSXTsvTWumgm3OHIxsKEXvTlTeC4y54/edit?resourcekey=0-M9sTxdyQBi8bUy5cpjmJNA#heading=h.90f2s4sc5ic9).

Before TAPL integration, we need to follow up on test rewrite to eliminate antipatterns in the following bug: b/242776943.

Bug: 241166788
Test: Run Locally, on presubmit, and on a test on a cuttlefish emulator
Change-Id: I556a47b93a7ea3b2583dbc1efd2de7623d820e2a
Merged-In: I556a47b93a7ea3b2583dbc1efd2de7623d820e2a
2022-10-20 22:58:46 +00:00
Brian Isganitis 2bcc3f8599 Merge "Fix crash on long press of prediction row icons" into tm-qpr-dev 2022-10-20 22:54:06 +00:00
Vinit Nayak e690ef7f80 Merge "Scale screenWidth for split proportionally for thumbnail matrix" into tm-qpr-dev 2022-10-20 22:49:57 +00:00
Jeremy Sim 8edca84cd5 Merge "Prevent doubling up on split placeholder insets" into tm-qpr-dev 2022-10-20 20:59:49 +00:00
Sukesh Ram aee55077cc Fix crash on long press of prediction row icons
Changed icon long click listener to use secondary display's long
click listener instead of launcher's.

Bug: 239616635
Test: Manual
Change-Id: I9a4679ba82cacb5e2648481274876dbfc95d80ce
Merged-In: I9a4679ba82cacb5e2648481274876dbfc95d80ce
2022-10-20 18:11:15 +00:00
Brian Isganitis ddbe35cc87 Merge "Drag from appDrawer & pin onto secondary display homescreen" into tm-qpr-dev 2022-10-20 18:08:07 +00:00
Sunny Goyal fc1928e324 Optimizing some icon generation code:
1) Fixing missing shadow from shortcut icons
2) Chaning all-apps icon rendering to draw background/foreground separately
   This allows us to reuse the bitmap generated for themed icons, instead of
   creating a new everytime

Bug: 248308987
Test: Verified on device
Change-Id: Ia3cbefb21a2ce676d6bb2df3d9375d61b5bed61b
2022-10-20 10:40:54 -07:00
TreeHugger Robot 4206239318 Merge "Removing the dependency on LooperExecutor in ViewCapture" into tm-qpr-dev 2022-10-20 16:41:46 +00:00
TreeHugger Robot 26e7dc1789 Merge "Add CUJ_RECENTS_SCROLLING" into tm-qpr-dev 2022-10-20 16:35:52 +00:00
Thales Lima ed8c69baca Make all handheld grids scalable
Also increase the icon size in the XML until the icon is sized correctly.

Fix: 239419094
Bug: 235886078
Test: manual
Change-Id: I0c7d75181a61177cc5993ba7002c3ccc8fd60fbf
2022-10-20 11:51:59 +01:00
Thales Lima a64a914ddf Calculate taskbar content size for edu
Using the value calculated in layout was not working because TaskbarView onLayout() was being called after TaskbarEduView onMeasure(). Now uses the same value on all orientations based on taskbar icon size.

Fixes: 252945031
Test: manual
Change-Id: Ib6914901638c82f3b3ec4c9b86f6c20e84d34d0f
2022-10-20 11:48:06 +01:00
Tony Huang 0fb921ef36 Snapshot 2 tasks when swipe up split case
Swipe up snapshot only capture the top one task, but for split
screen case it should capture two tasks otherwise the snapshot
in overview would be empty in some cases.

Fix: 247420799
Test: manual
Test: pass existing tests
Change-Id: I3acd477eaca3cb98d86e2446dbb2dbd6295c687d
2022-10-20 14:10:06 +08:00