Commit Graph

49755 Commits

Author SHA1 Message Date
Sunny Goyal 276e72c249 Merge "Fixing flakyness in widget tests" into tm-qpr-dev 2022-10-31 16:23:08 +00:00
Holly Jiuyu Sun 35b0378d45 Merge "[QL-v2] Use subtitle as hint if title doesn't apply." into tm-qpr-dev 2022-10-28 19:35:33 +00:00
Sunny Goyal 1d76159de4 Fixing flakyness in widget tests
For some predicted app widgets, the layout happens before the recyclerView
can layout completely (because of preview layout invalidation), causing the
scroll cache to get in a wrong state.
Checking for scroll cache validity everytime instead of only during
data changes

Bug: 255797215
Test: Verified by hardcoing the chrome widget as predicted widget
Change-Id: Id2c68560baa45de89e08c53bdb9ee6820eab68c4
2022-10-28 12:25:04 -07:00
Sebastian Franco 53a15a4b1f Decoupling finding the solution and animation of a reorder in CellLayout
Adding new functions to CellLayout, two of them return a solution
(calculateReorder, getSimpleReorder) and the other one takes a
solution and animates that solution (void performReorder) and it can
either submit the solution or just show it for a preview.

Right now this two things are done under the same function:
int[] performReorder. The need to separate this two functions is
because to add this functionality b/188081026 which needs to find
soluion without animation and animation solutions that can be
calculated in another place.

Bug: 188081026
Test: atest ReorderWidgets
Change-Id: Ib519d4346f58f9b55aff5008cd3ccbcfe8443d2d
2022-10-28 11:55:50 -07:00
Alex Chau 945c312eb7 Set autoSizeMaxTextSize for digital wellbeing toast
Fix: 253970740
Test: Enable app timer with normal display size and font size
Test: Enable app timer with largest display size and font size
Change-Id: I9a795dcf709a15c6e2c0eb24e31f09c84ea8eb2e
2022-10-28 16:03:24 +01:00
Jeremy Sim 570ddadcf9 Change tablet split confirm timing slightly
This patch changes the split confirm animation on tablets to 500ms. Based on UX discussion at b/241126570.

Fixes: 241126570
Test: Manual
Change-Id: I1de0e0f8882db059de09685f7756343d8a387b4f
2022-10-27 16:43:07 -07:00
Jeremy Sim 4972822c60 Merge "Add transitions to DWB banner when app thumbnail progresses from Overview tile to fullscreen" into tm-qpr-dev 2022-10-27 23:38:31 +00:00
Holly Sun 4d6fa05c83 Log sub event type to latency logger.
Bug: 255355348
Test: build
Change-Id: Idac85b5e31e2abdd98f6fd1bed4ec687d8bb5cd5
2022-10-27 16:37:18 -07:00
Vinit Nayak 21d8230b90 Prevent rotating TaskMenuViewWithArrow for large screen
* Only attempt to rotate TaskMenuView on
fake rotation

Fixes: 254198019
Test: Rotation on large screen w/ TaskMenu open doesn't
crash

Change-Id: If8ae8c018e9cc8cb80a2ec3313f5e8d0fda2e148
2022-10-27 22:03:00 +00:00
Sebastian Franco 285b749bcf Wait in ReorderWidgets test for the workapce to load after changing it.
Fix: 252860608
Test: atest ReorderWidgets
Change-Id: Idf99188837a475d0327174e264ab1d23d646d75d
2022-10-27 14:42:19 -07:00
Federico Baron 626d51c68c Move DropTargetBar to bottom
The DropTargetBar has "Remove" and "Uninstall" buttons for workspace edit mode. We are moving them to the bottom for workspace home gardening

Bug: 251259222
Test: Turn on flag HOME_GARDENING_WORKSPACE_BUTTONS and enter spring loaded mode (edit workspace), notice the buttons are now at the bottom
Change-Id: I739162bdd5764dd8367a63a67fae0fe5c7329b0a
2022-10-27 14:18:00 -07:00
Jon Miranda 0c1714bb45 Merge "Only draw transient taskbar background for transient taskbar" into tm-qpr-dev 2022-10-27 20:42:21 +00:00
Holly Sun 786bdce214 [QL-v2] Add logging for quick launch.
Move logging to DeviceSearchAdapterProvider to take advantage of View so we can log more info attached to the quick launch event. Another reason is currently we can't dynamically change the enter key icon so we can't really distinguish whether it's a quick search or quick launch using the icon (we are working with gboard team to fix this issue).

Bug: 256010819
Test: see wwlogging https://paste.googleplex.com/5668268562972672
Change-Id: I38aad2ae97c9b372f3d76222a82de45fc3bf3eed
2022-10-27 13:18:19 -07:00
Sihua Ma 17137e8bce Merge "Created LauncherWidgetHolder as a wrapper for LauncherAppWidgetHost" into tm-qpr-dev 2022-10-27 17:53:28 +00:00
Jon Miranda f80b5f50a3 Only draw transient taskbar background for transient taskbar
Bug: 252905206
Fix: 255925607
Test: disable flag, view taskbar
Change-Id: I1734fa238e3c07f5da6a03659c1079eb1b6b7277
2022-10-27 15:27:38 +00:00
Alex Chau b3ab6f5014 Merge "Update pullback animation to use reset FloatProperty for non-active state" into tm-qpr-dev 2022-10-27 12:38:15 +00:00
Luca Zuccarini 05d19dc261 Make sure that PropertySetter applies the final state.
In some tests with animations disabled, NO_ANIM_PROPERTY_SETTER wasn't
applying the correct final value. See ag/20139786 for more context.

Bug: 251769927
Test: see other CL in topic, plus manual
Change-Id: I296de1a0d64768c43608839745cc7e955ecd2076
2022-10-27 09:31:57 +00:00
Johannes Gallmann 989ffba0ec Merge "Extracting ViewCapture into common Library" into tm-qpr-dev 2022-10-27 07:30:11 +00:00
Saumya Prakash 5db9942c61 Merge "Revert "Removed disabled overview actions at end of scroll"" into tm-qpr-dev 2022-10-26 22:10:39 +00:00
Saumya Prakash 19250d69f7 Revert "Removed disabled overview actions at end of scroll"
This reverts commit 96cad794d7.

Reason for revert: Breaks build test_suites_x86_64_coverage (linux) build 9222442 in git_tm-qpr-dev. 

Change-Id: I482f526da169505cf5d3f42ef999303dcc162a1f
2022-10-26 20:59:30 +00:00
Becky Qiu 6a2dd438da Merge "[Toast] Use a BaseSearchConfig for launcher3 to read allapps device config." into tm-qpr-dev 2022-10-26 20:33:05 +00:00
Saumya Prakash f1a4121784 Merge "Removed disabled overview actions at end of scroll" into tm-qpr-dev 2022-10-26 20:31:44 +00:00
Jon Miranda f3a59b59f4 Add app window thresholds for transient taskbar.
- Threshold to move app window
- Threshold to reach home/overview
- Threshold for window to catch up to finger

Bug: 252905206
Test: manual
Change-Id: I71082fab07a0227d64ce6ed66cbfa3c1ffb319f5
2022-10-26 13:02:04 -07:00
Ats Jenk d98c88b4e0 Merge "Set launcher state to NORMAL when entering desktop" into tm-qpr-dev 2022-10-26 18:58:05 +00:00
Sihua Ma e53245fbc7 Merge "Correctly show the widget in the recommendation table" into tm-qpr-dev 2022-10-26 18:19:23 +00:00
Schneider Victor-tulias d7778831c5 Improve RecentsModel log dump for ease-of-use and readability.
Test: launched several apps, switched between apps and dumped logs
Bug: 255147097
Change-Id: I6319d7027ece9e3f244ebb6a82b260724f94096b
2022-10-26 11:01:26 -07:00
Sihua Ma 0593a0d3ec Created LauncherWidgetHolder as a wrapper for LauncherAppWidgetHost
The wrapper class is created for further changes that will run the wrapped host in the background.

Test: N/A
Bug: 235358918
Change-Id: I9bd6fc2749c5d4a4d3391fb75d0c3ff1e13d17bf
2022-10-26 10:57:13 -07:00
Ats Jenk f7474fa9a0 Merge "Screenshot freeform task when going to overview" into tm-qpr-dev 2022-10-26 17:01:08 +00:00
Sebastián Franco a4798b5687 Merge "Revert "Prevent double touch inputs in the BaseDragLayer"" into tm-qpr-dev 2022-10-26 16:42:12 +00:00
Thales Lima 3a63fca303 Merge "Make all handheld grids scalable" into tm-qpr-dev 2022-10-26 16:28:08 +00:00
Sunny Goyal dd3d50d76a Merge "Introducing feature flag for optimizing overlay service connection" into tm-qpr-dev 2022-10-26 16:24:16 +00:00
Alex Chau ee6a99b798 Update pullback animation to use reset FloatProperty for non-active state
Fix: 246733229
Test: Change display between phone and tablet, use home gesture in AllApps
Change-Id: I20bdef9dcf9a60475f482261501ad39106b8b107
2022-10-26 16:03:15 +01:00
Jon Miranda 661f38cdb8 Merge "Add transient taskbar UI" into tm-qpr-dev 2022-10-26 14:56:15 +00:00
Alex Chau f7abb69d0b Merge "Auto resize digital wellbeing toast" into tm-qpr-dev 2022-10-26 13:52:58 +00:00
Alex Chau a2ad627607 Merge "Improve All Set page UI for large screens" into tm-qpr-dev 2022-10-26 13:10:45 +00:00
Johannes Gallmann 6518efce73 Extracting ViewCapture into common Library
The ViewCapture functionality is extracted into a common Library accessible to the Launcher and SystemUi modules.

Test: None yet
Change-Id: I4be394ed8dc86e30f6b8c69c438b8bc943e7907c
2022-10-26 12:29:30 +00:00
Merissa Mitchell e7b6888a36 Merge "Move AllAppsButton placement for desktop environment." into tm-qpr-dev 2022-10-26 03:17:01 +00:00
Ats Jenk 7963c1d051 Set launcher state to NORMAL when entering desktop
When clicking on desktop tile, we need to explicitly move launcher state
to NORMAL. Freeform apps float on top of launcher and launcher remains
visible in the background. When on desktop, launcher should be in normal
state, with icons and widgets hidden. Hiding of the icons etc is handled
already by DesktopVisibilityController.

TODO:
 - need to fix home screen icons flicker, can be solved with new
   launcher state (b/255649902)

Bug: 244348395
Test: manual, click on desktop tile in overview, observe freeform apps
brought to front and overview closes

Change-Id: I214b0d6b622e673e0b0cb82f84b2080b479a7fb9
2022-10-25 18:02:05 -07:00
Ats Jenk ff9b36762a Screenshot freeform task when going to overview
When freeform tasks are visible in desktop mode, capture a screenshot of
the tasks when opening overview.
Also use RecentsView instead of RecentsAnimationController when
finishing the recents animation. RecentsView.finishRecentsAnimation
method has an extra call to onRecentsAnimationComplete() which ensures
that screenshot does got used.

Bug: 244348395
Test: manual, open freeform task, swipe up to go overview, observe a
screenshot of the task

Change-Id: I066b25ec7ae25d1e09aba0ff0a379d35bbe2b636
2022-10-25 16:51:00 -07:00
Sebastián Franco 7d4176bf73 Revert "Prevent double touch inputs in the BaseDragLayer"
This reverts commit 68fc44ffad.

Reason for revert: Wrong handling of events

Change-Id: Ic34916123ed6c4ba33f629549dda2cdbc890b413
2022-10-25 22:35:34 +00:00
Federico Baron a184511bb4 Add dot pagination in workspace
Here we add dot pagination (the same as the one in folders) to the workspace.

Bug: 254769710
Test: Turn on the flag SHOW_DOT_PAGINATION and check out the workspace
Change-Id: Ia1e9ec78eae661aa5e7c37b2b2f1ded38b138ce8
2022-10-25 15:14:37 -07:00
Sihua Ma a28182d9c6 Correctly show the widget in the recommendation table
Test: Manual
Bug: 246121954
Change-Id: Ib32a20683b3dc456417549284744642ad451a829
2022-10-25 14:40:02 -07:00
Sunny Goyal 3912808183 Merge "Merging MultiValueAlpha with MultiPropertyFactory" into tm-qpr-dev 2022-10-25 21:39:11 +00:00
Merissa Tan fcb9cb7664 Move AllAppsButton placement for desktop environment.
On desktop environment, we want the AllAppsButton to be on the left side
of the taskbar instead of the hotseat, but retain the functionality of
the button.

Bug: 251372204
Test: Manual
Change-Id: Ia2c95a20583cb98785ab6f8c719559d93982c06f
2022-10-25 14:26:07 -07:00
Jon Miranda 184a04266d Add transient taskbar UI
This change is only for the visual appearance of the
transient taskbar.

Bug: 252905206
Test: manual
Change-Id: I4990b20b39089a0c27ec2a72dd3010cf64ddba1d
2022-10-25 13:46:19 -07:00
Federico Baron 7c70ba3ede Merge "Add new flag for dot pagination" into tm-qpr-dev 2022-10-25 20:37:52 +00:00
Federico Baron 7382883ee6 Merge changes If1a00ac6,I5b233070 into tm-qpr-dev
* changes:
  Hide QSB (toast) when editing workspace
  Add flag for moving the workspace edit buttons to bottom
2022-10-25 20:27:47 +00:00
Federico Baron f834cfe954 Merge "Autohide and autoshow pagination in workspace" into tm-qpr-dev 2022-10-25 19:44:35 +00:00
Federico Baron cfa0f833f6 Add new flag for dot pagination
Here we add a flag for adding the dot pagination (same as currently in folders) to workspace

Bug: 254769710
Test: N/A
Change-Id: Id5fc33f61b9814f73afea8c5119c7d8d4ee24756
2022-10-25 18:00:03 +00:00
Holly Jiuyu Sun 381ba3319d Merge "Log a-z apps count." into tm-qpr-dev 2022-10-25 17:50:19 +00:00