Commit Graph

53916 Commits

Author SHA1 Message Date
Yein Jo dc1b3660fe Migrate Launcher to use the new OnBackInvokedCallback
Bug: b/238475344
Test: Tapl & manual
Change-Id: Ieab329873f82890d95136e490086cc2cffff7ba8
2022-09-14 19:45:41 +00:00
Vinit Nayak 7fb4f997c4 Add metrics sources for split invocation
* See design doc in bug description for
usage/details

Bug: 231369744
Change-Id: I0c0ec11e924e387c523b5ac5feb7cabf78eaa748
2022-09-14 11:58:03 -07:00
Schneider Victor-tulias 86b01d948e Merge "Add onTaskAppeared error detection." into tm-qpr-dev am: 56c92899f1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19936975

Change-Id: I9a176f1a4a8cac5d1e70a55aaf7e118ec08c3946
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-14 18:09:00 +00:00
Schneider Victor-tulias 56c92899f1 Merge "Add onTaskAppeared error detection." into tm-qpr-dev 2022-09-14 17:39:27 +00:00
Winson Chung 3f649ef892 Update Launcher for removed shared wrappers
- Launcher can reference system code directly now

Bug: 219861883
Test: Builds/Presubmit
Change-Id: I3f656b6c7fce93243ccb7591e52441e99137dec6
Merged-In: I3f656b6c7fce93243ccb7591e52441e99137dec6
2022-09-14 17:14:32 +00:00
Tony Huang 3fc57cb50a Fix split divider flash if swipe again quickly
This bug caused by divider will be set to show when animation
cancelled, because split screen will show divider itself when
both split visible, this call might be unnecessary. Fix it by
removing these lines.

Add surface valid checking when running divider animation to
avoid crash caused if surface was released during animation.

Fix: 242823773
Bug: 246371786
Test: manual
Test: pass existing tests
Change-Id: I10aaf86e4164327b1c6c2f323c62b246c600228a
2022-09-14 15:37:02 +08:00
Becky Qiu ff057e9b43 Merge "[Toast] Switch to use a device config instead of feature flag for appSearch." into tm-qpr-dev am: 1c8e630381
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19902946

Change-Id: I97fbcfebd39dea513943bf12eaa54f2cf3f0783f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-14 07:16:12 +00:00
Becky Qiu 1c8e630381 Merge "[Toast] Switch to use a device config instead of feature flag for appSearch." into tm-qpr-dev 2022-09-14 06:53:49 +00:00
Sunny Goyal bb2c85a3eb Using Transaction directly instead of building surface params am: fd2c9eb04e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19933596

Change-Id: I5441961aaae960333dbddd6585568412a88f52a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-14 04:28:16 +00:00
Android Build Coastguard Worker 97b8b52d17 Snap for 9058783 from 3ded296cee to tm-qpr1-release
Change-Id: I23768ef8470554d6e77290c4fb03fa1f22f4b887
2022-09-13 23:25:45 +00:00
Sebastian Franco 749b2b8493 Prevent dragging widgets to another page in tests when starting a drag.
The function Launchable.startDrag it's supposed to grab and icon or widget
and start the dragging by moving it only in the verticall position but
because it uses the coordinates of the object before entering the
SPRING_LOADED_STATE_ORDINAL state then the coordiates where it moves
are outisde of the cell layout and it moves to a new page. This only happens
if the phone is too slow and it triggers the page change, otherwise it would
be too fast.

To fix it, I'm moving the icon/widget to the center of the screen minus
getStartDragThreshold() to ensure the drag is always triggered.

Fix: 242323136
Fix: 244224955
Fix: 241019568
Fix: 241583798
Test: atest ReorderWidgets
Change-Id: I0e431b994aa4a3d5c8be45b6c73263732553b36c
2022-09-13 15:54:58 -07:00
Schneider Victor-tulias 350ebd8f5c Update ActiveGestureLog to print logs from oldest to newest
Fixes: 227514916
Test: completed several gestures and checked the logs
Change-Id: I8dca4a75c46f7324684a3ba297d1946105825fa6
2022-09-13 15:33:55 -07:00
Schneider Victor-tulias 56fc942e48 Add onTaskAppeared error detection.
Bug: 246340474
Test: used several gestures normally, and reproduced b/246340474, then checked logs
Change-Id: I8cdcb9c00c5cacc7737e796dbf5adf544c0220a7
2022-09-13 15:31:06 -07:00
Sunny Goyal fd2c9eb04e Using Transaction directly instead of building surface params
Bug: 221961069
Test: Presubmit
Change-Id: I31123dff78de513addd0c851403af9097686c46e
2022-09-13 22:26:42 +00:00
Tracy Zhou de315c24d8 Merge "Fix subsequent tabbing in recents from alt tab not working" into tm-qpr-dev am: 39d9eb819c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19938037

Change-Id: I0947061c88148842e2a508fea76d611a1bc84f3e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 21:28:14 +00:00
Tracy Zhou 39d9eb819c Merge "Fix subsequent tabbing in recents from alt tab not working" into tm-qpr-dev 2022-09-13 21:06:26 +00:00
TreeHugger Robot d675769721 Merge "Add error detection for aborting the recents scrolling during transition to home" into tm-qpr-dev am: 839297e232
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19873684

Change-Id: I13328c033aec5653cf82529c4823e84df8c92592
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 20:25:50 +00:00
Vinit Nayak 2e39049bdf Update secondary task menu check to explicitly check for phone
* Non grid check technically also returns
false for secondary app icon on focused task

Test: Open app menu in small and large screen

Bug: 245610772
Change-Id: Icf70c1893aba6a4a79bf51e98ac33c1d204c73c2
2022-09-13 13:22:51 -07:00
TreeHugger Robot 9c43626a36 Merge "Change wallpaper depth in widget picker" into tm-qpr-dev am: 3ded296cee
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19852193

Change-Id: I544623f2c67f846ac5e76bdb520750b5d4cdce2c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 20:15:13 +00:00
TreeHugger Robot 839297e232 Merge "Add error detection for aborting the recents scrolling during transition to home" into tm-qpr-dev 2022-09-13 19:49:44 +00:00
Becky Qiu cdac570298 [Toast] Switch to use a device config instead of feature flag for appSearch.
Bug: 241001264
Test: local
Change-Id: I47416b07a62379ab5c2c17b3b769c8bc8b2ef106
2022-09-13 12:26:42 -07:00
TreeHugger Robot 3ded296cee Merge "Change wallpaper depth in widget picker" into tm-qpr-dev 2022-09-13 18:46:53 +00:00
TreeHugger Robot 93d74aa41a Merge "Removing UiThreadHelper and moving code to corresponding classes" into tm-qpr-dev am: 22af7c2e7e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19931705

Change-Id: I6d342c9d59e94dc61b393bd53e84e417ccc81782
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 18:20:02 +00:00
Tracy Zhou d0f4896c11 Fix subsequent tabbing in recents from alt tab not working
Fix: 242114350
Test: Alt+tab to go to overview, and then keep tabbing to switch to the previous tasks

Change-Id: I03db23aa5424e46c0eb783379b0c5e959f75507f
2022-09-13 11:01:57 -07:00
TreeHugger Robot 22af7c2e7e Merge "Removing UiThreadHelper and moving code to corresponding classes" into tm-qpr-dev 2022-09-13 17:57:44 +00:00
Sebastián Franco 1163c5ea7a Merge "Add hotseat icons to TestWorkspaceBuilder and submit everything in a batch" into tm-qpr-dev am: 5587ef3262
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19759371

Change-Id: Ib2dcd7701e75c6c5d4ad3736859f67e473f7d843
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 17:23:46 +00:00
Sebastián Franco 5587ef3262 Merge "Add hotseat icons to TestWorkspaceBuilder and submit everything in a batch" into tm-qpr-dev 2022-09-13 16:53:36 +00:00
TreeHugger Robot 4917fbc846 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev am: 1b79d95ca2 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19923818

Change-Id: Ib48514dcee8592b4ce1fffed70433de163a7ddb8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 09:23:03 +00:00
Bill Yi a1a6a21309 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: b1360ad0d9 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19923818

Change-Id: Ic39822c1c414db9bbdb552315537aa10f62830ab
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 09:22:51 +00:00
TreeHugger Robot 1b79d95ca2 Merge "Import translations. DO NOT MERGE ANYWHERE" into tm-qpr-dev 2022-09-13 08:31:32 +00:00
Winson Chung 240b064cdb Fix case of gesture being stuck when the Launcher is stopped mid-gesture
- In rare cases, Launcher may be stopped mid-swipe up gesture which results
  in two issues:

  - it continues to register a page transition end callback, but because
    launcher is not drawing, the page will never scroll and the callback
    never happens
  - in the case where the calculated end target is RECENTS, we don't
    finish the recents animation (because of live tile), and since it's
    still running, subsequent gestures are interpreted as continuing the
    current gesture and it gets stuck

  Instead in these cases we can force the gesture to resolve to LAST_TASK
  (similar to the canceled gesture case), and not wait for the page to
  settle.

  Note, that we would prefer to fix the root issue of Launcher being
  stopped, but at least this change prevents Launcher from getting into
  the wrong state if so.

Bug: 246476942
Test: Repro steps from the bug
Change-Id: I59098229e5e37722e8017a2dfcb42eab6659643d
2022-09-13 06:59:34 +00:00
Alex Chau 3d2c062567 Change wallpaper depth in widget picker
- Also changed widget picker open/close duration, refactored the values into DeviceProfile
- Generalized MultiAdditivePropertyFactory to accept aggregator as parameter

Bug: 240580498
Test: manual
Change-Id: I6886ca514593e404b8d7b0e8ed44f20ec2b77c73
2022-09-13 12:20:56 +08:00
Andy Wickham 369c6e8be7 Reduces vertical padding of predicted apps in All Apps.
Rather than using the full allAppsCellHeight, manually construct
the icon + padding + text and add custom padding (8dp).

Screenshots: https://drive.google.com/drive/folders/1hgEE72PaTj60SxgfPUzQ8hGwnCOWx-Lp?resourcekey=0-TgrHKITyzIXmNAAMYpA_MA&usp=sharing

Fix: 242915342
Test: Manual inspection
Change-Id: Ic566e0f7ea7cf486054bb8fe2429ee5c53e8b174
2022-09-12 18:34:14 -07:00
Bill Yi 90e1d38fd3 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 3600979da3 -s ours am: 771a57009d -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19923819

Change-Id: Ibdbaa26bd5044b40abbe7dad6acc8baec41025b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 01:22:57 +00:00
Becky Qiu d91561558d Merge "[Toast] Add a debug log config for app search flow." into tm-qpr-dev am: a7be354913
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19890488

Change-Id: I4c5adf006ebf9c4707148a208b2c0208f04efdf5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 01:02:54 +00:00
Bill Yi ea6c8dfa2c [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 3600979da3 -s ours am: f58790063d -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19923819

Change-Id: Ie9a419cd9ea9e52a5463edf1c879a890cada085f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 00:52:34 +00:00
Bill Yi 771a57009d [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 3600979da3 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19923819

Change-Id: I0e3ecc35d906ec049a744d60a903825a19d9328a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 00:40:31 +00:00
Becky Qiu a7be354913 Merge "[Toast] Add a debug log config for app search flow." into tm-qpr-dev 2022-09-13 00:33:26 +00:00
Bill Yi f58790063d [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 3600979da3 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19923819

Change-Id: I534816600fbcfef59adb17cfe5103ec10e499c3b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-13 00:26:42 +00:00
Android Build Coastguard Worker fb59aa0c3b Snap for 9053530 from d581f40b30 to tm-qpr1-release
Change-Id: I3b6270f50cc77094c6a9f86b649d00ba5b555362
2022-09-12 23:29:11 +00:00
Sunny Goyal 42beb544e9 Removing UiThreadHelper and moving code to corresponding classes
This allows for better code organization based on the code logic

Bug: 246382466
Test: Presubmit
Change-Id: I6148143a60afdd917a11587e327f5e8a4d7def9e
2022-09-12 22:14:15 +00:00
TreeHugger Robot e6f7559b8c Merge "Removing some unused code:" into tm-qpr-dev am: d581f40b30
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19914949

Change-Id: I176ca6e8d2cd780f9e470693a83908f90047e21e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 19:59:54 +00:00
Brandon Dayauon 27b479a29b Merge "Work toggle button staying at the top when moving keyboard down" into tm-qpr-dev am: f17c581165
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19914917

Change-Id: Ibeb53734770b3a854cb209e838fe06a6d3581ecd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 19:59:44 +00:00
TreeHugger Robot 8563855387 Merge "Run animation for liveTile before trying to launch it" into tm-qpr-dev am: 7d8ba14b3c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19890490

Change-Id: Ia6a7f74c9a7ede2a41164fe68a271e94dcb7b724
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 19:59:16 +00:00
Vinit Nayak 1f97ccf5e2 Merge "Place TaskMenuView aligned with secondary split thumbnail" into tm-qpr-dev am: f5e5c8e1ce
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19912686

Change-Id: I40fbd2314fc02db46682e99057c365bae3973e19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 19:58:44 +00:00
Sunny Goyal 20bbe95ddb Updating the scroll calculation from recyclerView to avoid view inflation
> Updating the LayoutManager's scroll calculation instead of a separate
  implementation to better support recyclerView's calculations
> Caching the view sizes during layout to avoid view-inflation for
  unknown types
> Fixing scrollbar jump during scroll when widget list is expanded
> Fixing scrollbar never reaching end when onboarding card is displayed
  in work tab

Bug: 240343082
Test: Verified on device that new views are not inflated
Change-Id: Ied11ccf65b053691c5c126c4bf8de306ec24786d
2022-09-12 12:24:34 -07:00
TreeHugger Robot d581f40b30 Merge "Removing some unused code:" into tm-qpr-dev 2022-09-12 19:24:20 +00:00
Brandon Dayauon f17c581165 Merge "Work toggle button staying at the top when moving keyboard down" into tm-qpr-dev 2022-09-12 19:15:20 +00:00
TreeHugger Robot 7d8ba14b3c Merge "Run animation for liveTile before trying to launch it" into tm-qpr-dev 2022-09-12 18:30:47 +00:00
Vinit Nayak f5e5c8e1ce Merge "Place TaskMenuView aligned with secondary split thumbnail" into tm-qpr-dev 2022-09-12 18:29:22 +00:00