Commit Graph

53916 Commits

Author SHA1 Message Date
Sebastian Franco 5434c9d370 Add hotseat icons to TestWorkspaceBuilder and submit everything in a batch
Now TestWorkspaceBuilder has the logic to add hotseat icons and
the operations to add items to the Workspace is done in batches
which is faster and more stable. To submit everything in batches
it uses the FavoriteItemsTransaction.

This improves the design because TestWorkspaceBuilder and
HomeScreenImageTest belong to the Test layer and they should
only deal with the logic to run a test and TestWorkspaceBuilder
is the Model layer and holds all the logic to interact with the
Launcher model/data, so this separates the concern of each class.

Also, chagned the name from CellLayoutBoardBuilder to
TestWorkspaceBuilder to make it clearer.

Bug: 243440737
Bug: 235518637
Bug: 242323136
Test: atest HomeScreenImageTest
Test: atest ReorderWidgets
Change-Id: I14eef064fade153b8362537743b061958bb3071d
2022-09-12 10:54:53 -07:00
Sunny Goyal 5145e474d6 Merge "Removing back-button alpha animation code" into tm-qpr-dev am: 676d19c171
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19915471

Change-Id: I2958d9cd87323c5a3934904120d550fbb2d2f411
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-12 17:16:38 +00:00
Sunny Goyal 676d19c171 Merge "Removing back-button alpha animation code" into tm-qpr-dev 2022-09-12 16:04:34 +00:00
Luca Zuccarini ce03c9972b Fix issue with keyboard disappearing too late.
This seems to have been caused by a bad merge which removed the call
from outside the end listener. We reintroduce it for atomic animations
only, as for manual ones we want the keyboard to animate in sync with
All Apps (note that this is how it used to be, and doesn't depend on the
keyboard sync flag).

Fixes: 243632287
Fixes: 240116666
Test: manual
Change-Id: I9d226a4bd7cbde0692ae82b5a138b0d523fd5f25
2022-09-12 11:01:31 +00:00
Android Build Coastguard Worker 85b5ef43f7 Snap for 9050073 from 30c3552e7e to tm-qpr1-release
Change-Id: Icce95a4472b89d983e84a0c1f391ffb5dcfa1de7
2022-09-12 01:25:26 +00:00
Bill Yi 3600979da3 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1b516c078cb6441705244d00210475a372fba4e7
2022-09-11 14:57:09 -07:00
Bill Yi b1360ad0d9 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I8e28cc8f62473fe165827b1c92c566b3ad4f1e0b
2022-09-11 14:56:37 -07:00
Android Build Coastguard Worker 470e87dbe0 Snap for 9050009 from 69b9e736a8 to tm-qpr1-release
Change-Id: I695e33602c1ad09edb6ebeeb32e1e73c749b52cf
2022-09-10 21:24:53 +00:00
Qing Wang 46320961b9 Add tests to Launcher P0 CUJ Homescreen navigation via TAPL. am: 30c3552e7e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19773679

Change-Id: Ic6c93ba67f635f6523487848665569e67d83c990
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-10 20:08:27 +00:00
Qing Wang 30c3552e7e Add tests to Launcher P0 CUJ Homescreen navigation via TAPL.
1. Implement API to help to get page count.
2. Add test add and delete page.

Bug: 241685418
Bug: 232584721
Test: android.platform.test.scenario.launcher.integration_tests.ScreenNavigationTests#testAddAndDeletePageAndFling
Change-Id: I2e04b9ef1f2ca65ba14d6939b7b51fead6b6f6ca
2022-09-10 17:46:24 +00:00
TreeHugger Robot 81209bb59f Merge "Simplifying hideKeyboardAsync method" into tm-qpr-dev am: 69b9e736a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19914922

Change-Id: I42ce34aed46e52caa44246c9d026c3334948f79e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-10 05:25:36 +00:00
TreeHugger Robot 69b9e736a8 Merge "Simplifying hideKeyboardAsync method" into tm-qpr-dev 2022-09-10 05:03:23 +00:00
Sunny Goyal 8958a7078a Simplifying hideKeyboardAsync method
Bug: 246000321
Test: Presubmit
Change-Id: I2851c49b61b662d4a5b7cd0a863f690fd74a8bd0
Merged-In: I2851c49b61b662d4a5b7cd0a863f690fd74a8bd0
2022-09-10 04:01:48 +00:00
TreeHugger Robot be89a7dec5 Merge "Support for animating A-Z <-> Search." into tm-qpr-dev am: 1c22b7e57c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19629606

Change-Id: I929445576fd355da24385d95221a529be7fbf5d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-10 01:30:17 +00:00
Android Build Coastguard Worker 518a7b15bb Snap for 9048375 from 5d7aec8e03 to tm-qpr1-release
Change-Id: Ia87b6ab8c70ce96760b26e347228deb01ce99d84
2022-09-10 01:26:07 +00:00
TreeHugger Robot 1c22b7e57c Merge "Support for animating A-Z <-> Search." into tm-qpr-dev 2022-09-10 01:11:36 +00:00
Sunny Goyal 1eb1124d82 Removing back-button alpha animation code
Back button is only animation in 2-button UI which is not supported anymore

Bug: 246006580
Test: Presubmit
Change-Id: I7385b07272e44c1f9f0488c158e1b4ee67060120
2022-09-09 17:15:24 -07:00
Sunny Goyal eb018d8004 Removing some unused code:
> intrinsicIconScaleFactor is no longer read
> We no longer generatepreview outline for drag

Bug: 245997823
Test: Presubmit
Change-Id: I17ed25239d0affe89482da3406d529d323a426d9
2022-09-09 16:02:13 -07:00
Andy Wickham 94d5d3cb6c Support for animating A-Z <-> Search.
Demo videos (1/5 speed) and APK: https://drive.google.com/drive/folders/1qQNzcoibiFMzxYhvXc7UEHCaBhJg6SjN?resourcekey=0-OWD06iLXg3wf_eWce4rUPA&usp=sharing

Bug: 234882587
Bug: 243688989
Test: Manually tested a bunch of cases at 1/10 animation speed.
Such as work profile or not, suggested apps enabled/disabled,
typing during the animation, going back during the animation,
web results injected above apps, etc.

Change-Id: Id4f1a858d387bf3a7f9cf2d23564a276544abef1
2022-09-09 15:37:57 -07:00
Sebastián Franco 732ade12de Merge "Adding specific case for applications in getEntryMigrationId" into tm-qpr-dev am: b64894b095
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19788609

Change-Id: I0d295a927ca0137325e6eba8780508d872098d32
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-09 22:14:23 +00:00
Brandon Dayauon fa6011fcdf Work toggle button staying at the top when moving keyboard down
- Same fix from implementation when implementing extendedFAB. ag/19223926
- Essentiall remove isEnabled() check since it is not needed
bug: 235873194
test: Manual - before: https://drive.google.com/file/d/1JjDSudWS56fiDyMnP8Btvy0pWFyUIXND/view?usp=sharing
after: https://drive.google.com/file/d/1Ja-OVpXKK1yUrixpU_V6WsLV0Ryw152w/view?usp=sharing

Change-Id: Ibca405deccfcd61845dd4f5952ad196af1ab3fe2
2022-09-09 15:04:42 -07:00
Sebastián Franco b64894b095 Merge "Adding specific case for applications in getEntryMigrationId" into tm-qpr-dev 2022-09-09 21:50:52 +00:00
Brandon Dayauon f52626345e Merge "Added extra check to CLI command that was not checked for" into tm-qpr-dev am: 5d7aec8e03
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19801569

Change-Id: I105db267b74f0279c43722a7e596b4d1b77e80c6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-09 21:16:01 +00:00
Brandon Dayauon 5d7aec8e03 Merge "Added extra check to CLI command that was not checked for" into tm-qpr-dev 2022-09-09 20:53:14 +00:00
TreeHugger Robot 54a7e01a9b Merge "Introduce KeyboardStateManager to maintain keyboardstate as show or hide." into tm-qpr-dev am: d0aba60767
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19422976

Change-Id: Ie53404e533489591ced1c258c24ac5d780bf7bd7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-09 20:33:01 +00:00
Becky Qiu 431aed846e [Toast] Add a debug log config for app search flow.
Bug: 241001264
Test: manual
Change-Id: Ifb102477278f41ebf51d736cf6f0114dadcb94ce
2022-09-09 13:19:21 -07:00
TreeHugger Robot d0aba60767 Merge "Introduce KeyboardStateManager to maintain keyboardstate as show or hide." into tm-qpr-dev 2022-09-09 20:10:37 +00:00
Hui Kang f6142422af Merge "Add launch assistant method." into tm-qpr-dev am: 0b44854718
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19822904

Change-Id: I3770f6e904abf8507e47b62470540eb0e102ca3e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-09 18:25:19 +00:00
Vinit Nayak 2e4dcb16a7 Place TaskMenuView aligned with secondary split thumbnail
* Use consistent divider calculations in
different methods

Fixes: 245610772
Fixes: 218784487

Test: Open task menu view in split pair in landscape/
seascape/portrait, real and fake.

Change-Id: If1bbc7a0d4f1767584d0fc8cf549130f35b8e4a3
2022-09-09 11:25:08 -07:00
Hui Kang 0b44854718 Merge "Add launch assistant method." into tm-qpr-dev 2022-09-09 17:53:06 +00:00
Winson Chung ec981ec589 Merge "Fix missing call to super cancel method" into tm-qpr-dev am: 607a976635
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19900948

Change-Id: I28f5459745388bd5b6714a993ea95a68cff09159
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-09 16:49:53 +00:00
Winson Chung 607a976635 Merge "Fix missing call to super cancel method" into tm-qpr-dev 2022-09-09 16:16:09 +00:00
Aurélien Pomini 8cc2bbf6c7 Merge "Hide keyboard when transitioning from all-apps state to overview state." into tm-qpr-dev am: 687c6e415c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19559993

Change-Id: Ic6ce5293691ce40bd7069561be54bb57cdcbc28c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-09 14:48:22 +00:00
Aurélien Pomini 687c6e415c Merge "Hide keyboard when transitioning from all-apps state to overview state." into tm-qpr-dev 2022-09-09 14:25:16 +00:00
Winson Chung 82638f6ef1 Fix missing call to super cancel method
- Without the call, it's interpreted as a successful animation to the
  listener even though it was canceled

Bug: 245829938
Test: Swipe to previous task, immediately after settling touch the
      swipe area again
Change-Id: I531cbda0c2bc8168a312a14854a7a73fafd8f678
2022-09-09 05:58:27 +00:00
Anushree Ganjam a461660fa8 Introduce KeyboardStateManager to maintain keyboardstate as show or hide.
- Add a feature flag for IME Latency logging.

- Removed mShowImeAfterFirstLayout from ExtendedEditText.

   http://ag/1414509 added `mShowImeAfterFirstLayout`and cl description
   says "Show IME when search query != null after rotation".

   I verified the behavior by turning on "Allow home screen rotation".
   Keyboard is not getting dismissed on rotation in AA+ screen in a-z list
   or even in the search screen.
   Video : https://drive.google.com/file/d/1BWUTrW9OSEo6ojErj8INMwjFCPArVD4B/view?usp=sharing&resourcekey=0-SXTcKyUw1wCSi8Bm37ktow

Bug: 240192346
Test: Manual.

Verified by setting `ENABLE_KEYBOARD_TRANSITION_SYNC` to false and for
following usecases.

- All apps entry with ime enabled, scrolling a-z list to hide keyboard
- Folder name change - showing and dismissing keyboard
- Toast entry from Allapps and QSB - showing and dismissing keyboard

Change-Id: I1a6b5759b8e71e77744f58677b6d1b73e2f633e8
2022-09-09 04:32:33 +00:00
Raj Garg 70096cc480 Merge "Introducing new variable to enable/disable shortcuts." into tm-qpr-dev am: 2e106277d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19632795

Change-Id: I723323180940af2ac83583fc139732207c0abb15
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-09 04:05:10 +00:00
Raj Garg 2e106277d7 Merge "Introducing new variable to enable/disable shortcuts." into tm-qpr-dev 2022-09-09 03:41:47 +00:00
c af5017c6cc Add launch assistant method.
Test: manual atest

Local test with atest on cf_x86_64_phone: 100/100 PASS.
ABTD 100/100 PASS: https://android-build.googleplex.com/builds/abtd/run/L71100000956341271

Change-Id: Ib9276d1cc395f134d77ba0237d94f4f23a3485b3
2022-09-09 03:30:43 +00:00
Sebastian Franco b0ac461e06 Adding specific case for applications in getEntryMigrationId
A string like this are sued as id when migrating the grid:

The problem is that sourceBounds can chagne for the same app
and then return the same app as different. To fix it I added
a new case for Aplications and remove the variable sourceBounds
for the default case if there is anotherr Favorites item that
has the same problem but we don't know.

Test: Manually migrated between different grids.
Fix: 232004084
Change-Id: Ida015c971c70c8de2915fca1ebc38f446c21a310
2022-09-08 17:10:53 -07:00
Android Build Coastguard Worker be4ede5185 Snap for 9043175 from 5aa6deff8d to tm-qpr1-release
Change-Id: I5dd86b8b0756b3a5b911e322f268460c9d39213b
2022-09-08 23:25:51 +00:00
Bill Yi 78f7949215 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" am: 2799f17529 -s ours am: c447749476 -s ours am: 3deb7946e4 -s ours am: 6c081976f8 -s ours
am skip reason: subject contains skip directive

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2205847

Change-Id: I4f5b3bf7cd22b38f23b7fcc7de8dab5fc26d5a02
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 23:23:53 +00:00
Bill Yi f85158bfc4 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: cda56de564 -s ours am: 9775c4680a -s ours am: 03b45c9cfe -s ours am: 16f827b585 -s ours
am skip reason: subject contains skip directive

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2205847

Change-Id: I3a389f17fd69bd04e21fbb4ff4f8a3942a6e9055
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 23:23:47 +00:00
Bill Yi d1059c634a [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" am: 6585bac31d -s ours am: 93187f9e0b -s ours am: c0bb571b7a -s ours am: 0bf47e0244 -s ours
am skip reason: subject contains skip directive

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2205846

Change-Id: I4bdb011aa6ac9b0d4a10cb6cf9dca61bc6c00c8c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 23:23:45 +00:00
Bill Yi f2e1c1c8db [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: e7579d5066 -s ours am: 8c561ea41a -s ours am: 819cc4cf34 -s ours am: 75ae20bc65 -s ours
am skip reason: subject contains skip directive

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2205846

Change-Id: I05a5e62d63da0334312169110490dad69d58536e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 23:23:30 +00:00
Bill Yi 157ee69b79 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" am: 6dfb7a38b4 -s ours am: ea45ff2624 -s ours am: a1625eb124 -s ours am: 1150fef208 -s ours
am skip reason: subject contains skip directive

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2205845

Change-Id: Ic9270ef62324c3be753687af61a539adec625560
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 23:23:10 +00:00
Bill Yi d65afc386e [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: e312433f83 -s ours am: edeb3ecb0e -s ours am: c550760eec -s ours am: 90bc747a21 -s ours
am skip reason: subject contains skip directive

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2205845

Change-Id: I02539767ed4cc94224b32b86abb825045de319fc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 23:22:51 +00:00
Bill Yi 6c081976f8 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" am: 2799f17529 -s ours am: c447749476 -s ours am: 3deb7946e4 -s ours
am skip reason: subject contains skip directive

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2205847

Change-Id: I825c42a8a9b3ea982a48a914a0e386ff7fd82392
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 22:58:50 +00:00
Bill Yi 16f827b585 [automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: cda56de564 -s ours am: 9775c4680a -s ours am: 03b45c9cfe -s ours
am skip reason: subject contains skip directive

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2205847

Change-Id: If21ab70283843f732901601e488de436d5b1eb06
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 22:58:44 +00:00
Bill Yi 0bf47e0244 [automerger skipped] Merge "Import translations. DO NOT MERGE ANYWHERE" am: 6585bac31d -s ours am: 93187f9e0b -s ours am: c0bb571b7a -s ours
am skip reason: subject contains skip directive

Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2205846

Change-Id: I3aa1ce433a457ed8e93684db40d64134b6e7d675
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 22:58:35 +00:00