Commit Graph

53916 Commits

Author SHA1 Message Date
Jeremy Sim e9a0d41e2d Merge "Fix small bug with DWB banners not animating out promptly" into tm-qpr-dev am: c3c4be206c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19984439

Change-Id: I3b9be276113eabd3e1414abaf956a90c9f555686
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-20 15:49:33 +00:00
Jeremy Sim 5227613acb Merge "Update animations for TM-QPR: Home > OverviewSplitSelect transition" into tm-qpr-dev 2022-09-20 15:09:33 +00:00
Jeremy Sim c3c4be206c Merge "Fix small bug with DWB banners not animating out promptly" into tm-qpr-dev 2022-09-20 15:09:10 +00:00
Nicolo' Mazzucato 52909d0b5f Fix taskbar instrumentation crash
This was crashing when there were no views in the taskbar. Now, we're using getDragLayer, that will be always there.

Bug: 245690391
Test: TaskbarExpandCollapse
Change-Id: I4475adb0c6c425fca54af02bb071ed3e5f42d927
2022-09-20 14:01:40 +00:00
TreeHugger Robot 67d76fa9b6 Merge "Adding a comment for goHome()" into tm-qpr-dev am: 0dec527aae
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19994601

Change-Id: I05619d9401cde143c29ab923e44c932be499d6a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-20 09:14:40 +00:00
TreeHugger Robot 0dec527aae Merge "Adding a comment for goHome()" into tm-qpr-dev 2022-09-20 08:38:01 +00:00
Jeremy Sim f3bfe4e156 Update animations for TM-QPR: Home > OverviewSplitSelect transition
This change updates the animation for initiating a split from the home screen. Also fixes a bug where icons were getting severely pixelated mid-animation.

Fixes: 236759099
Fixes: 244499770
Test: Manual
Change-Id: I56a76cbf286bd30540f3debdcb681d39c890a445
2022-09-19 22:02:54 -07:00
Jeremy Sim 2fbddc4949 Fix small bug with DWB banners not animating out promptly
This CL fixes an issue where initiating split select on a task with a DWB banner would result in the DWB banner sticking around long after the thumbnail itself fades, interfering visually with the rest of the animation.

Fixed by hiding all child views of the taskview when splitting, instead of just the thumbnail.

Fixes: 247257724
Test: Manual
Change-Id: I4dbeccf8dd28431749df5e78482e80aacf5df55a
2022-09-19 21:58:38 -07:00
Jeremy Sim 78a9e49933 Merge "Update animations for TM-QPR: OverviewSplitSelect > Confirmed transition" into tm-qpr-dev am: 37f83cf246
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19936637

Change-Id: I41b5783d1682d404f42cda0237996db24c594b9c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-20 03:20:36 +00:00
Jeremy Sim 37f83cf246 Merge "Update animations for TM-QPR: OverviewSplitSelect > Confirmed transition" into tm-qpr-dev 2022-09-20 02:55:46 +00:00
vadimt f132bd7d3f Adding a comment for goHome()
Bug: 187761685
Test: presubmit
Change-Id: I2917daa90f22cc0da0169c287b02cc4cf37a8f4b
2022-09-19 19:08:43 -07:00
Bill Yi 5b7184135f Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I6fba94d4a9cc85b25b6dcd788b0d02f8de8d4851
2022-09-19 18:42:33 -07:00
Bill Yi 2013484cbe Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I511baa87327543bc8733df61a612aae93ddc9bed
2022-09-19 18:42:01 -07:00
Bill Yi c619b29971 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Iaf0fa7c94a7892ae41e3b374477568af36fb5679
2022-09-19 18:41:28 -07:00
Sihua Ma 10476b31b4 Merge "Showing Toast message when the target package is null for the disabled shortcut" into tm-qpr-dev am: 8e66905618
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19498059

Change-Id: I5321ab73320efc9666306702239364a205519c6b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-19 23:53:22 +00:00
Android Build Coastguard Worker b69802c593 Snap for 9080545 from 3ad08cd2b8 to tm-qpr1-release
Change-Id: I395dc00671c1c65a6ce0ee696ff4a3f725bffb73
2022-09-19 23:29:23 +00:00
Brian Isganitis d07b1a7c42 Add content description for taskbar all apps button.
Test: Manual
Fix: 221338615
Change-Id: Ic3b6f4e83a1234f1979f9fb4af75e6c893381a13
2022-09-19 16:25:15 -07:00
Sihua Ma 8e66905618 Merge "Showing Toast message when the target package is null for the disabled shortcut" into tm-qpr-dev 2022-09-19 23:20:12 +00:00
Sunny Goyal 1051108f3f Merge "Fixing nullPointerException is RotationHelper" into tm-qpr-dev am: 59caeb9468
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19979609

Change-Id: I9cfc9165f17b638b84346102ec39521a89e4df14
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-19 22:18:22 +00:00
Sunny Goyal 59caeb9468 Merge "Fixing nullPointerException is RotationHelper" into tm-qpr-dev 2022-09-19 21:43:23 +00:00
Schneider Victor-tulias f5c1242bee Update page index update logs
We are currently logging the wrong value, updating the logged value to getNextPage

Bug: 227514916
Test: manually checked logs
Change-Id: Ic1991644e1e52ba1b06e3f30e035577f01a46d4e
2022-09-19 21:37:56 +00:00
Jeremy Sim 210d26d320 Merge "Fix issue with Overview thumbnails appearing blank in certain situations" into tm-qpr-dev am: 3ad08cd2b8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19984956

Change-Id: I6159f009bdc354d79dcd3943623d4e30c9aa4601
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-19 20:28:17 +00:00
Jeremy Sim 3ad08cd2b8 Merge "Fix issue with Overview thumbnails appearing blank in certain situations" into tm-qpr-dev 2022-09-19 19:56:57 +00:00
Jeremy Sim a4ba516797 Update animations for TM-QPR: OverviewSplitSelect > Confirmed transition
This change updates the animation for confirming a split.

Includes:
- New timings
- A new interface, SplitAnimationTimings, that centralizes timing values for splitscreen animations

Fixes: 241126570
Test: Manual
Change-Id: I61339964a7254618b368b17f00fda8f5efb53de4
2022-09-19 12:04:33 -07:00
Sunny Goyal e41c5b005f Fixing nullPointerException is RotationHelper
Bug: 247055735
Test: Verified on device
Change-Id: Ie73be138bdb616fb9db739b09c12794d61183657
2022-09-19 11:02:04 -07:00
TreeHugger Robot ab6be24eec Merge "Explicit Nullbility in Launcher (Part 5)" into tm-qpr-dev am: 69c04c21c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19976255

Change-Id: Id7d92e7b4c432e8caafb92b62956387bd0c1e42e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-19 17:45:38 +00:00
TreeHugger Robot 69c04c21c5 Merge "Explicit Nullbility in Launcher (Part 5)" into tm-qpr-dev 2022-09-19 17:12:40 +00:00
Luca Zuccarini 62193df059 Merge "Fix issue with keyboard disappearing too late." into tm-qpr-dev am: 3fe8d2c9fa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19852198

Change-Id: I282bad334d5768df896e54f1f5c4e6553ae993f0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-19 16:11:36 +00:00
Luca Zuccarini 3fe8d2c9fa Merge "Fix issue with keyboard disappearing too late." into tm-qpr-dev 2022-09-19 15:36:59 +00:00
Nicolo' Mazzucato d2521bf843 Fix LauncherInstrumentation for OOP tests from gradle
The previous logic was assuming that if the test and target package were different, the target one was the launcher.

However, in the sysui-studio case, the packages are different despite none of the packages being launcher.

This detects if the test process is a gradle instrumentation, and if so selects the default launcher package name.

Test: locally with sysui-studio + presubmits
Bug: 234414088
Change-Id: Ie625e7d526f254f4b5f66b3a2b989d02eb95ac9c
2022-09-19 14:35:53 +00:00
Android Build Coastguard Worker 304dd1abc4 Snap for 9077201 from c528e7e818 to tm-qpr1-release
Change-Id: Ic3644bd3775e772fa0a274c05d97a71d804c2375
2022-09-18 00:45:00 +00:00
Jeremy Sim 08a9bcac1f Fix issue with Overview thumbnails appearing blank in certain situations
This CL fixes an issue where canceling any Launcher animation by entering Quick Switch would cause Overview to appear with all thumbnail tiles blank.

The issue occurred because we recently added a reset() to Overview that triggered on all state transition animation cancels. This fixed some issues, but introduced this bug.

Fixed by tailoring the reset() to only fire on animation cancels within BaseRecentsView and FallbackRecentsView.

Fixes: 246232494
Fixes: 243471493
Test: Manual
Change-Id: I175a22d52597a63e164a6f3b9353c62b199b0712
2022-09-17 16:01:46 -07:00
Jeremy Sim 69a22b907f Merge "Fix two bugs with rotation in split select state" into tm-qpr-dev am: c528e7e818
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19960985

Change-Id: Ib408c5b8f113d13a63fd6071283cdf73f69af74b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 22:18:53 +00:00
Jeremy Sim c528e7e818 Merge "Fix two bugs with rotation in split select state" into tm-qpr-dev 2022-09-17 21:45:24 +00:00
Alex Chau 4773a10dc2 Merge "Trying to fix flaky TAPL test on CF" into tm-qpr-dev am: 7c8ee4f8de
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19886864

Change-Id: I06694418da1b2d7c13fa5976b5780c2c7807ceca
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 04:31:51 +00:00
Alex Chau 7c8ee4f8de Merge "Trying to fix flaky TAPL test on CF" into tm-qpr-dev 2022-09-17 03:30:32 +00:00
TreeHugger Robot 4e758bfc23 Merge "Updating the title of the Add to homescreen prompt to the requesting app instead of the Launcher name" into tm-qpr-dev am: 17c4741432
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19980314

Change-Id: I96b1a2b01dfeef76bd3a9ba74599823dd76d30a6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 01:53:11 +00:00
Holly Jiuyu Sun f0a4b7dfcd Merge "Clear the staled mFocusedView when toast surface is closed." into tm-qpr-dev am: a6f9b4b76b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19956349

Change-Id: I171d868062472749de8955f4e4e6f857a36ec922
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 01:52:58 +00:00
TreeHugger Robot 17c4741432 Merge "Updating the title of the Add to homescreen prompt to the requesting app instead of the Launcher name" into tm-qpr-dev 2022-09-17 01:47:48 +00:00
Holly Jiuyu Sun a6f9b4b76b Merge "Clear the staled mFocusedView when toast surface is closed." into tm-qpr-dev 2022-09-17 01:34:45 +00:00
Android Build Coastguard Worker 54fa8131eb Snap for 9075033 from 455c942fd2 to tm-qpr1-release
Change-Id: I5f91680b6970789cd7b1cd95efedb955380068cf
2022-09-17 01:25:41 +00:00
Pinyao Ting 777c13eb00 Explicit Nullbility in Launcher (Part 5)
This CL addresses the nullbility in LauncherModel and update tasks.

Bug: 242895652
Test: manual
Change-Id: Ied635c944c3656f0d493b295f772aa0329b354b9
2022-09-16 17:17:16 -07:00
TreeHugger Robot cd4951f54b Merge "Updating the scroll calculation from recyclerView to avoid view inflation" into tm-qpr-dev am: 860657a5f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19469421

Change-Id: Ia1d1167c24cab50d1fca936c5e976fa85edcb853
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 23:46:44 +00:00
Vinit Nayak d887b56183 Reset TaskView transformations on orientationHandler change
* Transformations in the old orientation handler
(ex. translate X for portrait) aren't reset when
device changes to fake landscape (starts modifying translate Y).
The new translations are picked up correctly, this resets the
old ones.

Test: Bug no longer repros.
Rotated device while scrolling through tasks, no change in
behavior from before.
Can't think of other instances where tasks are in motion
and orientation handler can change.
Fixes: 233316942

Change-Id: Ie07340e69a2c93b71b1dabb8029c96ad05a4d4a1
2022-09-16 16:45:50 -07:00
TreeHugger Robot 860657a5f2 Merge "Updating the scroll calculation from recyclerView to avoid view inflation" into tm-qpr-dev 2022-09-16 23:07:54 +00:00
Sunny Goyal bb5ebb7f2d Updating the title of the Add to homescreen prompt to the requesting app
instead of the Launcher name

Bug: 239055068
Test: Verified on device
Change-Id: I1494d911565ddf3a598f9fbf372b8d784a4276e4
2022-09-16 15:54:53 -07:00
Jeremy Sim 7917ff31cc Fix two bugs with rotation in split select state
This CL fixes two bugs that were triggered by rotating in split select state:
1) Rotating in split select state will no longer cause a jittery animation to play
2) Initiating split from home, then rotating will no longer create extra split placeholders on screen

The bugs were present because handleSplitSelectionState() animated every state transition into SplitSelect, including SplitSelect > SplitSelect (which happens when rotating). This caused a jittery animation to play, and in certain cases, caused additional copies of FloatingTaskView and SplitInstructionsView to be created.

Fixed by auto-skipping animations for SplitSelect > SplitSelect, and by safely removing views when entering SplitSelect (to prevent duplicates).

Fixes: 242965515
Fixes: 243088958
Test: Verified visually on-device.
Change-Id: Iab813b1fe599bfdc550fe9a1d354b28cedb4b659
2022-09-16 15:28:33 -07:00
Yein Jo f8804d8ccd Merge "Migrate Launcher to use the new OnBackInvokedCallback" into tm-qpr-dev am: dfaabbb499
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19934356

Change-Id: Ib3ac38f3706abc7763d176c8bc065472e8e07289
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 21:55:41 +00:00
Yein Jo dfaabbb499 Merge "Migrate Launcher to use the new OnBackInvokedCallback" into tm-qpr-dev 2022-09-16 21:44:49 +00:00
Andy Wickham 92574a99f5 Merge "Pivot search results scale around top of view." into tm-qpr-dev am: 455c942fd2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19956355

Change-Id: Ibb3581e52154d2f08929aeca604e9b25671e1a31
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 21:42:29 +00:00