Commit Graph

33301 Commits

Author SHA1 Message Date
Jon Miranda a1567d50d0 Prevent two overlapping long press actions.
We add a check in CheckLongPressHelper to not trigger long press if the
view is already in the pressed state.

This fixes the bug where a stranded DragView is left in the DragLayer.

Repo's every 50 tries:
- Open folder
- Long click and slightly drag the same item over and over in slightly
  different directions.

Logs show that long click on folder item initiates the first long click,
and then later on CheckLongPressHelper triggers another long press before the
initial one is finished.

Bug: 151053858
Change-Id: Ifbb6919e4f0153aaef2904f704baa284e78f1e83
2020-04-16 14:00:50 -07:00
Jonathan Miranda c9e1375ed5 Merge "Add AnimationFlag for SKIP_DEPTH_CONTROLLER." into ub-launcher3-rvc-dev am: a976a2212d
Change-Id: If3b50143c236ea0ba4d01f19bbebbd46839f94cc
2020-04-16 20:23:48 +00:00
Jonathan Miranda a976a2212d Merge "Add AnimationFlag for SKIP_DEPTH_CONTROLLER." into ub-launcher3-rvc-dev 2020-04-16 20:10:05 +00:00
Jon Miranda 172302686c Add resume callback to animate back to appropriate depth.
This fixes the bug where depth gets stuck to 1 after opening a transluscent
activity.

Bug: 152950633
Change-Id: I8bf5f61c57ef79d41656865b1ff1fbadb298fc36
2020-04-16 13:03:48 -07:00
Hyunyoung Song 4fcf088ae0 Merge "Add AllAppsSearchPlugin Bug: 151089843" into ub-launcher3-rvc-dev am: 6dde528c82
Change-Id: I08ad8e8b704a158daf6742c4b2db57ab7b22e287
2020-04-16 19:47:33 +00:00
Andy Wickham 230f390d94 Adds dummy HomeGestureTutorialFragment. am: 4f66dc3bef
Change-Id: Ic5c688ef3bb7551f342d134a2068b1589bc42e4c
2020-04-16 19:47:20 +00:00
Hyunyoung Song 6dde528c82 Merge "Add AllAppsSearchPlugin Bug: 151089843" into ub-launcher3-rvc-dev 2020-04-16 19:45:26 +00:00
Hyunyoung Song 3f82135f06 Add AllAppsSearchPlugin
Bug: 151089843

Change-Id: I6d61fb9c7855bafee731f47147b3070a1b672071
2020-04-16 11:50:04 -07:00
Andy Wickham 4f66dc3bef Adds dummy HomeGestureTutorialFragment.
- Adds a new launch target in Dev options
 - Moves Back handling to the parent TutorialFragment
   (so all Tutorials can handle it as necessary)
 - Currently uses a dummy translating rectangle in
   place of a proper hand animation
 - No actual home gesture recognition is in place yet

Test: Manual
Bug: 148542211
Change-Id: Ic5a545eb9f5003914803272c8ffe367220d63336
2020-04-16 18:23:08 +00:00
Andy Wickham 00e241f82f Simplifies Tutorial fragment layout.
Removes nested LinearLayout and RelativeLayout, as well
as a Space (instead just aligning buttons to the bottom).

Test: Manually verified result looks same as before.

Change-Id: I773079107be5f8862bae68c0f8f5bf6edff79ce8
2020-04-16 18:16:56 +00:00
Andy Wickham ed7c8a41d0 Removes more Back references for generic tutorial styles.
Change-Id: Ie959f897ee19d636eabfd8cbe9a8a2615264d4cf
2020-04-16 18:15:34 +00:00
jayaprakashs 86703b3b49 Don't open the Folder and IME when Folder is created. am: 86932724e7
Change-Id: If166033a3017bcd805adc63292e4aae10d05f923
2020-04-16 09:16:44 +00:00
jayaprakashs 86932724e7 Don't open the Folder and IME when Folder is created.
Bug: 153751859
Change-Id: I8169d0890a43b614b293ca29f504e19c532b90ee
(cherry picked from commit 09066ffeb2)
2020-04-16 02:43:36 +00:00
TreeHugger Robot cd7d0e40d9 Merge "Fix regression where recents button had no animation" into ub-launcher3-rvc-dev am: a359556bff
Change-Id: I8e1f7a7443da5386769e46e3134f51210589b8ac
2020-04-16 00:17:54 +00:00
TreeHugger Robot a359556bff Merge "Fix regression where recents button had no animation" into ub-launcher3-rvc-dev 2020-04-15 23:56:26 +00:00
Tony Wickham 73ff6ddeac Remove mPendingCallback from ActivityTracker
Instead, all callers should use EXTRA_SCHEDULER_CALLBACK, set via
addToIntent(), to provide a callback for the next handleIntent().
The updated runCallbackWhenActivityExists() will do that for the
caller if the activity doesn't already exist (otherwise it will
run the callback synchronously as before).

Bug: 151389129
Change-Id: Idbec264354fd6de166ff3bae98249230078d5674
2020-04-15 18:48:39 -05:00
Tony Wickham 6ebf3d4434 Fix regression where recents button had no animation
Change-Id: I76102b4a9f3581b71285bfa9aa0c9dc29dd3165d
2020-04-15 18:06:28 -05:00
Hyunyoung Song 19a6022ae4 Merging from ub-launcher3-rvc-dev @ build 6396980
Bug:150504032
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-rvc-dev_rvc-dev_6396980.html

Change-Id: If639a1565ce5c4af36d7bce3701b0d1d77fedec0
2020-04-15 15:49:20 -07:00
Jon Miranda dc186e68a1 Add AnimationFlag for SKIP_DEPTH_CONTROLLER.
We use this flag to prevent the depth from being immediately set to 0 when
preparing to animate home.

Bug: 152327671
Change-Id: I614c6ae08b9f9e56ecb94fb51748791a38504583
2020-04-15 15:19:49 -07:00
TreeHugger Robot 699e6be178 [automerger skipped] Merge "Import translations. DO NOT MERGE" into ub-launcher3-rvc-dev am: 2e201a887d -s ours
am skip reason: subject contains skip directive

Change-Id: I90ceaf260364a1252bc89c9d63b7b21ac32ae4ef
2020-04-15 22:05:02 +00:00
TreeHugger Robot 2e201a887d Merge "Import translations. DO NOT MERGE" into ub-launcher3-rvc-dev 2020-04-15 22:00:38 +00:00
TreeHugger Robot 070dec105f Merge "Removing tracing for a fixed bug" into ub-launcher3-rvc-dev am: 62d493d50b
Change-Id: Iccccf405d5a9ea6b3fbfe0950138aee7fb66e7d9
2020-04-15 21:59:49 +00:00
TreeHugger Robot 62d493d50b Merge "Removing tracing for a fixed bug" into ub-launcher3-rvc-dev 2020-04-15 21:57:31 +00:00
TreeHugger Robot ebcff1447e Merge "Address race condition with drag from external window" into ub-launcher3-rvc-dev am: 1fe0a4e080
Change-Id: I16c1d400c42a7c99d7c7ee307ae3f90bfc43d181
2020-04-15 21:53:16 +00:00
TreeHugger Robot 1fe0a4e080 Merge "Address race condition with drag from external window" into ub-launcher3-rvc-dev 2020-04-15 21:41:34 +00:00
Tony Wickham cfb803c42c Address race condition with drag from external window
When dragging from another window, e.g. when pinning an app shortcut,
there's a race condition as follows if launcher is killed:
- System drag starts
- Workspace loads and starts binding, canceling the drag

With this change, the drag will get onDragStart() again after this
case and allow completion of the drop.

Change-Id: I3f1c786ad1d451ecda9bbac5e9a9a3e0d8b66f73
2020-04-15 15:56:57 -05:00
vadimt f528fa6518 Removing tracing for a fixed bug
Bug: 138251824
Change-Id: Icd0d5001bfce0b1dabc102a2bbb0212a57d5839a
2020-04-15 13:51:47 -07:00
TreeHugger Robot 6434273834 Merge "Increasing string size limit" into ub-launcher3-rvc-dev am: ac9cf47712
Change-Id: Iec63856a68e327e3fad7bd2f45e19c46400a1240
2020-04-15 20:51:01 +00:00
TreeHugger Robot ac9cf47712 Merge "Increasing string size limit" into ub-launcher3-rvc-dev 2020-04-15 20:38:38 +00:00
Bill Yi 4e74aa88b5 Import translations. DO NOT MERGE
Auto-generated-cl: translation import
Change-Id: I2a0d72250768648248eba861a61975553eb39322
2020-04-15 13:04:03 -07:00
Sunny Goyal 191e764cd3 Increasing string size limit
Bug: 153908290
Change-Id: I915a4505b4e63d9e1434c93857272c17d02acaca
2020-04-15 13:01:42 -07:00
vadimt cf275c1bd7 Choosing better points to output "start" events for TAPL
Now doing this before branching points, thus avoiding flakes when the
execution can go to an unexpected branch and not produce an event.

Bug: 153824894
Change-Id: If117da0498eaf2d94c9610552724981be34c6569
2020-04-15 12:45:11 -07:00
Andy Wickham 645a633900 [automerger skipped] Refactors Sandbox to more easily add new tutorials. am: 28095168e9 -s ours
am skip reason: Change-Id Id893869cb59609141dcdbdca01744d0f5952b546 with SHA-1 9c89358c7d is in history

Change-Id: Iea93bd2ac8cde559d2b1a176a2e02ed46aea378f
2020-04-15 19:22:06 +00:00
TreeHugger Robot 2780268e1a Merge "Manually marking widgets recycler as non-scrollable of frozen" into ub-launcher3-rvc-dev am: ce2d7134f6
Change-Id: If72d30a09523c5b37945b943ea78045a94b123b3
2020-04-15 18:30:55 +00:00
Andy Wickham 28095168e9 Refactors Sandbox to more easily add new tutorials.
- Extracts abstract classes for common functionality
 - Renames some layouts, etc. to not be back-specific
 - Consolidates more logic in the controllers rather
   than classes like BackGestureTutorialTypeInfo
 - Removes redundant TutorialStep enum (combining it
   with TutorialType)

Still considering removing additional layers of
abstraction like the Fragment itself (instead
keeping UI within the Activity, which would still
be controlled by a TutorialController).

Test: Built and went through the Back tutorial to
confirm existing funcitonality was not disrupted.
Bug: 148542211

Merged-In: Id893869cb59609141dcdbdca01744d0f5952b546
Change-Id: Id893869cb59609141dcdbdca01744d0f5952b546
2020-04-15 18:18:48 +00:00
TreeHugger Robot ce2d7134f6 Merge "Manually marking widgets recycler as non-scrollable of frozen" into ub-launcher3-rvc-dev 2020-04-15 18:12:13 +00:00
TreeHugger Robot 0a3c5a9e0e Merge "Revert "Use UiEvent for constants inside StatsLogManager"" into ub-launcher3-rvc-dev am: c730304898
Change-Id: Ic2ee6128b4ce695ef9c4a67b5f78df236a2cd515
2020-04-15 17:53:13 +00:00
TreeHugger Robot c730304898 Merge "Revert "Use UiEvent for constants inside StatsLogManager"" into ub-launcher3-rvc-dev 2020-04-15 17:32:22 +00:00
vadimt 31fa653ef3 Manually marking widgets recycler as non-scrollable of frozen
There was hope that freezing automatically marks it as non-scrollable,
but this happened to be not true.

Sending accessibility event per pweaver@'s instructions.

Bug: 152354290
Change-Id: Idd04c69cef9e8e621775ef86112f35e3d9d9d2da
2020-04-15 10:21:14 -07:00
Andy Wickham d375aa612a Merge "Refactors Sandbox to more easily add new tutorials." into ub-launcher3-master 2020-04-15 17:19:31 +00:00
Andy Wickham 56251a1562 Merge "Fixes issue where back tutorial animation didn't always appear." into ub-launcher3-rvc-dev am: cc51d2ce1d
Change-Id: I48c9fe77e2f52b362b0a3587cf436c4e466f8fef
2020-04-15 16:55:04 +00:00
TreeHugger Robot 6c958690d6 Merge "Revert "Cleanup code related to ag/11035582"" into ub-launcher3-rvc-dev am: e433812907
Change-Id: Ibf3afbd597fd1d770f7ec9ade2e4b721be2fa4c5
2020-04-15 16:54:54 +00:00
Sunny Goyal 2a5b3d8f20 Revert "Have consistent All Apps UI between grid size changes." am: ae190ff807
Change-Id: Iba0049722f377a5aed1836b0a12aec26bd26dab1
2020-04-15 16:54:42 +00:00
Hyunyoung Song 1505d2f2e6 Revert "Use UiEvent for constants inside StatsLogManager"
This reverts commit 6b99a7d397.

Reason for revert: Launcher3 AOSP cannot link to uieventloggerlib because it's private API

Change-Id: Id652b8a4cba54b97d1d8b8644c2939903cc0e88a
2020-04-15 16:52:19 +00:00
Andy Wickham cc51d2ce1d Merge "Fixes issue where back tutorial animation didn't always appear." into ub-launcher3-rvc-dev 2020-04-15 08:06:05 +00:00
android-build-team Robot 89aa75d91c Snap for 6396587 from e1e93e0687 to mainline-release
Change-Id: Ie260019bbde50b0bc038fcdcccb4b6139d074452
2020-04-15 07:08:57 +00:00
TreeHugger Robot e433812907 Merge "Revert "Cleanup code related to ag/11035582"" into ub-launcher3-rvc-dev 2020-04-15 06:13:34 +00:00
Andy Wickham 9f7e434244 Fixes issue where back tutorial animation didn't always appear.
Specifically, when switching from right to left edge, the
animation disappeared. This change forces the animation
to restart whenever you switch to another tutorial.

Bug: 148542211

Change-Id: Ie74c636a4afd1018c7c8e6998a1e7a176bf8099e
(cherry picked from commit e725b6fe56)
2020-04-15 06:06:55 +00:00
Vinit Nayak 770cc42685 Revert "Cleanup code related to ag/11035582"
This reverts commit a2a1f86dff.

Reason for revert: b/154068414

Change-Id: I1db0018fa97d5a5380651cf7d04a05a0abd62857
2020-04-15 05:24:10 +00:00
android-build-team Robot 0fc727750b Snap for 6396429 from fd3fc081d9 to rvc-release
Change-Id: I89cbb8faad98a4f6d537fc8456248801718652ee
2020-04-15 02:10:08 +00:00