Commit Graph

10334 Commits

Author SHA1 Message Date
Automerger Merge Worker 7891a71d5f Persist predicted items when dragged to workspace am: 02c794578c
Change-Id: I63c93b16f549fb974c7c0e6c86f0939aff8c7b70
2019-12-09 22:31:38 +00:00
Tracy Zhou 44fa2940cd Render user's actual workspace in ThemePicker preview (Part 1)
This change takes care of icon rendering. Further work still needs to be done for folders and widgets.

Test: Go to grid options, choose a different grid option, and see user's workspace rendered in the preview
Bug: 144052839
Change-Id: I696153dec1d1f08c5ac82d0c75be5740325c0fc4
2019-12-09 14:06:38 -08:00
TreeHugger Robot 432e0513d1 Merge "perform accessbility focus when the recyclerview doesn't gain focus after fragment replacement in SettingsActivity" into ub-launcher3-master 2019-12-09 22:05:43 +00:00
vadimt bc5d7e68e8 Diagnosing the reason for opening context menu
Adding it permanently. System tests using TAPL sometimes run into
mysterious hard-to-diagnose problems (like, a menu opens for no apparent
reason), so we'll need to keep diags like this forever.

Change-Id: I25fcab94931fa4f6e1bda34d5705de5dd411188a
2019-12-09 13:53:05 -08:00
TreeHugger Robot ebc50f3095 Merge "Moving some tests to robolectric" into ub-launcher3-master 2019-12-09 20:04:35 +00:00
TreeHugger Robot ecd7cc0e4c Merge "migrate from deprecated fragment api to latest" into ub-launcher3-master 2019-12-09 19:45:29 +00:00
Sunny Goyal 4b5b0eb60d Moving some tests to robolectric
> Adding support for simulating model load

Bug: 130562632
Change-Id: I1de8c0abe2e74d4e7e47e18914316c339920609a
2019-12-09 11:17:12 -08:00
TreeHugger Robot 32e8a96ee2 Merge "allow smart folder to support more than 2 items" into ub-launcher3-master 2019-12-06 05:29:24 +00:00
TreeHugger Robot 56c9c86fe9 Merge "Removing custom activity dump logic" into ub-launcher3-master 2019-12-05 20:34:54 +00:00
Pinyao Ting eacbdd3cde allow smart folder to support more than 2 items
Bug: 144975153
Test: Manual
Change-Id: Ib5ff34863312d8b8da7615371e353bb697261790
2019-12-05 11:35:14 -08:00
Pinyao Ting 865dc9b3b1 perform accessbility focus when the recyclerview doesn't gain focus
after fragment replacement in SettingsActivity

Bug: 145475911
Test: Settings -> App & Notifications -> Default Apps -> Enable Talkback
-> Gear Button next to Home app -> About -> Verify Talkback reads the
first item in the page

Change-Id: I100e646ad2aba0081b48b86ec408ce8e76a80713
2019-12-05 11:04:20 -08:00
Pinyao Ting 8b7483810a migrate from deprecated fragment api to latest
Bug: 145475911
Test: Settings -> App & Notifications -> Default Apps -> Gear Button
next to Home app -> Verify everything works

Change-Id: Icad09230e00991da91dd0b3f870ab46edc04d1a3
2019-12-05 10:59:01 -08:00
Samuel Fufa 02c794578c Persist predicted items when dragged to workspace
Bug: 143787549
Test: Manual
Change-Id: Ieff0ede4072a2a9a87a62b06ad846eedfe97583f
2019-12-04 14:21:12 -08:00
Samuel Fufa 3a39a25d1c Ignore predicted items when items are drag over them
Bug:145565886
Test:Manual
Change-Id: I727975234d36ef2cba0d58ba1df6886e09157ce6
2019-12-04 12:13:46 -08:00
TreeHugger Robot e1187e6d98 Merge "Dedupe Items on Workspace for hotseat prediction" into ub-launcher3-master 2019-12-04 02:39:36 +00:00
Samuel Fufa 2f0b2d3b4e Dedupe Items on Workspace for hotseat prediction
Bug:145236832
Test:Manual
Change-Id: I46da38998486c7f58aca829d33b42cbb04da515a
2019-12-03 14:39:12 -08:00
Zak Cohen f9e73a01a6 Update FeatureFlags documentation.
Test: comment change
Change-Id: I25f99150f467e4e65d4969ad20a91f18743eceb0
2019-12-03 12:00:44 -08:00
Sunny Goyal ec30c5ed51 Merge "Adding utility class to load customization resources for easier prototype" into ub-launcher3-master 2019-11-28 00:23:37 +00:00
TreeHugger Robot 51a5bf15ab Merge "Hybrid hotseat predicted icon visuals" into ub-launcher3-master 2019-11-26 20:13:09 +00:00
Samuel Fufa 1e2d004dd5 Hybrid hotseat predicted icon visuals
Bug:142753423
Test: Manual
Change-Id: I6f056aaec905c8ca357b7cf78a657cdaac84e2f1
2019-11-25 17:35:05 -08:00
Sunny Goyal fca20151b0 Removing custom activity dump logic
Change-Id: I37c339be205a4e35227986544d36ca03b1ae4ba4
2019-11-25 11:18:28 -08:00
Hyunyoung Song 5fcd8f9647 Provide up to 3 folder name suggestions to active IME
Bug: 144973594

Change-Id: I92078fffd68a1230fd87d2387404c8a2fed55bc0
2019-11-22 08:19:17 +00:00
Jon Miranda a3ea27de39 Fix bug where icon remains invisible after returning home.
- The bug is caused by cancelling of the RectFSpringAnim before the
  StaggeredWorkspaceAnim has started.
- Instead of having logic in StaggeredWorkspaceAnim control the visibility
  of the icon, we instead maintain all the visibility within the
  FloatingIconView class itself.

Bug: 142120338
Change-Id: I94f3a066d395f9c3b97dc6ee9fc836e9401650a5
Merged-In: I082291ca9b288f57701cc00d61a9b3a84da8b084
2019-11-21 22:16:36 +00:00
Jon Miranda ad7e30f5d7 Fix bug where icon remains invisible after returning home.
- The bug is caused by cancelling of the RectFSpringAnim before the
  StaggeredWorkspaceAnim has started.
- Instead of having logic in StaggeredWorkspaceAnim control the visibility
  of the icon, we instead maintain all the visibility within the
  FloatingIconView class itself.

Bug: 142120338
Change-Id: I082291ca9b288f57701cc00d61a9b3a84da8b084
2019-11-20 13:17:51 -08:00
TreeHugger Robot f3761296a1 Merge "Fix recents scale sometimes lagging behind window scale" into ub-launcher3-qt-future-dev 2019-11-20 19:02:45 +00:00
Tony Wickham ced2347289 Merge "Improve quick switch from home by tracking both x and y motion" into ub-launcher3-qt-future-dev 2019-11-20 18:46:50 +00:00
Tony Wickham 09c09bba1e Fix recents scale sometimes lagging behind window scale
We were previously offsetting the launcher animation progress based
on when we got onGestureStart, which meant it would lag behind if
onGestureStart came late. Now that we track the window instead of
the launcher shelf, and we don't show the launcher animation right
away in fully gestural mode anyway, we should remove this to ensure
the launcher part of the animation always lines up with the app
window.

We also reapply state whenever predictions are enabled, e.g. when
launcher starts after being force stopped, and previously this was
canceling the existing state animation. We don't want to do that
because predictions can be enabled at any point on a cold start,
and cancelling the existing state animation means that RecentsView
shows up in fullscreen and not attached to the app window for the
duration of the gesture.

Bug: 144454486
Change-Id: I65a2c71c9acd2f5345941ea2cff7d32c04b7be3f
Merged-In: I65a2c71c9acd2f5345941ea2cff7d32c04b7be3f
2019-11-20 18:05:06 +00:00
Tony Wickham ff828d2f24 Merge "Fix recents scale sometimes lagging behind window scale" into ub-launcher3-master 2019-11-20 05:07:12 +00:00
Tony Wickham 603c20ad37 Merge "Improve quick switch from home by tracking both x and y motion" into ub-launcher3-master 2019-11-20 00:35:05 +00:00
Jon Miranda 2d250b3fef Fix folder open/close animation when grid size is small.
am: 4744701f60

Change-Id: I34f242fd25b051b96447133f331d2e0e82a5760e
2019-11-19 16:11:30 -08:00
Jon Miranda 4744701f60 Fix folder open/close animation when grid size is small.
The issue was that the scaled folder size was smaller than the clip size.
To ensure that the folder size is always larger than the clip size, we
instead scale the contents of the folder instead of the folder itself.

Bug: 143703075
Change-Id: I6eadcc487148fe7e2b7dd9f0ff94a9205048b992
2019-11-19 14:42:48 -08:00
TreeHugger Robot f982b0dcc8 Merge "[a11y] fix the issue where launcher announces item added to homescreen before it does" into ub-launcher3-master 2019-11-19 07:29:44 +00:00
Winson Chung ea91205f66 Merge "Fix two small thumbnail leaks" into ub-launcher3-master 2019-11-18 18:41:49 +00:00
Samuel Fufa 4031d65171 Merge "Fix folder available height calculation" into ub-launcher3-qt-future-dev
am: 9353b00616

Change-Id: I37fab57d0c01b413ca05049326ca519d6d74323e
2019-11-18 10:32:02 -08:00
Samuel Fufa 9353b00616 Merge "Fix folder available height calculation" into ub-launcher3-qt-future-dev 2019-11-18 18:19:14 +00:00
Winson Chung 9b5f4aa48d Fix two small thumbnail leaks
- Even though the object wrapper is used within the same process, the
  call to start the fallback recents activity means that the system
  still ends up holding a reference to a copy of the intent and its
  extras, including the reference to the wrapper and the thumbnail it
  references, until the activity is destroyed (or next restarted).
  We need to clear the actual object strong ref after it's used when
  handling the new intent.
- The running task can have an associated thumbnail, so we should also
  clear the tmp running task ref when we leave overview.

Change-Id: Icdc0b1989b13927d112949797752615014856970
2019-11-15 11:31:15 -08:00
Tony Wickham 37a0970bf5 Improve quick switch from home by tracking both x and y motion
- Add NoButtonQuickSwitchTouchController which uses
  BothAxesSwipeDetector to track horizontal and vertical motion.
- Initially, we only detect swipe left to right to quick switch
  (like before), but then we allow swipe up to either go to
  overview (if you hold) or back home (if you don't hold).
- xDisplacement transitions non-overview components out (e.g. shelf
  and workspace), and translates overview in.
- yDisplacement translates overview up and scales it down

Bug: 126596417
Change-Id: Id679ad84c08246e205c667a78ed5df00d7276258
2019-11-14 15:50:18 -08:00
Pinyao Ting c90742775b [a11y] fix the issue where launcher announces item added to homescreen before
it does

Test:
1. long press on home screen -> widgets
2. enable talkback
3. add a custom shortcut to home screen (i.e. 1x1 widgets, e.g. drive
scan in Google Drive, Driving Mode in Google Maps ... e.t.c )
4. verify talkback announces "item addded to homescreen" after it does
get added to the homescreen
5. repeat the same test for widgets (e.g. calendar)

Bug: 141527338
Change-Id: I232e6e796c9edb81128f816c71a33310c3700e73
2019-11-14 22:37:24 +00:00
Thiru Ramasamy 445cc2421e Merge "Fixes missing LauncherEvent for TAP action on FOLDER_ICON" into ub-launcher3-qt-future-dev
am: 9d9c42ef38

Change-Id: I1d67cb5a77c46e05ddfdfa547a12d8c64c7b4fdd
2019-11-14 14:07:42 -08:00
Samuel Fufa ddab25da6b Merge "Enable a11y scrolling with item drag" into ub-launcher3-qt-future-dev
am: 574e8413ba

Change-Id: I37c71d6f55d2478d029a9509ca61d32599582442
2019-11-14 14:04:35 -08:00
Thiru Ramasamy 9d9c42ef38 Merge "Fixes missing LauncherEvent for TAP action on FOLDER_ICON" into ub-launcher3-qt-future-dev 2019-11-14 22:02:09 +00:00
Samuel Fufa 574e8413ba Merge "Enable a11y scrolling with item drag" into ub-launcher3-qt-future-dev 2019-11-14 21:53:04 +00:00
Tony Wickham 2785a5996c Improve quick switch from home by tracking both x and y motion
- Add NoButtonQuickSwitchTouchController which uses
  BothAxesSwipeDetector to track horizontal and vertical motion.
- Initially, we only detect swipe left to right to quick switch
  (like before), but then we allow swipe up to either go to
  overview (if you hold) or back home (if you don't hold).
- xDisplacement transitions non-overview components out (e.g. shelf
  and workspace), and translates overview in.
- yDisplacement translates overview up and scales it down

Bug: 126596417
Change-Id: Id679ad84c08246e205c667a78ed5df00d7276258
Merged-In: Id679ad84c08246e205c667a78ed5df00d7276258
2019-11-14 12:31:01 -08:00
Samuel Fufa 1c8d90aed0 Fix folder available height calculation
Bug: 139456471
Test: Manual
Change-Id: Ic86c481e76f8b6629ad74109ef98900f1c00e16c
2019-11-14 11:02:49 -08:00
Tony Wickham 4df42f85a4 Fix recents scale sometimes lagging behind window scale
We were previously offsetting the launcher animation progress based
on when we got onGestureStart, which meant it would lag behind if
onGestureStart came late. Now that we track the window instead of
the launcher shelf, and we don't show the launcher animation right
away in fully gestural mode anyway, we should remove this to ensure
the launcher part of the animation always lines up with the app
window.

We also reapply state whenever predictions are enabled, e.g. when
launcher starts after being force stopped, and previously this was
canceling the existing state animation. We don't want to do that
because predictions can be enabled at any point on a cold start,
and cancelling the existing state animation means that RecentsView
shows up in fullscreen and not attached to the app window for the
duration of the gesture.

Bug: 144454486
Change-Id: I65a2c71c9acd2f5345941ea2cff7d32c04b7be3f
2019-11-13 16:37:32 -08:00
TreeHugger Robot 49e72ac059 Merge "Tapl: AllApps: ensuring a minimal vertical size of an icon" into ub-launcher3-qt-future-dev 2019-11-13 22:03:11 +00:00
vadimt ec7c044c89 Tapl: AllApps: ensuring a minimal vertical size of an icon
Clicking an icon within its padding area is ignored by Launcher. Hence,
ensuring that the icon on AllApps is higher that 2 paddings.

Bug: 141770616
Change-Id: I19e3ba7cfa25de75a47202845d0838bea46af92c
Merged-In: I19e3ba7cfa25de75a47202845d0838bea46af92c
2019-11-13 21:45:16 +00:00
Samuel Fufa 8fb487413c Enable a11y scrolling with item drag
Bug:142300278
Test:Manual
Change-Id: Ieb79dac8a793f5adfe715b1cbe5b7ecae95a26b5
2019-11-13 13:22:49 -08:00
vadimt 480083490f Tapl: AllApps: ensuring a minimal vertical size of an icon
Clicking an icon within its padding area is ignored by Launcher. Hence,
ensuring that the whole icon is visible.

Bug: 141770616
Change-Id: I19e3ba7cfa25de75a47202845d0838bea46af92c
2019-11-13 20:20:57 +00:00
Pinyao Ting 1397a42fc2 include predicted_rank in app launch logging
Test:
1. . build/envsetup.sh && tapas NexusLauncher
2. ccdebug && cclogcat
3. launch from workspace any app that is also in predicted apps
4. verify in terminal it has correct predicted_rank

Bug: 143855018
Change-Id: I07a62f07057537a6c09384cf944bbc5aa5888d22
Merged-In: I07a62f07057537a6c09384cf944bbc5aa5888d22
2019-11-13 01:15:37 +00:00