Commit Graph

10334 Commits

Author SHA1 Message Date
vadimt 1186700c9a TAPL: Verifying activity start/stop events
It also turned out that Pilfer event seems to come in a
non-deterministic order relative to the events from the Main and TIS
sequences. So I moved it to its own sequence.

Change-Id: I5851aafb6d04398c5727712eaf8561916a30c4c5
2020-02-27 11:12:35 -08:00
Vadim Tryshev 9f62bc10af Merge "Remove unnecessary PilferPointer events and enable testPressHomeOnAllAppsContextMenu" into ub-launcher3-master 2020-02-27 19:08:29 +00:00
TreeHugger Robot b066af18a5 Merge "Update mEndRect when closing ArrowPopup" into ub-launcher3-master 2020-02-26 07:59:20 +00:00
vadimt dbc7583054 Remove unnecessary PilferPointer events and enable testPressHomeOnAllAppsContextMenu
Change-Id: I04199f46024b05f05d04ba2be7a797842bb48527
2020-02-25 18:17:04 -08:00
TreeHugger Robot f172419189 Merge "Fixing log message" into ub-launcher3-master 2020-02-26 00:50:47 +00:00
Sunny Goyal bb18f4c9c6 Fixing log message
Change-Id: I0668ea273a54ea741b1b871a50a8738c0ec4788b
2020-02-25 15:27:06 -08:00
Zak Cohen 9a4df4dba1 Overview Actions - Enable by default.
Enable the Overview Actions feature flag by default.

Test: local
Bug: 145297320
Change-Id: I6f4a2b6e90704b78d1ff1f77bbfea2d8789169ff
2020-02-25 15:09:12 -08:00
Zak Cohen 43a1615796 Hide apps view in transitions if none of its parts are visible.
Check where the all apps view has any pieces visible, if not hide it.

Test: local
Change-Id: I1d9b957b6c10dfbe4beaa56c4fee920844699a6c
2020-02-25 15:09:12 -08:00
Zak Cohen fe935dfbc1 TAPL test update - don't run all apps in overview tests with actions.
Overview actions removes the all apps from overview. Don't run the tests
that depend on these.
Ultimately need to add more tests for the actions.

Test: tapl local
Change-Id: I2471d10af7bc03a40a94f99aa16354b85bdb3ad7
2020-02-25 15:09:12 -08:00
Tony Wickham 6382b39ff4 Add null check to sendCustomAccessibilityEvent()
ag/10273975 caused a regression where launcher crashes if RecentsView is
empty.

Change-Id: I1607627be0a9748fd552adc757296d7b6bbfd1e2
2020-02-24 17:44:38 -08:00
Tony Wickham e6981a606a Update mEndRect when closing ArrowPopup
Generally mEndRect is still correct from when we set it in
animateOpen(), but there are cases where it is no longer valid and
should be recomputed in animateClose(). For example, if you dismiss
notifications, the height of the popup changes between opening and
closing it.

Test: Long press an icon with a notification dot, dismiss all
notifications from the popup and then close the popup. The shadow
follows the outline of the popup, instead of extending well below it.

Change-Id: Ic5d6ad2807ea1ec8aff5e3d6ce8abaa11ce5d33c
2020-02-24 17:33:20 -08:00
Tracy Zhou 4365734017 Merge "Render user's actual workspace in ThemePicker preview (Part 3)" into ub-launcher3-master 2020-02-24 20:01:58 +00:00
Andy Wickham 6b7fbd22dd Merge "Makes all ArrowPopups AccessibilityTargets." into ub-launcher3-master 2020-02-24 18:49:12 +00:00
Sunny Goyal d2c56525bb Merge "Using LeastSquaresVelocityTrackerStrategy for calculating velocity when detecting motion pause events. This is the same logic used by the platform implementation VelocityTracker" into ub-launcher3-master 2020-02-24 18:30:13 +00:00
TreeHugger Robot 7fa947cb31 Merge "Fix NPE on app launch log" into ub-launcher3-master 2020-02-24 18:24:22 +00:00
Samuel Fufa 5a93eb3baf Fix NPE on app launch log
Bug: 149969889
Change-Id: I60fd283ac082fab1ebf6ea90568e054525c414cc
2020-02-21 18:52:30 -08:00
Sreyas Rangaraju bc50563915 Merge "OverviewActions: Creating parent view to house RecentsView and Overview Actions." into ub-launcher3-master 2020-02-22 01:11:47 +00:00
thiruram 15d79a9b85 Fixes incorrect FromFolderLabelState in clearcut log when updating folder label.
Bug description: When folder label is updated from a suggested label to a custom label,
EditFolderLabelEvent log expected to have FromFolderLabelState = FROM_SUGGESTED.
Currently FromFolderLabelState is logged as FROM_CUSTOM in such scenarios.

Root cause: Folder label state is decided based on whether IME has entered into compose mode while editing.
This works fine for initial folder creation and also updated to non-empty label(to both custom or suggested).
But when folder is edited from suggested to empty label, its internal state changes from SUGGESTED to CUSTOM as expected.
Later when empty label is updated to suggested again, its internal state remains custom forever.

Fix: Instead of setting folder's internal state based on IME's compose mode, comparing actual folder label with suggestions
and set it to SUGGESTED if any suggestion matches else CUSTOM.

Change-Id: Ieea572ee93fd5567e3128c9bbcea3b670f0f01d9
2020-02-21 16:24:21 -08:00
Sreyas a241df66df OverviewActions: Creating parent view to house RecentsView and Overview Actions.
Creating RecentsViewHolder to be contain LauncherRecentsView in OverviewPanel so Overview Actions View can be created only once.

Change-Id: I111f88903d2ff80275cc2e07b761577260073c17
2020-02-21 16:14:51 -08:00
Tracy Zhou be13d109b7 Render user's actual workspace in ThemePicker preview (Part 3)
go/grid-migration-preview

With this change, we can see actual grid migration in wallpaper preview.

The approach here: we use a tmp table (favorites_preview) here specifically for this preview (to write off the migration results), and load from this tmp table workspace items if migration is necessary and successful. Otherwise, we load from the current workspace.

UPDATED: this change should be completely compatible with the new multi-db grid migration algorithm. Here is why
1. In LauncherPreviewRender#renderScreenShot, I added a check to decide which grid migration preview method we should call. Once v2 preview method is implemented, it should be integrated with other parts of this change perfectly (the reason will be mentioned below).
2. While we have multiple DBs, mOpenHelper in LauncherProvider always points to the current db we are using. Queries using CONTENT_URI is routed to whatever DB mOpenHelper points to, so it works perfectly to directly operate on CONTENT_URI even when we use multi-db underneath the hood.
3. With 1 and 2 mentioned, I believe in order for this preview change to support multi-db, we only need to implement the V2 grid migration algorithm. Because most of what we are doing in this change is wrapped in GridSizeMigrationTask, it's perfectly safeguarded.

Bug: 144052839
Change-Id: Ie6d6048d77326f96546c8a180a7cd8f15b47e4c4
2020-02-21 15:49:00 -08:00
Sunny Goyal a173193afa Using LeastSquaresVelocityTrackerStrategy for calculating velocity
when detecting motion pause events. This is the same logic used by
the platform implementation VelocityTracker

Bug: 139750033
Change-Id: I87aabd46e58a5caa1395be3a63fd38d0ee75e355
2020-02-21 15:28:06 -08:00
Hyunyoung Song 621c1a8be7 Merge "Update the suggestFolderName when items are added and deleted from folders" into ub-launcher3-master 2020-02-21 20:08:20 +00:00
TreeHugger Robot b47a08ad1e Merge "Fixes NPE when creating folder with null suggestedFolderNames." into ub-launcher3-master 2020-02-21 20:05:38 +00:00
thiruram 888b516a22 Fixes NPE when creating folder with null suggestedFolderNames.
Bug: 149993849

Change-Id: Ia2758b76aef1812dab225c8a95e7141fcdeefab4
2020-02-21 11:05:37 -08:00
Hyunyoung Song 6d3e5465e2 Update the suggestFolderName when items are added and deleted from folders
Bug: 149935239
Bug: 149967272
Bug: 148900990

Change-Id: I0ed27236ad22579a1f3dcfd35a32252c5b1f6691
2020-02-21 11:00:48 -08:00
TreeHugger Robot fb5d542f51 Merge "Increase FileLog days" into ub-launcher3-master 2020-02-21 17:33:27 +00:00
Samuel Fufa 46b4f58161 Increase FileLog days
Bug: 142753423
Change-Id: I43ccfe540cb0899a4a4ab6722b6670e830457f60
2020-02-20 16:45:57 -08:00
Andy Wickham 27d3c595cf Makes all ArrowPopups AccessibilityTargets.
This currently includes the menu that pops up when
long pressing an app icon in Launcher or Search, or
long pressing Smartspace. Previously, only the menu
for Launcher apps grabbed accessibility focus after
the open animation completed, and now all three do.

Fixes: 145253300
Change-Id: I147b45d38a04ab9a55eee9b5bd5551b4c7185fcf
2020-02-20 20:36:16 +00:00
Tracy Zhou 7be160170d Merge "Render user's actual workspace in ThemePicker preview (Part 5)" into ub-launcher3-master 2020-02-20 05:53:45 +00:00
TreeHugger Robot 6e82910a45 Merge "Give current TaskView accessibility focus" into ub-launcher3-master 2020-02-20 01:16:42 +00:00
Tracy Zhou 10a285dc24 Render user's actual workspace in ThemePicker preview (Part 5)
This change takes care of rendering widgets using widget provider's layout info.

Test: manual
Bug: 144052839

Change-Id: I7002d8bf653513cdd317736d550a47f61f0ee474
2020-02-19 16:46:25 -08:00
jayaprakashs 9ac4b580a1 null check in showLableSuggestion().
It throws NPE when the data is missing for all the packages and all the suggestions are null.

Change-Id: I4aa36969e1aee00bcfc577a839d6da01d4e67a75
2020-02-19 13:00:01 -08:00
Samuel Fufa aeb185e744 Merge "Clean up work profile" into ub-launcher3-master 2020-02-19 19:53:38 +00:00
Samuel Fufa ccebfbe273 Clean up work profile
This includes
- Dismiss work edu on launcher state change
- Remove work tab flash on first setup
- Make edu bottom sheet adopt theme color
- Fix Work toggle bottom inset


Bug: 149200572
Bug: 149197172
Bug: 149199058
Bug: 149215103
Bug: 149198955
Bug: 145595763
Bug:149481723

Test: Manual
Change-Id: I39a30782b80fd3a66bede55754fa30a940d2caee
2020-02-19 19:33:09 +00:00
Hyunyoung Song 356a9f05c4 Fix folder UI open regression when tapping edit text / Fix NPE
Bug: 149835166
Bug: 149839789



Change-Id: I295cc72e4228249794eae11f177226179f2a175f
2020-02-19 11:15:12 -08:00
Hyunyoung Song bd5048a156 Merge "Move foldername and appinfo fetching to model thread" into ub-launcher3-master 2020-02-19 01:57:36 +00:00
Hyunyoung Song 308faf8335 Move foldername and appinfo fetching to model thread
Bug: 149255695
Change-Id: I8377d4a06d4ae67b601f3e0ad9e722bd7b103a7a
2020-02-18 16:41:45 -08:00
Sunny Goyal 4a9e1e2117 Fixing long-press in syste-drag does not initialize the event pos
Bug: 147899070
Change-Id: I73bc7d5addde5fb3304cac29f0ecce17b2cc48ea
2020-02-18 16:27:07 -08:00
Hyunyoung Song 0580b4a5c1 Change hint text on folders
Bug: 135182686

Change-Id: I8e21384242b9d890a0f698fdaaf722b205967349
2020-02-17 12:38:58 -08:00
Samuel Fufa f240ef2a0c Merge "Add Tests for work profile toggle" into ub-launcher3-master 2020-02-16 02:28:23 +00:00
TreeHugger Robot 2c87fb99f6 Merge "Revert "Enabling testPressHomeOnAllAppsContextMenu while fixing failure cause"" into ub-launcher3-master 2020-02-15 07:02:24 +00:00
Vadim Tryshev 47b3588ba5 Revert "Enabling testPressHomeOnAllAppsContextMenu while fixing failure cause"
This reverts commit c2842d8f4a.

Reason for revert: CL broke TaplTestsLauncher3.testDevicePressMenu in 2-button mode

Change-Id: Idebda69a36b94686415434e8e3f158a8a7abc5bb
2020-02-15 02:25:35 +00:00
TreeHugger Robot 3fc9db9dae Merge "Rename flag IS_DOGFOOD to IS_STUDIO." into ub-launcher3-master 2020-02-15 01:32:33 +00:00
vadimt c2842d8f4a Enabling testPressHomeOnAllAppsContextMenu while fixing failure cause
Change-Id: I012d5144651f5e7fb362caaef6eec8cee7622fb4
2020-02-14 14:50:28 -08:00
Zak Cohen 3eeb41de9a Rename flag IS_DOGFOOD to IS_STUDIO.
The flag is only set when building from Android Studio... and is never
used for dogfood.

Test: local
Change-Id: I898d585f4558c2437f0152ef102bea59c351f80b
2020-02-14 14:19:59 -08:00
Samuel Fufa ea4dcf468e Add Tests for work profile toggle
+ Fix minor style issues

Bug: 140099753
Bug: 112899690
Test: Manual
Change-Id: I1257560be79748abe54a75a74d93caa4390943b5
2020-02-13 17:21:54 -08:00
Thiru Ramasamy f40c579524 Merge "Initial draft of smart folder logging to clearcut pipeline." into ub-launcher3-master 2020-02-14 00:49:14 +00:00
thiruram c1c2bfa7fb Initial draft of smart folder logging to clearcut pipeline.
* Adds additional fields to launcher_log.proto to capture smart folder related information.
* Uses ProtoLite to generate log object using builder pattern and converts to nano version before writing to clearcut. Hence not making drastic change to existing logging pattern.

Change-Id: I89b10da8d4e35e3abc7ddb553046946f91b43445
2020-02-13 13:32:21 -08:00
Tracy Zhou c7f39fc66d Merge "Follow up change to GridBackupTable per V2 backup / restore (multi-db)" into ub-launcher3-master 2020-02-13 21:18:04 +00:00
Tony Wickham f6dde3966a Add some more data to TouchInteractionService dumps
- Dump OverviewComponentObserver (to check if we're using 3P launcher)
- Dump current enabled and disabled plugins
- Dump all debug FeatureFlags instead of a few handpicked ones

Bug: 146174627
Change-Id: Ic8df899433b0e42d0e05eb1c80c87f62d3b936b6
2020-02-13 11:40:25 -08:00